im glad you've started this thread. 1) i like the idea of dropping the 80 char limit !
2) and indeed, we've now adopted it in ASF BigTop, where we try to take queues from hadoop when possible. On Tue, May 5, 2015 at 3:53 PM, Rich Haase <rha...@pandora.com> wrote: > Arun, > > I use my IDE split vertically all the time on projects without strict line > limits and I have never had a problem seeing the code from multiple classes > in such a setup. > > I can certainly setup my IDE to only do 80 characters a line, although I > think it hurts readability in many cases where long names force method > calls to wrap across many lines. The reason I initially asked about the > line length limit being so low is that I am having to reformat a quite a > bit of the distcp code in order to submit a patch. It’s clear to me that > distcp did not follow the code standards being checked by checkstyle. > While I don’t mind refactoring code to meet a standard I think that > standard should reflect the state of development environments used this > decade. > > Rich > > On May 5, 2015, at 1:36 PM, Arun Suresh <asur...@cloudera.com<mailto: > asur...@cloudera.com>> wrote: > > My 2 cents : > I actually like the lower char limit. Since most of the time, I end up > having to switch between classes, I end up splitting my screen vertically > and having multiple files open. for some reason, I find splitting > vertically is better for readability than horizontally. > In anycase, my IDE generally helps me format to 80 chars so, it has never > been a pain point for me. > > On Tue, May 5, 2015 at 12:30 PM, Niels Basjes <ni...@basjes.nl<mailto: > ni...@basjes.nl>> wrote: > > I respect immensely the contributions Doug has made to many Apache > projects, > > Hear hear! I fully agree with that one. > > On Tue, May 5, 2015 at 8:30 PM, Rich Haase <rha...@pandora.com<mailto: > rha...@pandora.com>> wrote: > > I respect immensely the contributions Doug has made to many Apache > projects, but I don’t think that should be a reason to force everyone to > write code as if our screen sizes can’t support more than 80 characters. > > On May 5, 2015, at 12:21 PM, Niels Basjes <ni...@basjes.nl<mailto: > ni...@basjes.nl><mailto: > ni...@basjes.nl<mailto:ni...@basjes.nl>>> wrote: > > Perhaps we should tell him these screens can also be turned landscape ? > ;) > > But seriously: > 1) Does Doug still actively work on code? From my perspective; Only very > infrequently. > 2) In the 200+ people IT department where I work I know only 1 colleague > who uses his screen in portrait mode and he doesn't do code. > > So, for who do we really stick to the 80 chars limit? > > Niels > > On Tue, May 5, 2015 at 8:11 PM, Allen Wittenauer <a...@altiscale.com<mailto: > a...@altiscale.com> > <mailto: > a...@altiscale.com<mailto:a...@altiscale.com>>> wrote: > > > On May 5, 2015, at 11:05 AM, Rich Haase <rha...@pandora.com<mailto: > rha...@pandora.com><mailto: > rha...@pandora.com<mailto:rha...@pandora.com>>> wrote: > > Can someone explain to me why on earth we care about limiting line > length to 80 characters? Are there hadoop developers out there working > from teletype terminals? Can we perhaps update this limit to something > sane, like 120 chars? > > > > > > > > http://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201407.mbox/%3CCALEq1Z8QvHof1A3zO0W5WGfbNjCOpfNo==jktq8jiu6efm_...@mail.gmail.com%3E > > > > > > -- > Best regards / Met vriendelijke groeten, > > Niels Basjes > > Rich Haase| Sr. Software Engineer | Pandora > m (303) 887-1146 | rha...@pandora.com<mailto:awils...@pandora.com> > > > > > > > -- > Best regards / Met vriendelijke groeten, > > Niels Basjes > > > Rich Haase| Sr. Software Engineer | Pandora > m (303) 887-1146 | rha...@pandora.com<mailto:rha...@pandora.com> > > > > > -- jay vyas
