Re: [DISCUSS] Checkin Hadoop code formatter

2021-09-23 Thread Viraj Jasani
PR 3387 has been merged and the Wiki page is also updated for devs to refer to the IDEA code formatter xml. If any Eclipse user would like to contribute the formatter xml, please feel free to comment on HADOOP-17892

Re: [DISCUSS] Checkin Hadoop code formatter

2021-09-14 Thread Hui Fei
Thanks Viraj. It does make sense. Viraj Jasani 于2021年9月12日周日 上午2:58写道: > + common-dev@hadoop.apache.org > > -- Forwarded message - > From: Viraj Jasani > Date: Tue, Sep 7, 2021 at 6:18 PM > Subject: Checkin Hadoop code formatter > To: common-dev@hadoop.apache.org > > > It seems

Re: [DISCUSS] Checkin Hadoop code formatter

2021-09-12 Thread Takanobu Asanuma
Thanks for the initiative, Viraj. I agree to add the code formatter. - Takanobu 2021年9月12日(日) 5:01 Ayush Saxena : > Thanx Viraj for initiating, Makes sense to me to include a formmater > inline with our checkstyle rules in the code, would make life simpler for > all devs. > > -Ayush > > > On 12-

Re: [DISCUSS] Checkin Hadoop code formatter

2021-09-11 Thread Ayush Saxena
Thanx Viraj for initiating, Makes sense to me to include a formmater inline with our checkstyle rules in the code, would make life simpler for all devs. -Ayush > On 12-Sep-2021, at 12:28 AM, Viraj Jasani wrote: > > + common-dev@hadoop.apache.org > > -- Forwarded message - > F

[DISCUSS] Checkin Hadoop code formatter

2021-09-11 Thread Viraj Jasani
+ common-dev@hadoop.apache.org -- Forwarded message - From: Viraj Jasani Date: Tue, Sep 7, 2021 at 6:18 PM Subject: Checkin Hadoop code formatter To: common-dev@hadoop.apache.org It seems some recent new devs are not familiar with the common code formatter that we use for our c