Thanx Viraj for initiating, Makes sense to me to include a formmater inline with our checkstyle rules in the code, would make life simpler for all devs.
-Ayush > On 12-Sep-2021, at 12:28 AM, Viraj Jasani <vjas...@apache.org> wrote: > > + common-dev@hadoop.apache.org > > ---------- Forwarded message --------- > From: Viraj Jasani <vjas...@apache.org> > Date: Tue, Sep 7, 2021 at 6:18 PM > Subject: Checkin Hadoop code formatter > To: common-dev@hadoop.apache.org <d...@hadoop.apache.org> > > > It seems some recent new devs are not familiar with the common code > formatter that we use for our codebase. > While we already have Wiki page [1] for new contributors and it mentions: > "Code must be formatted according to Sun's conventions > <http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html>" > but this Oracle's code conventions page is not being actively maintained > (no update has been received after 1999) and hence, I believe we should > check-in and maintain code formatter xmls for supported IDEs in our > codebase only (under dev-support) for all devs to be able to import it in > the respective IDE. > Keeping this in mind, I have created this PR 3387 > <https://github.com/apache/hadoop/pull/3387>. If you could please take a > look and if the PR receives sufficient +1s, we might want to update our > Wiki page to directly refer to our own codebase for code formatters that we > maintain. Thoughts? > > > 1. > https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-MakingChanges --------------------------------------------------------------------- To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-dev-h...@hadoop.apache.org
