[GitHub] [seatunnel] ruanwenjun opened a new issue, #5571: [Bug] [FileConnector] Optimize the File connector OptionRule

2023-09-27 Thread via GitHub
ruanwenjun opened a new issue, #5571: URL: https://github.com/apache/seatunnel/issues/5571 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/seatunnel/issues?q=is%3Aissue+label%3A%22bug%22) and found no similar issues. ### What happene

[GitHub] [seatunnel] XiaoJiang521 closed pull request #5533: [imporve] dm use schema and table

2023-09-27 Thread via GitHub
XiaoJiang521 closed pull request #5533: [imporve] dm use schema and table URL: https://github.com/apache/seatunnel/pull/5533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [seatunnel] XiaoJiang521 opened a new pull request, #5572: Dev dm udpdate gettablename

2023-09-27 Thread via GitHub
XiaoJiang521 opened a new pull request, #5572: URL: https://github.com/apache/seatunnel/pull/5572 ### Purpose of this pull request 1. mysql pg sqlserver oracle and dm auto create table add constraintKey 2. dm catalog and dm auto create table ### Does this

[GitHub] [seatunnel] whhe commented on a diff in pull request #5517: [BUGFIX][Catalog] oracle catalog create table repeat and oracle pg null point

2023-09-27 Thread via GitHub
whhe commented on code in PR #5517: URL: https://github.com/apache/seatunnel/pull/5517#discussion_r1338287551 ## seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/oracle/OracleCatalog.java: ## @@ -129,12 +129,12 @@ protec

[GitHub] [seatunnel] Hisoka-X commented on a diff in pull request #4918: [feature][Connector-V2][cdc] Support flink running cdc job

2023-09-27 Thread via GitHub
Hisoka-X commented on code in PR #4918: URL: https://github.com/apache/seatunnel/pull/4918#discussion_r1338375371 ## seatunnel-core/seatunnel-flink-starter/seatunnel-flink-starter-common/src/main/java/org/apache/seatunnel/core/starter/flink/execution/FlinkAbstractPluginExecuteProcessor.

[GitHub] [seatunnel] Hisoka-X commented on a diff in pull request #4918: [feature][Connector-V2][cdc] Support flink running cdc job

2023-09-27 Thread via GitHub
Hisoka-X commented on code in PR #4918: URL: https://github.com/apache/seatunnel/pull/4918#discussion_r1338375371 ## seatunnel-core/seatunnel-flink-starter/seatunnel-flink-starter-common/src/main/java/org/apache/seatunnel/core/starter/flink/execution/FlinkAbstractPluginExecuteProcessor.

[GitHub] [seatunnel] xiamidavid00 opened a new pull request, #5573: [Feature][Doc] Add Docker Doc #5513

2023-09-27 Thread via GitHub
xiamidavid00 opened a new pull request, #5573: URL: https://github.com/apache/seatunnel/pull/5573 Add documents for Zeta engine running on Docker -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [seatunnel] XiaoJiang521 commented on a diff in pull request #5517: [BUGFIX][Catalog] oracle catalog create table repeat and oracle pg null point

2023-09-27 Thread via GitHub
XiaoJiang521 commented on code in PR #5517: URL: https://github.com/apache/seatunnel/pull/5517#discussion_r1338561043 ## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-1/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/JdbcOracleLowerTabl

[GitHub] [seatunnel] XiaoJiang521 commented on a diff in pull request #5517: [BUGFIX][Catalog] oracle catalog create table repeat and oracle pg null point

2023-09-27 Thread via GitHub
XiaoJiang521 commented on code in PR #5517: URL: https://github.com/apache/seatunnel/pull/5517#discussion_r1338564500 ## seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/oracle/OracleCatalog.java: ## @@ -129,12 +129,12 @

[GitHub] [seatunnel] Hisoka-X merged pull request #5568: [Improve][Test] Remove docker image after test finish on jdbc suite

2023-09-27 Thread via GitHub
Hisoka-X merged PR #5568: URL: https://github.com/apache/seatunnel/pull/5568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seatunn

[seatunnel] branch dev updated: [Improve][Test] Remove docker image after test finish on jdbc suite (#5568)

2023-09-27 Thread fanjia
This is an automated email from the ASF dual-hosted git repository. fanjia pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new fd7727869f [Improve][Test] Remove docker image afte

[GitHub] [seatunnel] hailin0 commented on pull request #5550: [improve][mysql-cdc] Optimize the default value range of mysql server-id to reduce conflicts.

2023-09-27 Thread via GitHub
hailin0 commented on PR #5550: URL: https://github.com/apache/seatunnel/pull/5550#issuecomment-1737383280 Please check ci error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [seatunnel] Hisoka-X commented on a diff in pull request #5564: Support config column/primaryKey/constraintKey in schema

2023-09-27 Thread via GitHub
Hisoka-X commented on code in PR #5564: URL: https://github.com/apache/seatunnel/pull/5564#discussion_r1338601437 ## docs/en/concept/schema-feature.md: ## @@ -2,9 +2,55 @@ ## Why we need schema -Some NoSQL databases or message queue are not strongly limited schema, so the

[GitHub] [seatunnel] Hisoka-X opened a new pull request, #5574: [Fix] Fix build status in README.md not update

2023-09-27 Thread via GitHub
Hisoka-X opened a new pull request, #5574: URL: https://github.com/apache/seatunnel/pull/5574 ### Purpose of this pull request The build status in `README.md` not update when we move CI to fork repository. This PR change it to new build yml file, to sync build status in README.

[GitHub] [seatunnel] ruanwenjun commented on a diff in pull request #5564: Support config column/primaryKey/constraintKey in schema

2023-09-27 Thread via GitHub
ruanwenjun commented on code in PR #5564: URL: https://github.com/apache/seatunnel/pull/5564#discussion_r1338758293 ## docs/en/concept/schema-feature.md: ## @@ -26,9 +72,111 @@ Some NoSQL databases or message queue are not strongly limited schema, so the sc | map | `java

[GitHub] [seatunnel] ruanwenjun commented on a diff in pull request #5564: Support config column/primaryKey/constraintKey in schema

2023-09-27 Thread via GitHub
ruanwenjun commented on code in PR #5564: URL: https://github.com/apache/seatunnel/pull/5564#discussion_r1338760687 ## docs/en/concept/schema-feature.md: ## @@ -26,9 +72,111 @@ Some NoSQL databases or message queue are not strongly limited schema, so the sc | map | `java

[GitHub] [seatunnel] ruanwenjun commented on a diff in pull request #5564: Support config column/primaryKey/constraintKey in schema

2023-09-27 Thread via GitHub
ruanwenjun commented on code in PR #5564: URL: https://github.com/apache/seatunnel/pull/5564#discussion_r1338766058 ## seatunnel-api/src/main/java/org/apache/seatunnel/api/table/catalog/CatalogTableUtil.java: ## @@ -117,7 +113,7 @@ public static List getCatalogTables(Config con

[GitHub] [seatunnel] ruanwenjun commented on a diff in pull request #5564: Support config column/primaryKey/constraintKey in schema

2023-09-27 Thread via GitHub
ruanwenjun commented on code in PR #5564: URL: https://github.com/apache/seatunnel/pull/5564#discussion_r1338765332 ## docs/en/concept/schema-feature.md: ## @@ -2,9 +2,55 @@ ## Why we need schema -Some NoSQL databases or message queue are not strongly limited schema, so the

[GitHub] [seatunnel] ruanwenjun commented on a diff in pull request #5564: Support config column/primaryKey/constraintKey in schema

2023-09-27 Thread via GitHub
ruanwenjun commented on code in PR #5564: URL: https://github.com/apache/seatunnel/pull/5564#discussion_r1338768819 ## seatunnel-api/src/main/java/org/apache/seatunnel/api/table/catalog/CatalogTableUtil.java: ## @@ -184,16 +180,31 @@ public static List getCatalogTablesFromConfi

[GitHub] [seatunnel] ruanwenjun commented on a diff in pull request #5564: Support config column/primaryKey/constraintKey in schema

2023-09-27 Thread via GitHub
ruanwenjun commented on code in PR #5564: URL: https://github.com/apache/seatunnel/pull/5564#discussion_r1338769156 ## seatunnel-api/src/main/java/org/apache/seatunnel/api/table/catalog/schema/ReadonlyConfigParser.java: ## @@ -0,0 +1,378 @@ +/* Review Comment: I have removed

[GitHub] [seatunnel] ruanwenjun commented on a diff in pull request #5564: Support config column/primaryKey/constraintKey in schema

2023-09-27 Thread via GitHub
ruanwenjun commented on code in PR #5564: URL: https://github.com/apache/seatunnel/pull/5564#discussion_r1338770738 ## seatunnel-api/src/test/java/org/apache/seatunnel/api/table/catalog/CatalogTableUtilTest.java: ## @@ -51,7 +51,7 @@ public void testSimpleSchemaParse() throws F

[GitHub] [seatunnel] ruanwenjun commented on a diff in pull request #5564: Support config column/primaryKey/constraintKey in schema

2023-09-27 Thread via GitHub
ruanwenjun commented on code in PR #5564: URL: https://github.com/apache/seatunnel/pull/5564#discussion_r1338772056 ## seatunnel-connectors-v2/connector-fake/src/test/java/org/apache/seatunnel/connectors/seatunnel/fake/source/FakeDataGeneratorTest.java: ## @@ -111,7 +111,9 @@ pu

[GitHub] [seatunnel] ruanwenjun commented on a diff in pull request #5564: Support config column/primaryKey/constraintKey in schema

2023-09-27 Thread via GitHub
ruanwenjun commented on code in PR #5564: URL: https://github.com/apache/seatunnel/pull/5564#discussion_r1338965787 ## seatunnel-common/src/main/java/org/apache/seatunnel/common/utils/JsonUtils.java: ## @@ -178,6 +180,24 @@ public static Map toMap(JsonNode jsonNode) {

[GitHub] [seatunnel] github-actions[bot] commented on issue #5337: [Feature][connector_V2] Add Apache Pegasus connetcor support.

2023-09-27 Thread via GitHub
github-actions[bot] commented on issue #5337: URL: https://github.com/apache/seatunnel/issues/5337#issuecomment-1738273564 This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

[GitHub] [seatunnel] github-actions[bot] closed issue #5340: [Bug] [MongoDB-CDC] 数据中有字段值为Null 直接异常.

2023-09-27 Thread via GitHub
github-actions[bot] closed issue #5340: [Bug] [MongoDB-CDC] 数据中有字段值为Null 直接异常. URL: https://github.com/apache/seatunnel/issues/5340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [seatunnel] JohnZp opened a new issue, #5575: [Bug] [CDC] How to use schema evolution

2023-09-27 Thread via GitHub
JohnZp opened a new issue, #5575: URL: https://github.com/apache/seatunnel/issues/5575 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/seatunnel/issues?q=is%3Aissue+label%3A%22bug%22) and found no similar issues. ### What happened

[GitHub] [seatunnel] whhe commented on pull request #5439: [Feature][Connector-V2][Jdbc] Add OceanBase catalog

2023-09-27 Thread via GitHub
whhe commented on PR #5439: URL: https://github.com/apache/seatunnel/pull/5439#issuecomment-1738357403 I tried to enable the oceanbase it case with the new docker image, and there are still some issues about the container startup, which I will fix in another pr. The label is removed by the

[GitHub] [seatunnel] Hisoka-X commented on a diff in pull request #5561: [Feature][Connector-V2] HTTP supports page increase #5477

2023-09-27 Thread via GitHub
Hisoka-X commented on code in PR #5561: URL: https://github.com/apache/seatunnel/pull/5561#discussion_r1339451621 ## docs/en/connector-v2/source/Http.md: ## @@ -42,24 +42,31 @@ They can be downloaded via install-plugin.sh or from the Maven central repositor ## Source Options

[GitHub] [seatunnel] Hisoka-X commented on pull request #5561: [Feature][Connector-V2] HTTP supports page increase #5477

2023-09-27 Thread via GitHub
Hisoka-X commented on PR #5561: URL: https://github.com/apache/seatunnel/pull/5561#issuecomment-1738364169 @xiaofan2022 Also please add e2e test case for this new feature, you can refer https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-http-e2e/

[GitHub] [seatunnel] xiamidavid00 closed pull request #5573: [Feature][Doc] Add Docker Doc #5513

2023-09-27 Thread via GitHub
xiamidavid00 closed pull request #5573: [Feature][Doc] Add Docker Doc #5513 URL: https://github.com/apache/seatunnel/pull/5573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [seatunnel] Hisoka-X commented on pull request #5561: [Feature][Connector-V2] HTTP supports page increase #5477

2023-09-27 Thread via GitHub
Hisoka-X commented on PR #5561: URL: https://github.com/apache/seatunnel/pull/5561#issuecomment-1738364731 cc @ruanwenjun @hailin0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [seatunnel] xiaofan2022 commented on a diff in pull request #5561: [Feature][Connector-V2] HTTP supports page increase #5477

2023-09-27 Thread via GitHub
xiaofan2022 commented on code in PR #5561: URL: https://github.com/apache/seatunnel/pull/5561#discussion_r1339464449 ## docs/en/connector-v2/source/Http.md: ## @@ -42,24 +42,31 @@ They can be downloaded via install-plugin.sh or from the Maven central repositor ## Source Opti

[GitHub] [seatunnel] xiamidavid00 opened a new pull request, #5576: [Feature][Doc] Add Docker Doc #5513

2023-09-27 Thread via GitHub
xiamidavid00 opened a new pull request, #5576: URL: https://github.com/apache/seatunnel/pull/5576 Add documents for Zeta engine running on Docker -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [seatunnel] xiamidavid00 closed pull request #5576: [Feature][Doc] Add Docker Doc #5513

2023-09-27 Thread via GitHub
xiamidavid00 closed pull request #5576: [Feature][Doc] Add Docker Doc #5513 URL: https://github.com/apache/seatunnel/pull/5576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [seatunnel] xiamidavid00 opened a new pull request, #5577: [Feature][Doc] Add Docker Doc #5513

2023-09-27 Thread via GitHub
xiamidavid00 opened a new pull request, #5577: URL: https://github.com/apache/seatunnel/pull/5577 Add Docker Doc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [seatunnel] xiamidavid00 closed pull request #5577: [Feature][Doc] Add Docker Doc #5513

2023-09-27 Thread via GitHub
xiamidavid00 closed pull request #5577: [Feature][Doc] Add Docker Doc #5513 URL: https://github.com/apache/seatunnel/pull/5577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [seatunnel] liutaobigdata opened a new issue, #5578: [Bug] [Module Name] Bug title

2023-09-27 Thread via GitHub
liutaobigdata opened a new issue, #5578: URL: https://github.com/apache/seatunnel/issues/5578 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/seatunnel/issues?q=is%3Aissue+label%3A%22bug%22) and found no similar issues. ### What happ

[GitHub] [seatunnel] ic4y merged pull request #5551: Throw IllegalArgumentException when find multiple connector jar for one pluginIdentifier

2023-09-27 Thread via GitHub
ic4y merged PR #5551: URL: https://github.com/apache/seatunnel/pull/5551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seatunnel.a

[seatunnel] branch dev updated: Throw IllegalArgumentException when find multiple connector jar for one pluginIdentifier (#5551)

2023-09-27 Thread ic4y
This is an automated email from the ASF dual-hosted git repository. ic4y pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new 512d982ee3 Throw IllegalArgumentException when find m

[GitHub] [seatunnel] JohnZp opened a new pull request, #5579: [Fix]: fix the cdc bug about NPE when the original table deletes a field

2023-09-27 Thread via GitHub
JohnZp opened a new pull request, #5579: URL: https://github.com/apache/seatunnel/pull/5579 ### Purpose of this pull request Fix NPE, it introduced by https://github.com/apache/seatunnel/issues/5575 ### Does this PR introduce _any_ user-facing change? No ##

[GitHub] [seatunnel] Hisoka-X commented on a diff in pull request #5564: Support config column/primaryKey/constraintKey in schema

2023-09-27 Thread via GitHub
Hisoka-X commented on code in PR #5564: URL: https://github.com/apache/seatunnel/pull/5564#discussion_r1339578076 ## seatunnel-api/src/main/java/org/apache/seatunnel/api/table/catalog/CatalogTableUtil.java: ## @@ -46,16 +38,20 @@ import java.util.ArrayList; import java.util.Co

[GitHub] [seatunnel] Hisoka-X commented on pull request #5564: Support config column/primaryKey/constraintKey in schema

2023-09-27 Thread via GitHub
Hisoka-X commented on PR #5564: URL: https://github.com/apache/seatunnel/pull/5564#issuecomment-1738535054 Any demo we can directly run? I find we add this new feature but we don't have any e2e demo to prove it worked. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [seatunnel] xiamidavid00 closed pull request #5577: [Feature][Doc] Add Docker Doc #5513

2023-09-27 Thread via GitHub
xiamidavid00 closed pull request #5577: [Feature][Doc] Add Docker Doc #5513 URL: https://github.com/apache/seatunnel/pull/5577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [seatunnel] Hisoka-X commented on pull request #5572: [Catalog][DM][Improve] dm catalog and dm auto create table and auto create table add constraintKey

2023-09-27 Thread via GitHub
Hisoka-X commented on PR #5572: URL: https://github.com/apache/seatunnel/pull/5572#issuecomment-1738546704 Shall we add some test case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [seatunnel] XiaoJiang521 commented on pull request #5517: [BUGFIX][Catalog] oracle catalog create table repeat and oracle pg null point

2023-09-27 Thread via GitHub
XiaoJiang521 commented on PR #5517: URL: https://github.com/apache/seatunnel/pull/5517#issuecomment-1738551693 > Could you add some comment like this? ![image](https://user-images.githubusercontent.com/32387433/268954009-32e9389c-a220-4ce2-9281-1e7d342cabe2.png) > > Shall we add some

[GitHub] [seatunnel] Hisoka-X commented on pull request #5579: [Fix] Fix the cdc bug about NPE when the original table deletes a field

2023-09-27 Thread via GitHub
Hisoka-X commented on PR #5579: URL: https://github.com/apache/seatunnel/pull/5579#issuecomment-1738551781 Could you open your fork repository action follow the guide? ![image](https://github.com/apache/seatunnel/assets/32387433/bfbe20ff-855c-4cdc-96fd-6ffb8e3e9f1c) -- This is an a