[GitHub] [seatunnel] ruanwenjun commented on a diff in pull request #5564: Support config column/primaryKey/constraintKey in schema

[via GitHub]

ruanwenjun commented on code in PR #5564:
URL: https://github.com/apache/seatunnel/pull/5564#discussion_r1338770738


##########
seatunnel-api/src/test/java/org/apache/seatunnel/api/table/catalog/CatalogTableUtilTest.java:
##########
@@ -51,7 +51,7 @@ public void testSimpleSchemaParse() throws 
FileNotFoundException, URISyntaxExcep
         String path = getTestConfigFile("/conf/simple.schema.conf");
         Config config = ConfigFactory.parseFile(new File(path));
         SeaTunnelRowType seaTunnelRowType =
-                CatalogTableUtil.buildWithConfig(config).getSeaTunnelRowType();
+                
CatalogTableUtil.buildWithConfig(config).getTableSchema().toPhysicalRowDataType();

Review Comment:
   Has reverted this.



##########
seatunnel-api/src/test/java/org/apache/seatunnel/api/table/catalog/CatalogTableUtilTest.java:
##########
@@ -65,7 +65,7 @@ public void testComplexSchemaParse() throws 
FileNotFoundException, URISyntaxExce
         String path = getTestConfigFile("/conf/complex.schema.conf");
         Config config = ConfigFactory.parseFile(new File(path));
         SeaTunnelRowType seaTunnelRowType =
-                CatalogTableUtil.buildWithConfig(config).getSeaTunnelRowType();
+                
CatalogTableUtil.buildWithConfig(config).getTableSchema().toPhysicalRowDataType();

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org