[GitHub] [seatunnel] TaoZex commented on pull request #5129: [Docs][Connector-V2][MyHours]Reconstruct the MyHours connector document

2023-08-09 Thread via GitHub
TaoZex commented on PR #5129: URL: https://github.com/apache/seatunnel/pull/5129#issuecomment-1672654336 > Add a connector version for this : #4572 @TaoZex myhours is an http connector that does not require a specific version -- This is an automated message from the Apache Git Servi

[GitHub] [seatunnel] TaoZex commented on a diff in pull request #5132: [Docs][Connector-V2][StarRocks]Reconstruct the StarRocks connector document

2023-08-09 Thread via GitHub
TaoZex commented on code in PR #5132: URL: https://github.com/apache/seatunnel/pull/5132#discussion_r1289636755 ## docs/en/connector-v2/sink/StarRocks.md: ## @@ -2,94 +2,44 @@ > StarRocks sink connector -## Description +## Support Those Engines -Used to send data to StarR

[GitHub] [seatunnel] ic4y opened a new pull request, #5263: [Bugfix][zeta] Resolved the issue causing checkpoints to halt on tolerable-failure=0.

2023-08-09 Thread via GitHub
ic4y opened a new pull request, #5263: URL: https://github.com/apache/seatunnel/pull/5263 …rable-failure=0. ## Purpose of this pull request ## Check list * [ ] Code changed are covered with tests, or it does not need tests for reason: * [ ] If any new

[GitHub] [seatunnel] EricJoy2048 opened a new issue, #5262: [Feature][seatunnel-web] Support show Job run log

2023-08-09 Thread via GitHub
EricJoy2048 opened a new issue, #5262: URL: https://github.com/apache/seatunnel/issues/5262 ### Search before asking - [X] I had searched in the [feature](https://github.com/apache/seatunnel/issues?q=is%3Aissue+label%3A%22Feature%22) and found no similar feature requirement.

[GitHub] [seatunnel] VolodymyrDuke commented on pull request #5261: [Hotfix][Connector-V2][Hive] fix the bug that hive-site.xml can not be injected

2023-08-09 Thread via GitHub
VolodymyrDuke commented on PR #5261: URL: https://github.com/apache/seatunnel/pull/5261#issuecomment-1672633277 @TyrantLucifer @hailin0 @EricJoy2048 PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [seatunnel] VolodymyrDuke opened a new pull request, #5261: [Hotfix][Connector-V2][Hive] fix the bug that hive-site.xml can not be injected

2023-08-09 Thread via GitHub
VolodymyrDuke opened a new pull request, #5261: URL: https://github.com/apache/seatunnel/pull/5261 ## Purpose of this pull request ## Check list * [ ] Code changed are covered with tests, or it does not need tests for reason: * [ ] If any new Jar binary packa

[GitHub] [seatunnel] NickYoungPeng commented on pull request #4803: [Feature][Connector-V2] jdbc connector supports Kingbase database

2023-08-09 Thread via GitHub
NickYoungPeng commented on PR #4803: URL: https://github.com/apache/seatunnel/pull/4803#issuecomment-1672626936 > Wait for ci `SyntaxError: /home/runner/work/seatunnel/seatunnel/seatunnel-website/docs/connector-v2/sink/Kingbase.md: Expected corresponding JSX closing tag for . (76:55)

[GitHub] [seatunnel] hailin0 commented on a diff in pull request #5184: [BUG][Connector-V2][Mongo-cdc] Incremental data kind error in snapshot phase

2023-08-09 Thread via GitHub
hailin0 commented on code in PR #5184: URL: https://github.com/apache/seatunnel/pull/5184#discussion_r1289612762 ## seatunnel-connectors-v2/connector-cdc/connector-cdc-mongodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/mongodb/source/fetch/MongodbFetchTaskContext.java:

[GitHub] [seatunnel] NickYoungPeng commented on pull request #4803: [Feature][Connector-V2] jdbc connector supports Kingbase database

2023-08-09 Thread via GitHub
NickYoungPeng commented on PR #4803: URL: https://github.com/apache/seatunnel/pull/4803#issuecomment-1672623257 > Wait for ci last ci `Error: Client bundle compiled with errors therefore further build is impossible.` -- This is an automated message from the Apache Git Service. To

[GitHub] [seatunnel] hailin0 closed issue #5253: [Bug] [zeta] fixed zeta ci error

2023-08-09 Thread via GitHub
hailin0 closed issue #5253: [Bug] [zeta] fixed zeta ci error URL: https://github.com/apache/seatunnel/issues/5253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[seatunnel] branch dev updated: fixed zeta ci error (#5254)

2023-08-09 Thread wanghailin
This is an automated email from the ASF dual-hosted git repository. wanghailin pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new 25f9590a99 fixed zeta ci error (#5254) 25f9590a

[GitHub] [seatunnel] hailin0 merged pull request #5254: [Bug] [zeta] fixed zeta ci error

2023-08-09 Thread via GitHub
hailin0 merged PR #5254: URL: https://github.com/apache/seatunnel/pull/5254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seatunne

[GitHub] [seatunnel] ic4y commented on pull request #5222: [Feature] [api env] Add job-level configuration for checkpoint timeout.

2023-08-09 Thread via GitHub
ic4y commented on PR #5222: URL: https://github.com/apache/seatunnel/pull/5222#issuecomment-1672619526 @EricJoy2048 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [seatunnel] hailin0 commented on pull request #5254: [Bug] [zeta] fixed zeta ci error

2023-08-09 Thread via GitHub
hailin0 commented on PR #5254: URL: https://github.com/apache/seatunnel/pull/5254#issuecomment-1672614622 good pr fix https://pipelines.actions.githubusercontent.com/serviceHosts/5f1d2e93-1249-42e2-b16d-ed31c598c5d5/_apis/pipelines/1/runs/62402/signedlogcontent/20?urlExpires=2023-0

[GitHub] [seatunnel] hailin0 commented on a diff in pull request #5101: [Doc] Improve S3File Source & S3File Sink document

2023-08-09 Thread via GitHub
hailin0 commented on code in PR #5101: URL: https://github.com/apache/seatunnel/pull/5101#discussion_r1289596746 ## docs/en/connector-v2/source/S3File.md: ## @@ -300,9 +281,56 @@ Reader the sheet of the workbook,Only used when file_format_type is excel. ``` -### file_filte

[GitHub] [seatunnel] NickYoungPeng commented on pull request #4803: [Feature][Connector-V2] jdbc connector supports Kingbase database

2023-08-09 Thread via GitHub
NickYoungPeng commented on PR #4803: URL: https://github.com/apache/seatunnel/pull/4803#issuecomment-1672608505 > You need to put the screenshot of the e2e test here it's above and it's folded -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [seatunnel] hailin0 commented on a diff in pull request #5101: [Doc] Improve S3File Source & S3File Sink document

2023-08-09 Thread via GitHub
hailin0 commented on code in PR #5101: URL: https://github.com/apache/seatunnel/pull/5101#discussion_r1289596298 ## docs/en/connector-v2/source/S3File.md: ## @@ -300,9 +281,56 @@ Reader the sheet of the workbook,Only used when file_format_type is excel. ``` -### file_filte

[GitHub] [seatunnel] EricJoy2048 commented on pull request #4975: [Feature][Connector-v2][RedisSink]Support redis to set expiration time.

2023-08-09 Thread via GitHub
EricJoy2048 commented on PR #4975: URL: https://github.com/apache/seatunnel/pull/4975#issuecomment-1672607700 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [seatunnel] EricJoy2048 commented on pull request #5260: [Improve][CheckStyle] Remove useless 'SuppressWarnings' annotation of checkstyle.

2023-08-09 Thread via GitHub
EricJoy2048 commented on PR #5260: URL: https://github.com/apache/seatunnel/pull/5260#issuecomment-1672603633 LGTM, Please wait CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [seatunnel] EricJoy2048 commented on pull request #4940: [Improve][Connector-v2][HiveSink]remove drop partition when abort.

2023-08-09 Thread via GitHub
EricJoy2048 commented on PR #4940: URL: https://github.com/apache/seatunnel/pull/4940#issuecomment-1672599288 @TyrantLucifer PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [seatunnel] EricJoy2048 commented on pull request #4940: [Improve][Connector-v2][HiveSink]remove drop partition when abort.

2023-08-09 Thread via GitHub
EricJoy2048 commented on PR #4940: URL: https://github.com/apache/seatunnel/pull/4940#issuecomment-1672598824 Yes, you can right. LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [seatunnel] FlechazoW opened a new pull request, #5260: [Improve][CheckStyle] Remove useless 'SuppressWarnings' annotation of checkstyle.

2023-08-09 Thread via GitHub
FlechazoW opened a new pull request, #5260: URL: https://github.com/apache/seatunnel/pull/5260 Remove useless 'SuppressWarnings' annotation of checkstyle. ## Purpose of this pull request ## Check list * [ ] Code changed are covered with tests, or it does n

[GitHub] [seatunnel] EricJoy2048 commented on a diff in pull request #5129: [Docs][Connector-V2][MyHours]Reconstruct the MyHours connector document

2023-08-09 Thread via GitHub
EricJoy2048 commented on code in PR #5129: URL: https://github.com/apache/seatunnel/pull/5129#discussion_r1289579885 ## docs/en/connector-v2/source/MyHours.md: ## @@ -131,13 +165,7 @@ connector will generate data as the following: |--

[GitHub] [seatunnel] EricJoy2048 commented on a diff in pull request #5101: [Doc] Improve S3File Source & S3File Sink document

2023-08-09 Thread via GitHub
EricJoy2048 commented on code in PR #5101: URL: https://github.com/apache/seatunnel/pull/5101#discussion_r1289577033 ## docs/en/connector-v2/sink/S3File.md: ## @@ -208,6 +242,70 @@ Writer the sheet of the workbook ## Example +### Simple: + +> This example defines a SeaTunne

[GitHub] [seatunnel] MonsterChenzhuo commented on pull request #5184: [BUG][Connector-V2][Mongo-cdc] Incremental data kind error in snapshot phase

2023-08-09 Thread via GitHub
MonsterChenzhuo commented on PR #5184: URL: https://github.com/apache/seatunnel/pull/5184#issuecomment-1672576497 > > > @hailin0 @MonsterChenzhuo Please help review > > > > > > I think it would be better for you to associate an issue and explain the problem. > > @MonsterChe

[GitHub] [seatunnel] MonsterChenzhuo commented on pull request #5184: [BUG][Connector-V2][Mongo-cdc] Incremental data kind error in snapshot phase

2023-08-09 Thread via GitHub
MonsterChenzhuo commented on PR #5184: URL: https://github.com/apache/seatunnel/pull/5184#issuecomment-1672575418 "I don't understand the relevance between your statement 'all data in the snapshot phase should have a rowkind of read' and the changes you made. Could you please clarify?" --

[GitHub] [seatunnel] MonsterChenzhuo commented on pull request #5184: [BUG][Connector-V2][Mongo-cdc] Incremental data kind error in snapshot phase

2023-08-09 Thread via GitHub
MonsterChenzhuo commented on PR #5184: URL: https://github.com/apache/seatunnel/pull/5184#issuecomment-1672565704 https://github.com/apache/seatunnel/assets/60029759/036dc614-d558-4330-b63e-b835a27c1a0f";> -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [seatunnel] MonsterChenzhuo commented on pull request #5184: [BUG][Connector-V2][Mongo-cdc] Incremental data kind error in snapshot phase

2023-08-09 Thread via GitHub
MonsterChenzhuo commented on PR #5184: URL: https://github.com/apache/seatunnel/pull/5184#issuecomment-167298 @Carl-Zhou-CN Let's go ahead and merge the 'dev' branch first. Due to the issue mentioned in https://github.com/apache/seatunnel/pull/5195, the code is unable to trigger the 'r

[GitHub] [seatunnel-web] kim-up opened a new pull request, #101: [Hotfix] Fix convert virtual table of kafka to table field error

2023-08-09 Thread via GitHub
kim-up opened a new pull request, #101: URL: https://github.com/apache/seatunnel-web/pull/101 https://github.com/apache/seatunnel/issues/5259 ## Purpose of this pull request ## Check list * [ ] Code changed are covered with tests, or it does not need tests for

[GitHub] [seatunnel] EricJoy2048 commented on a diff in pull request #5101: [Doc] Improve S3File Source & S3File Sink document

2023-08-09 Thread via GitHub
EricJoy2048 commented on code in PR #5101: URL: https://github.com/apache/seatunnel/pull/5101#discussion_r1289519122 ## docs/en/connector-v2/source/S3File.md: ## @@ -300,9 +281,56 @@ Reader the sheet of the workbook,Only used when file_format_type is excel. ``` -### file_f

[GitHub] [seatunnel] kim-up opened a new issue, #5259: [Bug] [seatunnel-web] Conver virtual table of kafka to table field error

2023-08-09 Thread via GitHub
kim-up opened a new issue, #5259: URL: https://github.com/apache/seatunnel/issues/5259 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/seatunnel/issues?q=is%3Aissue+label%3A%22bug%22) and found no similar issues. ### What happened

[GitHub] [seatunnel] EricJoy2048 commented on a diff in pull request #5132: [Docs][Connector-V2][StarRocks]Reconstruct the StarRocks connector document

2023-08-09 Thread via GitHub
EricJoy2048 commented on code in PR #5132: URL: https://github.com/apache/seatunnel/pull/5132#discussion_r1289515207 ## docs/en/connector-v2/sink/StarRocks.md: ## @@ -2,94 +2,44 @@ > StarRocks sink connector -## Description +## Support Those Engines -Used to send data to

[GitHub] [seatunnel] EricJoy2048 commented on a diff in pull request #5154: [feature][web] hive add option because web need

2023-08-09 Thread via GitHub
EricJoy2048 commented on code in PR #5154: URL: https://github.com/apache/seatunnel/pull/5154#discussion_r1289512876 ## seatunnel-connectors-v2/connector-hive/src/main/java/org/apache/seatunnel/connectors/seatunnel/hive/source/HiveSourceFactory.java: ## @@ -37,6 +37,8 @@ public

[seatunnel] branch dev updated: [Imporve] [CDC Base] Add a fast sampling method that supports character types (#5179)

2023-08-09 Thread gaojun2048
This is an automated email from the ASF dual-hosted git repository. gaojun2048 pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new c0422dbfeb [Imporve] [CDC Base] Add a fast samp

[GitHub] [seatunnel] FlechazoW opened a new issue, #5258: [Feature][Bin] Seatunnel bin file support windows.

2023-08-09 Thread via GitHub
FlechazoW opened a new issue, #5258: URL: https://github.com/apache/seatunnel/issues/5258 ### Search before asking - [X] I had searched in the [feature](https://github.com/apache/seatunnel/issues?q=is%3Aissue+label%3A%22Feature%22) and found no similar feature requirement.

[seatunnel] branch dev updated: [Bugfix][zeta] Fixed the issue of duplicated metrics caused by job fault tolerance or restore. (#5214)

2023-08-09 Thread gaojun2048
This is an automated email from the ASF dual-hosted git repository. gaojun2048 pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new 4280291072 [Bugfix][zeta] Fixed the issue of du

[GitHub] [seatunnel] EricJoy2048 merged pull request #5214: [Bugfix][zeta] Fixed the issue of duplicated metrics caused by job fault tolerance or restore.

2023-08-09 Thread via GitHub
EricJoy2048 merged PR #5214: URL: https://github.com/apache/seatunnel/pull/5214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seat

[GitHub] [seatunnel] zhilinli123 commented on pull request #4803: [Feature][Connector-V2] jdbc connector supports Kingbase database

2023-08-09 Thread via GitHub
zhilinli123 commented on PR #4803: URL: https://github.com/apache/seatunnel/pull/4803#issuecomment-1672475526 Wait for ci -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [seatunnel] liunaijie opened a new pull request, #5257: [Docs] remove `incubating` keyword in document

2023-08-09 Thread via GitHub
liunaijie opened a new pull request, #5257: URL: https://github.com/apache/seatunnel/pull/5257 ## Purpose of this pull request update doc, remove `incubating` keyword ## Check list * [ ] Code changed are covered with tests, or it does not need tests for reason:

[GitHub] [seatunnel] kalencaya closed issue #5256: [Bug] [plugins] install-plugin.sh run failed within container caused by absence of .mvn directory

2023-08-09 Thread via GitHub
kalencaya closed issue #5256: [Bug] [plugins] install-plugin.sh run failed within container caused by absence of .mvn directory URL: https://github.com/apache/seatunnel/issues/5256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [seatunnel] kalencaya commented on issue #5256: [Bug] [plugins] install-plugin.sh run failed within container caused by absence of .mvn directory

2023-08-09 Thread via GitHub
kalencaya commented on issue #5256: URL: https://github.com/apache/seatunnel/issues/5256#issuecomment-1672425632 After replace build image by `maven:3.8-eclipse-temurin-11` and change `${SEATUNNEL_HOME}/mvnw xxx yyy zzz` to `mvn xxx yyy zzz` works well -- This is an automated message from

[GitHub] [seatunnel] kalencaya opened a new issue, #5256: [Bug] [plugins] install-plugin.sh run failed within container caused by absence of .mvn directory

2023-08-09 Thread via GitHub
kalencaya opened a new issue, #5256: URL: https://github.com/apache/seatunnel/issues/5256 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/seatunnel/issues?q=is%3Aissue+label%3A%22bug%22) and found no similar issues. ### What happened

[GitHub] [seatunnel] chaorongzhi commented on pull request #5252: [Hotfix][Zeta] Fix submit job throw jobId NPE

2023-08-09 Thread via GitHub
chaorongzhi commented on PR #5252: URL: https://github.com/apache/seatunnel/pull/5252#issuecomment-1672407768 > Can you add a unit test? Sure, I'll add unit tests to the e2e module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [seatunnel] chaorongzhi commented on pull request #5252: [Hotfix][Zeta] Fix submit job throw jobId NPE

2023-08-09 Thread via GitHub
chaorongzhi commented on PR #5252: URL: https://github.com/apache/seatunnel/pull/5252#issuecomment-1672407547 > Can you add a unit test? Sure, I'll add unit tests to the e2e module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [seatunnel] github-actions[bot] closed issue #5010: [Bug] [Mysql-cdc] send Mysql data to kafka

2023-08-09 Thread via GitHub
github-actions[bot] closed issue #5010: [Bug] [Mysql-cdc] send Mysql data to kafka URL: https://github.com/apache/seatunnel/issues/5010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [seatunnel] github-actions[bot] commented on issue #5038: Seatunnel with Phoenix [BUG]

2023-08-09 Thread via GitHub
github-actions[bot] commented on issue #5038: URL: https://github.com/apache/seatunnel/issues/5038#issuecomment-1672356380 This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

[GitHub] [seatunnel] zhilinli123 opened a new pull request, #5255: [Feature][doc][Connector-V2][Fake] Add FakeSource connector documentation

2023-08-09 Thread via GitHub
zhilinli123 opened a new pull request, #5255: URL: https://github.com/apache/seatunnel/pull/5255 ## Purpose of this pull request ## Check list * [ ] Code changed are covered with tests, or it does not need tests for reason: * [ ] If any new Jar binary package

[GitHub] [seatunnel] zhilinli123 commented on issue #4572: [Umbrella][Feature][Connector-V2][Docs] Refactor connector-v2 docs using unified format

2023-08-09 Thread via GitHub
zhilinli123 commented on issue #4572: URL: https://github.com/apache/seatunnel/issues/4572#issuecomment-1671644058 FakeSource Assign me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [seatunnel] zhilinli123 commented on issue #4572: [Umbrella][Feature][Connector-V2][Docs] Refactor connector-v2 docs using unified format

2023-08-09 Thread via GitHub
zhilinli123 commented on issue #4572: URL: https://github.com/apache/seatunnel/issues/4572#issuecomment-1671631281 hi, how is the progress of Connector document? @lightzhao @Carl-Zhou-CN @zhangchengming601 -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [seatunnel] liugddx commented on pull request #5132: [Docs][Connector-V2][StarRocks]Reconstruct the StarRocks connector document

2023-08-09 Thread via GitHub
liugddx commented on PR #5132: URL: https://github.com/apache/seatunnel/pull/5132#issuecomment-1671604869 > Add a connector version for this #4572 @TaoZex thks +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [seatunnel] zhilinli123 commented on a diff in pull request #4803: [Feature][Connector-V2] jdbc connector supports Kingbase database

2023-08-09 Thread via GitHub
zhilinli123 commented on code in PR #4803: URL: https://github.com/apache/seatunnel/pull/4803#discussion_r1288672097 ## docs/en/connector-v2/sink/Kingbase.md: ## @@ -0,0 +1,159 @@ +# Kingbase + +> JDBC Kingbase Sink Connector + +## Support Those Engines + +> Spark +> Flink +> Se

[GitHub] [seatunnel] zhilinli123 commented on a diff in pull request #5234: [Improve][hbase] The specified column is written to the specified column family

2023-08-09 Thread via GitHub
zhilinli123 commented on code in PR #5234: URL: https://github.com/apache/seatunnel/pull/5234#discussion_r1288664418 ## seatunnel-connectors-v2/connector-hbase/src/main/java/org/apache/seatunnel/connectors/seatunnel/hbase/sink/HbaseSinkWriter.java: ## @@ -128,8 +129,13 @@ privat

[GitHub] [seatunnel] zhilinli123 commented on a diff in pull request #5234: [Improve][hbase] The specified column is written to the specified column family

2023-08-09 Thread via GitHub
zhilinli123 commented on code in PR #5234: URL: https://github.com/apache/seatunnel/pull/5234#discussion_r1288662236 ## seatunnel-connectors-v2/connector-hbase/src/main/java/org/apache/seatunnel/connectors/seatunnel/hbase/sink/HbaseSinkWriter.java: ## @@ -128,8 +129,13 @@ privat

[GitHub] [seatunnel] NickYoungPeng commented on a diff in pull request #4803: [Feature][Connector-V2] jdbc connector supports Kingbase database

2023-08-09 Thread via GitHub
NickYoungPeng commented on code in PR #4803: URL: https://github.com/apache/seatunnel/pull/4803#discussion_r1288553317 ## docs/en/connector-v2/sink/Kingbase.md: ## @@ -0,0 +1,159 @@ +# Kingbase + +> JDBC Kingbase Sink Connector + +## Support Those Engines + +> Spark +> Flink +>

[GitHub] [seatunnel] hailin0 commented on a diff in pull request #5129: [Docs][Connector-V2][MyHours]Reconstruct the MyHours connector document

2023-08-09 Thread via GitHub
hailin0 commented on code in PR #5129: URL: https://github.com/apache/seatunnel/pull/5129#discussion_r1288528754 ## docs/en/connector-v2/source/MyHours.md: ## @@ -15,71 +17,103 @@ Used to read data from My Hours. - [ ] [parallelism](../../concept/connector-v2-features.md) - [

[GitHub] [seatunnel] hailin0 commented on a diff in pull request #5101: [Doc] Improve S3File Source & S3File Sink document

2023-08-09 Thread via GitHub
hailin0 commented on code in PR #5101: URL: https://github.com/apache/seatunnel/pull/5101#discussion_r1288517369 ## docs/en/connector-v2/source/S3File.md: ## @@ -279,9 +239,30 @@ Reader the sheet of the workbook,Only used when file_format_type is excel. bucket = "s3a://sea

[GitHub] [seatunnel] NickYoungPeng commented on a diff in pull request #4803: [Feature][Connector-V2] jdbc connector supports Kingbase database

2023-08-09 Thread via GitHub
NickYoungPeng commented on code in PR #4803: URL: https://github.com/apache/seatunnel/pull/4803#discussion_r1288435397 ## docs/en/connector-v2/sink/Kingbase.md: ## @@ -0,0 +1,159 @@ +# Kingbase + +> JDBC Kingbase Sink Connector + +## Support Those Engines + +> Spark +> Flink +>

[GitHub] [seatunnel] TyrantLucifer commented on a diff in pull request #5234: [Improve][hbase] The specified column is written to the specified column family

2023-08-09 Thread via GitHub
TyrantLucifer commented on code in PR #5234: URL: https://github.com/apache/seatunnel/pull/5234#discussion_r1288411807 ## seatunnel-connectors-v2/connector-hbase/src/main/java/org/apache/seatunnel/connectors/seatunnel/hbase/sink/HbaseSinkWriter.java: ## @@ -128,8 +129,13 @@ priv

[GitHub] [seatunnel] XiaoJiang521 commented on pull request #5089: [feature][jdbc] Jdbc database support identifier

2023-08-09 Thread via GitHub
XiaoJiang521 commented on PR #5089: URL: https://github.com/apache/seatunnel/pull/5089#issuecomment-1671233542 > Related documents need to be updated Done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [seatunnel] NickYoungPeng commented on a diff in pull request #4803: [Feature][Connector-V2] jdbc connector supports Kingbase database

2023-08-09 Thread via GitHub
NickYoungPeng commented on code in PR #4803: URL: https://github.com/apache/seatunnel/pull/4803#discussion_r1288401065 ## docs/en/connector-v2/sink/Kingbase.md: ## @@ -0,0 +1,159 @@ +# Kingbase + +> JDBC Kingbase Sink Connector + +## Support Those Engines + +> Spark +> Flink +>

[GitHub] [seatunnel] TyrantLucifer commented on pull request #5226: [Core][Spark] remove duplicate properties,and add OriginalParameters

2023-08-09 Thread via GitHub
TyrantLucifer commented on PR #5226: URL: https://github.com/apache/seatunnel/pull/5226#issuecomment-1671228158 > @TyrantLucifer @liugddx @hailin0 PTAL I need time to test it in my local env, I remember the redundant parameters is necessary. -- This is an automated message from the

[seatunnel] branch dev updated: [Hotfix][Zeta] Avoid Redundant Job Submissions by Checking Job Status (#5229)

2023-08-09 Thread tyrantlucifer
This is an automated email from the ASF dual-hosted git repository. tyrantlucifer pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new 87a4fa69d5 [Hotfix][Zeta] Avoid Redundant Jo

[GitHub] [seatunnel] TyrantLucifer merged pull request #5229: [Bugfix][zeta] Avoid Redundant Job Submissions by Checking Job Status

2023-08-09 Thread via GitHub
TyrantLucifer merged PR #5229: URL: https://github.com/apache/seatunnel/pull/5229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@se

[GitHub] [seatunnel] sunxiaojian opened a new pull request, #5254: [Bug] [zeta] fixed zeta ci error

2023-08-09 Thread via GitHub
sunxiaojian opened a new pull request, #5254: URL: https://github.com/apache/seatunnel/pull/5254 ## Purpose of this pull request ## Check list * [ ] Code changed are covered with tests, or it does not need tests for reason: * [ ] If any new Jar binary package

[GitHub] [seatunnel] NickYoungPeng commented on a diff in pull request #4803: [Feature][Connector-V2] jdbc connector supports Kingbase database

2023-08-09 Thread via GitHub
NickYoungPeng commented on code in PR #4803: URL: https://github.com/apache/seatunnel/pull/4803#discussion_r1288384099 ## docs/en/connector-v2/sink/Kingbase.md: ## @@ -0,0 +1,159 @@ +# Kingbase + +> JDBC Kingbase Sink Connector + +## Support Those Engines + +> Spark +> Flink +>

[GitHub] [seatunnel] sunxiaojian opened a new issue, #5253: [Bug] [zeta] fixed zeta ci error

2023-08-09 Thread via GitHub
sunxiaojian opened a new issue, #5253: URL: https://github.com/apache/seatunnel/issues/5253 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/seatunnel/issues?q=is%3Aissue+label%3A%22bug%22) and found no similar issues. ### What happen

[GitHub] [seatunnel] zhilinli123 commented on a diff in pull request #4871: [Docs][Connector-V2][HDFS]Refactor connector-v2 docs using unified format HDFS.

2023-08-09 Thread via GitHub
zhilinli123 commented on code in PR #4871: URL: https://github.com/apache/seatunnel/pull/4871#discussion_r1284153975 ## docs/en/connector-v2/sink/HdfsFile.md: ## @@ -30,183 +24,108 @@ By default, we use 2PC commit to ensure `exactly-once` - [x] compress codec - [x] lzo -##

[GitHub] [seatunnel] NickYoungPeng commented on a diff in pull request #4803: [Feature][Connector-V2] jdbc connector supports Kingbase database

2023-08-09 Thread via GitHub
NickYoungPeng commented on code in PR #4803: URL: https://github.com/apache/seatunnel/pull/4803#discussion_r1288318648 ## docs/en/connector-v2/sink/Kingbase.md: ## @@ -0,0 +1,159 @@ +# Kingbase + +> JDBC Kingbase Sink Connector + +## Support Those Engines + +> Spark +> Flink +>

[GitHub] [seatunnel] zhilinli123 commented on a diff in pull request #4803: [Feature][Connector-V2] jdbc connector supports Kingbase database

2023-08-09 Thread via GitHub
zhilinli123 commented on code in PR #4803: URL: https://github.com/apache/seatunnel/pull/4803#discussion_r1288317234 ## docs/en/connector-v2/source/Kingbase.md: ## @@ -0,0 +1,145 @@ +# Kingbase + +> JDBC Kingbase Source Connector + +## Support Those Engines + +> Spark +> Flink +

[GitHub] [seatunnel] zhilinli123 commented on a diff in pull request #4803: [Feature][Connector-V2] jdbc connector supports Kingbase database

2023-08-09 Thread via GitHub
zhilinli123 commented on code in PR #4803: URL: https://github.com/apache/seatunnel/pull/4803#discussion_r1288316435 ## docs/en/connector-v2/source/Kingbase.md: ## @@ -0,0 +1,145 @@ +# Kingbase + +> JDBC Kingbase Source Connector + Review Comment: Add version information as

[GitHub] [seatunnel] zhilinli123 commented on a diff in pull request #4803: [Feature][Connector-V2] jdbc connector supports Kingbase database

2023-08-09 Thread via GitHub
zhilinli123 commented on code in PR #4803: URL: https://github.com/apache/seatunnel/pull/4803#discussion_r1288315947 ## docs/en/connector-v2/sink/Kingbase.md: ## @@ -0,0 +1,159 @@ +# Kingbase + +> JDBC Kingbase Sink Connector + +## Support Those Engines + +> Spark +> Flink +> Se

[GitHub] [seatunnel] liugddx commented on pull request #5252: [Hotfix][Zeta] Fix submit job throw jobId NPE

2023-08-09 Thread via GitHub
liugddx commented on PR #5252: URL: https://github.com/apache/seatunnel/pull/5252#issuecomment-1671115902 Can you add a unit test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [seatunnel] zhilinli123 commented on a diff in pull request #4803: [Feature][Connector-V2] jdbc connector supports Kingbase database

2023-08-09 Thread via GitHub
zhilinli123 commented on code in PR #4803: URL: https://github.com/apache/seatunnel/pull/4803#discussion_r1288314038 ## docs/en/connector-v2/sink/Kingbase.md: ## @@ -0,0 +1,159 @@ +# Kingbase + +> JDBC Kingbase Sink Connector + Review Comment: reference: https://github.com/a

[GitHub] [seatunnel] zhilinli123 commented on a diff in pull request #4803: [Feature][Connector-V2] jdbc connector supports Kingbase database

2023-08-09 Thread via GitHub
zhilinli123 commented on code in PR #4803: URL: https://github.com/apache/seatunnel/pull/4803#discussion_r1288313218 ## docs/en/connector-v2/sink/Kingbase.md: ## @@ -0,0 +1,159 @@ +# Kingbase + +> JDBC Kingbase Sink Connector + +## Support Those Engines + +> Spark +> Flink +> Se

[GitHub] [seatunnel] liugddx commented on pull request #4803: [Feature][Connector-V2] jdbc connector supports Kingbase database

2023-08-09 Thread via GitHub
liugddx commented on PR #4803: URL: https://github.com/apache/seatunnel/pull/4803#issuecomment-1671109881 You need to put the screenshot of the e2e test here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [seatunnel] liugddx commented on a diff in pull request #4803: [Feature][Connector-V2] jdbc connector supports Kingbase database

2023-08-09 Thread via GitHub
liugddx commented on code in PR #4803: URL: https://github.com/apache/seatunnel/pull/4803#discussion_r1288303892 ## docs/en/connector-v2/sink/Kingbase.md: ## @@ -0,0 +1,159 @@ +# Kingbase + +> JDBC Kingbase Sink Connector + +## Support Those Engines + +> Spark +> Flink +> SeaTun

[GitHub] [seatunnel] Carl-Zhou-CN commented on issue #5251: [Feature ] [Connector-V2] [Mongo-cdc] flink failed to support

2023-08-09 Thread via GitHub
Carl-Zhou-CN commented on issue #5251: URL: https://github.com/apache/seatunnel/issues/5251#issuecomment-1671097867 ![image](https://github.com/apache/seatunnel/assets/67902676/f851071a-1bf3-4c57-9110-aedb982d634f) ![image](https://github.com/apache/seatunnel/assets/67902676/60be6a13-da3

[GitHub] [seatunnel] sh1shan commented on issue #5174: [Bug] spark engine can not read hive source

2023-08-09 Thread via GitHub
sh1shan commented on issue #5174: URL: https://github.com/apache/seatunnel/issues/5174#issuecomment-1671066120 Get the same error,How do I troubleshoot this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [seatunnel] Carl-Zhou-CN commented on pull request #4918: [feature][Connector-V2][cdc] Support flink running cdc job

2023-08-09 Thread via GitHub
Carl-Zhou-CN commented on PR #4918: URL: https://github.com/apache/seatunnel/pull/4918#issuecomment-1671062646 Temporarily blocks mongo cdc effects #5251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [seatunnel] sunxiaojian commented on pull request #5135: [Feature][SeaTunnel Engine Checkpoint Storage] Checkpoint storage supports kafka compact topic

2023-08-09 Thread via GitHub
sunxiaojian commented on PR #5135: URL: https://github.com/apache/seatunnel/pull/5135#issuecomment-1671062000 > @ic4y PTAL CI error is not related to this modification -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [seatunnel] lightzhao commented on pull request #4844: [Feature][Connector-v2]add raw format with KafkaSource

2023-08-09 Thread via GitHub
lightzhao commented on PR #4844: URL: https://github.com/apache/seatunnel/pull/4844#issuecomment-1671061917 > @lightzhao Please merge the latest dev branch and resolve the conflicts. fixed. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [seatunnel] sunxiaojian commented on pull request #4516: [Feature][Connector-V2] connector-kafka source support data conversion extracted by kafka connect source

2023-08-09 Thread via GitHub
sunxiaojian commented on PR #4516: URL: https://github.com/apache/seatunnel/pull/4516#issuecomment-1671059179 CI error is not related to this modification -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [seatunnel] lightzhao commented on pull request #4871: [Docs][Connector-V2][HDFS]Refactor connector-v2 docs using unified format HDFS.

2023-08-09 Thread via GitHub
lightzhao commented on PR #4871: URL: https://github.com/apache/seatunnel/pull/4871#issuecomment-1671056547 > @lightzhao Please fix the code conflict fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [seatunnel] NickYoungPeng commented on pull request #4803: [Feature][Connector-V2] jdbc connector supports Kingbase database

2023-08-09 Thread via GitHub
NickYoungPeng commented on PR #4803: URL: https://github.com/apache/seatunnel/pull/4803#issuecomment-1671041737 @zhilinli123 TBR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [seatunnel] chaorongzhi opened a new pull request, #5252: [Fix][Zeta] Fix the problem that the job submission fails if the jobId is null

2023-08-09 Thread via GitHub
chaorongzhi opened a new pull request, #5252: URL: https://github.com/apache/seatunnel/pull/5252 ## Purpose of this pull request Fix the problem that jobId is null and job submission fails, and add documentation comments. ## Check list * [ ] Code changed are cove

[GitHub] [seatunnel-web] kim-up opened a new pull request, #100: [Hotfix] Fix admin user for using mysql

2023-08-09 Thread via GitHub
kim-up opened a new pull request, #100: URL: https://github.com/apache/seatunnel-web/pull/100 Add `admin` user for using mysql database. ## Purpose of this pull request ## Check list * [ ] Code changed are covered with tests, or it does not need tests

[GitHub] [seatunnel] sunxiaojian commented on pull request #5135: [Feature][SeaTunnel Engine Checkpoint Storage] Checkpoint storage supports kafka compact topic

2023-08-09 Thread via GitHub
sunxiaojian commented on PR #5135: URL: https://github.com/apache/seatunnel/pull/5135#issuecomment-1671025304 @ic4y PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [seatunnel] hailin0 commented on pull request #4871: [Docs][Connector-V2][HDFS]Refactor connector-v2 docs using unified format HDFS.

2023-08-09 Thread via GitHub
hailin0 commented on PR #4871: URL: https://github.com/apache/seatunnel/pull/4871#issuecomment-1671023260 @lightzhao Please fix the code conflict -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [seatunnel] hailin0 commented on a diff in pull request #5154: [feature][web] hive add option because web need

2023-08-09 Thread via GitHub
hailin0 commented on code in PR #5154: URL: https://github.com/apache/seatunnel/pull/5154#discussion_r1288226112 ## seatunnel-connectors-v2/connector-hive/src/main/java/org/apache/seatunnel/connectors/seatunnel/hive/source/HiveSourceFactory.java: ## @@ -37,6 +37,8 @@ public Opti

[GitHub] [seatunnel] hailin0 commented on pull request #5180: [Feature][Zeta]The expiration time of a historical Job can be config

2023-08-09 Thread via GitHub
hailin0 commented on PR #5180: URL: https://github.com/apache/seatunnel/pull/5180#issuecomment-1670991165 please fix the code conflict @wu-a-ge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [seatunnel] laglangyue commented on pull request #5226: [Core][Spark] remove duplicate properties,and add OriginalParameters

2023-08-09 Thread via GitHub
laglangyue commented on PR #5226: URL: https://github.com/apache/seatunnel/pull/5226#issuecomment-1670989817 @TyrantLucifer @liugddx @hailin0 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [seatunnel] Carl-Zhou-CN opened a new issue, #5251: [Feature ] [Connector-V2] [Mongo-cdc] flink failed to support

2023-08-09 Thread via GitHub
Carl-Zhou-CN opened a new issue, #5251: URL: https://github.com/apache/seatunnel/issues/5251 ### Search before asking - [X] I had searched in the [feature](https://github.com/apache/seatunnel/issues?q=is%3Aissue+label%3A%22Feature%22) and found no similar feature requirement.

[GitHub] [seatunnel] sunxiaojian commented on pull request #5024: [Feature][SeaTunnel Engine IMap Storage] Imap storage supports kafka compact topic in cluster mode

2023-08-09 Thread via GitHub
sunxiaojian commented on PR #5024: URL: https://github.com/apache/seatunnel/pull/5024#issuecomment-1670962652 @liugddx @ic4y PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [seatunnel] hailin0 commented on pull request #5184: [BUG][Connector-V2][Mongo-cdc] Incremental data kind error in snapshot phase

2023-08-09 Thread via GitHub
hailin0 commented on PR #5184: URL: https://github.com/apache/seatunnel/pull/5184#issuecomment-1670958396 waiting for local test run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [seatunnel] liugddx commented on issue #5241: [Bug] [rest-api] rest-api 返回的jobId不对

2023-08-09 Thread via GitHub
liugddx commented on issue #5241: URL: https://github.com/apache/seatunnel/issues/5241#issuecomment-1670878585 Hi, Would you like to fix this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [seatunnel] XiaoJiang521 commented on pull request #5089: [feature][jdbc] Jdbc database support identifier

2023-08-09 Thread via GitHub
XiaoJiang521 commented on PR #5089: URL: https://github.com/apache/seatunnel/pull/5089#issuecomment-1670876850 > Do we need to add this in the jdbc doc? Done ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [seatunnel] zhilinli123 commented on pull request #4938: [Improve][Flink][core]The outdated method of creating a table is deprecated

2023-08-09 Thread via GitHub
zhilinli123 commented on PR #4938: URL: https://github.com/apache/seatunnel/pull/4938#issuecomment-1670875014 ![image](https://github.com/apache/seatunnel/assets/76689593/09d4315d-737b-45f6-b64e-452bccf3d880) merge dev fix -- This is an automated message from the Apache Git Service. To

[seatunnel] branch dev updated (9d3c3de90d -> faeab890a2)

2023-08-09 Thread wanghailin
This is an automated email from the ASF dual-hosted git repository. wanghailin pushed a change to branch dev in repository https://gitbox.apache.org/repos/asf/seatunnel.git from 9d3c3de90d [bug][jdbc][oracle]Fix the Oracle number type mapping problem (#5209) add faeab890a2 [Bugfix][zet

[GitHub] [seatunnel] hailin0 merged pull request #5206: [Bugfix][zeta] Fix the serialization issue of GetMetricsOperation during multi-node operation.

2023-08-09 Thread via GitHub
hailin0 merged PR #5206: URL: https://github.com/apache/seatunnel/pull/5206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seatunne

[GitHub] [seatunnel] hailin0 commented on pull request #5184: [BUG][Connector-V2][Mongo-cdc] Incremental data kind error in snapshot phase

2023-08-09 Thread via GitHub
hailin0 commented on PR #5184: URL: https://github.com/apache/seatunnel/pull/5184#issuecomment-1670813338 good pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

  1   2   >