EricJoy2048 commented on code in PR #5154:
URL: https://github.com/apache/seatunnel/pull/5154#discussion_r1289512876


##########
seatunnel-connectors-v2/connector-hive/src/main/java/org/apache/seatunnel/connectors/seatunnel/hive/source/HiveSourceFactory.java:
##########
@@ -37,6 +37,8 @@ public OptionRule optionRule() {
         return OptionRule.builder()
                 .required(HiveConfig.TABLE_NAME)
                 .required(HiveConfig.METASTORE_URI)
+                .optional(HiveConfig.READ_PARTITIONS)
+                .optional(HiveConfig.READ_COLUMNS)

Review Comment:
   @VolodymyrDuke Hi, I see you are familiar with this connector. Could you 
review this PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to