[GH] (rocketmq): Workflow run "PUSH-CI" failed!

2023-10-20 Thread GitBox
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 3968c186a59db96701ade8c343bc6a5d31ee2d24 / weihubeats [ISSUE #7231] Fix: proxy client language error (#7200) * Adding null does not update * add

[GH] (rocketmq): Workflow run "Coverage" failed!

2023-10-20 Thread GitBox
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 3968c186a59db96701ade8c343bc6a5d31ee2d24 / weihubeats [ISSUE #7231] Fix: proxy client language error (#7200) * Adding null does not update * ad

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2023-10-20 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 3968c186a59db96701ade8c343bc6a5d31ee2d24 / weihubeats [ISSUE #7231] Fix: proxy client language error (#7200) * Adding null

Re: [I] Code comments of updateConsumeOffset() should be corrected [rocketmq]

2023-10-20 Thread via GitHub
joeCarf commented on issue #7489: URL: https://github.com/apache/rocketmq/issues/7489#issuecomment-1772364020 https://github.com/apache/rocketmq/assets/52153761/b801a8e5-773b-472d-8304-1327ff800e52";> updateOffset这个方法有两个实现,一个是在本地存储offset,一个是将offset存在broker里。这两种实现分别对应着广播消费和集群消费模式,因此我理解这里的c

Re: [I] 提示 close the connection to remote address [rocketmq]

2023-10-20 Thread via GitHub
joeCarf commented on issue #7485: URL: https://github.com/apache/rocketmq/issues/7485#issuecomment-1772366984 > > 看了下代码里,打出这个log的地方有很多。但大多会有其他的warn 或者 error日志,辛苦看下是否有其他日志呢 > > 代码中没有这个日志 是rocketmq底层打印出来的 有一台服务器不报这个 都是一样的配置 是rocketmq的代码。看下你的命令行中是否有其他日志打印出来。如果没有的话,由于这个日志和netty通信相关,

Re: [I] 提示 close the connection to remote address [rocketmq]

2023-10-20 Thread via GitHub
1607004157 commented on issue #7485: URL: https://github.com/apache/rocketmq/issues/7485#issuecomment-1772429746 > > > 看了下代码里,打出这个log的地方有很多。但大多会有其他的warn 或者 error日志,辛苦看下是否有其他日志呢 > > > > > > 代码中没有这个日志 是rocketmq底层打印出来的 有一台服务器不报这个 都是一样的配置 > > 是rocketmq的代码。看下你的命令行中是否有其他日志打印出来。如果

Re: [I] Code comments of updateConsumeOffset() should be corrected [rocketmq]

2023-10-20 Thread via GitHub
tensory2022 commented on issue #7489: URL: https://github.com/apache/rocketmq/issues/7489#issuecomment-1772543186 > https://user-images.githubusercontent.com/52153761/276881360-b801a8e5-773b-472d-8304-1327ff800e52.png";> updateOffset这个方法有两个实现,一个是在本地存储offset,一个是将offset存在broker里。这两种实现分别对应着广播消

Re: [I] Code comments of updateConsumeOffset() should be corrected [rocketmq]

2023-10-20 Thread via GitHub
joeCarf commented on issue #7489: URL: https://github.com/apache/rocketmq/issues/7489#issuecomment-1772555145 @tensory2022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Code comments of updateConsumeOffset() should be corrected [rocketmq]

2023-10-20 Thread via GitHub
joeCarf commented on issue #7489: URL: https://github.com/apache/rocketmq/issues/7489#issuecomment-1772554676 图中的代码只更新了内存中的offset。在`RemoteBrokerOffsetStore`中,有一`persistAll`函数,会将整个offsetTable更新到对应的broker https://github.com/apache/rocketmq/assets/52153761/87751575-c2e3-4eba-bc2a-7ec1c14ab9d

[I] rocketmq 5. x 构建镜像,使用operator启动集群时,namesrv无法启动 [rocketmq-operator]

2023-10-20 Thread via GitHub
Cloud-Yao opened a new issue, #188: URL: https://github.com/apache/rocketmq-operator/issues/188 **BUG REPORT** 1. Please describe the issue you observed: 我使用的是rocketmq5.x的版本,用的是示例的脚本构建的broker和namesrv的镜像,然后使用官方的提供的example启动一个集群,但是namesrv一直启动不起来,namesrv中的报错日志如下,broker主从节点启动都没有问题。

Re: [I] Optimize the heartbeat check pre-collection address [rocketmq]

2023-10-20 Thread via GitHub
github-actions[bot] commented on issue #5359: URL: https://github.com/apache/rocketmq/issues/5359#issuecomment-1773541429 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message

Re: [I] Duplicate code in TimerFlushService [rocketmq]

2023-10-20 Thread via GitHub
github-actions[bot] commented on issue #5327: URL: https://github.com/apache/rocketmq/issues/5327#issuecomment-1773541564 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to t

Re: [I] Duplicate code in TimerFlushService [rocketmq]

2023-10-20 Thread via GitHub
github-actions[bot] closed issue #5327: Duplicate code in TimerFlushService URL: https://github.com/apache/rocketmq/issues/5327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] DefaultLitePullConsumerImpl's persistConsumeOffset method should not be called by MQClientInstance if DefaultLitePullConsumerImpl disable autoCommit [rocketmq]

2023-10-20 Thread via GitHub
github-actions[bot] commented on issue #5315: URL: https://github.com/apache/rocketmq/issues/5315#issuecomment-1773541597 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message

Re: [PR] [ISSUE#5359] Optimize the heartbeat check pre-collection address [rocketmq]

2023-10-20 Thread via GitHub
github-actions[bot] commented on PR #5360: URL: https://github.com/apache/rocketmq/pull/5360#issuecomment-1773541392 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, pleas

Re: [I] Error core-concept url in comment. [rocketmq]

2023-10-20 Thread via GitHub
github-actions[bot] commented on issue #5358: URL: https://github.com/apache/rocketmq/issues/5358#issuecomment-1773541463 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message

Re: [I] Resolve the unstable unit tests [rocketmq]

2023-10-20 Thread via GitHub
github-actions[bot] commented on issue #5331: URL: https://github.com/apache/rocketmq/issues/5331#issuecomment-1773541501 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message

Re: [I] How to use Rocketmq Ledger cluster mode for spring boot? [rocketmq]

2023-10-20 Thread via GitHub
github-actions[bot] commented on issue #5330: URL: https://github.com/apache/rocketmq/issues/5330#issuecomment-1773541530 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message

[GH] (rocketmq-e2e): Workflow run "E2E test for pull request" failed!

2023-10-20 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq-e2e.git has failed. Run started by GitHub user Zintoki (triggered by Zintoki). Head commit for run: 51a01c18fd9eb2652dbf3ec97a9877d48e00cd89 / XiaoWei Zhang <1403767...@qq.com> Added the java4.x client cluster filter pull test conte

[GH] (rocketmq-e2e): Workflow run "E2E test for pull request" failed!

2023-10-20 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq-e2e.git has failed. Run started by GitHub user Zintoki (triggered by Zintoki). Head commit for run: 51a01c18fd9eb2652dbf3ec97a9877d48e00cd89 / XiaoWei Zhang <1403767...@qq.com> Added the java4.x client cluster filter pull test conte

Re: [PR] [ISSUE #7437] Add the CRC check of commitlog [rocketmq]

2023-10-20 Thread via GitHub
joeCarf commented on code in PR #7468: URL: https://github.com/apache/rocketmq/pull/7468#discussion_r1367675718 ## store/src/main/java/org/apache/rocketmq/store/CommitLog.java: ## @@ -61,7 +61,6 @@ import org.apache.rocketmq.store.logfile.MappedFile; import org.apache.rocketmq