Re: [I] Code comments of updateConsumeOffset() should be corrected [rocketmq]

[via GitHub]

tensory2022 commented on issue #7489:
URL: https://github.com/apache/rocketmq/issues/7489#issuecomment-1772543186

   > <img alt="截屏2023-10-20 17 07 41" width="865" 
src="https://user-images.githubusercontent.com/52153761/276881360-b801a8e5-773b-472d-8304-1327ff800e52.png";>
 
updateOffset这个方法有两个实现，一个是在本地存储offset，一个是将offset存在broker里。这两种实现分别对应着广播消费和集群消费模式，因此我理解这里的comment有些模糊，但是大意应该没有问题
   
   Thanks for your reply :)
   
   There is no difference in the implementations of method updateOffset() 
between LocalFileOffsetStore and RemoteBrokerOffsetStore. The codes of 
updateOffset() in RemoteBrokerOffsetStore (Clustering mode as you said) are as 
follows：
   
![image](https://github.com/apache/rocketmq/assets/126217979/7943812a-8537-4231-923d-1081dc46dfe5)
   
   As per the code, I can not found the interaction between client and broker. 
Therefore, I still think the comment should be corrected. You are right with 
the fact that the scheduled service would update offset from client memory to 
broker disk. However, that action is not directly to update offset to broker.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org