Re: [PR] [ISSUE #7601] Fix slave acting master bug [rocketmq]

2023-12-06 Thread via GitHub
RongtongJin merged PR #7603: URL: https://github.com/apache/rocketmq/pull/7603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocke

Re: [PR] [ISSUE #7601] Fix slave acting master bug [rocketmq]

2023-12-06 Thread via GitHub
gaoyf commented on code in PR #7603: URL: https://github.com/apache/rocketmq/pull/7603#discussion_r1418237986 ## store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java: ## @@ -1140,8 +1146,8 @@ public MessageExtBrokerInner convertMessage(MessageExt msgExt, b

Re: [PR] [ISSUE #7601] Fix slave acting master bug [rocketmq]

2023-12-06 Thread via GitHub
gaoyf commented on code in PR #7603: URL: https://github.com/apache/rocketmq/pull/7603#discussion_r1418237986 ## store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java: ## @@ -1140,8 +1146,8 @@ public MessageExtBrokerInner convertMessage(MessageExt msgExt, b

Re: [PR] [ISSUE #7601] Fix slave acting master bug [rocketmq]

2023-12-06 Thread via GitHub
RongtongJin commented on code in PR #7603: URL: https://github.com/apache/rocketmq/pull/7603#discussion_r1417232281 ## store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java: ## @@ -1140,8 +1146,8 @@ public MessageExtBrokerInner convertMessage(MessageExt msg