RongtongJin commented on code in PR #7603:
URL: https://github.com/apache/rocketmq/pull/7603#discussion_r1417232281
##########
store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java:
##########
@@ -1140,8 +1146,8 @@ public MessageExtBrokerInner convertMessage(MessageExt
msgExt, boolean needRoll)
} else {
msgInner.setTopic(msgInner.getProperty(MessageConst.PROPERTY_REAL_TOPIC));
msgInner.setQueueId(Integer.parseInt(msgInner.getProperty(MessageConst.PROPERTY_REAL_QUEUE_ID)));
- MessageAccessor.clearProperty(msgInner,
MessageConst.PROPERTY_REAL_TOPIC);
- MessageAccessor.clearProperty(msgInner,
MessageConst.PROPERTY_REAL_QUEUE_ID);
+ // MessageAccessor.clearProperty(msgInner,
MessageConst.PROPERTY_REAL_TOPIC);
Review Comment:
Alternatively, we should add a messageAccessior.deepCopyProperties instead
of using the same reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
