Re: [PR] [ISSUE #8963] Fix code36 request sent to ns [rocketmq]

2024-11-26 Thread via GitHub
yuz10 merged PR #8964: URL: https://github.com/apache/rocketmq/pull/8964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.ap

Re: [PR] [ISSUE #8963] Fix code36 request sent to ns [rocketmq]

2024-11-26 Thread via GitHub
yx9o commented on code in PR #8964: URL: https://github.com/apache/rocketmq/pull/8964#discussion_r1858555978 ## client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java: ## @@ -767,6 +767,9 @@ private void sendMessageBack(MessageExt msg, int

Re: [PR] [ISSUE #8963] Fix code36 request sent to ns [rocketmq]

2024-11-25 Thread via GitHub
ltamber commented on code in PR #8964: URL: https://github.com/apache/rocketmq/pull/8964#discussion_r1857667797 ## client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java: ## @@ -767,6 +767,9 @@ private void sendMessageBack(MessageExt msg, in

Re: [PR] [ISSUE #8963] Fix code36 request sent to ns [rocketmq]

2024-11-25 Thread via GitHub
yx9o commented on code in PR #8964: URL: https://github.com/apache/rocketmq/pull/8964#discussion_r1856415747 ## client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java: ## @@ -767,6 +767,9 @@ private void sendMessageBack(MessageExt msg, int

Re: [PR] [ISSUE #8963] Fix code36 request sent to ns [rocketmq]

2024-11-25 Thread via GitHub
yx9o commented on code in PR #8964: URL: https://github.com/apache/rocketmq/pull/8964#discussion_r1856415747 ## client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java: ## @@ -767,6 +767,9 @@ private void sendMessageBack(MessageExt msg, int

Re: [PR] [ISSUE #8963] Fix code36 request sent to ns [rocketmq]

2024-11-25 Thread via GitHub
ltamber commented on code in PR #8964: URL: https://github.com/apache/rocketmq/pull/8964#discussion_r1856398948 ## client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java: ## @@ -767,6 +767,9 @@ private void sendMessageBack(MessageExt msg, in

Re: [PR] [ISSUE #8963] Fix code36 request sent to ns [rocketmq]

2024-11-20 Thread via GitHub
codecov-commenter commented on PR #8964: URL: https://github.com/apache/rocketmq/pull/8964#issuecomment-2488571680 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8964?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment