ltamber commented on code in PR #8964:
URL: https://github.com/apache/rocketmq/pull/8964#discussion_r1856398948
##########
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java:
##########
@@ -767,6 +767,9 @@ private void sendMessageBack(MessageExt msg, int
delayLevel, final String broker
} else {
String brokerAddr = (null != brokerName) ?
this.mQClientFactory.findBrokerAddressInPublish(brokerName)
:
RemotingHelper.parseSocketAddressAddr(msg.getStoreHost());
+ if (UtilAll.isBlank(brokerAddr)) {
Review Comment:
Will this code have the same issue
?https://github.com/apache/rocketmq/blob/a8779c0d4e815835bc17f708a0215cb5877b4004/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java#L649-L651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
