Re: [PR] [ISSUE #7651] Support to send trace for batchSend [rocketmq]

github-actions[bot] closed pull request #7652: [ISSUE #7651] Support to send trace for batchSend URL: https://github.com/apache/rocketmq/pull/7652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [ISSUE #7651] Support to send trace for batchSend [rocketmq]

github-actions[bot] commented on PR #7652: URL: https://github.com/apache/rocketmq/pull/7652#issuecomment-2781745682 This PR was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] [ISSUE #7651] Support to send trace for batchSend [rocketmq]

github-actions[bot] commented on PR #7652: URL: https://github.com/apache/rocketmq/pull/7652#issuecomment-2777250616 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, pleas

Re: [PR] [ISSUE #7651] Support to send trace for batchSend [rocketmq]

cserwen commented on PR #7652: URL: https://github.com/apache/rocketmq/pull/7652#issuecomment-2014540135 @lizhimins Please help me review this code :-D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [ISSUE #7651] Support to send trace for batchSend [rocketmq]

cserwen commented on code in PR #7652: URL: https://github.com/apache/rocketmq/pull/7652#discussion_r1500412841 ## client/src/main/java/org/apache/rocketmq/client/trace/hook/SendMessageTraceHookImpl.java: ## @@ -75,24 +97,38 @@ public void sendMessageAfter(SendMessageContext con

Re: [PR] [ISSUE #7651] Support to send trace for batchSend [rocketmq]

lizhimins commented on code in PR #7652: URL: https://github.com/apache/rocketmq/pull/7652#discussion_r1500180420 ## client/src/main/java/org/apache/rocketmq/client/trace/hook/SendMessageTraceHookImpl.java: ## @@ -75,24 +97,38 @@ public void sendMessageAfter(SendMessageContext c

Re: [PR] [ISSUE #7651] support to send trace for batchSend [rocketmq]

cserwen commented on PR #7652: URL: https://github.com/apache/rocketmq/pull/7652#issuecomment-1888736870 > LGTM > > There will be significant improvement in the performance of the trajectory. Need to approve it, lol @leizhiyuan -- This is an automated message from the Apache

Re: [PR] [ISSUE #7651] support to send trace for batchSend [rocketmq]

leizhiyuan commented on PR #7652: URL: https://github.com/apache/rocketmq/pull/7652#issuecomment-1886992109 LGTM There will be significant improvement in the performance of the trajectory. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [ISSUE #7651] support to send trace for batchSend [rocketmq]

humkum commented on PR #7652: URL: https://github.com/apache/rocketmq/pull/7652#issuecomment-1886384979 LGTM~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] [ISSUE #7651] support to send trace for batchSend [rocketmq]

codecov-commenter commented on PR #7652: URL: https://github.com/apache/rocketmq/pull/7652#issuecomment-1853255700 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7652?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

[PR] [ISSUE #7651] support to send trace for batchSend [rocketmq]

cserwen opened a new pull request, #7652: URL: https://github.com/apache/rocketmq/pull/7652 ### Which Issue(s) This PR Fixes Fixes #7651 ### Brief Description Make SendMessageTraceHookImpl support processing batch messages ### How Did You Test T