lizhimins commented on code in PR #7652:
URL: https://github.com/apache/rocketmq/pull/7652#discussion_r1500180420
##########
client/src/main/java/org/apache/rocketmq/client/trace/hook/SendMessageTraceHookImpl.java:
##########
@@ -75,24 +97,38 @@ public void sendMessageAfter(SendMessageContext context) {
}
if (context.getSendResult().getRegionId() == null
- || !context.getSendResult().isTraceOn()) {
+ || !context.getSendResult().isTraceOn()
+ || StringUtils.isEmpty(context.getSendResult().getMsgId())
Review Comment:
MsgId 是客户端生成的 uniqueKey，OffsetId 是服务端生成的，应该有其一就可以定位消息了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
