YxAc commented on PR #279:
URL: https://github.com/apache/rocketmq-mqtt/pull/279#issuecomment-2154840175
hi @DongyuanPan , i have updated this PR according to the review comments,
pls take a look when you are free. Thx.
--
This is an automated message from the Apache Git Service.
To respo
YxAc commented on code in PR #279:
URL: https://github.com/apache/rocketmq-mqtt/pull/279#discussion_r1630793092
##
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/session/infly/PushAction.java:
##
@@ -181,6 +185,12 @@ public void write(Session session, Message message, int
mq
YxAc commented on code in PR #279:
URL: https://github.com/apache/rocketmq-mqtt/pull/279#discussion_r1630791168
##
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/channel/DefaultChannelManager.java:
##
@@ -47,6 +48,12 @@ public class DefaultChannelManager implements ChannelMan
YxAc commented on code in PR #279:
URL: https://github.com/apache/rocketmq-mqtt/pull/279#discussion_r1630790862
##
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/config/ConnectConf.java:
##
@@ -61,6 +61,7 @@ public class ConnectConf {
private boolean enableRetain = false
YxAc commented on code in PR #279:
URL: https://github.com/apache/rocketmq-mqtt/pull/279#discussion_r1630789596
##
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/channel/ChannelManager.java:
##
@@ -63,4 +63,35 @@ public interface ChannelManager {
*/
int totalConn()
DongyuanPan commented on code in PR #279:
URL: https://github.com/apache/rocketmq-mqtt/pull/279#discussion_r1628718513
##
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/channel/DefaultChannelManager.java:
##
@@ -177,4 +188,71 @@ public int totalConn() {
return channe
ChangingFond commented on code in PR #279:
URL: https://github.com/apache/rocketmq-mqtt/pull/279#discussion_r1626836891
##
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/config/ConnectConf.java:
##
@@ -61,6 +61,7 @@ public class ConnectConf {
private boolean enableRetain
YxAc opened a new pull request, #279:
URL: https://github.com/apache/rocketmq-mqtt/pull/279
### Which Issue(s) This PR Fixes
Close #246
### Brief Description
implement flow control for MQTT 5.0
### How Did You Test This Change?
UT
--
This is an automated message fro
