ChangingFond commented on code in PR #279:
URL: https://github.com/apache/rocketmq-mqtt/pull/279#discussion_r1626836891
##########
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/config/ConnectConf.java:
##########
@@ -61,6 +61,7 @@ public class ConnectConf {
private boolean enableRetain = false;
private boolean enableSubscriptionIdentifier = false;
private int topicAliasMaximum = 10;
+ private int serverReceiveMaximum = 65535;
Review Comment:
why set to 65535？
##########
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/channel/ChannelManager.java:
##########
@@ -63,4 +63,35 @@ public interface ChannelManager {
*/
int totalConn();
+ /**
+ * Refills the publish receive quota for the given channel.
+ * This method is typically called after a publish acknowledgement or
other scenarios that refill the quota.
+ * @param channel The channel for which the quota needs to be refilled.
+ * @return true if the quota was successfully refilled, false otherwise.
+ */
+ boolean publishReceiveRefill(Channel channel);
Review Comment:
extract these flow releated method into another class？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
