Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-06 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2074856652 ## include/nuttx/mutex.h: ## @@ -354,407 +384,497 @@ void nxmutex_reset(FAR mutex_t *mutex); *

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-06 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2074866117 ## libs/libc/semaphore/sem_getvalue.c: ## @@ -67,25 +63,9 @@ int nxsem_get_value(FAR sem_t *sem, FAR int *sval) { - if (sem != NULL && sval != NULL) + if (sem !=

Re: [PR] sched/wqueue: Refactor delayed and periodic workqueue. [nuttx]

2025-05-06 Thread via GitHub
Fix-Point commented on code in PR #16231: URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074918858 ## libs/libc/wqueue/work_cancel.c: ## @@ -89,7 +89,7 @@ static int work_qcancel(FAR struct usr_wqueue_s *wqueue, */ curr = wqueue->q.head; - whi

Re: [PR] tools: add a convert tool to help migrate from make to cmake [nuttx]

2025-05-06 Thread via GitHub
raiden00pl commented on code in PR #9782: URL: https://github.com/apache/nuttx/pull/9782#discussion_r2074895701 ## tools/nxmake2cmake.py: ## @@ -0,0 +1,241 @@ +#!/usr/bin/env python3 + +# tools/nxmake2cm

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-06 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074983072 ## drivers/misc/optee.c: ## @@ -145,10 +207,398 @@ static bool optee_safe_va_range(FAR void *va, size_t size) return false; } -#else +#else /* !CONFIG_ARCH_ADDR

Re: [PR] boards/stm32f0l0g0: Add Nucleo G0B1RE support. [nuttx]

2025-05-06 Thread via GitHub
raiden00pl commented on PR #16293: URL: https://github.com/apache/nuttx/pull/16293#issuecomment-2853524486 @stbenn `nucleo-g0b1re/nsh` is not normalized. Try this command and update config: ``` boards/arm/stm32f0l0g0/nucleo-g0b1re/configs/nsh/defconfig ``` -- This is an automated

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-06 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2074862627 ## libs/libc/semaphore/sem_getvalue.c: ## @@ -65,7 +69,23 @@ int nxsem_get_value(FAR sem_t *sem, FAR int *sval) { if (sem != NULL && sval != NULL) { - *s

Re: [PR] tools: add a convert tool to help migrate from make to cmake [nuttx]

2025-05-06 Thread via GitHub
raiden00pl commented on code in PR #9782: URL: https://github.com/apache/nuttx/pull/9782#discussion_r2074889448 ## tools/nxmake2cmake.py: ## @@ -0,0 +1,241 @@ +#!/usr/bin/env python3 + +# tools/nxmake2cm

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-06 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2075016912 ## drivers/misc/optee.c: ## @@ -476,62 +956,83 @@ static int optee_ioctl_invoke(FAR struct optee_priv_data *priv, arg->ret = TEE_ERROR_COMMUNICATION; arg->ret_o

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-06 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2075016912 ## drivers/misc/optee.c: ## @@ -476,62 +956,83 @@ static int optee_ioctl_invoke(FAR struct optee_priv_data *priv, arg->ret = TEE_ERROR_COMMUNICATION; arg->ret_o

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-06 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074827254 ## drivers/misc/optee.c: ## @@ -476,62 +956,83 @@ static int optee_ioctl_invoke(FAR struct optee_priv_data *priv, arg->ret = TEE_ERROR_COMMUNICATION; arg->ret_o

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-06 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074827254 ## drivers/misc/optee.c: ## @@ -476,62 +956,83 @@ static int optee_ioctl_invoke(FAR struct optee_priv_data *priv, arg->ret = TEE_ERROR_COMMUNICATION; arg->ret_o

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2075158766 ## sched/semaphore/sem_waitirq.c: ## @@ -72,31 +72,55 @@ void nxsem_wait_irq(FAR struct tcb_s *wtcb, int errcode) { FAR struct tcb_s *rtcb = this_task();

Re: [PR] sched/wqueue: Refactor delayed and periodic workqueue. [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 commented on PR #16231: URL: https://github.com/apache/nuttx/pull/16231#issuecomment-2854034824 @Fix-Point please fix: ``` /home/runner/work/nuttx/nuttx/nuttx/sched/wdog/wd_start.c:297: Absoulute ==> Absolute `` -- This is an automated message from the Apache Git

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 commented on PR #16194: URL: https://github.com/apache/nuttx/pull/16194#issuecomment-2854058081 > > It doesn't make sense to boost the thread which pass nxsem_wait on a counting semaphore, since the priority boost is meaningful only for a mutex(binary semaphore). That's why

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2075183253 ## drivers/misc/optee.c: ## @@ -145,10 +207,398 @@ static bool optee_safe_va_range(FAR void *va, size_t size) return false; } -#else +#else /* !CONFIG_AR

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2075185420 ## include/nuttx/tee.h: ## @@ -198,6 +198,10 @@ struct tee_ioctl_shm_register_fd_data #define TEE_IOCTL_LOGIN_REE_KERNEL 0x8000 +/* Macro

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2075194354 ## drivers/misc/optee.c: ## @@ -476,62 +956,83 @@ static int optee_ioctl_invoke(FAR struct optee_priv_data *priv, arg->ret = TEE_ERROR_COMMUNICATION; arg

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2075194354 ## drivers/misc/optee.c: ## @@ -476,62 +956,83 @@ static int optee_ioctl_invoke(FAR struct optee_priv_data *priv, arg->ret = TEE_ERROR_COMMUNICATION; arg

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-06 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2075217001 ## drivers/misc/optee.c: ## @@ -476,62 +956,83 @@ static int optee_ioctl_invoke(FAR struct optee_priv_data *priv, arg->ret = TEE_ERROR_COMMUNICATION; arg->ret_o

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2075276174 ## drivers/misc/optee.c: ## @@ -476,62 +956,83 @@ static int optee_ioctl_invoke(FAR struct optee_priv_data *priv, arg->ret = TEE_ERROR_COMMUNICATION; arg

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2075276174 ## drivers/misc/optee.c: ## @@ -476,62 +956,83 @@ static int optee_ioctl_invoke(FAR struct optee_priv_data *priv, arg->ret = TEE_ERROR_COMMUNICATION; arg

Re: [PR] Documentation: fix spelling [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 commented on PR #16318: URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2854250308 > I think that the release notes should not be corrected since those are spelling errors in the actual commit titles but the similar issue in commit message is already fixed

Re: [PR] espressif: Add variable to override MCUboot version and URL [nuttx]

2025-05-06 Thread via GitHub
tmedicci commented on code in PR #16320: URL: https://github.com/apache/nuttx/pull/16320#discussion_r2075363360 ## arch/risc-v/src/common/espressif/Bootloader.mk: ## @@ -35,8 +35,14 @@ BOOTLOADER_CONFIG= $(BOOTLOADER_SRCDIR)/bootloader.conf MCUBOOT_SRCDIR = $(BOOTLOAD

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2075344025 ## sched/semaphore/sem_waitirq.c: ## @@ -72,31 +72,54 @@ void nxsem_wait_irq(FAR struct tcb_s *wtcb, int errcode) { FAR struct tcb_s *rtcb = this_task();

Re: [I] [HELP] Please explain the esp32 wlan driver working which cause the following issue on cpu0 [nuttx]

2025-05-06 Thread via GitHub
fdcavalcanti commented on issue #16269: URL: https://github.com/apache/nuttx/issues/16269#issuecomment-2854500885 I used your `defconfig` and failed to replicate. `wapi scan wlan0` worked normally right after a reboot. Also, I asked this before, but are you using a devkit or a custom

Re: [PR] Patches to support AVRDA/DB created by KR [nuttx]

2025-05-06 Thread via GitHub
acassis commented on PR #16323: URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2854607607 @xiaoxiang781216 @lupyuen should we disable AVRDA/DB check for now until we get a proper AVR Toolchain? -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] boot/nxboot: Enhancements to add progress messages and copy-to-RAM [nuttx-apps]

2025-05-06 Thread via GitHub
michallenc commented on code in PR #3068: URL: https://github.com/apache/nuttx-apps/pull/3068#discussion_r2075502357 ## boot/nxboot/Kconfig: ## @@ -92,6 +103,10 @@ config NXBOOT_PREVENT_DOWNGRADE WARNING: NXboot currently implements preferences only for

Re: [PR] fs/dup3: If "newfd" is open, close it gracefully to prevent panic [nuttx]

2025-05-06 Thread via GitHub
nuttxpr commented on PR #16326: URL: https://github.com/apache/nuttx/pull/16326#issuecomment-2854833494 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR summary is missing some key information required

Re: [I] [HELP] Please explain the esp32 wlan driver working which cause the following issue on cpu0 [nuttx]

2025-05-06 Thread via GitHub
abisop commented on issue #16269: URL: https://github.com/apache/nuttx/issues/16269#issuecomment-2854817087 @fdcavalcanti Its a xiao esp32s3 -> https://wiki.seeedstudio.com/xiao_esp32s3_getting_started/ ![Image](https://github.com/user-attachments/assets/dbe0509b-b409-4266-b884-da887

Re: [PR] espressif: Add variable to override MCUboot version and URL [nuttx]

2025-05-06 Thread via GitHub
anchao commented on code in PR #16320: URL: https://github.com/apache/nuttx/pull/16320#discussion_r2075628670 ## arch/risc-v/src/common/espressif/Bootloader.mk: ## @@ -35,8 +35,14 @@ BOOTLOADER_CONFIG= $(BOOTLOADER_SRCDIR)/bootloader.conf MCUBOOT_SRCDIR = $(BOOTLOADER

Re: [PR] boards/stm32f0l0g0: Add Nucleo G0B1RE support. [nuttx]

2025-05-06 Thread via GitHub
stbenn commented on PR #16293: URL: https://github.com/apache/nuttx/pull/16293#issuecomment-2854579971 @jerpelea They have been split into separate commits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] github: Setup protection for master branch. [nuttx]

2025-05-06 Thread via GitHub
pussuw commented on PR #16324: URL: https://github.com/apache/nuttx/pull/16324#issuecomment-2854632952 What does linear history mean, no merge commits allowed ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] boot/nxboot: Enhancements to add progress messages and copy-to-RAM [nuttx-apps]

2025-05-06 Thread via GitHub
TimJTi commented on code in PR #3068: URL: https://github.com/apache/nuttx-apps/pull/3068#discussion_r2075512816 ## boot/nxboot/Kconfig: ## @@ -92,6 +103,10 @@ config NXBOOT_PREVENT_DOWNGRADE WARNING: NXboot currently implements preferences only for

Re: [PR] boot/nxboot: Enhancements to add progress messages and copy-to-RAM [nuttx-apps]

2025-05-06 Thread via GitHub
TimJTi commented on code in PR #3068: URL: https://github.com/apache/nuttx-apps/pull/3068#discussion_r2075513462 ## boot/nxboot/Kconfig: ## @@ -64,6 +64,17 @@ config NXBOOT_BOOTLOADER if NXBOOT_BOOTLOADER +config NXBOOT_COPY_TO_RAM + bool "Copy bootable image to RAM b

Re: [PR] boot/nxboot: Enhancements to add progress messages and copy-to-RAM [nuttx-apps]

2025-05-06 Thread via GitHub
jerpelea commented on code in PR #3068: URL: https://github.com/apache/nuttx-apps/pull/3068#discussion_r2075517506 ## boot/nxboot/Kconfig: ## @@ -64,6 +64,17 @@ config NXBOOT_BOOTLOADER if NXBOOT_BOOTLOADER +config NXBOOT_COPY_TO_RAM + bool "Copy bootable image to RAM

Re: [PR] DOCS: Chip tagging [nuttx]

2025-05-06 Thread via GitHub
cederom commented on code in PR #16321: URL: https://github.com/apache/nuttx/pull/16321#discussion_r2075518138 ## Documentation/platforms/arm64/zynq-mpsoc/boards/zcu111/index.rst: ## @@ -2,6 +2,8 @@ Zynq UltraScale+ RFSoC ZCU111 = +.. tags:: chip:

Re: [PR] DOCS: Chip tagging [nuttx]

2025-05-06 Thread via GitHub
cederom commented on code in PR #16321: URL: https://github.com/apache/nuttx/pull/16321#discussion_r2075518138 ## Documentation/platforms/arm64/zynq-mpsoc/boards/zcu111/index.rst: ## @@ -2,6 +2,8 @@ Zynq UltraScale+ RFSoC ZCU111 = +.. tags:: chip:

Re: [PR] boot/nxboot: Enhancements to add progress messages and copy-to-RAM [nuttx-apps]

2025-05-06 Thread via GitHub
TimJTi commented on code in PR #3068: URL: https://github.com/apache/nuttx-apps/pull/3068#discussion_r2075523110 ## boot/nxboot/Kconfig: ## @@ -64,6 +64,17 @@ config NXBOOT_BOOTLOADER if NXBOOT_BOOTLOADER +config NXBOOT_COPY_TO_RAM + bool "Copy bootable image to RAM b

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 commented on PR #16194: URL: https://github.com/apache/nuttx/pull/16194#issuecomment-2854659321 > > @patacongo could you give some comment about this problem? > > If this feature is removed, you will re-introduce priority inheritance issues and damage realtime performa

Re: [PR] github: Setup protection for master branch. [nuttx]

2025-05-06 Thread via GitHub
cederom commented on PR #16324: URL: https://github.com/apache/nuttx/pull/16324#issuecomment-2854665017 > @pussuw: What does linear history mean, no merge commits allowed ? Good question :-) Admins help would be nice here :-P I think we DO WANT the linear history as we do rebase PRs n

Re: [PR] Patches to support AVRDA/DB created by KR [nuttx]

2025-05-06 Thread via GitHub
simbit18 commented on PR #16323: URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2854893902 > @xiaoxiang781216 @lupyuen should we disable AVRDA/DB check for now until we get a proper AVR Toolchain? hi @acassis you must add this ``` # Sparc-gaisler-elf

Re: [PR] espressif: Add variable to override MCUboot version and URL [nuttx]

2025-05-06 Thread via GitHub
tmedicci commented on code in PR #16320: URL: https://github.com/apache/nuttx/pull/16320#discussion_r2075788287 ## arch/risc-v/src/common/espressif/Bootloader.mk: ## @@ -35,8 +35,14 @@ BOOTLOADER_CONFIG= $(BOOTLOADER_SRCDIR)/bootloader.conf MCUBOOT_SRCDIR = $(BOOTLOAD

Re: [PR] Patches to support AVRDA/DB created by KR [nuttx]

2025-05-06 Thread via GitHub
acassis commented on PR #16323: URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2855087468 > > @xiaoxiang781216 @lupyuen should we disable AVRDA/DB check for now until we get a proper AVR Toolchain? > > hi @acassis you must add this > > ``` > # Sparc-gaisler-elf

[PR] boards/stm32h5/nucleo-h563zi: Add USART2 board defines. [nuttx]

2025-05-06 Thread via GitHub
stbenn opened a new pull request, #16327: URL: https://github.com/apache/nuttx/pull/16327 This adds the ability to use USART2 as a console if wanting to use a console without going through the ST-Link VCOM port. This required when using an external debugger or trace with this board.

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-06 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2075217001 ## drivers/misc/optee.c: ## @@ -476,62 +956,83 @@ static int optee_ioctl_invoke(FAR struct optee_priv_data *priv, arg->ret = TEE_ERROR_COMMUNICATION; arg->ret_o

Re: [PR] boot/nxboot: Enhancements to add progress messages and copy-to-RAM [nuttx-apps]

2025-05-06 Thread via GitHub
acassis commented on code in PR #3068: URL: https://github.com/apache/nuttx-apps/pull/3068#discussion_r2075411412 ## boot/nxboot/Kconfig: ## @@ -92,6 +103,10 @@ config NXBOOT_PREVENT_DOWNGRADE WARNING: NXboot currently implements preferences only for

Re: [PR] rpdev_server prefix name enhancement and issue fix [nuttx]

2025-05-06 Thread via GitHub
nuttxpr commented on PR #16325: URL: https://github.com/apache/nuttx/pull/16325#issuecomment-2854742121 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does **not** appear to meet the NuttX requireme

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-06 Thread via GitHub
jlaitine commented on PR #16194: URL: https://github.com/apache/nuttx/pull/16194#issuecomment-2854746686 > 2. Remove the code which track multiple holder for counting semaphore since it never work as expect and impact the real time "never work as expect" *might* not be correct. I do a

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-06 Thread via GitHub
pussuw commented on PR #16194: URL: https://github.com/apache/nuttx/pull/16194#issuecomment-2854759698 > Counting semaphore is normally waited(event) in one thread, but posted(event) in another thread(or even interrupt context) yes in this case using priority inheritance is totally wrong. F

[PR] fs/dup3: If "newfd" is open, close it gracefully to prevent panic [nuttx]

2025-05-06 Thread via GitHub
pussuw opened a new pull request, #16326: URL: https://github.com/apache/nuttx/pull/16326 ## Summary There are two race conditions present in the current implementation: 1. File is partially open / getting closed and dup2/3 is called - This condition arises when one thread op

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 commented on PR #16194: URL: https://github.com/apache/nuttx/pull/16194#issuecomment-2854788694 > > 2. Remove the code which track multiple holder for counting semaphore since it never work as expect and impact the real time > > "never work as expect" _might_ not be co

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-06 Thread via GitHub
patacongo commented on PR #16194: URL: https://github.com/apache/nuttx/pull/16194#issuecomment-2854789114 > But POSIX never define the priority inheritance and priority ceiling for counting semaphore. As I said, the logic is there to support necessary priority inheritance in a realti

Re: [PR] Patches to support AVRDA/DB created by KR [nuttx]

2025-05-06 Thread via GitHub
acassis commented on code in PR #16323: URL: https://github.com/apache/nuttx/pull/16323#discussion_r2075394221 ## arch/avr/src/avr/Kconfig: ## @@ -57,6 +57,26 @@ config AVR_BUILDROOT_TOOLCHAIN endchoice # Toolchain +config AVR_LINUXGCC_TOOLCHAIN_IS_GCC + bool "Mark th

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-06 Thread via GitHub
patacongo commented on PR #16194: URL: https://github.com/apache/nuttx/pull/16194#issuecomment-2854544906 > @patacongo could you give some comment about this problem? If this feature is removed, you will re-introduce priority inheritance issues and damage realtime performance. That i

[PR] github: Setup protection for master branch. [nuttx]

2025-05-06 Thread via GitHub
cederom opened a new pull request, #16324: URL: https://github.com/apache/nuttx/pull/16324 ## Summary * We do not have "Settings" tab in the Apache's owned repository, thus we need to update `.asf.yaml` file with repository settings. * No direct push to master branch is possible.

Re: [PR] Documentation: fix spelling [nuttx]

2025-05-06 Thread via GitHub
sumpfralle commented on PR #16318: URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2854536217 I am trying to summarize the state of discussion: * A) Enabling codespell checks in `checkpatch.sh` by default? * At the moment, *no tests* are enabled by default in that s

Re: [PR] boot/nxboot: Enhancements to add progress messages and copy-to-RAM [nuttx-apps]

2025-05-06 Thread via GitHub
TimJTi commented on code in PR #3068: URL: https://github.com/apache/nuttx-apps/pull/3068#discussion_r2075463497 ## boot/nxboot/Kconfig: ## @@ -92,6 +103,10 @@ config NXBOOT_PREVENT_DOWNGRADE WARNING: NXboot currently implements preferences only for

Re: [PR] boot/nxboot: Enhancements to add progress messages and copy-to-RAM [nuttx-apps]

2025-05-06 Thread via GitHub
TimJTi commented on code in PR #3068: URL: https://github.com/apache/nuttx-apps/pull/3068#discussion_r2075464067 ## boot/nxboot/Kconfig: ## @@ -64,6 +64,17 @@ config NXBOOT_BOOTLOADER if NXBOOT_BOOTLOADER +config NXBOOT_COPY_TO_RAM + bool "Copy bootable image to RAM b

Re: [PR] github: Setup protection for master branch. [nuttx]

2025-05-06 Thread via GitHub
nuttxpr commented on PR #16324: URL: https://github.com/apache/nuttx/pull/16324#issuecomment-2854570505 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR likely meets the NuttX requirements, but n

Re: [PR] Documentation: fix spelling [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 commented on PR #16318: URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2854683859 If we already modify Release note, I prefer to fix all problems directly instead adding the exception rule. It's always good to minimize the exception rule as much as possible.

[PR] rpdev_server prefix name enhancement and issue fix [nuttx]

2025-05-06 Thread via GitHub
yezhonghui2024 opened a new pull request, #16325: URL: https://github.com/apache/nuttx/pull/16325 *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary rpdev_servers as base, support many driver with prefix

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-06 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2075559102 ## sched/semaphore/sem_post.c: ## @@ -85,19 +87,54 @@ int nxsem_post_slow(FAR sem_t *sem) flags = enter_critical_section(); - /* Check the maximum allowable va

Re: [PR] github: Setup protection for master branch. [nuttx]

2025-05-06 Thread via GitHub
pussuw commented on PR #16324: URL: https://github.com/apache/nuttx/pull/16324#issuecomment-2854725871 So linear history means fast forward only. Yes, enforce that please. I reading hate a git history that has a million divergent branches. Impossible to follow. -- This is an automated me

Re: [PR] boards/stm32h5/nucleo-h563zi: Add USART2 board defines. [nuttx]

2025-05-06 Thread via GitHub
nuttxpr commented on PR #16327: URL: https://github.com/apache/nuttx/pull/16327#issuecomment-2855246855 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR description mostly meets the NuttX require

Re: [I] [BUG] ostest failure on Nucleo-G071RB NSH config [nuttx]

2025-05-06 Thread via GitHub
stbenn closed issue #16290: [BUG] ostest failure on Nucleo-G071RB NSH config URL: https://github.com/apache/nuttx/issues/16290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [I] [HELP] Please explain the esp32 wlan driver working which cause the following issue on cpu0 [nuttx]

2025-05-06 Thread via GitHub
fdcavalcanti commented on issue #16269: URL: https://github.com/apache/nuttx/issues/16269#issuecomment-2855255642 I used your defconfig on my `ESP32S3-Devkit`. Telnet is up, ROMFS is selected and connected to a hotspot, did a wireless scan with `wapi scan wlan0`. No issues. ``` ns

Re: [I] [BUG] esp32: cannot create fatfs on /dev/mtdblock0 [nuttx]

2025-05-06 Thread via GitHub
Laczen closed issue #16245: [BUG] esp32: cannot create fatfs on /dev/mtdblock0 URL: https://github.com/apache/nuttx/issues/16245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Patches to support AVRDA/DB created by KR [nuttx]

2025-05-06 Thread via GitHub
acassis commented on PR #16323: URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2855429661 > Thank you @acassis :-) > > These patches come from outside private repository, and processed by @acassis, I have asked original author to follow Contributing Guidelines and sign

Re: [PR] espressif: Add variable to override MCUboot version and URL [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 merged PR #16320: URL: https://github.com/apache/nuttx/pull/16320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated: espressif: Add variable to override MCUboot version and URL

2025-05-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new c22df41ca6 espressif: Add variable to override

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2075950987 ## drivers/misc/optee.c: ## @@ -154,6 +202,248 @@ static bool optee_is_valid_range(FAR void *va, size_t size) # define optee_is_valid_range(addr, size) (true

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2075981968 ## drivers/misc/optee_smc.c: ## @@ -0,0 +1,322 @@ +/ + * drivers/misc/optee_smc.c +

Re: [PR] Patches to support AVRDA/DB created by KR [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #16323: URL: https://github.com/apache/nuttx/pull/16323#discussion_r2075996375 ## arch/avr/src/avr/Kconfig: ## @@ -57,6 +57,26 @@ config AVR_BUILDROOT_TOOLCHAIN endchoice # Toolchain +config AVR_LINUXGCC_TOOLCHAIN_IS_GCC + bool

Re: [I] Actions list to improve NuttX quality and reliability [nuttx]

2025-05-06 Thread via GitHub
Jasinsky commented on issue #16278: URL: https://github.com/apache/nuttx/issues/16278#issuecomment-2855467484 > 11. **Create a base board with a standard MCU plug/insert connector** > > The idea is to have a single base board with many peripherals (sensors, display, audio codec, ether

(nuttx) 04/04: sched: Improved the wdog and wq list insertion.

2025-05-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit fb592064cb22ef7f1c30a457912e6a30546d9892 Author: ouyangxiangzhen AuthorDate: Tue May 6 17:49:43 2025 +0800 sched:

(nuttx) 01/04: wqueue: improve the robustness of the work

2025-05-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 900b1c19ddfaece35df7306ad368db72c6a32a78 Author: ouyangxiangzhen AuthorDate: Tue May 6 15:05:40 2025 +0800 wqueue

(nuttx) 03/04: sched/wqueue: Refactor delayed and periodical workqueue.

2025-05-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 6f72f5481d52f6d5ce5cb1d38d60b443d01b8c11 Author: ouyangxiangzhen AuthorDate: Thu Apr 17 11:41:22 2025 +0800 sched

Re: [PR] sched/wqueue: Refactor delayed and periodic workqueue. [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 merged PR #16231: URL: https://github.com/apache/nuttx/pull/16231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated (fb592064cb -> f967a69748)

2025-05-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from fb592064cb sched: Improved the wdog and wq list insertion. add f967a69748 arch/arm/sama5: Add code to report th

(nuttx) 02/04: sched/wqueue: Change dq to list.

2025-05-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 9dbb9b49c65ed738948f3047d44d871c195cf3d2 Author: ouyangxiangzhen AuthorDate: Wed Apr 16 19:44:35 2025 +0800 sched

(nuttx) 02/02: documentation/platforms/arm: Add Nucleo G0B1 board.

2025-05-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 6ef5dab1600230cb008f348b165effc16373e11c Author: Tyler Bennett AuthorDate: Tue May 6 08:07:52 2025 -0500 document

(nuttx) branch master updated (c22df41ca6 -> fb592064cb)

2025-05-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from c22df41ca6 espressif: Add variable to override MCUboot version and URL new 900b1c19dd wqueue: improve the robus

Re: [PR] arch/arm/sama5: Add support for reset reason logging [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 merged PR #16303: URL: https://github.com/apache/nuttx/pull/16303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) 01/02: boards/stm32f0l0g0: Add Nucleo G0B1RE support

2025-05-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 94a62cb5a7999b333bd2eec026a159e2cf48c760 Author: Tyler Bennett AuthorDate: Tue May 6 08:07:32 2025 -0500 boards/s

(nuttx) branch master updated (f967a69748 -> 6ef5dab160)

2025-05-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from f967a69748 arch/arm/sama5: Add code to report the reset reason new 94a62cb5a7 boards/stm32f0l0g0: Add Nucleo G0

Re: [PR] boards/stm32f0l0g0: Add Nucleo G0B1RE support. [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 merged PR #16293: URL: https://github.com/apache/nuttx/pull/16293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] fs/dup3: If "newfd" is open, close it gracefully to prevent panic [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #16326: URL: https://github.com/apache/nuttx/pull/16326#discussion_r2075885368 ## fs/inode/fs_files.c: ## @@ -317,11 +331,36 @@ static int nx_dup3_from_tcb(FAR struct tcb_s *tcb, int fd1, int fd2, return -EBADF; } + /* dup3

Re: [PR] fs/dup3: If "newfd" is open, close it gracefully to prevent panic [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #16326: URL: https://github.com/apache/nuttx/pull/16326#discussion_r2075896334 ## include/nuttx/fs/fs.h: ## @@ -462,6 +462,7 @@ struct file int f_oflags; /* Open mode flags */ #ifdef CONFIG_FS_REFCOUNT atomic_t

Re: [PR] fs/dup3: If "newfd" is open, close it gracefully to prevent panic [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #16326: URL: https://github.com/apache/nuttx/pull/16326#discussion_r2075896334 ## include/nuttx/fs/fs.h: ## @@ -462,6 +462,7 @@ struct file int f_oflags; /* Open mode flags */ #ifdef CONFIG_FS_REFCOUNT atomic_t

(nuttx) branch master updated (e086ef2d02 -> 6eba7ad35b)

2025-05-06 Thread cederom
This is an automated email from the ASF dual-hosted git repository. cederom pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from e086ef2d02 boards/arm/stm32f7/nucleo-f767zi: enhance button support add 4d8d2354ec docs/arm/stm32: Tag all STM32

Re: [PR] DOCS: Chip tagging [nuttx]

2025-05-06 Thread via GitHub
cederom merged PR #16321: URL: https://github.com/apache/nuttx/pull/16321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

(nuttx) branch master updated (6ef5dab160 -> 559a278ddb)

2025-05-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 6ef5dab160 documentation/platforms/arm: Add Nucleo G0B1 board. add 559a278ddb boards/stm32h5/nucleo-h563zi: Add

Re: [PR] boards/stm32h5/nucleo-h563zi: Add USART2 board defines. [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 merged PR #16327: URL: https://github.com/apache/nuttx/pull/16327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2076022628 ## sched/semaphore/sem_post.c: ## @@ -116,7 +153,10 @@ int nxsem_post_slow(FAR sem_t *sem) * initialized if the semaphore is to used for signaling purposes.

Re: [PR] Patches to support AVRDA/DB created by KR [nuttx]

2025-05-06 Thread via GitHub
acassis commented on code in PR #16323: URL: https://github.com/apache/nuttx/pull/16323#discussion_r2076029293 ## arch/avr/src/avr/Kconfig: ## @@ -57,6 +57,26 @@ config AVR_BUILDROOT_TOOLCHAIN endchoice # Toolchain +config AVR_LINUXGCC_TOOLCHAIN_IS_GCC + bool "Mark th

Re: [PR] Patches to support AVRDA/DB created by KR [nuttx]

2025-05-06 Thread via GitHub
acassis commented on code in PR #16323: URL: https://github.com/apache/nuttx/pull/16323#discussion_r2076029293 ## arch/avr/src/avr/Kconfig: ## @@ -57,6 +57,26 @@ config AVR_BUILDROOT_TOOLCHAIN endchoice # Toolchain +config AVR_LINUXGCC_TOOLCHAIN_IS_GCC + bool "Mark th

Re: [PR] Patches to support AVRDA/DB created by KR [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #16323: URL: https://github.com/apache/nuttx/pull/16323#discussion_r2076033609 ## arch/avr/src/avr/Kconfig: ## @@ -57,6 +57,26 @@ config AVR_BUILDROOT_TOOLCHAIN endchoice # Toolchain +config AVR_LINUXGCC_TOOLCHAIN_IS_GCC + bool

Re: [PR] arch/arm/rp23xx: add dsp/fpu extensions support [nuttx]

2025-05-06 Thread via GitHub
avgoor commented on PR #16306: URL: https://github.com/apache/nuttx/pull/16306#issuecomment-2855593946 @shtirlic doesn't help unfortunately. I've even tried to completely remove `arm_fpuconfig();` and it still crashes. Only removing `ARCH_HAVE_FPU` from the `.config` fixes the issue. It see

Re: [PR] examples/posix_stdio: Adding posix stdio example for new joiners. [nuttx-apps]

2025-05-06 Thread via GitHub
vrmay23 commented on code in PR #3065: URL: https://github.com/apache/nuttx-apps/pull/3065#discussion_r2076114099 ## examples/posix_stdio/posix_stdio.c: ## @@ -0,0 +1,100 @@ +/ + * apps/examples/posix_st

  1   2   >