xiaoxiang781216 commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2075981968
########## drivers/misc/optee_smc.c: ########## @@ -0,0 +1,322 @@ +/**************************************************************************** + * drivers/misc/optee_smc.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <errno.h> +#include <syslog.h> +#include <string.h> +#include <arch/syscall.h> + +#include "optee.h" +#include "optee_smc.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#if defined(CONFIG_ARCH_ARM) +# define smccc_smc arm_smccc_smc +# define smccc_hvc arm_smccc_hvc +# define smccc_res_t arm_smccc_res_t +#elif defined(CONFIG_ARCH_ARM64) +# define smccc_smc arm64_smccc_smc +# define smccc_hvc arm64_smccc_hvc +# define smccc_res_t arm64_smccc_res_t +#else +# error "CONFIG_DEV_OPTEE_SMC is only supported on arm and arm64" +#endif + +#ifdef CONFIG_DEV_OPTEE_SMC_CONDUIT_SMC +# define smc_conduit smccc_smc +#else +# define smc_conduit smccc_hvc +#endif + +/**************************************************************************** + * Private Types + ****************************************************************************/ + +typedef void (*optee_smc_fn)(unsigned long, unsigned long, unsigned long, + unsigned long, unsigned long, unsigned long, + unsigned long, unsigned long, + FAR smccc_res_t *); + +union optee_os_revision +{ + smccc_res_t smccc; + struct optee_smc_call_get_os_revision_result result; +}; + +union optee_calls_revision +{ + smccc_res_t smccc; + struct optee_smc_calls_revision_result result; +}; + +union optee_exchg_caps +{ + smccc_res_t smccc; + struct optee_smc_exchange_capabilities_result result; +}; + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +/**************************************************************************** + * Private Functions + ****************************************************************************/ + +static bool optee_smc_is_compatible(optee_smc_fn smc_fn) +{ + smccc_res_t callsuid; + union optee_os_revision osrev; + union optee_calls_revision callsrev; + union optee_exchg_caps xchgcaps; + + /* Print the OS revision and build ID (if reported) */ + + osrev.result.build_id = 0; + + smc_fn(OPTEE_SMC_CALL_GET_OS_REVISION, 0, 0, 0, 0, 0, 0, 0, &osrev.smccc); + + if (osrev.result.build_id) + { + syslog(LOG_INFO, "OP-TEE: OS revision %lu.%lu (%08lx)\n", + osrev.result.major, osrev.result.minor, + osrev.result.build_id); + } + else + { + syslog(LOG_INFO, "OP-TEE: OS revision %lu.%lu\n", + osrev.result.major, osrev.result.minor); + } + + /* Check the API UID */ + + smc_fn(OPTEE_SMC_CALLS_UID, 0, 0, 0, 0, 0, 0, 0, &callsuid); + + if (callsuid.a0 != OPTEE_MSG_UID_0 || callsuid.a1 != OPTEE_MSG_UID_1 || + callsuid.a2 != OPTEE_MSG_UID_2 || callsuid.a3 != OPTEE_MSG_UID_3) + { + syslog(LOG_ERR, "OP-TEE: API UID mismatch\n"); + return false; + } + + /* Check the API revision */ + + smc_fn(OPTEE_SMC_CALLS_REVISION, 0, 0, 0, 0, 0, 0, 0, &callsrev.smccc); + + if (callsrev.result.major != OPTEE_MSG_REVISION_MAJOR || + (int)callsrev.result.minor < OPTEE_MSG_REVISION_MINOR) + { + syslog(LOG_ERR, "OP-TEE: API revision incompatible\n"); + return false; + } + + /* Check the capabilities */ + + smc_fn(OPTEE_SMC_EXCHANGE_CAPABILITIES, OPTEE_SMC_NSEC_CAP_UNIPROCESSOR, + 0, 0, 0, 0, 0, 0, &xchgcaps.smccc); + + if (xchgcaps.result.status != OPTEE_SMC_RETURN_OK) + { + syslog(LOG_ERR, "OP-TEE: Failed to exchange capabilities\n"); + return false; + } + + if (!(xchgcaps.result.capabilities & OPTEE_SMC_SEC_CAP_DYNAMIC_SHM)) + { + syslog(LOG_ERR, "OP-TEE: Does not support dynamic shared mem\n"); + return false; + } + + return true; +} + +static void optee_smc_handle_rpc(FAR struct optee_priv_data *priv, + FAR smccc_res_t *par) +{ + FAR struct optee_shm_entry *shme; + uintptr_t shme_pa; + uint32_t rpc_func; + size_t shm_size; + + rpc_func = OPTEE_SMC_RETURN_GET_RPC_FUNC(par->a0); + par->a0 = OPTEE_SMC_CALL_RETURN_FROM_RPC; + + switch (rpc_func) + { + case OPTEE_SMC_RPC_FUNC_ALLOC: + { + shm_size = par->a1; + par->a1 = 0; + par->a2 = 0; + par->a4 = 0; + par->a5 = 0; + + if (!optee_shm_alloc(priv, true, NULL, shm_size, + TEE_SHM_ALLOC | TEE_SHM_REGISTER, &shme)) + { + shme_pa = optee_va_to_pa( + (FAR void *)(uintptr_t)shme->shm.addr); + par->a1 = shme_pa >> 32; + par->a2 = shme_pa & UINT32_MAX; + par->a4 = (uintptr_t)shme >> 32; + par->a5 = (uintptr_t)shme & UINT32_MAX; + } + break; + } + + case OPTEE_SMC_RPC_FUNC_FREE: + { + shme = (FAR struct optee_shm_entry *)(uintptr_t) + ((par->a1 << 32) | (par->a2 & UINT32_MAX)); + optee_shm_free(priv, shme); + break; + } + + case OPTEE_SMC_RPC_FUNC_FOREIGN_INTR: + { + break; + } + + default: + { + syslog(LOG_ERR, "OP-TEE: RPC 0x%04x not implemented\n", rpc_func); + break; + } + } +} + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: optee_transport_init + * + * Description: + * Perform any initialization actions specific to the transport used + * right before the driver is registered. + * + * Returned Values: + * 0 on success; A negated errno value is returned on any failure. + * + ****************************************************************************/ + +int optee_transport_init(void) +{ + if (!optee_smc_is_compatible(smc_conduit)) + { + return -ENOENT; + } + + syslog(LOG_INFO, "OP-TEE: compatibility check complete\n"); + + return 0; +} + +/**************************************************************************** + * Name: optee_transport_open + * + * Description: + * Perform any transport-specific actions upon driver character device + * open. + * + * Returned Values: + * 0 on success; A negated errno value is returned on any failure. + * + ****************************************************************************/ + +int optee_transport_open(FAR struct optee_priv_data *priv) +{ + priv->transport = smc_conduit; Review Comment: let's add: ``` struct optee_smc_priv_data { struct optee_priv_data base; optee_smc_fn smc_fn; }; ``` ########## drivers/misc/optee_socket.c: ########## @@ -0,0 +1,272 @@ +/**************************************************************************** + * drivers/misc/optee_socket.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/arch.h> +#include <nuttx/config.h> +#include <nuttx/net/net.h> +#include <nuttx/kmalloc.h> +#include <sys/types.h> +#include <sys/socket.h> +#include <sys/param.h> +#include <sys/un.h> +#include <netpacket/rpmsg.h> + +#include "optee.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define OPTEE_MAX_IOVEC_NUM 7 Review Comment: ```suggestion #define OPTEE_SOCKET_MAX_IOVEC_NUM 7 ``` ########## drivers/misc/optee_smc.c: ########## @@ -0,0 +1,322 @@ +/**************************************************************************** + * drivers/misc/optee_smc.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <errno.h> +#include <syslog.h> +#include <string.h> +#include <arch/syscall.h> + +#include "optee.h" +#include "optee_smc.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#if defined(CONFIG_ARCH_ARM) +# define smccc_smc arm_smccc_smc +# define smccc_hvc arm_smccc_hvc +# define smccc_res_t arm_smccc_res_t +#elif defined(CONFIG_ARCH_ARM64) +# define smccc_smc arm64_smccc_smc +# define smccc_hvc arm64_smccc_hvc +# define smccc_res_t arm64_smccc_res_t +#else +# error "CONFIG_DEV_OPTEE_SMC is only supported on arm and arm64" +#endif + +#ifdef CONFIG_DEV_OPTEE_SMC_CONDUIT_SMC +# define smc_conduit smccc_smc +#else +# define smc_conduit smccc_hvc +#endif + +/**************************************************************************** + * Private Types + ****************************************************************************/ + +typedef void (*optee_smc_fn)(unsigned long, unsigned long, unsigned long, + unsigned long, unsigned long, unsigned long, + unsigned long, unsigned long, + FAR smccc_res_t *); + +union optee_os_revision Review Comment: let's add optee_smc_ prefix for ALL union -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
