Re: [I] [BUG] USB CDC/ACM write message lost [nuttx]

2025-03-13 Thread via GitHub
yangsong8-a1 commented on issue #15960: URL: https://github.com/apache/nuttx/issues/15960#issuecomment-2723318249 @SPRESENSE without https://github.com/apache/nuttx/pull/15931, the same phenomenon still occurs on windows. After I reset the board, there is still log printing on the serial

Re: [PR] bugfix [nuttx]

2025-03-13 Thread via GitHub
nuttxpr commented on PR #15991: URL: https://github.com/apache/nuttx/pull/15991#issuecomment-2723268649 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR likely meets the _format_ requirements of

[PR] bugfix [nuttx]

2025-03-13 Thread via GitHub
lipan118 opened a new pull request, #15991: URL: https://github.com/apache/nuttx/pull/15991 stm32f1xx support CONFIG_RTC_ALARM=y -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] drivers/sensors/fakesensor: Add baro sensor type to fakesensor [nuttx]

2025-03-13 Thread via GitHub
lupyuen commented on code in PR #15990: URL: https://github.com/apache/nuttx/pull/15990#discussion_r1994654504 ## drivers/sensors/fakesensor_uorb.c: ## @@ -197,6 +197,19 @@ static inline void fakesensor_read_gyro(FAR struct fakesensor_s *sensor, sizeof(stru

Re: [PR] sched/wdog: merge wdog_periods_s into wdog_s [nuttx]

2025-03-13 Thread via GitHub
anchao commented on PR #15959: URL: https://github.com/apache/nuttx/pull/15959#issuecomment-2723459834 > @anchao the initial design is using the unified wdog_s, but it increase 8 bytes for each wdog_s even the caller doesn't use period timer, so the final decision is to used the seperated s

Re: [PR] sched/wdog: merge wdog_periods_s into wdog_s [nuttx]

2025-03-13 Thread via GitHub
anchao commented on PR #15959: URL: https://github.com/apache/nuttx/pull/15959#issuecomment-2723809952 @xiaoxiang781216 So you expect developers to write code like this? ``` struct wdog_periods_s pwdog; struct wdog_s wdog; int ret; if (...) ret = wd_start(&wdog, .

Re: [PR] sched/wdog: merge wdog_periods_s into wdog_s [nuttx]

2025-03-13 Thread via GitHub
anchao commented on PR #15959: URL: https://github.com/apache/nuttx/pull/15959#issuecomment-2723803318 > Sorry, I don't think the new function use new struct isn't consistency. If I only have one wdog_s instance, and I want to support both periodic and non-periodic scenarios, how

Re: [I] [HELP] menuconfig compiling errors about kconfig [nuttx]

2025-03-13 Thread via GitHub
kevinuav commented on issue #15984: URL: https://github.com/apache/nuttx/issues/15984#issuecomment-2723308243 Yeah. It can build the target"px4_fmu-v5_default"successfully but "px4_fmu-v5_default menuconfig". -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] driver/mtd: ramtron multi-device spi bus support [nuttx]

2025-03-13 Thread via GitHub
xiaoxiang781216 commented on code in PR #15987: URL: https://github.com/apache/nuttx/pull/15987#discussion_r1994692170 ## drivers/mtd/ramtron.c: ## @@ -932,19 +945,22 @@ static int ramtron_ioctl(FAR struct mtd_dev_s *dev, * as instances that can be bound to other functions

Re: [PR] sched/wdog: merge wdog_periods_s into wdog_s [nuttx]

2025-03-13 Thread via GitHub
xiaoxiang781216 commented on PR #15959: URL: https://github.com/apache/nuttx/pull/15959#issuecomment-2723569721 > > @anchao the initial design is using the unified wdog_s, but it increase 8 bytes for each wdog_s even the caller doesn't use period timer, so the final decision is to used the

Re: [PR] [BREAKING] boot/nxboot: enhance bootloader capabilities and decision logic [nuttx-apps]

2025-03-13 Thread via GitHub
TimJTi commented on PR #3024: URL: https://github.com/apache/nuttx-apps/pull/3024#issuecomment-2721082510 @michallenc Thank you for the explanation. Having just implemented MCU boot for my custom board I have seen all the issues you mention and now regret choosing it. I much prefer t

[PR] arch/mcx-nxxx: Add register definitions for SYSCON_CLOCKCTRL and LPTMR [nuttx]

2025-03-13 Thread via GitHub
pussuw opened a new pull request, #15986: URL: https://github.com/apache/nuttx/pull/15986 ## Summary This adds memory mapped register definitions for: - SYSCON_CLOCKCTRL (Controls internal FRO output) - LPTMR (Low Power Timer) ## Impact Code impact is adding registe

Re: [PR] libcoap: add makefile, Kconfig and CMakeLists.txt [nuttx-apps]

2025-03-13 Thread via GitHub
Laczen commented on PR #2250: URL: https://github.com/apache/nuttx-apps/pull/2250#issuecomment-2721058773 @zhhyu7 I have been trying to use libcoap on a esp32-devkitc, but I am seeing a lot of errors caused by mbedtls and oscore. I am also seeing errors on sim:nsh. Could you help me

Re: [PR] arch/xtensa: initial support for debugpoint api [nuttx]

2025-03-13 Thread via GitHub
tmedicci commented on PR #15907: URL: https://github.com/apache/nuttx/pull/15907#issuecomment-2721281359 Thanks for submitting it, @chirping78! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] arch/xtensa/esp32: espnow improvements [nuttx]

2025-03-13 Thread via GitHub
tmedicci commented on PR #15962: URL: https://github.com/apache/nuttx/pull/15962#issuecomment-2721278006 > please modify the commit titles and add the affected areas ex arch/xtensa/esp32: 6lowpan over espnow improvements Anything else, @jerpelea ? -- This is an automated message fr

Re: [PR] [BREAKING] boot/nxboot: enhance bootloader capabilities and decision logic [nuttx-apps]

2025-03-13 Thread via GitHub
jerpelea commented on PR #3024: URL: https://github.com/apache/nuttx-apps/pull/3024#issuecomment-2720357936 I would prefer that this change should be scheduled for NuttX 13.0.0. we have already branched out the current release so I have no concerns -- This is an automated message from the

Re: [PR] 202503 Apache NuttX RTOS Contributing Guidelines update. [nuttx]

2025-03-13 Thread via GitHub
hartmannathan commented on code in PR #15950: URL: https://github.com/apache/nuttx/pull/15950#discussion_r1993350373 ## CONTRIBUTING.md: ## @@ -1,133 +1,438 @@ -# Contributing to Apache NuttX RTOS +# Apache NuttX RTOS Contributing Guidelines -Hi! Thank you for your interest in

Re: [PR] arch/xtensa: set PS.EXCM initial value to 1 while new thread created [nuttx]

2025-03-13 Thread via GitHub
tmedicci commented on PR #15985: URL: https://github.com/apache/nuttx/pull/15985#issuecomment-2721392583 Hi @sdc-g , did you find any bug related to this PR? Before applying its patch, what was the behavior of the testing application? Can you please update the PR's descriptions with t

[PR] driver/mtd: ramtron multi-device spi bus support [nuttx]

2025-03-13 Thread via GitHub
stbenn opened a new pull request, #15987: URL: https://github.com/apache/nuttx/pull/15987 Adds a device ID to `ramtron_initialize`, which is stored in the `ramtron_dev_s` structure. This ID is used when calling SPI_SELECT to board specific logic to allow chip select on the SPI bus. T

Re: [PR] net/udp: correct icmp(v6) response from udp_input [nuttx]

2025-03-13 Thread via GitHub
acassis commented on PR #15978: URL: https://github.com/apache/nuttx/pull/15978#issuecomment-2721488477 @jerpelea could you please clear the Change Request? It was fixed already -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] driver/mtd: ramtron multi-device spi bus support [nuttx]

2025-03-13 Thread via GitHub
xiaoxiang781216 commented on code in PR #15987: URL: https://github.com/apache/nuttx/pull/15987#discussion_r1993706173 ## drivers/mtd/ramtron.c: ## @@ -932,19 +945,22 @@ static int ramtron_ioctl(FAR struct mtd_dev_s *dev, * as instances that can be bound to other functions

Re: [I] [BUG] USB CDC/ACM write message lost [nuttx]

2025-03-13 Thread via GitHub
SPRESENSE commented on issue #15960: URL: https://github.com/apache/nuttx/issues/15960#issuecomment-2721070945 @yangsong8-a1 What are the results of Windows before https://github.com/apache/nuttx/pull/15931? -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] fs/vfs/fs_poll: Add noinstrument_function to poll_notify function [nuttx]

2025-03-13 Thread via GitHub
tmedicci commented on PR #15971: URL: https://github.com/apache/nuttx/pull/15971#issuecomment-2721000742 > @xiaoxiang781216 @anjiahao1 I think the correct solution should be to add a nesting counter in the instrument hook to avoid recursion. poll_notify() can only solve the current problem.

Re: [PR] 202503 Apache NuttX RTOS Contributing Guidelines update. [nuttx]

2025-03-13 Thread via GitHub
hartmannathan commented on code in PR #15950: URL: https://github.com/apache/nuttx/pull/15950#discussion_r1993351458 ## CONTRIBUTING.md: ## @@ -1,133 +1,445 @@ -# Contributing to Apache NuttX RTOS +# Apache NuttX RTOS Contributing Guidelines -Hi! Thank you for your interest in

Re: [PR] fs/vfs/fs_poll: Add noinstrument_function to poll_notify function [nuttx]

2025-03-13 Thread via GitHub
tmedicci commented on PR #15971: URL: https://github.com/apache/nuttx/pull/15971#issuecomment-2721294472 > > @xiaoxiang781216 @anjiahao1 I think the correct solution should be to add a nesting counter in the instrument hook to avoid recursion. poll_notify() can only solve the current proble

Re: [PR] driver/mtd: ramtron multi-device spi bus support [nuttx]

2025-03-13 Thread via GitHub
stbenn commented on code in PR #15987: URL: https://github.com/apache/nuttx/pull/15987#discussion_r1993723914 ## drivers/mtd/ramtron.c: ## @@ -932,19 +945,22 @@ static int ramtron_ioctl(FAR struct mtd_dev_s *dev, * as instances that can be bound to other functions * (suc

Re: [I] [HELP] menuconfig compiling errors about kconfig [nuttx]

2025-03-13 Thread via GitHub
acassis commented on issue #15984: URL: https://github.com/apache/nuttx/issues/15984#issuecomment-2722589354 @kevinuav are you able to compile this board profile using the using "make px4_fmu-v5_default " I tried here and it is reporting this error: [ 4%] Built target ver_gen

[PR] drivers/sensors/fakesensor: Add baro sensor type to fakesensor [nuttx]

2025-03-13 Thread via GitHub
AngusJull opened a new pull request, #15990: URL: https://github.com/apache/nuttx/pull/15990 ## Summary Allow fakesensor to read baro data and publish it in the same way as the other supported fakesensor data types. Adds a single function that reads from a CSV file and publishes new

Re: [PR] drivers/sensors/fakesensor: Add baro sensor type to fakesensor [nuttx]

2025-03-13 Thread via GitHub
nuttxpr commented on PR #15990: URL: https://github.com/apache/nuttx/pull/15990#issuecomment-2722661898 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

Re: [PR] net/udp: correct icmp(v6) response from udp_input [nuttx]

2025-03-13 Thread via GitHub
acassis commented on PR #15978: URL: https://github.com/apache/nuttx/pull/15978#issuecomment-2721262888 > > Thank you @Laczen !!! > > This modification should be tested in more boards and with apps examples that use ICMP: > > > > * ipforward > > * nettest > > * tcpblaster

Re: [PR] net/udp: correct icmp(v6) response from udp_input [nuttx]

2025-03-13 Thread via GitHub
Laczen commented on PR #15978: URL: https://github.com/apache/nuttx/pull/15978#issuecomment-2721346660 > @Laczen although it didn't change the code too much, it changed a lot the structure and it could introduce some issues. So let assume everything is fine! Rest assured that if an is

Re: [PR] arch/xtensa: set PS.EXCM initial value to 1 while new thread created [nuttx]

2025-03-13 Thread via GitHub
tmedicci commented on PR #15985: URL: https://github.com/apache/nuttx/pull/15985#issuecomment-2720986262 Marked as draft to avoid being merged before extensive testing. I will trigger our internal CI and test run the runtime testing. -- This is an automated message from the Apache Git Ser

Re: [PR] driver/mtd: ramtron multi-device spi bus support [nuttx]

2025-03-13 Thread via GitHub
nuttxpr commented on PR #15987: URL: https://github.com/apache/nuttx/pull/15987#issuecomment-2721431682 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR mostly meets the requirements, but needs m

Re: [PR] driver/mtd: ramtron multi-device spi bus support [nuttx]

2025-03-13 Thread via GitHub
stbenn commented on PR #15987: URL: https://github.com/apache/nuttx/pull/15987#issuecomment-2721439683 If breaking backwards compatibility with the initialization is not acceptable, it could be broken into two functions. `FAR struct mtd_dev_s ramtron_initialize(FAR struct spi_dev_s *dev)` (

(nuttx) branch master updated: fs/virtio-9p:When virtio-9p is not supported, return -ENODEV

2025-03-13 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 91d895d9a2 fs/virtio-9p:When virtio-9p is not su

Re: [PR] tools/ci: Added CI system on Windows Native [nuttx]

2025-03-13 Thread via GitHub
hartmannathan commented on code in PR #15989: URL: https://github.com/apache/nuttx/pull/15989#discussion_r1994119107 ## tools/ci/platforms/windows.ps1: ## @@ -0,0 +1,305 @@ +#!/usr/bin/env pswd + +# tool

Re: [PR] fs/virtio-9p:When virtio-9p is not supported, return -ENODEV [nuttx]

2025-03-13 Thread via GitHub
acassis merged PR #15963: URL: https://github.com/apache/nuttx/pull/15963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

[PR] tools/ci: Added CI system on Windows Native [nuttx]

2025-03-13 Thread via GitHub
simbit18 opened a new pull request, #15989: URL: https://github.com/apache/nuttx/pull/15989 ## Summary This PR adds support for the CI system for native Windows as well. It allows you to build NuttX on GitHub and test it locally for Windows users. With these CI tools with Power

Re: [PR] fs/vfs/fs_poll: Add noinstrument_function to poll_notify function [nuttx]

2025-03-13 Thread via GitHub
anchao commented on PR #15971: URL: https://github.com/apache/nuttx/pull/15971#issuecomment-2721466557 > > > @xiaoxiang781216 @anjiahao1 I think the correct solution should be to add a nesting counter in the instrument hook to avoid recursion. poll_notify() can only solve the current proble

[PR] arm/nucleo-f429zi: Add board flash size config for STM32F429ZI [nuttx]

2025-03-13 Thread via GitHub
yangwei-william opened a new pull request, #15988: URL: https://github.com/apache/nuttx/pull/15988 This patch add flash size config for nucleo-f429zi nsh. *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary

Re: [PR] tools/ci: Added CI system on Windows Native [nuttx]

2025-03-13 Thread via GitHub
nuttxpr commented on PR #15989: URL: https://github.com/apache/nuttx/pull/15989#issuecomment-2722011068 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR description mostly meets the NuttX requirements

[PR] documentation/boot/nxboot: update nxboot documentation [nuttx]

2025-03-13 Thread via GitHub
michallenc opened a new pull request, #15981: URL: https://github.com/apache/nuttx/pull/15981 ## Summary This updates nxboot documentation with the last changes in nuttx-apps repository. ## Impact Documentation update only. This reflects https://github.com/apache/nuttx-apps/pul

Re: [PR] Documentation:: Add photo of PINE64 StarPro64 SBC [nuttx]

2025-03-13 Thread via GitHub
jerpelea merged PR #15946: URL: https://github.com/apache/nuttx/pull/15946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apa

Re: [PR] arch/mcx-nxxx: Add register definitions for SYSCON_CLOCKCTRL and LPTMR [nuttx]

2025-03-13 Thread via GitHub
lupyuen commented on PR #15986: URL: https://github.com/apache/nuttx/pull/15986#issuecomment-2722880142 Thanks @pussuw! Remember to fill in the Commit Description and Sign Off :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] arch/xtensa: set PS.EXCM initial value to 1 while new thread created [nuttx]

2025-03-13 Thread via GitHub
sdc-g commented on PR #15985: URL: https://github.com/apache/nuttx/pull/15985#issuecomment-2723113854 > Hi @sdc-g , did you find any bug related to this PR? > > Before applying its patch, what was the behavior of the testing application? Can you please update the PR's descriptions wit

Re: [PR] 202503 Apache NuttX RTOS Contributing Guidelines update. [nuttx]

2025-03-13 Thread via GitHub
simbit18 commented on PR #15950: URL: https://github.com/apache/nuttx/pull/15950#issuecomment-2720575953 Hi @cederom I was referring to Is a Pull Request open forever ? (PR is like diamonds !!! ) :) Post **Always Be Closing...Pull Requests** https://www.hanselman.com/blog/always-

Re: [PR] net/can: Fix NULL dereference for I/O Block [nuttx]

2025-03-13 Thread via GitHub
jerpelea merged PR #15965: URL: https://github.com/apache/nuttx/pull/15965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apa

(nuttx) branch master updated (96eb5e7819 -> 9c04b9ed4a)

2025-03-13 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 96eb5e7819 net: sixlowpan icmpv6 return from udp_input add 9c04b9ed4a net/can: Fix NULL dereference for I/O Bloc

Re: [PR] arch/xtensa: set PS.EXCM initial value to 1 while new thread created [nuttx]

2025-03-13 Thread via GitHub
sdc-g commented on PR #15985: URL: https://github.com/apache/nuttx/pull/15985#issuecomment-2720321515 > please update the commit title to > > arch/xtensa: set PS.EXCM initial value to 1 while new thread created Done, thanks for your comment. @jerpelea -- This is an automated

(nuttx) branch master updated (9c04b9ed4a -> e0b02314e6)

2025-03-13 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 9c04b9ed4a net/can: Fix NULL dereference for I/O Block add e0b02314e6 arch/xtensa: initial support for debugpoin

Re: [PR] arch/xtensa: initial support for debugpoint api [nuttx]

2025-03-13 Thread via GitHub
jerpelea merged PR #15907: URL: https://github.com/apache/nuttx/pull/15907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apa

[PR] xtensa: set PS.EXCM initial value to 1 while new thread created [nuttx]

2025-03-13 Thread via GitHub
sdc-g opened a new pull request, #15985: URL: https://github.com/apache/nuttx/pull/15985 ## Summary To avoid level-1 interrupt break retrieve PC/A0/SP/A2 register, PS.EXCM set to 1 by CPU HW while handling exception/interrupt. But if context switching happens and new thread cre

Re: [PR] arch/xtensa: set PS.EXCM initial value to 1 while new thread created [nuttx]

2025-03-13 Thread via GitHub
sdc-g commented on PR #15985: URL: https://github.com/apache/nuttx/pull/15985#issuecomment-2720311503 @zhuyanlin111 Could you please also review the change since previous PR: https://github.com/apache/nuttx/commit/fbc1da98b7b500580a183771c938cce121056c65#diff-6ea32ef16de4dfd7e2971ae010a3

Re: [PR] arch/mcx-nxxx: Add register definitions for SYSCON_CLOCKCTRL and LPTMR [nuttx]

2025-03-13 Thread via GitHub
nuttxpr commented on PR #15986: URL: https://github.com/apache/nuttx/pull/15986#issuecomment-2720713360 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with

Re: [PR] [BREAKING] boot/nxboot: enhance bootloader capabilities and decision logic [nuttx-apps]

2025-03-13 Thread via GitHub
TimJTi commented on PR #3024: URL: https://github.com/apache/nuttx-apps/pull/3024#issuecomment-2720759411 Just a question if I may as this seems to be making NXboot much more like MCUboot? What is the reasoning for improving NXboot rather than using MCUboot? -- This is an automated me

Re: [PR] [BREAKING] boot/nxboot: enhance bootloader capabilities and decision logic [nuttx-apps]

2025-03-13 Thread via GitHub
michallenc commented on PR #3024: URL: https://github.com/apache/nuttx-apps/pull/3024#issuecomment-2720816171 > Just a question if I may as this seems to be making NXboot much more like MCUboot? What is the reasoning for improving NXboot rather than using MCUboot? I would not say this