Laczen commented on PR #15978: URL: https://github.com/apache/nuttx/pull/15978#issuecomment-2721346660
> @Laczen although it didn't change the code too much, it changed a lot the structure and it could introduce some issues. So let assume everything is fine! Rest assured that if an issue is introduced I will take up the glove to correct it. These macro constructs are very good to reduce the code size but they come with a downside of being difficult to verify (test all possible combinations) and make the code hard to read (hence my question regarding `IS_ENABLED()`). They are also difficult to review when looking at the changes instead of the final code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
