Re: [PR] xtensa/esp32: write encrypt func implementation [nuttx]

2025-02-24 Thread via GitHub
sdc-g commented on PR #15896: URL: https://github.com/apache/nuttx/pull/15896#issuecomment-2680642537 > Hello @sdc-g, can you post here test output? Also improve the PR description as suggested by PR bot Hi @fdcavalcanti Please check the test code I shared. Regarding of PR

(nuttx-apps) branch master updated (2eb18712d -> 536e2ccac)

2025-02-24 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git from 2eb18712d netutils/pppd/ppp.h: Fix build issue when network debug is enabled new 89c784188 system/fastboot

Re: [PR] system/fastboot: Add support for fastboot oem shell [nuttx-apps]

2025-02-24 Thread via GitHub
jerpelea merged PR #3003: URL: https://github.com/apache/nuttx-apps/pull/3003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.

(nuttx-apps) 01/02: system/fastboot: Add format string support for fastboot_fail()

2025-02-24 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit 89c784188e7f763fa979d97b9278dc95ce563e42 Author: wangjianyu3 AuthorDate: Thu Feb 20 15:57:57 2025 +0800 syste

(nuttx-apps) 02/02: system/fastboot: Add support for fastboot oem shell

2025-02-24 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit 536e2ccac6d04b983dfaf34f45ca5ec383e76ac3 Author: wangjianyu3 AuthorDate: Thu Feb 20 11:28:10 2025 +0800 syste

(nuttx) branch master updated (70f070fa1c -> eef122260b)

2025-02-24 Thread lupyuen
This is an automated email from the ASF dual-hosted git repository. lupyuen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 70f070fa1c riscv/esp32c6: Fix issue related esp32c6 usbserial driver. add eef122260b arch: cxd56xx: Update delay

Re: [I] [FEATURE] Should we extend fastboot oem to support executing custom commands? [nuttx-apps]

2025-02-24 Thread via GitHub
jerpelea closed issue #2991: [FEATURE] Should we extend fastboot oem to support executing custom commands? URL: https://github.com/apache/nuttx-apps/issues/2991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[PR] arch/esp32_spi: Add check to see if the TX_FIFO is empty [nuttx]

2025-02-24 Thread via GitHub
nuttxs opened a new pull request, #15904: URL: https://github.com/apache/nuttx/pull/15904 ## Summary arch/esp32_spi: Add check to see if the TX_FIFO is empty to avoid sending empty data ## Impact New Feature/Change: Issue fix (no new feature). User Impact: No Build Impact:

Re: [I] [DRUNX] Distributed Runtime and bUild for NuttX Test Environment [nuttx]

2025-02-24 Thread via GitHub
lupyuen commented on issue #15730: URL: https://github.com/apache/nuttx/issues/15730#issuecomment-2680803768 @tmedicci Sorry I thought we were talk about an Initial Defconfig, instead of an Initial CI Test? `rv-virt:citest` has problems today: - It fails randomly, according to [NuttX Das

Re: [I] [Feedback] PR Test Bot [nuttx]

2025-02-24 Thread via GitHub
lupyuen commented on issue #15779: URL: https://github.com/apache/nuttx/issues/15779#issuecomment-2680811005 @tmedicci Right now I have to review manually every Test Bot request, for security issues. Please tag me `@lupyuen` after sending a `@nuttxpr` request :-) -- This is an automated m

Re: [PR] arch: cxd56xx: Update delay value for subcore [nuttx]

2025-02-24 Thread via GitHub
lupyuen merged PR #15884: URL: https://github.com/apache/nuttx/pull/15884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [I] [Feedback] PR Test Bot [nuttx]

2025-02-24 Thread via GitHub
tmedicci commented on issue #15779: URL: https://github.com/apache/nuttx/issues/15779#issuecomment-2679284557 @lupyuen , I have a question: If I understood correctly, anyone could trigger (by tagging @nuttxpr) the testbot but I'd only run if you "like" the message that tagged it? Is t

Re: [PR] Initial standalone sx126x driver [WIP] [nuttx]

2025-02-24 Thread via GitHub
keever50 commented on PR #15795: URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2679284009 Documentation added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] arch/arm: guard .thumb_func use [nuttx]

2025-02-24 Thread via GitHub
pkarashchenko commented on code in PR #15897: URL: https://github.com/apache/nuttx/pull/15897#discussion_r1968204754 ## arch/arm/src/common/gnu/arm_signal_handler.S: ## @@ -70,7 +70,7 @@ .text #ifdef __ghs__ .thumb -#else +#elif defined(CONFIG_ARM_THUMB) Review

Re: [I] [DRUNX] Distributed Runtime and bUild for NuttX Test Environment [nuttx]

2025-02-24 Thread via GitHub
tmedicci commented on issue #15730: URL: https://github.com/apache/nuttx/issues/15730#issuecomment-2679324130 > > [@tmedicci](https://github.com/tmedicci): Just some additional thoughts about our CI organization. Although it's recommended to keep the distributed build farm, we should avoid

Re: [I] [DRUNX] Distributed Runtime and bUild for NuttX Test Environment [nuttx]

2025-02-24 Thread via GitHub
cederom commented on issue #15730: URL: https://github.com/apache/nuttx/issues/15730#issuecomment-2679150134 > @tmedicci: Just some additional thoughts about our CI organization. Although it's recommended to keep the distributed build farm, we should avoid as many as possible bad commits fr

[PR] esp32,esp32s3: use mcuboot for qemu_openeth [nuttx]

2025-02-24 Thread via GitHub
casaroli opened a new pull request, #15902: URL: https://github.com/apache/nuttx/pull/15902 ## Summary Update the `esp32-devkitc:qemu_openeth` and `esp32s3-devkit:qemu_openeth` configs to use MCUboot. Now, espressif qemu supports MCUboot, so we can switch the app format. ## Im

Re: [PR] getsockopt: move the options check to the upper layer [nuttx]

2025-02-24 Thread via GitHub
hartmannathan commented on code in PR #15899: URL: https://github.com/apache/nuttx/pull/15899#discussion_r1968514659 ## net/socket/getsockopt.c: ## @@ -271,6 +264,13 @@ int psock_getsockopt(FAR struct socket *psock, int level, int option, { int ret = -ENOPROTOOPT; + /* V

[PR] syslog/rpmsg_server: fix build break if enable SYSLOG_RPMSG/SYSLOG_RPMSG_SERVER [nuttx]

2025-02-24 Thread via GitHub
anchao opened a new pull request, #15903: URL: https://github.com/apache/nuttx/pull/15903 ## Summary syslog/rpmsg_server: fix build break if enable SYSLOG_RPMSG/SYSLOG_RPMSG_SERVER syslog/syslog_rpmsg_server.c:66:13: error: conflicting types for 'syslog_rpmsg_write';

Re: [PR] syslog/rpmsg_server: fix build break if enable SYSLOG_RPMSG/SYSLOG_RPMSG_SERVER [nuttx]

2025-02-24 Thread via GitHub
nuttxpr commented on PR #15903: URL: https://github.com/apache/nuttx/pull/15903#issuecomment-2680301390 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR appears to **mostly** meet the NuttX requiremen

Re: [PR] arch/arm: guard .thumb_func use [nuttx]

2025-02-24 Thread via GitHub
xiaoxiang781216 commented on code in PR #15897: URL: https://github.com/apache/nuttx/pull/15897#discussion_r1968652629 ## arch/arm/src/common/gnu/arm_signal_handler.S: ## @@ -70,7 +70,7 @@ .text #ifdef __ghs__ .thumb -#else +#elif defined(CONFIG_ARM_THUMB) Revi

Re: [PR] arch: cxd56xx: Fix i2c bus freeze at i2c initialization [nuttx]

2025-02-24 Thread via GitHub
SPRESENSE commented on PR #15870: URL: https://github.com/apache/nuttx/pull/15870#issuecomment-2680124206 > Please remember to sign-off the 2 commits: git commit -s. Thanks :-) done -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] arch: cxd56xx: Update delay value for subcore [nuttx]

2025-02-24 Thread via GitHub
SPRESENSE commented on PR #15884: URL: https://github.com/apache/nuttx/pull/15884#issuecomment-2680124595 > @SPRESENSE please use git commit -s to sign the commit done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] arch/arm: guard .thumb_func use [nuttx]

2025-02-24 Thread via GitHub
yf13 commented on PR #15897: URL: https://github.com/apache/nuttx/pull/15897#issuecomment-2680241160 @xiaoxiang781216 thanks for info about GHS, it has been guarded in the latest update already. -- This is an automated message from the Apache Git Service. To respond to the message, please

(nuttx-website) branch asf-site updated: Publishing web: 405a7126bab3fbbeef1bb95fabd1561c86029fc1 docs: 70f070fa1c271c466a1c0eabc6dcbe56498118ef

2025-02-24 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new d0be41f89 Publishing web: 405a712

Re: [PR] arch/arm: guard .thumb_func use [nuttx]

2025-02-24 Thread via GitHub
yf13 commented on PR #15897: URL: https://github.com/apache/nuttx/pull/15897#issuecomment-2680061365 > So greehills compiler will use thumb unconditionally? @pkarashchenko, thanks for the comments! I thought this is only for GNU as it is under `gnu/` folder, but after seeing your note

Re: [PR] net/socket/getsockopt: move the options check to the upper layer [nuttx]

2025-02-24 Thread via GitHub
zhhyu7 commented on code in PR #15899: URL: https://github.com/apache/nuttx/pull/15899#discussion_r1968689655 ## net/socket/getsockopt.c: ## @@ -271,6 +264,13 @@ int psock_getsockopt(FAR struct socket *psock, int level, int option, { int ret = -ENOPROTOOPT; + /* Verify t

Re: [PR] net/socket/getsockopt: move the options check to the upper layer [nuttx]

2025-02-24 Thread via GitHub
zhhyu7 commented on PR #15899: URL: https://github.com/apache/nuttx/pull/15899#issuecomment-2680155869 > please update the title to net/socket/getsockopt: move the options check to the upper layer done. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] system/debugpoint: fix bug the length option is parsed error [nuttx-apps]

2025-02-24 Thread via GitHub
chirping78 commented on PR #3007: URL: https://github.com/apache/nuttx-apps/pull/3007#issuecomment-2680188281 > please add a commit message Updated the commit message. @jerpelea -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] arch/esp32_spi: Add check to see if the TX_FIFO is empty [nuttx]

2025-02-24 Thread via GitHub
nuttxpr commented on PR #15904: URL: https://github.com/apache/nuttx/pull/15904#issuecomment-2680329314 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

Re: [PR] lcd/st7789: fix incorrect buffer count for 3 wire RAM write [nuttx]

2025-02-24 Thread via GitHub
raiden00pl merged PR #15873: URL: https://github.com/apache/nuttx/pull/15873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

(nuttx) branch master updated: lcd/st7789: fix incorrect buffer count for 3 wire RAM write

2025-02-24 Thread raiden00
This is an automated email from the ASF dual-hosted git repository. raiden00 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 425ddc7f72 lcd/st7789: fix incorrect buffer cou

[PR] xtensa/esp32: write encrypt func implementation [nuttx]

2025-02-24 Thread via GitHub
sdc-g opened a new pull request, #15896: URL: https://github.com/apache/nuttx/pull/15896 ## Summary based on spec, 16 bytes alignment is checked. ## Impact both block write and byte write are supported now, but 16 bytes alignment is required. ## Testing tes

Re: [PR] netutils/pppd/ppp.h: Fix build issue when network debug is enabled [nuttx-apps]

2025-02-24 Thread via GitHub
jerpelea merged PR #3006: URL: https://github.com/apache/nuttx-apps/pull/3006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.

Re: [PR] xtensa/esp32: write encrypt func implementation [nuttx]

2025-02-24 Thread via GitHub
nuttxpr commented on PR #15896: URL: https://github.com/apache/nuttx/pull/15896#issuecomment-2677826508 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not fully meet the NuttX r

(nuttx-apps) branch master updated: netutils/pppd/ppp.h: Fix build issue when network debug is enabled

2025-02-24 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 2eb18712d netutils/pppd/ppp.h: Fix build i

Re: [PR] boards/arm/rp2040/common: Add weak_function to SPI common logic [nuttx]

2025-02-24 Thread via GitHub
keever50 commented on PR #15894: URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2677870987 Okay! Signed and added a message -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] boards/arm/rp2040/common: Add weak_function to SPI common logic [nuttx]

2025-02-24 Thread via GitHub
keever50 commented on PR #15894: URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2677874634 I realized i copied the entire PR message and should have been only summery i believe. Hope this isnt a big issue. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] boards/arm/rp2040/common: Add weak_function to SPI common logic [nuttx]

2025-02-24 Thread via GitHub
lupyuen commented on PR #15894: URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2677878629 Sorry could you run `git commit -s` to sign off? Thanks :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] boards/arm/rp2040/common: Add weak_function to SPI common logic [nuttx]

2025-02-24 Thread via GitHub
keever50 commented on PR #15894: URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2677883271 Signed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] boards/arm/rp2040/common: Add weak_function to SPI common logic [nuttx]

2025-02-24 Thread via GitHub
lupyuen commented on PR #15894: URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2677899773 Hmmm I don't see the "Signed-off-by". Could you do `git push`? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] boards/arm/rp2040/common: Add weak_function to SPI common logic [nuttx]

2025-02-24 Thread via GitHub
keever50 commented on PR #15894: URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2677900199 @lupyuen By just running commit -s i get "nothing to commit, working tree clean". I ran git commit --amend --no-edit -S which should in theory add a sign? -- This is an automated messa

[PR] system/debugpoint: fix bug the length option is parsed error [nuttx-apps]

2025-02-24 Thread via GitHub
chirping78 opened a new pull request, #3007: URL: https://github.com/apache/nuttx-apps/pull/3007 ## Summary The `debugpoint` program has a option `-l` which requires an number argument, which means the `optstring` to `int getopt(int argc, char * const argv[], const char *o

Re: [PR] boards/arm/rp2040/common: Add weak_function to SPI common logic [nuttx]

2025-02-24 Thread via GitHub
keever50 commented on PR #15894: URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2677906247 ahhh i see signed off now! However now i have issues pushing it because it does not let me enter my password anymore. Ill get back to this soon -- This is an automated message from

Re: [PR] boards/arm/rp2040/common: Add weak_function to SPI common logic [nuttx]

2025-02-24 Thread via GitHub
keever50 commented on PR #15894: URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2677909757 oh okay do the same thing twice and it works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] boards/arm/rp2040/common: Add weak_function to SPI common logic [nuttx]

2025-02-24 Thread via GitHub
lupyuen commented on PR #15894: URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2677910306 Looks great, thanks! :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Initial standalone sx126x driver [WIP] [nuttx]

2025-02-24 Thread via GitHub
keever50 commented on PR #15795: URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2677939104 Signed and changed message. Also includes [experimental] as tag. It is review ready. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[PR] [nxstyle] fix Relative file path [nuttx-apps]

2025-02-24 Thread via GitHub
simbit18 opened a new pull request, #3008: URL: https://github.com/apache/nuttx-apps/pull/3008 ## Summary fix Relative file path does not match actual file. EOL Conversion -> Unix (LF) Adding the message header to the Kconfig file ## Impact Impact on user: NO

Re: [I] [FEATURE] Should we extend fastboot oem to support executing custom commands? [nuttx-apps]

2025-02-24 Thread via GitHub
JianyuWang0623 commented on issue #2991: URL: https://github.com/apache/nuttx-apps/issues/2991#issuecomment-2678170040 @cederom Could you review this pull request (https://github.com/apache/nuttx-apps/pull/3003) please? -- This is an automated message from the Apache Git Service. To resp

[PR] [Kconfig style] Fix Kconfig style [nuttx-apps]

2025-02-24 Thread via GitHub
simbit18 opened a new pull request, #3009: URL: https://github.com/apache/nuttx-apps/pull/3009 ## Summary Remove spaces from Kconfig files Add TABs Replace help => ---help--- Remove extra TABs ## Impact Impact on user: NO Impact on build: NO Impact on hardw

Re: [PR] xtensa/esp32: write encrypt func implementation [nuttx]

2025-02-24 Thread via GitHub
fdcavalcanti commented on PR #15896: URL: https://github.com/apache/nuttx/pull/15896#issuecomment-2678167609 Hello @sdc-g, can you post here test output? Also improve the PR description as suggested by PR bot -- This is an automated message from the Apache Git Service. To respond to th

[PR] arch/arm: guard .thumb_func use [nuttx]

2025-02-24 Thread via GitHub
yf13 opened a new pull request, #15897: URL: https://github.com/apache/nuttx/pull/15897 # Summary This guards use of thumb_func with ARM_THUMB so that PROTECTED build can work in non-THUMB mode. # Impacts arm 32 bit devices w/o ARM_THUMB can do signal handling in PROTECT

Re: [PR] [Kconfig style] Fix Kconfig style [nuttx-apps]

2025-02-24 Thread via GitHub
nuttxpr commented on PR #3009: URL: https://github.com/apache/nuttx-apps/pull/3009#issuecomment-2678193264 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the basic NuttX require

Re: [PR] riscv/esp32c6: Fix issue related esp32c6 usbserial driver. [nuttx]

2025-02-24 Thread via GitHub
FelipeMdeO commented on PR #15895: URL: https://github.com/apache/nuttx/pull/15895#issuecomment-2678206299 > please split the commit message to 80 characters Hello @jerpelea. Can you explain to me better about this rule. I use rule below: `Block Comments The final asterisk (*) shou

Re: [PR] Add esp_spiram_writeback_range support [nuttx]

2025-02-24 Thread via GitHub
tmedicci commented on PR #15849: URL: https://github.com/apache/nuttx/pull/15849#issuecomment-2678210474 @xiaoxiang781216 @jerpelea @acassis @hartmannathan @anchao @yamt , can you please help reviewing? -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] riscv/esp32c6: Fix issue related esp32c6 usbserial driver. [nuttx]

2025-02-24 Thread via GitHub
jerpelea commented on PR #15895: URL: https://github.com/apache/nuttx/pull/15895#issuecomment-2678216342 > > please split the commit message to 80 characters > > Hello @jerpelea. Can you explain to me better about this rule. I use rule below: `Block Comments The final asterisk (*) sho

[PR] esp32s3-devkit/fastboot: Enable fastboot oem shell [nuttx]

2025-02-24 Thread via GitHub
JianyuWang0623 opened a new pull request, #15898: URL: https://github.com/apache/nuttx/pull/15898 ## Summary Link: https://github.com/apache/nuttx-apps/pull/3003 1. Documentation/fastboot: Add usage for fastboot oem shell 2. Enable fastboot oem shell for board "esp32s3-devkit/fastboo

Re: [I] [DRUNX] Distributed Runtime and bUild for NuttX Test Environment [nuttx]

2025-02-24 Thread via GitHub
tmedicci commented on issue #15730: URL: https://github.com/apache/nuttx/issues/15730#issuecomment-2678257844 > [@tmedicci](https://github.com/tmedicci) Interesting idea! So someone needs to maintain the Initial Defconfig? (The one that builds before all others) I could do it for RISC-V. Bu

Re: [PR] riscv/esp32c6: Fix issue related esp32c6 usbserial driver. [nuttx]

2025-02-24 Thread via GitHub
FelipeMdeO commented on PR #15895: URL: https://github.com/apache/nuttx/pull/15895#issuecomment-2678283249 Hello @jerpelea . Commit https://github.com/apache/nuttx/commit/d6074ae67ca43e94b265aba86489ec204028dc3c was overwrited by a force push. This issue was solved. ![image](https://git

Re: [PR] riscv/esp32c6: Fix issue related esp32c6 usbserial driver. [nuttx]

2025-02-24 Thread via GitHub
jerpelea commented on PR #15895: URL: https://github.com/apache/nuttx/pull/15895#issuecomment-2678288778 I think that you mat forgot to forcepush since on github the commit is not updated ![image](https://github.com/user-attachments/assets/ff330df0-af7f-41a4-ba16-f398ed891d11) --

Re: [PR] getsockopt: move the options check to the upper layer [nuttx]

2025-02-24 Thread via GitHub
nuttxpr commented on PR #15899: URL: https://github.com/apache/nuttx/pull/15899#issuecomment-2678304063 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.

[PR] getsockopt: move the options check to the upper layer [nuttx]

2025-02-24 Thread via GitHub
zhhyu7 opened a new pull request, #15899: URL: https://github.com/apache/nuttx/pull/15899 ## Summary check parameters at the top level to avoid errors when assigning values in si_getsockopt. ## Impact N/A ## Testing qemu:local -- This is an automated

Re: [PR] Initial standalone sx126x driver [WIP] [nuttx]

2025-02-24 Thread via GitHub
xiaoxiang781216 commented on PR #15795: URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2678321236 > #15828 here is another PR with LORA chip support. Shared ioctl will be beneficial for this driver as well I suggest to follow the suggestion from @raiden00pl before mergin

Re: [PR] riscv/esp32c6: Fix issue related esp32c6 usbserial driver. [nuttx]

2025-02-24 Thread via GitHub
FelipeMdeO commented on PR #15895: URL: https://github.com/apache/nuttx/pull/15895#issuecomment-2678324608 Sorry @jerpelea, You asked for commit message. I was think in code comments. :disappointed_relieved: -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] Initial standalone sx126x driver [WIP] [nuttx]

2025-02-24 Thread via GitHub
keever50 commented on PR #15795: URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2678335275 @xiaoxiang781216 Yes thats the idea, however it could help to have this one pushed as experimental driver. So i can push a board and app which can be used for testing. Currently my bo

Re: [PR] Initial standalone sx126x driver [WIP] [nuttx]

2025-02-24 Thread via GitHub
keever50 commented on PR #15795: URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2678338495 The common API is discussed here https://github.com/apache/nuttx/issues/15856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] boards/esp32s3: move QEMU toywasm to different defconfig [nuttx]

2025-02-24 Thread via GitHub
fdcavalcanti commented on PR #15874: URL: https://github.com/apache/nuttx/pull/15874#issuecomment-2678416274 > please add a commit message Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [I] [FEATURE] Should we extend fastboot oem to support executing custom commands? [nuttx-apps]

2025-02-24 Thread via GitHub
cederom commented on issue #2991: URL: https://github.com/apache/nuttx-apps/issues/2991#issuecomment-2678416575 > @JianyuWang0623 [@cederom](https://github.com/cederom) Could you review this pull request ([#3003](https://github.com/apache/nuttx-apps/pull/3003)) please? done :-) than

Re: [PR] Initial standalone sx126x driver [WIP] [nuttx]

2025-02-24 Thread via GitHub
acassis commented on PR #15795: URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2678432589 @keever50 please create also the Documentation/ and include the screenshots about the SDR and NSH to let people get more information before using it. -- This is an automated message fro

(nuttx) 02/02: esp32[s2|s3|c3|c6|h2]: Update common layer Update common layer to prevent build errors

2025-02-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 713c10717c5ccc9399214e884485ba57d81cb76f Author: Eren Terzioglu AuthorDate: Wed Jan 15 17:18:55 2025 +0100 esp32[s2

(nuttx) 01/02: esp32[s2|s3]: Enhance SPIRAM/PSRAM support Add esp_spiram_writeback_range function to flush some areas of spiram cache

2025-02-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 5865d2a8ff5bda14497ac65571c2f9d0bccb4964 Author: Eren Terzioglu AuthorDate: Mon Jan 13 10:52:17 2025 +0100 esp32[s2

Re: [I] [DRUNX] Distributed Runtime and bUild for NuttX Test Environment [nuttx]

2025-02-24 Thread via GitHub
tmedicci commented on issue #15730: URL: https://github.com/apache/nuttx/issues/15730#issuecomment-2678439892 What do you mean by _generic configurations_? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] getsockopt: move the options check to the upper layer [nuttx]

2025-02-24 Thread via GitHub
zhhyu7 commented on code in PR #15899: URL: https://github.com/apache/nuttx/pull/15899#discussion_r1967664535 ## net/socket/getsockopt.c: ## @@ -271,6 +264,13 @@ int psock_getsockopt(FAR struct socket *psock, int level, int option, { int ret = -ENOPROTOOPT; + /* Verify t

Re: [PR] getsockopt: move the options check to the upper layer [nuttx]

2025-02-24 Thread via GitHub
anchao commented on code in PR #15899: URL: https://github.com/apache/nuttx/pull/15899#discussion_r1967657637 ## net/socket/getsockopt.c: ## @@ -271,6 +264,13 @@ int psock_getsockopt(FAR struct socket *psock, int level, int option, { int ret = -ENOPROTOOPT; + /* Verify t

Re: [I] [DRUNX] Distributed Runtime and bUild for NuttX Test Environment [nuttx]

2025-02-24 Thread via GitHub
cederom commented on issue #15730: URL: https://github.com/apache/nuttx/issues/15730#issuecomment-2678461840 The ones that already exist. It may take more time to build separate configurations, but there will be no additional burden and compatibility problems. Anyways, this idea is nice, bu

(nuttx) branch master updated (425ddc7f72 -> 713c10717c)

2025-02-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 425ddc7f72 lcd/st7789: fix incorrect buffer count for 3 wire RAM write new 5865d2a8ff esp32[s2|s3]: Enhance SPIRA

Re: [PR] Add esp_spiram_writeback_range support [nuttx]

2025-02-24 Thread via GitHub
acassis merged PR #15849: URL: https://github.com/apache/nuttx/pull/15849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

(nuttx) branch master updated: riscv/esp32c6: Fix issue related esp32c6 usbserial driver.

2025-02-24 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 70f070fa1c riscv/esp32c6: Fix issue related esp

Re: [PR] riscv/esp32c6: Fix issue related esp32c6 usbserial driver. [nuttx]

2025-02-24 Thread via GitHub
jerpelea merged PR #15895: URL: https://github.com/apache/nuttx/pull/15895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apa

Re: [PR] Initial standalone sx126x driver [WIP] [nuttx]

2025-02-24 Thread via GitHub
keever50 commented on PR #15795: URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2678566430 @acassis I can do that. Is it a good idea if i create a directory called /wireless/lpwan under /documentation/components/drivers/character/ ? I am not very familiar with this docume

Re: [PR] Initial standalone sx126x driver [WIP] [nuttx]

2025-02-24 Thread via GitHub
acassis commented on PR #15795: URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2678592279 > @acassis I can do that. Is it a good idea if i create a directory called /wireless/lpwan under /documentation/components/drivers/character/ ? I am not very familiar with this documentat

Re: [PR] system/fastboot: Add support for fastboot oem shell [nuttx-apps]

2025-02-24 Thread via GitHub
JianyuWang0623 commented on PR #3003: URL: https://github.com/apache/nuttx-apps/pull/3003#issuecomment-2678718417 > please add commit message [fb4c03f](https://github.com/apache/nuttx-apps/commit/fb4c03f4135dde4e6bc6c90e55ceba0ebb28f373) @jerpelea done, thank you. ```diff +Add s

[PR] samv7/spi: fix ifdelay setup in spi_setdelay call [nuttx]

2025-02-24 Thread via GitHub
michallenc opened a new pull request, #15900: URL: https://github.com/apache/nuttx/pull/15900 ## Summary `ifdelay` description (delay between frames) matches the DLYBCT field (delay between consecutive transfers without removing chip select) much better compared to `stopdelay` (delay bet

Re: [PR] samv7/spi: fix ifdelay setup in spi_setdelay call [nuttx]

2025-02-24 Thread via GitHub
michallenc commented on PR #15900: URL: https://github.com/apache/nuttx/pull/15900#issuecomment-2678857577 @pkarashchenko Could you take a look? I think this makes much more sense, but I hope it won't break the behavior for someone using SPI... it shouldn't though, this call is not used tha

[PR] arch/arm64: fix boot stage prints with CONFIG_ARCH_EARLY_PRINT=y [nuttx]

2025-02-24 Thread via GitHub
gpoulios opened a new pull request, #15901: URL: https://github.com/apache/nuttx/pull/15901 ## Summary `boot_stage_puts` used by early assembly head, calls `arm64_lowputc()` for each character of the string to be printed in a loop. During that loop it uses `x1` as the pointer to the

Re: [I] [DRUNX] Distributed Runtime and bUild for NuttX Test Environment [nuttx]

2025-02-24 Thread via GitHub
tmedicci commented on issue #15730: URL: https://github.com/apache/nuttx/issues/15730#issuecomment-2679052278 > The ones that already exist. It may take more time to build separate configurations, but there will be no additional burden and compatibility problems. Anyways, this idea is nice,

Re: [I] [DRUNX] Distributed Runtime and bUild for NuttX Test Environment [nuttx]

2025-02-24 Thread via GitHub
cederom commented on issue #15730: URL: https://github.com/apache/nuttx/issues/15730#issuecomment-2679081582 Sounds good, can you present a working prototype @tmedicci ? :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] [DRUNX] Distributed Runtime and bUild for NuttX Test Environment [nuttx]

2025-02-24 Thread via GitHub
tmedicci commented on issue #15730: URL: https://github.com/apache/nuttx/issues/15730#issuecomment-2679095609 Just some additional thoughts about our CI organization. Although it's recommended to keep the distributed build farm, we should avoid as many as possible bad commits from being mer

Re: [I] [DRUNX] Distributed Runtime and bUild for NuttX Test Environment [nuttx]

2025-02-24 Thread via GitHub
tmedicci commented on issue #15730: URL: https://github.com/apache/nuttx/issues/15730#issuecomment-2679131200 > Sounds good, can you present a working prototype [@tmedicci](https://github.com/tmedicci) ? :-) Yes, I think so. It'd take a while to get used to GH workflows but I'll work

Re: [I] [DRUNX] Distributed Runtime and bUild for NuttX Test Environment [nuttx]

2025-02-24 Thread via GitHub
tmedicci commented on issue #15730: URL: https://github.com/apache/nuttx/issues/15730#issuecomment-2679169620 > Btw what tool do you use to make that nice charts [@tmedicci](https://github.com/tmedicci) ? :-) I used [draw.io](https://draw.io) ;) -- This is an automated message from