xiaoxiang781216 commented on code in PR #15897:
URL: https://github.com/apache/nuttx/pull/15897#discussion_r1968652629
##########
arch/arm/src/common/gnu/arm_signal_handler.S:
##########
@@ -70,7 +70,7 @@
.text
#ifdef __ghs__
.thumb
-#else
+#elif defined(CONFIG_ARM_THUMB)
Review Comment:
no, should guard __ghs__ by CONFIG_ARM_THUMB too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
