[GitHub] [nuttx-apps] anchao opened a new pull request, #1678: netutils/iperf: guaranteed precision before division

2023-03-22 Thread via GitHub
anchao opened a new pull request, #1678: URL: https://github.com/apache/nuttx-apps/pull/1678 ## Summary netutils/iperf: guaranteed precision before division Iperf test on photon/wlan Before: ` 0.00- 1.08 sec 65536 Bytes0.00 Mbits/sec` After: ` 0.00-

[GitHub] [nuttx-apps] pussuw commented on a diff in pull request #1654: nsh/alias: Add shell alias support for NSH

2023-03-22 Thread via GitHub
pussuw commented on code in PR #1654: URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1144326109 ## nshlib/nsh_console.h: ## @@ -153,6 +155,15 @@ struct console_stdio_s size_t varsz; #endif +#ifdef CONFIG_NSH_ALIAS Review Comment: Thanks for the explana

[GitHub] [nuttx-apps] pussuw commented on a diff in pull request #1654: nsh/alias: Add shell alias support for NSH

2023-03-22 Thread via GitHub
pussuw commented on code in PR #1654: URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1144349219 ## nshlib/nsh_parse.c: ## @@ -115,6 +129,14 @@ struct nsh_memlist_s }; #endif +#ifdef CONFIG_NSH_ALIAS +struct nsh_alist_s +{ + int nallocs; + FAR struct nsh_al

[GitHub] [nuttx-apps] pussuw commented on a diff in pull request #1654: nsh/alias: Add shell alias support for NSH

2023-03-22 Thread via GitHub
pussuw commented on code in PR #1654: URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1144349219 ## nshlib/nsh_parse.c: ## @@ -115,6 +129,14 @@ struct nsh_memlist_s }; #endif +#ifdef CONFIG_NSH_ALIAS +struct nsh_alist_s +{ + int nallocs; + FAR struct nsh_al

[GitHub] [nuttx] jturnsek commented on a diff in pull request #8788: imxrt_flexpwm independent output B support added

2023-03-22 Thread via GitHub
jturnsek commented on code in PR #8788: URL: https://github.com/apache/nuttx/pull/8788#discussion_r1144415600 ## arch/arm/src/imxrt/imxrt_flexpwm.c: ## @@ -873,21 +905,38 @@ static int pwm_set_output(struct pwm_lowerhalf_s *dev, uint8_t channel, regval |= MCTRL_CLDOK(1 << sh

[GitHub] [nuttx-apps] pussuw commented on a diff in pull request #1654: nsh/alias: Add shell alias support for NSH

2023-03-22 Thread via GitHub
pussuw commented on code in PR #1654: URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1143779202 ## nshlib/nsh.h: ## @@ -715,6 +715,25 @@ struct nsh_parser_s #endif }; +#ifdef CONFIG_NSH_ALIAS +struct nsh_alias_s +{ + FAR struct nsh_alias_s *next;/* Sing

[GitHub] [nuttx-apps] pussuw commented on a diff in pull request #1654: nsh/alias: Add shell alias support for NSH

2023-03-22 Thread via GitHub
pussuw commented on code in PR #1654: URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1143779202 ## nshlib/nsh.h: ## @@ -715,6 +715,25 @@ struct nsh_parser_s #endif }; +#ifdef CONFIG_NSH_ALIAS +struct nsh_alias_s +{ + FAR struct nsh_alias_s *next;/* Sing

[GitHub] [nuttx-apps] pussuw commented on pull request #1654: nsh/alias: Add shell alias support for NSH

2023-03-22 Thread via GitHub
pussuw commented on PR #1654: URL: https://github.com/apache/nuttx-apps/pull/1654#issuecomment-1479189911 There is a massive error here still. I just realized only the *command* is ever expanded, the argument list is not subject to alias expansion. Need to fix this also. -- This is an au

[GitHub] [nuttx] CV-Bowen opened a new pull request, #8871: fs/fs_epoll: add oneshot list to handle the EPOLLONESHOT correctly

2023-03-22 Thread via GitHub
CV-Bowen opened a new pull request, #8871: URL: https://github.com/apache/nuttx/pull/8871 ## Summary https://github.com/apache/nuttx-apps/pull/1625 mentioned that nng can't work with epoll. After analysis, the epoll do not handle the EPOLLONESHOT events correctly, the epoll node with

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8868: fs/hostfs: add sim hostfs path convert

2023-03-22 Thread via GitHub
xiaoxiang781216 commented on PR #8868: URL: https://github.com/apache/nuttx/pull/8868#issuecomment-1479228963 > > In the sim, hostfs uses $CWD as the root path. When running in different paths, the access path of hostfs is different. > > what's wrong with it? > Here is an e

[GitHub] [nuttx-apps] CV-Bowen commented on pull request #1625: Initial load for nng library

2023-03-22 Thread via GitHub
CV-Bowen commented on PR #1625: URL: https://github.com/apache/nuttx-apps/pull/1625#issuecomment-1479230715 @jturnsek Sorry to response too late, I'm busy with other work recently. And now I find the bug in epoll and fix it in https://github.com/apache/nuttx/pull/8871, the pubsub example wo

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1654: nsh/alias: Add shell alias support for NSH

2023-03-22 Thread via GitHub
xiaoxiang781216 commented on code in PR #1654: URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1144531747 ## nshlib/nsh_parse.c: ## @@ -115,6 +129,14 @@ struct nsh_memlist_s }; #endif +#ifdef CONFIG_NSH_ALIAS +struct nsh_alist_s +{ + int nallocs; + FAR stru

[GitHub] [nuttx] yamt commented on pull request #8868: fs/hostfs: add sim hostfs path convert

2023-03-22 Thread via GitHub
yamt commented on PR #8868: URL: https://github.com/apache/nuttx/pull/8868#issuecomment-1479289100 > > > In the sim, hostfs uses $CWD as the root path. When running in different paths, the access path of hostfs is different. > > > > > > what's wrong with it? > > @yamt Here

[nuttx-apps] branch master updated: ostest: Introduce basic work queue test

2023-03-22 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 412505d28 ostest: Introduce basic wor

[GitHub] [nuttx-apps] pkarashchenko merged pull request #1665: ostest: Introduce basic work queue test

2023-03-22 Thread via GitHub
pkarashchenko merged PR #1665: URL: https://github.com/apache/nuttx-apps/pull/1665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@n

[GitHub] [nuttx-apps] pussuw commented on a diff in pull request #1654: nsh/alias: Add shell alias support for NSH

2023-03-22 Thread via GitHub
pussuw commented on code in PR #1654: URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1144621202 ## nshlib/nsh_parse.c: ## @@ -115,6 +129,14 @@ struct nsh_memlist_s }; #endif +#ifdef CONFIG_NSH_ALIAS +struct nsh_alist_s +{ + int nallocs; + FAR struct nsh_al

[GitHub] [nuttx-apps] pussuw commented on a diff in pull request #1654: nsh/alias: Add shell alias support for NSH

2023-03-22 Thread via GitHub
pussuw commented on code in PR #1654: URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1144621202 ## nshlib/nsh_parse.c: ## @@ -115,6 +129,14 @@ struct nsh_memlist_s }; #endif +#ifdef CONFIG_NSH_ALIAS +struct nsh_alist_s +{ + int nallocs; + FAR struct nsh_al

[GitHub] [nuttx-apps] pussuw commented on a diff in pull request #1654: nsh/alias: Add shell alias support for NSH

2023-03-22 Thread via GitHub
pussuw commented on code in PR #1654: URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1144621202 ## nshlib/nsh_parse.c: ## @@ -115,6 +129,14 @@ struct nsh_memlist_s }; #endif +#ifdef CONFIG_NSH_ALIAS +struct nsh_alist_s +{ + int nallocs; + FAR struct nsh_al

[GitHub] [nuttx-apps] pussuw commented on a diff in pull request #1654: nsh/alias: Add shell alias support for NSH

2023-03-22 Thread via GitHub
pussuw commented on code in PR #1654: URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1144621202 ## nshlib/nsh_parse.c: ## @@ -115,6 +129,14 @@ struct nsh_memlist_s }; #endif +#ifdef CONFIG_NSH_ALIAS +struct nsh_alist_s +{ + int nallocs; + FAR struct nsh_al

[GitHub] [nuttx] donghengqaz commented on a diff in pull request #8783: xtensa/esp32: Tasks use PSRAM as stack can do SPI flash read/write/erase/map/unmap

2023-03-22 Thread via GitHub
donghengqaz commented on code in PR #8783: URL: https://github.com/apache/nuttx/pull/8783#discussion_r1144643932 ## arch/xtensa/src/esp32/esp32_spiflash.c: ## @@ -170,6 +183,27 @@ struct spiflash_cachestate_s uint32_t val[CONFIG_SMP_NCPUS]; }; +#ifdef CONFIG_ESP32_SPI_FLAS

[GitHub] [nuttx] TimJTi commented on a diff in pull request #8789: Add Broadcom APDS9922 ambient light and proximity sensor

2023-03-22 Thread via GitHub
TimJTi commented on code in PR #8789: URL: https://github.com/apache/nuttx/pull/8789#discussion_r1144656078 ## include/nuttx/sensors/apds9922.h: ## @@ -0,0 +1,279 @@ +/ + * include/nuttx/sensors/apds9922

[GitHub] [nuttx] TimJTi commented on a diff in pull request #8789: Add Broadcom APDS9922 ambient light and proximity sensor

2023-03-22 Thread via GitHub
TimJTi commented on code in PR #8789: URL: https://github.com/apache/nuttx/pull/8789#discussion_r1144658074 ## drivers/sensors/apds9922.c: ## @@ -0,0 +1,2619 @@ +/ + * drivers/sensors/apds9922.c + * + *

[GitHub] [nuttx] standby24x7 opened a new pull request, #8872: Documentation: Fix some spelling typos in index.rst

2023-03-22 Thread via GitHub
standby24x7 opened a new pull request, #8872: URL: https://github.com/apache/nuttx/pull/8872 This patch fixes some spelling typos in index.rst. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [nuttx] TimJTi commented on a diff in pull request #8789: Add Broadcom APDS9922 ambient light and proximity sensor

2023-03-22 Thread via GitHub
TimJTi commented on code in PR #8789: URL: https://github.com/apache/nuttx/pull/8789#discussion_r1144660227 ## drivers/sensors/apds9922.c: ## @@ -0,0 +1,2619 @@ +/ + * drivers/sensors/apds9922.c + * + *

[GitHub] [nuttx] TimJTi commented on a diff in pull request #8789: Add Broadcom APDS9922 ambient light and proximity sensor

2023-03-22 Thread via GitHub
TimJTi commented on code in PR #8789: URL: https://github.com/apache/nuttx/pull/8789#discussion_r1144661054 ## drivers/sensors/apds9922.c: ## @@ -0,0 +1,2619 @@ +/ + * drivers/sensors/apds9922.c + * + *

[GitHub] [nuttx] TimJTi commented on a diff in pull request #8789: Add Broadcom APDS9922 ambient light and proximity sensor

2023-03-22 Thread via GitHub
TimJTi commented on code in PR #8789: URL: https://github.com/apache/nuttx/pull/8789#discussion_r1144661556 ## drivers/sensors/apds9922.c: ## @@ -0,0 +1,2619 @@ +/ + * drivers/sensors/apds9922.c + * + *

[GitHub] [nuttx] TimJTi commented on a diff in pull request #8789: Add Broadcom APDS9922 ambient light and proximity sensor

2023-03-22 Thread via GitHub
TimJTi commented on code in PR #8789: URL: https://github.com/apache/nuttx/pull/8789#discussion_r1144661881 ## drivers/sensors/apds9922.c: ## @@ -0,0 +1,2619 @@ +/ + * drivers/sensors/apds9922.c + * + *

[GitHub] [nuttx] TimJTi commented on a diff in pull request #8789: Add Broadcom APDS9922 ambient light and proximity sensor

2023-03-22 Thread via GitHub
TimJTi commented on code in PR #8789: URL: https://github.com/apache/nuttx/pull/8789#discussion_r1144662160 ## drivers/sensors/apds9922.c: ## @@ -0,0 +1,2619 @@ +/ + * drivers/sensors/apds9922.c + * + *

[GitHub] [nuttx] TimJTi commented on a diff in pull request #8789: Add Broadcom APDS9922 ambient light and proximity sensor

2023-03-22 Thread via GitHub
TimJTi commented on code in PR #8789: URL: https://github.com/apache/nuttx/pull/8789#discussion_r1144664020 ## drivers/sensors/apds9922.c: ## @@ -0,0 +1,2619 @@ +/ + * drivers/sensors/apds9922.c + * + *

[GitHub] [nuttx] zyfeier commented on pull request #8863: arch/arm: enable eoimode only select CONFIG_XXX_GIC_EOIMODE

2023-03-22 Thread via GitHub
zyfeier commented on PR #8863: URL: https://github.com/apache/nuttx/pull/8863#issuecomment-1479410864 > @zyfeier since ARMV7A_GIC_EOIMODE is a "bool" without text it is an invisible flag that needs to be enabled by some other config, but there is no other config selecting it. Should it be:

[GitHub] [nuttx] anchao opened a new pull request, #8873: stm32/photon: Use D0 Busy to detect Write Complete

2023-03-22 Thread via GitHub
anchao opened a new pull request, #8873: URL: https://github.com/apache/nuttx/pull/8873 ## Summary 1. stm32/photon: Use D0 Busy to detect Write Complete 1. Enable CONFIG_MMCSD_SDIOWAIT_WRCOMPLETE to use D0 Busy to detect Write Complete 2. Increase bcmf frame pool to 16 3.

[GitHub] [nuttx] anchao commented on issue #8839: Photon P0 WiFi not functional

2023-03-22 Thread via GitHub
anchao commented on issue #8839: URL: https://github.com/apache/nuttx/issues/8839#issuecomment-1479492277 >> Not sure what that sdio_rw error during boot up is related to... Hi @TheCranston , nice to get your reply, you are right, now stm32 sdio does not detect write completion, you c

[GitHub] [nuttx] TimJTi commented on a diff in pull request #8789: Add Broadcom APDS9922 ambient light and proximity sensor

2023-03-22 Thread via GitHub
TimJTi commented on code in PR #8789: URL: https://github.com/apache/nuttx/pull/8789#discussion_r1144808610 ## drivers/sensors/apds9922.c: ## @@ -0,0 +1,2619 @@ +/ + * drivers/sensors/apds9922.c + * + *

[GitHub] [nuttx] slorquet commented on a diff in pull request #8867: Optimize implementation of strsignal()

2023-03-22 Thread via GitHub
slorquet commented on code in PR #8867: URL: https://github.com/apache/nuttx/pull/8867#discussion_r1144809842 ## libs/libc/string/Kconfig: ## @@ -90,3 +90,29 @@ config MEMSET_64BIT efficiently. endmenu # memcpy/memset Options + +menu "signal Decode Support" +

[GitHub] [nuttx] patacongo commented on issue #8869: Should the number of signals in signal.h be increased?

2023-03-22 Thread via GitHub
patacongo commented on issue #8869: URL: https://github.com/apache/nuttx/issues/8869#issuecomment-1479571659 > **Another Must-Fix Bug**. I just did a quit glance through some of the code to see how real time signal numbers are being defined. They appear: ... Kconfig files that allow c

[GitHub] [nuttx] TheCranston commented on issue #8839: Photon P0 WiFi not functional

2023-03-22 Thread via GitHub
TheCranston commented on issue #8839: URL: https://github.com/apache/nuttx/issues/8839#issuecomment-1479589845 @anchao Thank you for the code changes. I've applied them locally and it appears to have helped ``` ABCDF [1.19] [ 2] sdio_io_rw_extended: error 1 telnetd [5:10

[GitHub] [nuttx] jturnsek commented on pull request #8871: fs/fs_epoll: add oneshot list to handle the EPOLLONESHOT correctly

2023-03-22 Thread via GitHub
jturnsek commented on PR #8871: URL: https://github.com/apache/nuttx/pull/8871#issuecomment-1479623135 @CV-Bowen It looks ok. NNG is rearming oneshot events, so this must be it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8868: fs/hostfs: add sim hostfs path convert

2023-03-22 Thread via GitHub
xiaoxiang781216 commented on PR #8868: URL: https://github.com/apache/nuttx/pull/8868#issuecomment-1479625519 > > ls /data will report the error. This patch ensures the user get the consistent result regardless he launches the program from anywhere. > > probably sometimes it's a g

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8789: Add Broadcom APDS9922 ambient light and proximity sensor

2023-03-22 Thread via GitHub
pkarashchenko commented on code in PR #8789: URL: https://github.com/apache/nuttx/pull/8789#discussion_r1144874702 ## drivers/sensors/apds9922.c: ## @@ -0,0 +1,2619 @@ +/ + * drivers/sensors/apds9922.c +

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8867: Optimize implementation of strsignal()

2023-03-22 Thread via GitHub
pkarashchenko commented on code in PR #8867: URL: https://github.com/apache/nuttx/pull/8867#discussion_r1144878582 ## libs/libc/string/Kconfig: ## @@ -90,3 +90,29 @@ config MEMSET_64BIT efficiently. endmenu # memcpy/memset Options + +menu "signal Decode Suppor

[GitHub] [nuttx] TimJTi commented on a diff in pull request #8789: Add Broadcom APDS9922 ambient light and proximity sensor

2023-03-22 Thread via GitHub
TimJTi commented on code in PR #8789: URL: https://github.com/apache/nuttx/pull/8789#discussion_r1144887635 ## drivers/sensors/apds9922.c: ## @@ -0,0 +1,2619 @@ +/ + * drivers/sensors/apds9922.c + * + *

[GitHub] [nuttx] anchao commented on issue #8839: Photon P0 WiFi not functional

2023-03-22 Thread via GitHub
anchao commented on issue #8839: URL: https://github.com/apache/nuttx/issues/8839#issuecomment-1479657026 @TheCranston >> That sdio_io_rw_extended error upon boot persists. >> [ 1.19] [ 2] sdio_io_rw_extended: error 1 This issue exists in nuttx-9.0, but it does not has a

[GitHub] [nuttx] TimJTi commented on a diff in pull request #8789: Add Broadcom APDS9922 ambient light and proximity sensor

2023-03-22 Thread via GitHub
TimJTi commented on code in PR #8789: URL: https://github.com/apache/nuttx/pull/8789#discussion_r1144887635 ## drivers/sensors/apds9922.c: ## @@ -0,0 +1,2619 @@ +/ + * drivers/sensors/apds9922.c + * + *

[GitHub] [nuttx] anchao opened a new pull request, #8874: libc/math: rename libc/math.csv to libm/libm.csv

2023-03-22 Thread via GitHub
anchao opened a new pull request, #8874: URL: https://github.com/apache/nuttx/pull/8874 ## Summary libc/math: rename libc/math.csv to libm/libm.csv follow https://github.com/apache/nuttx/pull/8584 ## Impact N/A ## Testing ci-check -- This is an aut

[GitHub] [nuttx-apps] acassis merged pull request #1678: netutils/iperf: guaranteed precision before division

2023-03-22 Thread via GitHub
acassis merged PR #1678: URL: https://github.com/apache/nuttx-apps/pull/1678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

[nuttx-apps] branch master updated (412505d28 -> b3cfcee47)

2023-03-22 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git from 412505d28 ostest: Introduce basic work queue test add b3cfcee47 netutils/iperf: guaranteed precision before

[GitHub] [nuttx-apps] acassis merged pull request #1673: system/cu: Let remote machine handle special character except Ctrl-C

2023-03-22 Thread via GitHub
acassis merged PR #1673: URL: https://github.com/apache/nuttx-apps/pull/1673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

[nuttx-apps] branch master updated (b3cfcee47 -> 4079f6d61)

2023-03-22 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git from b3cfcee47 netutils/iperf: guaranteed precision before division add 4079f6d61 system/cu: Let remote machine h

[GitHub] [nuttx] CV-Bowen commented on pull request #8871: fs/fs_epoll: add oneshot list to handle the EPOLLONESHOT correctly

2023-03-22 Thread via GitHub
CV-Bowen commented on PR #8871: URL: https://github.com/apache/nuttx/pull/8871#issuecomment-1479716355 > @CV-Bowen It looks ok. NNG is rearming oneshot events, so this must be it. @jturnsek Thanks, @acassis Do you have more concern? -- This is an automated message from the Apache Gi

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8867: Optimize implementation of strsignal()

2023-03-22 Thread via GitHub
xiaoxiang781216 commented on code in PR #8867: URL: https://github.com/apache/nuttx/pull/8867#discussion_r1144962798 ## libs/libc/string/lib_strsignal.c: ## @@ -22,53 +22,24 @@ * Included Files / +

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8867: Optimize implementation of strsignal()

2023-03-22 Thread via GitHub
xiaoxiang781216 commented on code in PR #8867: URL: https://github.com/apache/nuttx/pull/8867#discussion_r1144964480 ## libs/libc/string/lib_strsignal.c: ## @@ -96,80 +69,51 @@ FAR char *strsignal(int signum) switch (signum) { +#ifdef CONFIG_LIBC_STRSIGNAL Review Comm

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8867: Optimize implementation of strsignal()

2023-03-22 Thread via GitHub
xiaoxiang781216 commented on code in PR #8867: URL: https://github.com/apache/nuttx/pull/8867#discussion_r1144964885 ## libs/libc/string/lib_strsignal.c: ## @@ -96,80 +69,51 @@ FAR char *strsignal(int signum) switch (signum) { +#ifdef CONFIG_LIBC_STRSIGNAL /* St

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8867: Optimize implementation of strsignal()

2023-03-22 Thread via GitHub
xiaoxiang781216 commented on code in PR #8867: URL: https://github.com/apache/nuttx/pull/8867#discussion_r1144969071 ## sched/Kconfig: ## @@ -1647,6 +1647,13 @@ config SIG_POLL The SIGPOLL signal is sent to a process when an asynchronous I/O event

[GitHub] [nuttx] pkarashchenko commented on pull request #8645: mutex: move nxmutex to sched

2023-03-22 Thread via GitHub
pkarashchenko commented on PR #8645: URL: https://github.com/apache/nuttx/pull/8645#issuecomment-1479783853 I'm planning to start mailing list discussion till the end of this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [nuttx] TimJTi commented on a diff in pull request #8789: Add Broadcom APDS9922 ambient light and proximity sensor

2023-03-22 Thread via GitHub
TimJTi commented on code in PR #8789: URL: https://github.com/apache/nuttx/pull/8789#discussion_r1145012589 ## drivers/sensors/apds9922.c: ## @@ -0,0 +1,2619 @@ +/ + * drivers/sensors/apds9922.c + * + *

[GitHub] [nuttx] slorquet commented on a diff in pull request #8867: Optimize implementation of strsignal()

2023-03-22 Thread via GitHub
slorquet commented on code in PR #8867: URL: https://github.com/apache/nuttx/pull/8867#discussion_r1145078377 ## libs/libc/string/Kconfig: ## @@ -90,3 +90,29 @@ config MEMSET_64BIT efficiently. endmenu # memcpy/memset Options + +menu "signal Decode Support" +

[GitHub] [nuttx] TimJTi commented on a diff in pull request #8789: Add Broadcom APDS9922 ambient light and proximity sensor

2023-03-22 Thread via GitHub
TimJTi commented on code in PR #8789: URL: https://github.com/apache/nuttx/pull/8789#discussion_r1145094257 ## drivers/sensors/apds9922.c: ## @@ -0,0 +1,2587 @@ +/ + * drivers/sensors/apds9922.c + * + *

[GitHub] [nuttx] TimJTi commented on a diff in pull request #8789: Add Broadcom APDS9922 ambient light and proximity sensor

2023-03-22 Thread via GitHub
TimJTi commented on code in PR #8789: URL: https://github.com/apache/nuttx/pull/8789#discussion_r1145094813 ## include/nuttx/sensors/apds9922.h: ## @@ -0,0 +1,315 @@ +/ + * include/nuttx/sensors/apds9922

[GitHub] [nuttx] TheCranston commented on issue #8839: Photon P0 WiFi not functional

2023-03-22 Thread via GitHub
TheCranston commented on issue #8839: URL: https://github.com/apache/nuttx/issues/8839#issuecomment-1479884997 @anchao I'm out of my depth on this, but did some string searches on the particleIO device-os code base looking for something similar to the file you referenced. I figure they hav

[GitHub] [nuttx] michallenc commented on issue #8858: Issues with adjtime implementation / Build failure.

2023-03-22 Thread via GitHub
michallenc commented on issue #8858: URL: https://github.com/apache/nuttx/issues/8858#issuecomment-1479908280 Thank you Greg @patacongo for detailed issue description. I agree clock rate adjustment would be better solution and would solve possible problems with time jumps. This is also how

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8871: fs/fs_epoll: add oneshot list to handle the EPOLLONESHOT correctly

2023-03-22 Thread via GitHub
xiaoxiang781216 commented on PR #8871: URL: https://github.com/apache/nuttx/pull/8871#issuecomment-148952 > @CV-Bowen It looks ok. NNG is rearming oneshot events, so this must be it. @jturnsek so it's better to make epoll as the default setting -- This is an automated message fr

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8875: arch: Remove MIN macro definition

2023-03-22 Thread via GitHub
xiaoxiang781216 opened a new pull request, #8875: URL: https://github.com/apache/nuttx/pull/8875 ## Summary use the definition from sys/param.h instead ## Impact Minor ## Testing CI -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [nuttx-apps] simbit18 opened a new pull request, #1679: apps: fix nxstyle

2023-03-22 Thread via GitHub
simbit18 opened a new pull request, #1679: URL: https://github.com/apache/nuttx-apps/pull/1679 ## Summary fix error: Relative file path does not match actual file Add missing Apache Foundation copyright header ## Impact none ## Testing -- This is an automated message

[GitHub] [nuttx] jturnsek commented on pull request #8871: fs/fs_epoll: add oneshot list to handle the EPOLLONESHOT correctly

2023-03-22 Thread via GitHub
jturnsek commented on PR #8871: URL: https://github.com/apache/nuttx/pull/8871#issuecomment-1480064069 > so it's better to make epoll as the default setting I would say no, because with small number of fds, poll should be more efficient. At least on Linux. It is the other way around w

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1654: nsh/alias: Add shell alias support for NSH

2023-03-22 Thread via GitHub
xiaoxiang781216 commented on code in PR #1654: URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1145271083 ## nshlib/nsh_alias.c: ## @@ -0,0 +1,441 @@ +/ + * apps/nshlib/nsh_alias.c + * +

[GitHub] [nuttx-apps] pussuw commented on a diff in pull request #1654: nsh/alias: Add shell alias support for NSH

2023-03-22 Thread via GitHub
pussuw commented on code in PR #1654: URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1145288937 ## nshlib/nsh_alias.c: ## @@ -0,0 +1,441 @@ +/ + * apps/nshlib/nsh_alias.c + * + * License

[GitHub] [nuttx-apps] pussuw commented on a diff in pull request #1654: nsh/alias: Add shell alias support for NSH

2023-03-22 Thread via GitHub
pussuw commented on code in PR #1654: URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1145289665 ## nshlib/nsh_alias.c: ## @@ -0,0 +1,441 @@ +/ + * apps/nshlib/nsh_alias.c + * + * License

[GitHub] [nuttx-apps] pussuw commented on a diff in pull request #1654: nsh/alias: Add shell alias support for NSH

2023-03-22 Thread via GitHub
pussuw commented on code in PR #1654: URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1145291625 ## nshlib/nsh_alias.c: ## @@ -0,0 +1,454 @@ +/ + * apps/nshlib/nsh_alias.c + * + * License

[GitHub] [nuttx-apps] pussuw commented on a diff in pull request #1654: nsh/alias: Add shell alias support for NSH

2023-03-22 Thread via GitHub
pussuw commented on code in PR #1654: URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1145291834 ## nshlib/nsh_alias.c: ## @@ -0,0 +1,441 @@ +/ + * apps/nshlib/nsh_alias.c + * + * License

[GitHub] [nuttx-apps] pussuw commented on a diff in pull request #1654: nsh/alias: Add shell alias support for NSH

2023-03-22 Thread via GitHub
pussuw commented on code in PR #1654: URL: https://github.com/apache/nuttx-apps/pull/1654#discussion_r1145289665 ## nshlib/nsh_alias.c: ## @@ -0,0 +1,441 @@ +/ + * apps/nshlib/nsh_alias.c + * + * License

[GitHub] [nuttx] acassis merged pull request #8875: arch: Remove MIN macro definition

2023-03-22 Thread via GitHub
acassis merged PR #8875: URL: https://github.com/apache/nuttx/pull/8875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache

[nuttx] branch master updated: arch: Remove MIN macro definition

2023-03-22 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 901cd599b1 arch: Remove MIN macro definition 901

[GitHub] [nuttx] acassis merged pull request #8873: stm32/photon: Use D0 Busy to detect Write Complete

2023-03-22 Thread via GitHub
acassis merged PR #8873: URL: https://github.com/apache/nuttx/pull/8873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache

[nuttx] 03/04: wireless/bcm43xxx: enter power saving only if IEEE80211_BROADCOM_LOWPOWER enabled

2023-03-22 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit cdcdce16f73cdd95990c1abc20b060d99765890a Author: chao an AuthorDate: Wed Mar 22 20:19:06 2023 +0800 wireless/bcm43x

[nuttx] 02/04: wireless/bcm43xxx: downgrade log level of allocate frame fail

2023-03-22 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 266774939f429c86d3750c267c1f6a2f381c040d Author: chao an AuthorDate: Wed Mar 22 20:17:21 2023 +0800 wireless/bcm43x

[nuttx] 01/04: mmcsd/sdio: enlarge cmd53 timeout to 1s

2023-03-22 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 4e3480554d6fa2b561fdf76136f4f60a8de3ad00 Author: chao an AuthorDate: Wed Mar 22 20:14:12 2023 +0800 mmcsd/sdio: enl

[nuttx] 04/04: stm32/photon: Use D0 Busy to detect Write Complete

2023-03-22 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit bafef6b3d32f6b57df0e2398ece674a99aa7cc37 Author: chao an AuthorDate: Wed Mar 22 20:21:40 2023 +0800 stm32/photon: U

[nuttx] branch master updated (901cd599b1 -> bafef6b3d3)

2023-03-22 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 901cd599b1 arch: Remove MIN macro definition new 4e3480554d mmcsd/sdio: enlarge cmd53 timeout to 1s new 2667

[GitHub] [nuttx] acassis merged pull request #8872: Documentation: Fix some spelling typos in index.rst

2023-03-22 Thread via GitHub
acassis merged PR #8872: URL: https://github.com/apache/nuttx/pull/8872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache

[nuttx] branch master updated: Documentation: Fix some spelling typos in index.rst

2023-03-22 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 7ac80d4e59 Documentation: Fix some spelling typo

[GitHub] [nuttx] patacongo commented on issue #8858: Issues with adjtime implementation / Build failure.

2023-03-22 Thread via GitHub
patacongo commented on issue #8858: URL: https://github.com/apache/nuttx/issues/8858#issuecomment-1480324651 > I will take a look into possible implementation to NuttX mainline. There are lots of implementations of algorithms out there, so fixing the NuttX adjtime should not be too di

[GitHub] [nuttx-apps] pkarashchenko merged pull request #1679: apps: fix nxstyle

2023-03-22 Thread via GitHub
pkarashchenko merged PR #1679: URL: https://github.com/apache/nuttx-apps/pull/1679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@n

[nuttx-apps] branch master updated (4079f6d61 -> 800f1f4ba)

2023-03-22 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git from 4079f6d61 system/cu: Let remote machine handle special character except Ctrl-C new c86b15467 apps/exa

[nuttx-apps] 04/04: apps/examples/adc/adc.h: fix nxstyle

2023-03-22 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit 800f1f4bae3bfcae206bed7f29581858cb0ed556 Author: simbit18 <101105604+simbi...@users.noreply.github.com> Author

[nuttx-apps] 01/04: apps/examples/fboverlay/Makefile: fix nxstyle

2023-03-22 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit c86b154677c9fad1cdf659e5d7a448b906a42731 Author: simbit18 <101105604+simbi...@users.noreply.github.com> Author

[nuttx-apps] 03/04: apps/examples/charger/Makefile: fix nxstyle

2023-03-22 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit ad8478045e6232e470055ece4d47e791e7d73bec Author: simbit18 <101105604+simbi...@users.noreply.github.com> Author

[nuttx-apps] 02/04: apps/examples/flash_test/Makefile: fix nxstyle

2023-03-22 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit d80b08d07ef276a923fce0a6b7194001ea5a0dea Author: simbit18 <101105604+simbi...@users.noreply.github.com> Author

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8867: Optimize implementation of strsignal()

2023-03-22 Thread via GitHub
pkarashchenko commented on code in PR #8867: URL: https://github.com/apache/nuttx/pull/8867#discussion_r1145508258 ## libs/libc/string/lib_strsignal.c: ## @@ -96,80 +69,51 @@ FAR char *strsignal(int signum) switch (signum) { +#ifdef CONFIG_LIBC_STRSIGNAL Review Commen

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8867: Optimize implementation of strsignal()

2023-03-22 Thread via GitHub
pkarashchenko commented on code in PR #8867: URL: https://github.com/apache/nuttx/pull/8867#discussion_r1145511676 ## libs/libc/string/lib_strsignal.c: ## @@ -22,53 +22,24 @@ * Included Files / +#i

[nuttx-website] branch asf-site updated: Publishing web: b50f5ca4ed22743959c1160aab5dcc9ae18b3eff docs: 7ac80d4e5989924c8c969d4811a5e7857fc23f89

2023-03-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 60f97491 Publishing web: b50f5ca4

[GitHub] [nuttx] zyfeier opened a new pull request, #8876: arch/arm64: fixed cache issue and add more cache interface

2023-03-22 Thread via GitHub
zyfeier opened a new pull request, #8876: URL: https://github.com/apache/nuttx/pull/8876 ## Summary 1. When there has no mmu, the cache size will fail to be obtained. Therefore, the initial cache size is set the first time up_get_dcache_linesize is called. 2. Add cache enable an

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8876: arch/arm64: fixed cache issue and add more cache interface

2023-03-22 Thread via GitHub
pkarashchenko commented on code in PR #8876: URL: https://github.com/apache/nuttx/pull/8876#discussion_r1145620157 ## arch/arm64/src/common/arm64_boot.c: ## @@ -100,26 +106,28 @@ void arm64_boot_el2_init(void) { uint64_t reg; - reg = read_sysreg(sctlr_el2); - reg |=

[GitHub] [nuttx] SPRESENSE opened a new pull request, #8877: arch: cxd56xx: Fix SPI transfer without DMA

2023-03-22 Thread via GitHub
SPRESENSE opened a new pull request, #8877: URL: https://github.com/apache/nuttx/pull/8877 ## Summary SPI transfers are dynamically determined to use DMA or not. The flag to judge is removed in a previous simple refactoring commit https://github.com/apache/nuttx/pull/7472. Revert

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8867: Optimize implementation of strsignal()

2023-03-22 Thread via GitHub
xiaoxiang781216 commented on code in PR #8867: URL: https://github.com/apache/nuttx/pull/8867#discussion_r1145664995 ## libs/libc/string/lib_strsignal.c: ## @@ -22,53 +22,24 @@ * Included Files / +

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8878: assert.h: Replace NULL with 0 to avoid including stddef.h

2023-03-22 Thread via GitHub
xiaoxiang781216 opened a new pull request, #8878: URL: https://github.com/apache/nuttx/pull/8878 ## Summary Fix error: 'NULL' undeclared if user include assert.h only ## Impact Minor ## Testing CI -- This is an automated message from the Apache Git Servic

[GitHub] [nuttx] CV-Bowen commented on pull request #8871: fs/fs_epoll: add oneshot list to handle the EPOLLONESHOT correctly

2023-03-22 Thread via GitHub
CV-Bowen commented on PR #8871: URL: https://github.com/apache/nuttx/pull/8871#issuecomment-1480610379 Could you merge this PR if no more comments? @pkarashchenko -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [nuttx] ldube opened a new pull request, #8879: boards/sama5d3-xplained: Make hot plugging more reliable.

2023-03-22 Thread via GitHub
ldube opened a new pull request, #8879: URL: https://github.com/apache/nuttx/pull/8879 ## Summary Prevent the crash seen when USB devices are removed or inserted. ## Impact Change to usbhost_hub.c affects other platforms. ## Testing SAMA5D3 Xplained board (USB A port)

[GitHub] [nuttx] ldube commented on issue #8491: USB HID Keyboard causes crash

2023-03-22 Thread via GitHub
ldube commented on issue #8491: URL: https://github.com/apache/nuttx/issues/8491#issuecomment-1480682786 @TimJTi Check and see if #8879 fixes this problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above