acassis opened a new issue, #8017:
URL: https://github.com/apache/nuttx/issues/8017
Currently we don't have any kind of Qualification Testing to confirm that a
regression wasn't included in our code base.
A good starting point is the "ostest" (at apps/testing/ostest) and the SIM
CI t
acassis merged PR #7268:
URL: https://github.com/apache/nuttx/pull/7268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache
acassis commented on PR #1341:
URL: https://github.com/apache/nuttx-apps/pull/1341#issuecomment-1368442483
Let's merge and fix possible regressions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
acassis merged PR #1341:
URL: https://github.com/apache/nuttx-apps/pull/1341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.a
acassis closed issue #1322: LVGL v8 version upgrade
URL: https://github.com/apache/nuttx-apps/issues/1322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 1c62181b0d boards: adapt LVGL v8 defconfig
1c621
lupyuen commented on issue #1322:
URL: https://github.com/apache/nuttx-apps/issues/1322#issuecomment-1368456995
Tested OK on PinePhone. Thanks everyone! :-)
```
Let's change `6C` to `6c` to be consistent.
--
This is an
lupyuen commented on PR #8009:
URL: https://github.com/apache/nuttx/pull/8009#issuecomment-1368607152
In a64_twi.c: Let's insert a blank line after `#endif`
```c
#endif
/
* Private Functions
```
lupyuen commented on PR #8009:
URL: https://github.com/apache/nuttx/pull/8009#issuecomment-1368610696
In a64_twi.c: Let's insert a space before `Put`:
```c
* Description:
* Put a 32-bit register value by offset
```
Let's insert 2 spaces before `modreg32` and `putreg3
lupyuen commented on PR #8009:
URL: https://github.com/apache/nuttx/pull/8009#issuecomment-1368612655
In a64_memorymap.h:
```c
#define A64_RTWI_ADDR 0x01f02400 /* R_TWI
0x01f0:2400-0x01f0:27ff 1K */
#define A64_TWI0_ADDR 0x01c2ac00 /* TWI 0
0x01c
lupyuen commented on PR #8009:
URL: https://github.com/apache/nuttx/pull/8009#issuecomment-1368613725
In a64_twi.h:
```c
#define A64_TWI_CNTR_OFFSET (0x0C) /* 31:8 bit reserved, INT_EN,
BUS_EN, M_STA, INT_FLAG, A_ACK */
#define A64_TWI_EFR_OFFSET (0x1C)
lupyuen commented on PR #8009:
URL: https://github.com/apache/nuttx/pull/8009#issuecomment-1368614383
In a64_twi.h: Let's align the numbers:
```c
#define TWI_STAT_ARBLOST_RXGCAS_ACK (0x78)
#define TWI_STAT_RXDS_ACK (0x80)
#define TWI_STAT_RXDS_NAK (0x
lupyuen commented on PR #8009:
URL: https://github.com/apache/nuttx/pull/8009#issuecomment-1368616653
In a64_twi.c:
```c
switch (status)
{
case 0xf8: /* On reset or stop the bus is idle, used only on polled */
err_code = 0xf8;
goto errout;
ca
lupyuen commented on PR #8009:
URL: https://github.com/apache/nuttx/pull/8009#issuecomment-1368618056
The I2C logic looks OK when I checked with the A64 User Manual. So my review
is complete.
After the I2C driver has been merged, I look forward to testing your driver
with the [PinePh
lupyuen commented on PR #8009:
URL: https://github.com/apache/nuttx/pull/8009#issuecomment-1368619444
Sorry one last comment: In pinephone_bringup.c:
```c
#include
```
Let's wrap it as:
```c
#ifdef CONFIG_MPU60X0_I2C
# include
#endif
```
The sa
zouboan commented on PR #8009:
URL: https://github.com/apache/nuttx/pull/8009#issuecomment-1368622943
Thanks very much for your review @lupyuen, let me change the code!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
btashton opened a new pull request, #8018:
URL: https://github.com/apache/nuttx/pull/8018
## Summary
When the documentation build was run an error like this would fire:
```
[pipenv.exceptions.InstallError]: ERROR: THESE PACKAGES DO NOT MATCH THE
HASHES FROM THE REQUIREMENTS FILE. I
xiaoxiang781216 merged PR #8018:
URL: https://github.com/apache/nuttx/pull/8018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new a4ca15aa3e CI/Documentation: livereload hash m
jlaitine commented on code in PR #8000:
URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059864272
##
include/nuttx/fs/fs.h:
##
@@ -206,16 +207,21 @@ struct file_operations
* treated like unions.
*/
- int (*close)(FAR struct file *filep);
- ssize_t (*r
jlaitine commented on code in PR #8000:
URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059864433
##
drivers/video/fb.c:
##
@@ -682,6 +675,30 @@ static int fb_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
return ret;
}
+static int fb_mmap(FAR s
jlaitine commented on code in PR #8000:
URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059865937
##
drivers/video/fb.c:
##
@@ -682,6 +675,30 @@ static int fb_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
return ret;
}
+static int fb_mmap(FAR s
jlaitine commented on code in PR #8000:
URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059866272
##
drivers/video/video.c:
##
@@ -3200,6 +3198,22 @@ static int video_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
return ret;
}
+static int video_mma
jlaitine commented on code in PR #8000:
URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059869454
##
include/nuttx/fs/fs.h:
##
@@ -209,13 +211,19 @@ struct file_operations
int (*close)(FAR struct file *filep);
ssize_t (*read)(FAR struct file *filep, FAR cha
jlaitine commented on code in PR #8000:
URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059870695
##
include/nuttx/fs/fs.h:
##
@@ -209,13 +211,19 @@ struct file_operations
int (*close)(FAR struct file *filep);
ssize_t (*read)(FAR struct file *filep, FAR cha
jlaitine commented on PR #8000:
URL: https://github.com/apache/nuttx/pull/8000#issuecomment-1368713477
Here I must disagree. You definitely need to change these, since they
currently look like this:
```
NULL, /* write */
NULL, /
28 matches
Mail list logo
