jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059869454
########## include/nuttx/fs/fs.h: ########## @@ -209,13 +211,19 @@ struct file_operations int (*close)(FAR struct file *filep); ssize_t (*read)(FAR struct file *filep, FAR char *buffer, size_t buflen); ssize_t (*write)(FAR struct file *filep, FAR const char *buffer, - size_t buflen); + size_t buflen); off_t (*seek)(FAR struct file *filep, off_t offset, int whence); int (*ioctl)(FAR struct file *filep, int cmd, unsigned long arg); + int (*truncate)(FAR struct file *filep, off_t length); + int (*mmap)(FAR struct file *filep, FAR void **addr, off_t start, + size_t length); + int (*munmap)(FAR struct task_group_s *group, FAR struct mm_map_s *map, Review Comment: This is to handle the special case of process exit. Normally munmap needs to remove the mapping and also in case of CONFIG_BUILD_KERNEL also do the real MMU unmapping. In case of process exit the MMU unmapping can't be done (since there may be some other address environment currently in use), and also removal from the group can be done outside. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
