xiaoxiang781216 commented on code in PR #7717:
URL: https://github.com/apache/nuttx/pull/7717#discussion_r1037879930
##
arch/sim/src/sim/sim_alsa.c:
##
@@ -578,11 +709,32 @@ static void sim_audio_process(struct sim_audio_s *priv)
if (priv->playback)
{
- ret = snd_
xiaoxiang781216 commented on code in PR #7717:
URL: https://github.com/apache/nuttx/pull/7717#discussion_r1037879930
##
arch/sim/src/sim/sim_alsa.c:
##
@@ -578,11 +709,32 @@ static void sim_audio_process(struct sim_audio_s *priv)
if (priv->playback)
{
- ret = snd_
xiaoxiang781216 commented on code in PR #1440:
URL: https://github.com/apache/nuttx-apps/pull/1440#discussion_r1037883978
##
system/nxplayer/nxplayer.c:
##
@@ -80,6 +80,12 @@ struct nxplayer_ext_fmt_s
};
#endif
+struct nxplayer_fmt_s
Review Comment:
remove, no user
--
xiaoxiang781216 commented on code in PR #1440:
URL: https://github.com/apache/nuttx-apps/pull/1440#discussion_r1037884402
##
system/nxplayer/nxplayer.c:
##
@@ -121,6 +131,27 @@ static const struct nxplayer_ext_fmt_s g_known_ext[] =
static const int g_known_ext_count = sizeof(
xiaoxiang781216 commented on code in PR #7717:
URL: https://github.com/apache/nuttx/pull/7717#discussion_r1037891804
##
arch/sim/src/sim/sim_alsa.c:
##
@@ -116,6 +177,32 @@ static const struct audio_ops_s g_sim_audio_ops =
.release = sim_audio_release,
};
+static con
xiaoxiang781216 commented on code in PR #7717:
URL: https://github.com/apache/nuttx/pull/7717#discussion_r1037892262
##
arch/sim/src/sim/sim_alsa.c:
##
@@ -116,6 +177,32 @@ static const struct audio_ops_s g_sim_audio_ops =
.release = sim_audio_release,
};
+static con
xiaoxiang781216 commented on code in PR #7749:
URL: https://github.com/apache/nuttx/pull/7749#discussion_r1037895346
##
drivers/video/video.c:
##
@@ -1547,6 +1595,24 @@ static int video_try_fmt(FAR struct video_mng_s *priv,
&type_inf->frame_inter
pkarashchenko commented on code in PR #1440:
URL: https://github.com/apache/nuttx-apps/pull/1440#discussion_r1037920760
##
system/nxplayer/nxplayer.c:
##
@@ -121,6 +131,27 @@ static const struct nxplayer_ext_fmt_s g_known_ext[] =
static const int g_known_ext_count = sizeof(g_
xiaoxiang781216 commented on code in PR #1407:
URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1037921466
##
Application.mk:
##
@@ -191,6 +192,21 @@ else
MAINNAME := $(addsuffix _main,$(PROGNAME))
+ifeq ($(CONFIG_WINDOWS_NATIVE),y)
+$(MAINCXXOBJ): %$(CXXEXT)
xiaoxiang781216 commented on code in PR #1407:
URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1037922304
##
Make.defs:
##
@@ -85,14 +80,24 @@ endif
BUILTIN_REGISTRY = $(APPDIR)$(DELIM)builtin$(DELIM)registry
DEPCONFIG = $(TOPDIR)$(DELIM).config
+ifeq ($(CONF
xiaoxiang781216 commented on code in PR #1407:
URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1037923239
##
Makefile:
##
@@ -21,6 +21,16 @@
export APPDIR = $(CURDIR)
include $(APPDIR)/Make.defs
+# The GNU make CURDIR will always be a POSIX-like path with for
xiaoxiang781216 commented on code in PR #1407:
URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1037924651
##
Makefile:
##
@@ -83,11 +93,15 @@ else
# symbol table is required.
ifeq ($(CONFIG_BUILD_LOADABLE),)
-
+ifeq ($(CONFIG_WINDOWS_NATIVE),y)
+$(BIN): $(for
pkarashchenko commented on code in PR #7735:
URL: https://github.com/apache/nuttx/pull/7735#discussion_r1037933095
##
include/nuttx/notifier.h:
##
@@ -0,0 +1,201 @@
+/
+ * include/nuttx/notifier.h
+ *
+
XinStellaris commented on code in PR #7735:
URL: https://github.com/apache/nuttx/pull/7735#discussion_r1037935431
##
include/nuttx/notifier.h:
##
@@ -0,0 +1,201 @@
+/
+ * include/nuttx/notifier.h
+ *
+ *
xiaoxiang781216 commented on code in PR #7735:
URL: https://github.com/apache/nuttx/pull/7735#discussion_r1037951675
##
include/nuttx/notifier.h:
##
@@ -0,0 +1,201 @@
+/
+ * include/nuttx/notifier.h
+ *
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1037774072
##
mm/iob/Kconfig:
##
@@ -41,7 +41,7 @@ config IOB_HEADSIZE
config IOB_ALIGNMENT
int "Alignment size of each I/O buffer"
- default 1
+ default 4
Re
XuNeo opened a new pull request, #1444:
URL: https://github.com/apache/nuttx-apps/pull/1444
## Summary
Libuv lua binding: https://github.com/luvit/luv
Initial work done by Michael Mogenson as shown in LICENSE
## Impact
No.
## Testing
--
This is an automat
qiaohaijiao commented on code in PR #1440:
URL: https://github.com/apache/nuttx-apps/pull/1440#discussion_r1038011536
##
system/nxplayer/nxplayer.c:
##
@@ -121,6 +131,27 @@ static const struct nxplayer_ext_fmt_s g_known_ext[] =
static const int g_known_ext_count = sizeof(g_kn
qiaohaijiao commented on code in PR #7717:
URL: https://github.com/apache/nuttx/pull/7717#discussion_r1038011702
##
arch/sim/src/sim/sim_alsa.c:
##
@@ -116,6 +177,32 @@ static const struct audio_ops_s g_sim_audio_ops =
.release = sim_audio_release,
};
+static const s
qiaohaijiao commented on code in PR #7717:
URL: https://github.com/apache/nuttx/pull/7717#discussion_r1038012159
##
arch/sim/src/sim/sim_alsa.c:
##
@@ -578,11 +709,32 @@ static void sim_audio_process(struct sim_audio_s *priv)
if (priv->playback)
{
- ret = snd_pcm_
acassis commented on PR #7749:
URL: https://github.com/apache/nuttx/pull/7749#issuecomment-1335102490
Yes, I think the headers files are not covered by GPL license. But it is
important to clarify to avoid issues in the future. Maybe adding this info that
the file header is based on FreeBSD
acassis closed issue #7731: SAMA5D2 has no support for Flexcom SPI - best
method?
URL: https://github.com/apache/nuttx/issues/7731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
huangjianxiaomi opened a new pull request, #1445:
URL: https://github.com/apache/nuttx-apps/pull/1445
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
davids5 opened a new pull request, #7757:
URL: https://github.com/apache/nuttx/pull/7757
## Summary
Incorrect indexing was causing a bus violation
## Impact
Critical
## Testing
nxp_mr-canhubk3_fmu with PX4
--
This is an automated message from the Apache
zouboan commented on code in PR #1407:
URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1038157687
##
Makefile:
##
@@ -83,11 +93,15 @@ else
# symbol table is required.
ifeq ($(CONFIG_BUILD_LOADABLE),)
-
+ifeq ($(CONFIG_WINDOWS_NATIVE),y)
+$(BIN): $(foreach SDI
zouboan commented on code in PR #1407:
URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1038157687
##
Makefile:
##
@@ -83,11 +93,15 @@ else
# symbol table is required.
ifeq ($(CONFIG_BUILD_LOADABLE),)
-
+ifeq ($(CONFIG_WINDOWS_NATIVE),y)
+$(BIN): $(foreach SDI
zouboan commented on code in PR #1407:
URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1038157687
##
Makefile:
##
@@ -83,11 +93,15 @@ else
# symbol table is required.
ifeq ($(CONFIG_BUILD_LOADABLE),)
-
+ifeq ($(CONFIG_WINDOWS_NATIVE),y)
+$(BIN): $(foreach SDI
zouboan commented on code in PR #1407:
URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1038157687
##
Makefile:
##
@@ -83,11 +93,15 @@ else
# symbol table is required.
ifeq ($(CONFIG_BUILD_LOADABLE),)
-
+ifeq ($(CONFIG_WINDOWS_NATIVE),y)
+$(BIN): $(foreach SDI
zouboan commented on code in PR #1407:
URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1038192710
##
Make.defs:
##
@@ -85,14 +80,24 @@ endif
BUILTIN_REGISTRY = $(APPDIR)$(DELIM)builtin$(DELIM)registry
DEPCONFIG = $(TOPDIR)$(DELIM).config
+ifeq ($(CONFIG_WINDO
zouboan commented on code in PR #1407:
URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1038192710
##
Make.defs:
##
@@ -85,14 +80,24 @@ endif
BUILTIN_REGISTRY = $(APPDIR)$(DELIM)builtin$(DELIM)registry
DEPCONFIG = $(TOPDIR)$(DELIM).config
+ifeq ($(CONFIG_WINDO
zouboan commented on code in PR #1407:
URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1038192710
##
Make.defs:
##
@@ -85,14 +80,24 @@ endif
BUILTIN_REGISTRY = $(APPDIR)$(DELIM)builtin$(DELIM)registry
DEPCONFIG = $(TOPDIR)$(DELIM).config
+ifeq ($(CONFIG_WINDO
zouboan commented on code in PR #1407:
URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1038192710
##
Make.defs:
##
@@ -85,14 +80,24 @@ endif
BUILTIN_REGISTRY = $(APPDIR)$(DELIM)builtin$(DELIM)registry
DEPCONFIG = $(TOPDIR)$(DELIM).config
+ifeq ($(CONFIG_WINDO
zouboan commented on code in PR #1407:
URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1038192710
##
Make.defs:
##
@@ -85,14 +80,24 @@ endif
BUILTIN_REGISTRY = $(APPDIR)$(DELIM)builtin$(DELIM)registry
DEPCONFIG = $(TOPDIR)$(DELIM).config
+ifeq ($(CONFIG_WINDO
zouboan commented on code in PR #1407:
URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1038192710
##
Make.defs:
##
@@ -85,14 +80,24 @@ endif
BUILTIN_REGISTRY = $(APPDIR)$(DELIM)builtin$(DELIM)registry
DEPCONFIG = $(TOPDIR)$(DELIM).config
+ifeq ($(CONFIG_WINDO
zouboan commented on code in PR #1407:
URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1038199589
##
Makefile:
##
@@ -21,6 +21,16 @@
export APPDIR = $(CURDIR)
include $(APPDIR)/Make.defs
+# The GNU make CURDIR will always be a POSIX-like path with forward sla
zouboan commented on code in PR #1407:
URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1038199589
##
Makefile:
##
@@ -21,6 +21,16 @@
export APPDIR = $(CURDIR)
include $(APPDIR)/Make.defs
+# The GNU make CURDIR will always be a POSIX-like path with forward sla
zouboan commented on code in PR #1407:
URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1038208846
##
Application.mk:
##
@@ -191,6 +192,21 @@ else
MAINNAME := $(addsuffix _main,$(PROGNAME))
+ifeq ($(CONFIG_WINDOWS_NATIVE),y)
+$(MAINCXXOBJ): %$(CXXEXT)$(SUFFIX
zouboan commented on code in PR #1407:
URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1038192710
##
Make.defs:
##
@@ -85,14 +80,24 @@ endif
BUILTIN_REGISTRY = $(APPDIR)$(DELIM)builtin$(DELIM)registry
DEPCONFIG = $(TOPDIR)$(DELIM).config
+ifeq ($(CONFIG_WINDO
xiaoxiang781216 merged PR #1440:
URL: https://github.com/apache/nuttx-apps/pull/1440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 05eadd1bd nxplayer: add mp3 offload playb
xiaoxiang781216 merged PR #7717:
URL: https://github.com/apache/nuttx/pull/7717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 025430a964 net/icmpv6: Fix icmpv6_reply function
new e6ec6e1a94 sim/alsa: enable CONFIG_SIM_M32 config
new
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit e6ec6e1a941ce68c7189c4f1e179bf9df1afd06f
Author: qiaohaijiao1
AuthorDate: Tue Nov 29 18:32:07 2022 +0800
sim/alsa
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit 18bca596d498bc964ce854a7dd5509f348f11713
Author: qiaohaijiao1
AuthorDate: Tue Nov 8 11:08:49 2022 +0800
sim/sim_a
xiaoxiang781216 merged PR #7757:
URL: https://github.com/apache/nuttx/pull/7757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 18bca596d4 sim/sim_alsa.c: add mp3 offload playback on sim
add 22390df92d s32k3xx:EDMA fix DMAMUX1 access viol
xiaoxiang781216 merged PR #7735:
URL: https://github.com/apache/nuttx/pull/7735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 22390df92d s32k3xx:EDMA fix DMAMUX1 access violation
add cb0418676f include/nuttx:add linux-like notifier
No n
xiaoxiang781216 closed pull request #7528: net/tcp: Remove the unused
TCP_STOPPED flags
URL: https://github.com/apache/nuttx/pull/7528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
PeterBee97 commented on PR #7749:
URL: https://github.com/apache/nuttx/pull/7749#issuecomment-1335388269
> Yes, I think the headers files are not covered by GPL license. But it is
important to clarify to avoid issues in the future. Maybe adding this info that
the file header is based on Fre
xiaoxiang781216 closed pull request #6816: arch/arm: Remove the critical
section protection in up_invalidate_dcache_all
URL: https://github.com/apache/nuttx/pull/6816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
xiaoxiang781216 commented on PR #6631:
URL: https://github.com/apache/nuttx/pull/6631#issuecomment-1335390481
@fjpanag do you want to improve this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
xiaoxiang781216 commented on code in PR #1444:
URL: https://github.com/apache/nuttx-apps/pull/1444#discussion_r1038222539
##
system/luv/Make.defs:
##
@@ -0,0 +1,28 @@
+
+# apps/system/luv/Make.defs
+#
+#
TimJTi commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038285593
##
arch/arm/src/sama5/sam_adc.c:
##
@@ -1335,7 +1417,7 @@ static int sam_adc_settimer(struct sam_adc_s *priv,
uint32_t frequency,
priv->tc = sam_tc_allocate(channel, m
xiaoxiang781216 commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1038278716
##
arch/sim/src/sim/sim_netdriver.c:
##
@@ -224,6 +241,11 @@ static void netdriver_recv_work(void *arg)
NETDEV_RXERRORS(dev);
}
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1038289564
##
arch/sim/src/sim/sim_netdriver.c:
##
@@ -224,6 +241,11 @@ static void netdriver_recv_work(void *arg)
NETDEV_RXERRORS(dev);
}
}
+
+#
TimJTi commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038289670
##
arch/arm/src/sama5/sam_adc.c:
##
@@ -1728,7 +1890,8 @@ static void sam_adc_gain(struct sam_adc_s *priv)
/* Set GAIN0 only. GAIN0 will be used for all channels. */
TimJTi commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038291569
##
arch/arm/src/sama5/sam_tsd.c:
##
@@ -1655,7 +1755,7 @@ int sam_tsd_register(struct sam_adc_s *adc, int minor)
/* Initialize the touchscreen device driver instance
davids5 opened a new pull request, #7758:
URL: https://github.com/apache/nuttx/pull/7758
## Summary
s32k1xx:LPI2C Add DMA support
s32k3xx:LPI2C fix RESET so it compiles
## Impact
Build will succeed with CONFIG_I2C_RESET lit
None for DMA it is a new feature
##
TimJTi commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038291947
##
arch/arm/src/sama5/sam_adc.c:
##
@@ -1335,7 +1417,7 @@ static int sam_adc_settimer(struct sam_adc_s *priv,
uint32_t frequency,
priv->tc = sam_tc_allocate(channel, m
TimJTi commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038292534
##
arch/arm/src/sama5/sam_adc.c:
##
@@ -1069,10 +1137,13 @@ static void sam_adc_reset(struct adc_dev_s *dev)
/* Reset gain, offset, differential modes */
+#if defin
TimJTi commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038293171
##
arch/arm/src/sama5/sam_tsd.c:
##
@@ -1318,7 +1382,11 @@ static void sam_tsd_tracking(struct sam_tsd_s *priv,
uint32_t time)
tracktim--;
}
}
-
TimJTi commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038294627
##
arch/arm/src/sama5/sam_tsd.c:
##
@@ -137,6 +137,18 @@
# define MAX(a,b) (((a) > (b)) ? (a) : (b))
#endif
+#ifndef BOARD_TSSCTIM
+# define BOARD_TSSCTIM 0
Review C
TimJTi commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038295217
##
arch/arm/src/sama5/sam_adc.c:
##
@@ -2050,9 +2213,17 @@ struct adc_dev_s *sam_adc_initialize(void)
/* Initialize the public ADC device data structure */
#ifde
TimJTi commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038295545
##
arch/arm/src/sama5/sam_adc.c:
##
@@ -2050,9 +2213,17 @@ struct adc_dev_s *sam_adc_initialize(void)
/* Initialize the public ADC device data structure */
#ifde
TimJTi commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038296668
##
arch/arm/src/sama5/sam_adc.c:
##
@@ -865,7 +935,7 @@ static void sam_adc_endconversion(void *arg)
int ret;
DEBUGASSERT(priv != NULL);
- ainfo("pending=%08x\n",
pkarashchenko commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038302910
##
arch/arm/src/sama5/sam_adc.c:
##
@@ -865,7 +935,7 @@ static void sam_adc_endconversion(void *arg)
int ret;
DEBUGASSERT(priv != NULL);
- ainfo("pending=%
TimJTi commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038318332
##
arch/arm/src/sama5/sam_adc.c:
##
@@ -865,7 +935,7 @@ static void sam_adc_endconversion(void *arg)
int ret;
DEBUGASSERT(priv != NULL);
- ainfo("pending=%08x\n",
TimJTi commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038320009
##
arch/arm/src/sama5/sam_adc.c:
##
@@ -1728,7 +1890,8 @@ static void sam_adc_gain(struct sam_adc_s *priv)
/* Set GAIN0 only. GAIN0 will be used for all channels. */
davids5 opened a new pull request, #7759:
URL: https://github.com/apache/nuttx/pull/7759
## Summary
Cleaned up s32k3xx EDMA. Added looping and Error handling
## Impact
Correct performance and error termination
## Testing
PX4 nxp_mr-canhubk3_fmu
--
This i
crafcat7 opened a new pull request, #7760:
URL: https://github.com/apache/nuttx/pull/7760
## Summary
In some cases, deleting a folder will return unexpected results. For
example, ENOENT should be returned when deleting a non-existent folder, but the
result will return ENOTDIR.After this
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1038339360
##
include/nuttx/net/netdev.h:
##
@@ -238,6 +241,8 @@ struct netdev_varaddr_s
struct devif_callback_s; /* Forward reference */
+typedef CODE int (*devif_poll_callback
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1038340165
##
include/nuttx/net/netdev.h:
##
@@ -802,4 +923,88 @@ void net_incr32(FAR uint8_t *op32, uint16_t op16);
int netdev_lladdrsize(FAR struct net_driver_s *dev);
+/*
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1038341027
##
net/Kconfig:
##
@@ -117,6 +117,15 @@ config NET_GUARDSIZE
packet size will be chopped down to the size indicated in the
TCP
header.
+
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1038341235
##
net/devif/devif_poll.c:
##
@@ -772,6 +769,217 @@ int devif_poll(FAR struct net_driver_s *dev,
devif_poll_callback_t callback)
return bstop;
}
+/*
TimJTi opened a new pull request, #7761:
URL: https://github.com/apache/nuttx/pull/7761
## Summary
The feedback is still coming!
In double checking it all, I found an error in sam_tc.c as (perhaps some
other change meant) "int ret" had not been declared.
## Impact
None
pkarashchenko commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038369485
##
arch/arm/src/sama5/sam_adc.c:
##
@@ -865,7 +935,7 @@ static void sam_adc_endconversion(void *arg)
int ret;
DEBUGASSERT(priv != NULL);
- ainfo("pending=%
pkarashchenko commented on code in PR #7761:
URL: https://github.com/apache/nuttx/pull/7761#discussion_r1038370808
##
arch/arm/src/sama5/sam_tc.c:
##
@@ -1451,7 +1452,8 @@ int sam_tc_divisor(uint32_t frequency, uint32_t *div,
uint32_t *tcclks)
if (tcclks)
{
- tmr
TimJTi commented on code in PR #7761:
URL: https://github.com/apache/nuttx/pull/7761#discussion_r1038373118
##
arch/arm/src/sama5/sam_tc.c:
##
@@ -1451,7 +1452,8 @@ int sam_tc_divisor(uint32_t frequency, uint32_t *div,
uint32_t *tcclks)
if (tcclks)
{
- tmrinfo("r
enai opened a new pull request, #7762:
URL: https://github.com/apache/nuttx/pull/7762
Summary:
- It is applicable to esp32 products and uses the himem part of 8M psram by
creating character devices.
Impact:
- None
Testing:
- Tested with esp32-devkitc:himem
#
enai opened a new pull request, #1446:
URL: https://github.com/apache/nuttx-apps/pull/1446
…cter devices,
read/write multi block character devices, etc.
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To r
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from cb0418676f include/nuttx:add linux-like notifier
add 8b95b7ca5b littlefs: Get and return the current error stat
xiaoxiang781216 merged PR #7760:
URL: https://github.com/apache/nuttx/pull/7760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
xiaoxiang781216 commented on code in PR #7762:
URL: https://github.com/apache/nuttx/pull/7762#discussion_r1038430232
##
include/nuttx/drivers/himem_chardev.h:
##
@@ -0,0 +1,42 @@
+/
+ * include/nuttx/dri
xiaoxiang781216 merged PR #7759:
URL: https://github.com/apache/nuttx/pull/7759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 8b95b7ca5b littlefs: Get and return the current error status before
RMDIR execution type
add 1d84656f79 s32k3x
xiaoxiang781216 merged PR #7749:
URL: https://github.com/apache/nuttx/pull/7749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from ddc178122e s32k3xx:EDMA Add Error handeling
add c26fd6565d drivers/video: enhance v4l2 compatibility
No new re
xiaoxiang781216 commented on PR #7687:
URL: https://github.com/apache/nuttx/pull/7687#issuecomment-1335674511
@PeterBee97 please rebase this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
xiaoxiang781216 commented on code in PR #7687:
URL: https://github.com/apache/nuttx/pull/7687#discussion_r1034350440
##
video/Kconfig:
##
@@ -13,6 +13,10 @@ config VIDEO
if VIDEO
+config VIDEO_DEV_PATH
Review Comment:
why VIDEO_DEV_PATH in this patch?
--
This is an
xiaoxiang781216 commented on code in PR #1407:
URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1038432756
##
Application.mk:
##
@@ -191,6 +192,21 @@ else
MAINNAME := $(addsuffix _main,$(PROGNAME))
+ifeq ($(CONFIG_WINDOWS_NATIVE),y)
+$(MAINCXXOBJ): %$(CXXEXT)
xiaoxiang781216 commented on code in PR #1407:
URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1038433017
##
Makefile:
##
@@ -21,6 +21,16 @@
export APPDIR = $(CURDIR)
include $(APPDIR)/Make.defs
+# The GNU make CURDIR will always be a POSIX-like path with for
xiaoxiang781216 commented on PR #7705:
URL: https://github.com/apache/nuttx/pull/7705#issuecomment-1335694513
@pkarashchenko could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
TimJTi commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038454957
##
arch/arm/src/sama5/sam_adc.c:
##
@@ -865,7 +935,7 @@ static void sam_adc_endconversion(void *arg)
int ret;
DEBUGASSERT(priv != NULL);
- ainfo("pending=%08x\n",
TimJTi commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038458296
##
arch/arm/src/sama5/sam_adc.c:
##
@@ -865,7 +935,7 @@ static void sam_adc_endconversion(void *arg)
int ret;
DEBUGASSERT(priv != NULL);
- ainfo("pending=%08x\n",
pkarashchenko commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038503990
##
arch/arm/src/sama5/sam_adc.c:
##
@@ -865,7 +935,7 @@ static void sam_adc_endconversion(void *arg)
int ret;
DEBUGASSERT(priv != NULL);
- ainfo("pending=%
TimJTi commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038516692
##
arch/arm/src/sama5/sam_adc.c:
##
@@ -865,7 +935,7 @@ static void sam_adc_endconversion(void *arg)
int ret;
DEBUGASSERT(priv != NULL);
- ainfo("pending=%08x\n",
pkarashchenko commented on code in PR #7702:
URL: https://github.com/apache/nuttx/pull/7702#discussion_r1038523774
##
arch/arm/src/sama5/sam_adc.c:
##
@@ -865,7 +935,7 @@ static void sam_adc_endconversion(void *arg)
int ret;
DEBUGASSERT(priv != NULL);
- ainfo("pending=%
okayserh opened a new pull request, #7763:
URL: https://github.com/apache/nuttx/pull/7763
## Summary
Adds USB FS Host support for the STM32F746, in particular the STM32F746
Discovery board. Mainly copying code from either the H7 implementation or the
STM32 base implementation.
##
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 6b75604a Publishing web: e978ad4c
1 - 100 of 107 matches
Mail list logo
