zouboan commented on code in PR #1407:
URL: https://github.com/apache/nuttx-apps/pull/1407#discussion_r1038157687


##########
Makefile:
##########
@@ -83,11 +93,15 @@ else
 # symbol table is required.
 
 ifeq ($(CONFIG_BUILD_LOADABLE),)
-
+ifeq ($(CONFIG_WINDOWS_NATIVE),y)
+$(BIN): $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_all)
+       $(Q) for %%G in ($(CONFIGURED_APPS)) do ( $(MAKE) -C %%G archive )
+else
 $(BIN): $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_all)
        $(Q) for app in ${CONFIGURED_APPS}; do \

Review Comment:
   the usage of `FOR` loop in Windows is:
   `FOR %variable IN (set) DO command [command-parameters]`
   to use the FOR command in a batch program, specify `%%variable` instead of 
`%variable`
   
   I tried to use `$(Q) for %%G in ($(CONFIGURED_APPS)) do ( $(MAKE) -C %%G 
archive )` or I tried to use `$(Q) for %%G in ($(CONFIGURED_APPS)) do ( $(MAKE) 
-C ${%%G} archive )` in Linux, but failed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to