pussuw commented on pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1077299391
> Ok, I get your point. U-mode thread never directly initiative the context
switch through riscv_switch_context, instead through other normal syscall or
the hardware int
xiaoxiang781216 commented on pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1077307022
Why not implement OpenSBI API in M-mode required by S-mode NuttX directly? I
think is more simple and general than a private MiniSBI.
--
This is an automated
xiaoxiang781216 edited a comment on pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1077307022
Why not implement OpenSBI API in M-mode required by S-mode NuttX directly? I
think is more simple and general than a private MiniSBI. We can write from
s
xiaoxiang781216 edited a comment on pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1077307022
Why not implement OpenSBI API in M-mode required by S-mode NuttX directly? I
think is more simple and general than a private MiniSBI. We can write from
s
xiaoxiang781216 edited a comment on pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1077307022
Why not implement OpenSBI API in M-mode required by S-mode NuttX directly? I
think is more simple and general than a private MiniSBI. We can write from
s
xiaoxiang781216 commented on pull request #5835:
URL: https://github.com/apache/incubator-nuttx/pull/5835#issuecomment-1077319163
Please fix the warning report here:
https://github.com/apache/incubator-nuttx/runs/5671271324?check_suite_focus=true
--
This is an automated message from t
xiaoxiang781216 commented on a change in pull request #5835:
URL: https://github.com/apache/incubator-nuttx/pull/5835#discussion_r833996279
##
File path: arch/risc-v/src/litex/litex_cache.c
##
@@ -0,0 +1,76 @@
+/**
anjiahao1 opened a new pull request #5836:
URL: https://github.com/apache/incubator-nuttx/pull/5836
this is a tool,when crash help you to debug.
Signed-off-by: anjiahao
## introduce
This tool can help you analyze the call stack information when the system
crashes
##
pussuw commented on pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1077331325
> Why not implement OpenSBI API in M-mode required by S-mode NuttX directly?
I think is more simple and general than a private MiniSBI. We can write from
scratch in M-mo
xiaoxiang781216 commented on pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1077337012
Yes, I understand, that is why I emphasize that M-mode only need implement
the minimal API(subset of function and argument) which is actually used by
S-mode Nut
xiaoxiang781216 commented on pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1077339652
Maybe we can change CONFIG_OPENSBI at
https://github.com/apache/incubator-nuttx/tree/master/arch/risc-v/src/opensbi
from bool to choice and add a new minimal im
lupyuen commented on issue #5810:
URL:
https://github.com/apache/incubator-nuttx/issues/5810#issuecomment-1077355494
Cool thanks! BL602 MISO / MOSI Swap is in the master branch here:
[bl602_spi.c](https://github.com/apache/incubator-nuttx/blob/master/arch/risc-v/src/bl602/bl602_spi.c#L1137
jlaitine commented on pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1077368297
I think that we are responsible for the SBI confusion, so let me explain a
bit where we are.
The OpenSBI library, which we added (by @eenurkka) is not really use
AndrewD commented on a change in pull request #5835:
URL: https://github.com/apache/incubator-nuttx/pull/5835#discussion_r834056629
##
File path: include/nuttx/sdio.h
##
@@ -477,6 +477,7 @@
#define SDIO_CAPS_DMABEFOREWRITE 0x04 /* Bit 2=1: Executes DMA before write
command *
xiaoxiang781216 commented on pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1077383465
Since OpenSBI is the standard way to expose M-mode functionality to S-mode,
what I suggest it's that we use OpenSBI API definition, but write our own
minimal im
anjiahao1 commented on pull request #5836:
URL: https://github.com/apache/incubator-nuttx/pull/5836#issuecomment-1077384838
maybe Lint CI have conflict，about `:` 🐛
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
xiaoxiang781216 edited a comment on pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1077383465
> I think that we are responsible for the SBI confusion, so let me explain a
bit where we are.
>
> The OpenSBI library, which we added (by @eenurkk
xiaoxiang781216 edited a comment on pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1077383465
> I think that we are responsible for the SBI confusion, so let me explain a
bit where we are.
>
> The OpenSBI library, which we added (by @eenurkk
jlaitine commented on pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1077406182
> Since OpenSBI is the standard way to expose M-mode functionality to
S-mode, what I suggest it's that we use OpenSBI API definition, but write our
own minimal imp
xiaoxiang781216 commented on pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1077456944
> > Since OpenSBI is the standard way to expose M-mode functionality to
S-mode, what I suggest it's that we use OpenSBI API definition, but write our
own minima
xiaoxiang781216 edited a comment on pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1077456944
> > Since OpenSBI is the standard way to expose M-mode functionality to
S-mode, what I suggest it's that we use OpenSBI API definition, but write our
own
pussuw commented on pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1077474453
I moved the SBI parts out of this review. I will publish that part later and
the discussion about the SBI can be moved there.
For now there are stub wrappers that
acassis commented on pull request #5835:
URL: https://github.com/apache/incubator-nuttx/pull/5835#issuecomment-1077562013
Hi @rtucker85 could you please fix these issues:
```
../nuttx/tools/checkpatch.sh -g
c92c4af304dcc09254dc4023ca822fef11d98233..HEAD
Error:
/home/runner/work/i
gustavonihei commented on a change in pull request #5836:
URL: https://github.com/apache/incubator-nuttx/pull/5836#discussion_r834392204
##
File path: tools/minidumpserver.py
##
@@ -0,0 +1,530 @@
+#!/usr/bin/env python3
+# tools/minidumpserver.py
+#
+# Licensed to the Apache So
xiaoxiang781216 opened a new pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837
## Summary
- libc: Implement getrandom on top of "/dev/[u]random"
- libc/uuid: Call getrandom instaed arc4random_buf
## Impact
New API
## Testing
Pass CI
gustavonihei commented on a change in pull request #5836:
URL: https://github.com/apache/incubator-nuttx/pull/5836#discussion_r834398608
##
File path: tools/minidumpserver.py
##
@@ -0,0 +1,530 @@
+#!/usr/bin/env python3
+# tools/minidumpserver.py
+#
+# Licensed to the Apache So
gustavonihei commented on pull request #5836:
URL: https://github.com/apache/incubator-nuttx/pull/5836#issuecomment-1077752838
> maybe Lint CI have conflict，about `:` bug
Aren't we able to fix the linker issues?
Something like: `line[tmp.span()[1] :]` into `line[tmp.span()[1] : ]`
pkarashchenko commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r834434602
##
File path: libs/libc/misc/lib_getrandom.c
##
@@ -0,0 +1,91 @@
+/*
pkarashchenko commented on a change in pull request #5836:
URL: https://github.com/apache/incubator-nuttx/pull/5836#discussion_r83659
##
File path: tools/minidumpserver.py
##
@@ -0,0 +1,530 @@
+#!/usr/bin/env python3
+# tools/minidumpserver.py
+#
+# Licensed to the Apache S
pkarashchenko commented on a change in pull request #5836:
URL: https://github.com/apache/incubator-nuttx/pull/5836#discussion_r834446920
##
File path: tools/minidumpserver.py
##
@@ -0,0 +1,530 @@
+#!/usr/bin/env python3
+# tools/minidumpserver.py
+#
+# Licensed to the Apache S
pkarashchenko commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r834450589
##
File path: libs/libc/misc/lib_getrandom.c
##
@@ -0,0 +1,91 @@
+/*
xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834451712
##
File path: arch/risc-v/src/common/riscv_assert.c
##
@@ -338,6 +338,10 @@ static void riscv_dumpstate(void)
else
{
riscv_
xiaoxiang781216 commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r834479860
##
File path: libs/libc/misc/lib_getrandom.c
##
@@ -0,0 +1,91 @@
+/***
xiaoxiang781216 commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r834480277
##
File path: libs/libc/misc/lib_getrandom.c
##
@@ -0,0 +1,91 @@
+/***
xiaoxiang781216 commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r834482992
##
File path: libs/libc/uuid/lib_uuid_create.c
##
@@ -42,25 +43,31 @@
void uuid_create(uuid_t *u, uint32_t *status)
{
-#ifdef CONFIG_C
xiaoxiang781216 commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r834483165
##
File path: libs/libc/uuid/lib_uuid_create.c
##
@@ -42,25 +43,31 @@
void uuid_create(uuid_t *u, uint32_t *status)
{
-#ifdef CONFIG_C
xiaoxiang781216 commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r834485253
##
File path: include/sys/random.h
##
@@ -0,0 +1,79 @@
+/
+ *
pkarashchenko commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r834489067
##
File path: libs/libc/uuid/lib_uuid_create.c
##
@@ -42,20 +43,27 @@
void uuid_create(uuid_t *u, uint32_t *status)
{
-#ifdef CONFIG_CRY
xiaoxiang781216 commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r834498581
##
File path: libs/libc/uuid/lib_uuid_create.c
##
@@ -42,20 +43,27 @@
void uuid_create(uuid_t *u, uint32_t *status)
{
-#ifdef CONFIG_C
pkarashchenko commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r834502554
##
File path: include/sys/random.h
##
@@ -0,0 +1,79 @@
+/
+ * in
pkarashchenko opened a new pull request #1088:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1088
## Summary
`passwd` compilation fails with
```
./passwd_verify.c:29:10: fatal error: passwd.h: No such file or directory
29 | #include
```
## Impact
None.
gustavonihei commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r834558642
##
File path: include/sys/random.h
##
@@ -0,0 +1,79 @@
+/
+ * inc
gustavonihei commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r834558642
##
File path: include/sys/random.h
##
@@ -0,0 +1,79 @@
+/
+ * inc
gustavonihei commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r834560415
##
File path: libs/libc/misc/lib_getrandom.c
##
@@ -0,0 +1,91 @@
+/**
pussuw commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834587806
##
File path: arch/risc-v/src/common/riscv_assert.c
##
@@ -338,6 +338,10 @@ static void riscv_dumpstate(void)
else
{
riscv_saveuserc
pussuw commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834588116
##
File path: arch/risc-v/src/mpfs/Make.defs
##
@@ -34,6 +34,14 @@ CMN_CSRCS += riscv_mdelay.c riscv_udelay.c
riscv_copyfullstate.c
CMN_CSRCS +=
xiaoxiang781216 commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r834590146
##
File path: include/sys/random.h
##
@@ -0,0 +1,79 @@
+/
+ *
xiaoxiang781216 commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r834590574
##
File path: libs/libc/misc/lib_getrandom.c
##
@@ -0,0 +1,91 @@
+/***
pussuw commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834588405
##
File path: arch/risc-v/src/common/riscv_swint.c
##
@@ -196,12 +229,14 @@ int riscv_swint(int irq, void *context, void *arg)
* save regis
xiaoxiang781216 commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r834605056
##
File path: include/sys/random.h
##
@@ -0,0 +1,79 @@
+/
+ *
xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834611239
##
File path: arch/risc-v/src/common/riscv_assert.c
##
@@ -338,6 +338,10 @@ static void riscv_dumpstate(void)
else
{
riscv_
xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834612123
##
File path: arch/risc-v/src/mpfs/Make.defs
##
@@ -34,6 +34,14 @@ CMN_CSRCS += riscv_mdelay.c riscv_udelay.c
riscv_copyfullstate.c
CMN_
pussuw commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834612920
##
File path: arch/risc-v/src/mpfs/Make.defs
##
@@ -34,6 +34,14 @@ CMN_CSRCS += riscv_mdelay.c riscv_udelay.c
riscv_copyfullstate.c
CMN_CSRCS +=
xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834614792
##
File path: arch/risc-v/include/syscall.h
##
@@ -391,6 +396,64 @@ static inline uintptr_t sys_call6(unsigned int nbr,
uintptr_t parm1,
pussuw commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834615075
##
File path: arch/risc-v/src/common/riscv_assert.c
##
@@ -338,6 +338,10 @@ static void riscv_dumpstate(void)
else
{
riscv_saveuserc
pussuw commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834617061
##
File path: arch/risc-v/include/syscall.h
##
@@ -391,6 +396,64 @@ static inline uintptr_t sys_call6(unsigned int nbr,
uintptr_t parm1,
return
xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834618522
##
File path: arch/risc-v/include/mode.h
##
@@ -0,0 +1,91 @@
+/***
pussuw commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834620526
##
File path: arch/risc-v/src/common/riscv_assert.c
##
@@ -338,6 +338,10 @@ static void riscv_dumpstate(void)
else
{
riscv_saveuserc
pussuw commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834627145
##
File path: arch/risc-v/include/mode.h
##
@@ -0,0 +1,91 @@
+/
+ * arc
xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834637806
##
File path: arch/risc-v/include/syscall.h
##
@@ -391,6 +396,64 @@ static inline uintptr_t sys_call6(unsigned int nbr,
uintptr_t parm1,
xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834638548
##
File path: arch/risc-v/src/mpfs/Make.defs
##
@@ -34,6 +34,14 @@ CMN_CSRCS += riscv_mdelay.c riscv_udelay.c
riscv_copyfullstate.c
CMN_
pussuw commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834641431
##
File path: arch/risc-v/include/syscall.h
##
@@ -391,6 +396,64 @@ static inline uintptr_t sys_call6(unsigned int nbr,
uintptr_t parm1,
return
xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834643637
##
File path: arch/risc-v/src/common/riscv_assert.c
##
@@ -338,6 +338,10 @@ static void riscv_dumpstate(void)
else
{
riscv_
xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834643637
##
File path: arch/risc-v/src/common/riscv_assert.c
##
@@ -338,6 +338,10 @@ static void riscv_dumpstate(void)
else
{
riscv_
xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834643637
##
File path: arch/risc-v/src/common/riscv_assert.c
##
@@ -338,6 +338,10 @@ static void riscv_dumpstate(void)
else
{
riscv_
pussuw commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834645556
##
File path: arch/risc-v/src/mpfs/Make.defs
##
@@ -34,6 +34,14 @@ CMN_CSRCS += riscv_mdelay.c riscv_udelay.c
riscv_copyfullstate.c
CMN_CSRCS +=
xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834647332
##
File path: arch/risc-v/include/mode.h
##
@@ -0,0 +1,91 @@
+/***
xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834649820
##
File path: arch/risc-v/src/mpfs/Make.defs
##
@@ -34,6 +34,14 @@ CMN_CSRCS += riscv_mdelay.c riscv_udelay.c
riscv_copyfullstate.c
CMN_
xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834649820
##
File path: arch/risc-v/src/mpfs/Make.defs
##
@@ -34,6 +34,14 @@ CMN_CSRCS += riscv_mdelay.c riscv_udelay.c
riscv_copyfullstate.c
CMN_
pussuw commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834651377
##
File path: arch/risc-v/include/mode.h
##
@@ -0,0 +1,91 @@
+/
+ * arc
xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834649820
##
File path: arch/risc-v/src/mpfs/Make.defs
##
@@ -34,6 +34,14 @@ CMN_CSRCS += riscv_mdelay.c riscv_udelay.c
riscv_copyfullstate.c
CMN_
xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834649820
##
File path: arch/risc-v/src/mpfs/Make.defs
##
@@ -34,6 +34,14 @@ CMN_CSRCS += riscv_mdelay.c riscv_udelay.c
riscv_copyfullstate.c
CMN_
pussuw commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834653649
##
File path: arch/risc-v/src/common/riscv_assert.c
##
@@ -338,6 +338,10 @@ static void riscv_dumpstate(void)
else
{
riscv_saveuserc
pussuw commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834653649
##
File path: arch/risc-v/src/common/riscv_assert.c
##
@@ -338,6 +338,10 @@ static void riscv_dumpstate(void)
else
{
riscv_saveuserc
pussuw commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834653649
##
File path: arch/risc-v/src/common/riscv_assert.c
##
@@ -338,6 +338,10 @@ static void riscv_dumpstate(void)
else
{
riscv_saveuserc
patacongo commented on issue #5832:
URL:
https://github.com/apache/incubator-nuttx/issues/5832#issuecomment-1078204479
> @patacongo - what is the configure line used?
It was a custom configuration based on stm3240g-evel:nsh
--
This is an automated message from the Apache Git Servi
patacongo commented on issue #5832:
URL:
https://github.com/apache/incubator-nuttx/issues/5832#issuecomment-1078208072
Also, after getting a clean build by disabling buttons and SDIO mux, the
resulting binary would not run. It hardfaulted very early.
--
This is an automated message fro
Ouss4 opened a new pull request #5838:
URL: https://github.com/apache/incubator-nuttx/pull/5838
## Summary
Some chip files where grouped with the common files variable.
## Impact
ESP32.
## Testing
All configs still build error free.
--
This is an automated message from
rtucker85 commented on a change in pull request #5835:
URL: https://github.com/apache/incubator-nuttx/pull/5835#discussion_r834786849
##
File path: include/nuttx/sdio.h
##
@@ -477,6 +477,7 @@
#define SDIO_CAPS_DMABEFOREWRITE 0x04 /* Bit 2=1: Executes DMA before write
command
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new b30a906 Publishing web
rtucker85 commented on a change in pull request #5835:
URL: https://github.com/apache/incubator-nuttx/pull/5835#discussion_r834861334
##
File path: arch/risc-v/src/litex/litex_cache.c
##
@@ -0,0 +1,76 @@
+/
lupyuen edited a comment on issue #5810:
URL:
https://github.com/apache/incubator-nuttx/issues/5810#issuecomment-1077001344
ST7789 Driver runs in Kernel Space so I don't think it can access
`/dev/gpio*`?
There is a generic LCD Driver that wraps up the ST7789 Driver as `/dev/lcd*`:
yamt commented on pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#issuecomment-1078600313
* is this meant for linux compat? why not getentropy, which is accepted by
posix?
* it seems dangerous to ignore !GRND_INSECURE.
--
This is an automated message from
PeterBee97 opened a new pull request #1089:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1089
only one .c needed for each function group
add -flax-vector-conversions to avoid build error on gcc && M55
Signed-off-by: Peter Bee
## Summary
## Impact
#
no1wudi commented on pull request #5731:
URL: https://github.com/apache/incubator-nuttx/pull/5731#issuecomment-1078604901
@xiaoxiang781216 @masayuki2009 This patch is ready to review now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
xiaoxiang781216 commented on pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#issuecomment-1078607419
> * is this meant for linux compat? why not getentropy, which is accepted by
posix?
I thought getentropy also Linux specific before. Anyway, I prefer to s
pkarashchenko commented on pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#issuecomment-1078609547
I think the good way is to support both as `getentropy` has a limitation of
no more than 256 bytes buffer length, so may be still good for uuid, but we
might avoi
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 97fa9b8 defconfig: add Lua configs for sim and teensy-4.x
add 914e958 esp32/Make.defs: Organise co
xiaoxiang781216 merged pull request #5838:
URL: https://github.com/apache/incubator-nuttx/pull/5838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
lupyuen edited a comment on issue #5810:
URL:
https://github.com/apache/incubator-nuttx/issues/5810#issuecomment-1077355494
Cool thanks! BL602 MISO / MOSI Swap is in the master branch here:
[bl602_spi.c](https://github.com/apache/incubator-nuttx/blob/master/arch/risc-v/src/bl602/bl602_spi.
anjiahao1 commented on a change in pull request #5836:
URL: https://github.com/apache/incubator-nuttx/pull/5836#discussion_r834929431
##
File path: tools/minidumpserver.py
##
@@ -0,0 +1,530 @@
+#!/usr/bin/env python3
+# tools/minidumpserver.py
+#
+# Licensed to the Apache Softw
no1wudi commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834936825
##
File path: arch/risc-v/Kconfig
##
@@ -188,6 +189,30 @@ config ARCH_MMU_TYPE_SV39
bool
default n
+config ARCH_HAVE_S_MODE
Rev
yamt commented on pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#issuecomment-1078651938
> > * is this meant for linux compat? why not getentropy, which is accepted
by posix?
>
> I thought getentropy also Linux specific before. Anyway, I prefer to
suppo
yamt commented on pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#issuecomment-1078658264
why do you replace arc4random_buf with getrandom?
it seems awkward as one of the purpose of arc4random_buf (renamed from
getrandom) was
to avoid descrptor shortag
pkarashchenko commented on a change in pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#discussion_r834959115
##
File path: libs/libc/uuid/lib_uuid_create.c
##
@@ -42,17 +43,24 @@
void uuid_create(uuid_t *u, uint32_t *status)
{
-#ifdef CONFIG_CRY
xiaoxiang781216 commented on pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#issuecomment-1078688420
> why do you replace arc4random_buf with getrandom?
One problem is that arc4random_buf couple with the random pool and only
exist when CONFIG_DEV_URANDOM_
xiaoxiang781216 edited a comment on pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#issuecomment-1078688420
> why do you replace arc4random_buf with getrandom?
One problem is that arc4random_buf couple with the random pool and only
exist when CONFIG_DEV_U
xiaoxiang781216 commented on pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#issuecomment-1078693797
BTW, from the manual:
https://www.freebsd.org/cgi/man.cgi?query=arc4random_buf&sektion=3&n=1
https://man7.org/linux/man-pages/man2/getrandom.2.html
https
xiaoxiang781216 edited a comment on pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#issuecomment-1078693797
BTW, from the manual:
https://www.freebsd.org/cgi/man.cgi?query=arc4random_buf&sektion=3&n=1
https://man7.org/linux/man-pages/man2/getrandom.2.html
xiaoxiang781216 edited a comment on pull request #5837:
URL: https://github.com/apache/incubator-nuttx/pull/5837#issuecomment-1078693797
BTW, from the manual:
https://www.freebsd.org/cgi/man.cgi?query=arc4random_buf&sektion=3&n=1
https://man7.org/linux/man-pages/man2/getrandom.2.html
1 - 100 of 101 matches
Mail list logo
