xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834649820
##########
File path: arch/risc-v/src/mpfs/Make.defs
##########
@@ -34,6 +34,14 @@ CMN_CSRCS += riscv_mdelay.c riscv_udelay.c
riscv_copyfullstate.c
CMN_CSRCS += riscv_idle.c riscv_tcbinfo.c riscv_getnewintctx.c
CMN_CSRCS += riscv_cpuindex.c
+# If the NuttX kernel runs in S-mode
+
+ifeq ($(CONFIG_ARCH_USE_S_MODE),y)
+CMN_ASRCS += riscv_exception_macros.S riscv_machine_trap.S riscv_context.S
Review comment:
> Unfortunately this will end in a compile error in the riscv_sbi
functions I think.
If it's compile/assembler error, I don't believe that adding
riscv_exception_macros.S to CMN_ASRCS can fix your problem. Please recheck your
change again.
>The defconfig is ready but it also includes CONFIG_BUILD_KERNEL=y which is
done, but I have not yet included that for review (it is a LARGE patch too!).
So, the defconfig will come later.
If so, I would suggest to split mpfs specific change to your next patch. It
doesn't make sense to bring the partial mpfs modification into this huge PR:
1. Move the common change not related to kernel mode(e.g. bug fix, typo...)
to new PR
2. Keep the arch common modification in PR
3. MPFS specific change in another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
