[GitHub] [incubator-nuttx] pussuw opened a new pull request #5753: Fix the initial idle tasks environment

2022-03-16 Thread GitBox
pussuw opened a new pull request #5753: URL: https://github.com/apache/incubator-nuttx/pull/5753 - User mode allocator was used for setting up the environment. This works in flat mode and probably in protected mode as well, as there is always a a single user allocator present -

[GitHub] [incubator-nuttx] no1wudi opened a new pull request #5754: arch/risc-v: Correct stack coloration in riscv_cpu_boot

2022-03-16 Thread GitBox
no1wudi opened a new pull request #5754: URL: https://github.com/apache/incubator-nuttx/pull/5754 ## Summary In smp system riscv_cpu_boot run in idle task so there is a overlap with the origin coloration range and in used stack. ## Impact RISC-V SMP ## Testing maix-bit:smp

[GitHub] [incubator-nuttx] anchao opened a new pull request #5755: wireless/80211: update the 80211 header

2022-03-16 Thread GitBox
anchao opened a new pull request #5755: URL: https://github.com/apache/incubator-nuttx/pull/5755 ## Summary wireless/80211: update the 80211 header Upstream from: https://github.com/torvalds/linux/blob/master/include/linux/ieee80211.h Signed-off-by: chao.an

[GitHub] [incubator-nuttx] anchao opened a new pull request #5756: sim: Enable garbage collection of unused input sections

2022-03-16 Thread GitBox
anchao opened a new pull request #5756: URL: https://github.com/apache/incubator-nuttx/pull/5756 ## Summary sim: Enable garbage collection of unused input sections LDFLAGS += -Wl,--gc-sections GC should be enabled on arch/sim/src/Makefile: ``` 326 $(if $(CONF

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5753: Fix the initial idle tasks environment

2022-03-16 Thread GitBox
pkarashchenko commented on a change in pull request #5753: URL: https://github.com/apache/incubator-nuttx/pull/5753#discussion_r827718964 ## File path: sched/group/group_realloc.c ## @@ -0,0 +1,83 @@ +/

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5756: sim: Enable garbage collection of unused input sections

2022-03-16 Thread GitBox
pkarashchenko commented on a change in pull request #5756: URL: https://github.com/apache/incubator-nuttx/pull/5756#discussion_r827720255 ## File path: boards/sim/sim/sim/scripts/Make.defs ## @@ -209,6 +209,7 @@ endif LDELFFLAGS = -r -e main --gc-sections LDELFFLAGS += -T $

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5754: arch/risc-v: Correct stack coloration in riscv_cpu_boot

2022-03-16 Thread GitBox
pkarashchenko commented on a change in pull request #5754: URL: https://github.com/apache/incubator-nuttx/pull/5754#discussion_r827721301 ## File path: arch/risc-v/src/common/riscv_createstack.c ## @@ -218,7 +218,7 @@ void riscv_stack_color(void *stackbase, size_t nbytes) ui

[GitHub] [incubator-nuttx] pussuw commented on a change in pull request #5753: Fix the initial idle tasks environment

2022-03-16 Thread GitBox
pussuw commented on a change in pull request #5753: URL: https://github.com/apache/incubator-nuttx/pull/5753#discussion_r827721932 ## File path: include/nuttx/kmalloc.h ## @@ -136,9 +141,10 @@ void group_free(FAR struct task_group_s *group, FAR void *mem); * in privileges.

[GitHub] [incubator-nuttx] pussuw commented on a change in pull request #5753: Fix the initial idle tasks environment

2022-03-16 Thread GitBox
pussuw commented on a change in pull request #5753: URL: https://github.com/apache/incubator-nuttx/pull/5753#discussion_r827722135 ## File path: sched/environ/env_setenv.c ## @@ -145,7 +145,7 @@ int setenv(FAR const char *name, FAR const char *value, int overwrite) if (grou

[GitHub] [incubator-nuttx] pussuw commented on a change in pull request #5753: Fix the initial idle tasks environment

2022-03-16 Thread GitBox
pussuw commented on a change in pull request #5753: URL: https://github.com/apache/incubator-nuttx/pull/5753#discussion_r827722281 ## File path: sched/group/group_realloc.c ## @@ -0,0 +1,83 @@ +/ + * sc

[GitHub] [incubator-nuttx] pussuw commented on a change in pull request #5753: Fix the initial idle tasks environment

2022-03-16 Thread GitBox
pussuw commented on a change in pull request #5753: URL: https://github.com/apache/incubator-nuttx/pull/5753#discussion_r827722438 ## File path: sched/init/nx_start.c ## @@ -558,7 +558,8 @@ void nx_start(void) */ group_initialize(&g_idletcb[i]); - g_idletc

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5752: arch: cxd56xx: Fix critical section in serial transmission

2022-03-16 Thread GitBox
pkarashchenko commented on a change in pull request #5752: URL: https://github.com/apache/incubator-nuttx/pull/5752#discussion_r827731503 ## File path: arch/arm/src/cxd56xx/cxd56_serial.c ## @@ -1001,9 +1001,13 @@ static void up_txint(FAR struct uart_dev_s *dev, bool enable)

[incubator-nuttx] branch master updated: boards/sim/adb: Enable CONFIG_ADBD_SOCKET_SERVICE

2022-03-16 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new bbf12f3 boards/sim/adb: Enable

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5751: boards/sim/adb: Enable CONFIG_ADBD_SOCKET_SERVICE

2022-03-16 Thread GitBox
pkarashchenko merged pull request #5751: URL: https://github.com/apache/incubator-nuttx/pull/5751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5662: arch/arm: Move ARCHCPUFLAGS to Toolchain.defs

2022-03-16 Thread GitBox
pkarashchenko commented on pull request #5662: URL: https://github.com/apache/incubator-nuttx/pull/5662#issuecomment-1068854328 @no1wudi are all necessary changes to mainline done? Can we move forward with NEON now? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-nuttx] Gary-Hobson commented on a change in pull request #5736: driver/uinput: add cross core control function

2022-03-16 Thread GitBox
Gary-Hobson commented on a change in pull request #5736: URL: https://github.com/apache/incubator-nuttx/pull/5736#discussion_r827760122 ## File path: drivers/input/keyboard_upper.c ## @@ -0,0 +1,436 @@ +/**

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5756: sim: Enable garbage collection of unused input sections

2022-03-16 Thread GitBox
anchao commented on a change in pull request #5756: URL: https://github.com/apache/incubator-nuttx/pull/5756#discussion_r827766320 ## File path: boards/sim/sim/sim/scripts/Make.defs ## @@ -209,6 +209,7 @@ endif LDELFFLAGS = -r -e main --gc-sections LDELFFLAGS += -T $(call

[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5754: arch/risc-v: Correct stack coloration in riscv_cpu_boot

2022-03-16 Thread GitBox
no1wudi commented on a change in pull request #5754: URL: https://github.com/apache/incubator-nuttx/pull/5754#discussion_r827799031 ## File path: arch/risc-v/src/common/riscv_createstack.c ## @@ -218,7 +218,7 @@ void riscv_stack_color(void *stackbase, size_t nbytes) uint32_t

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5756: sim: Enable garbage collection of unused input sections

2022-03-16 Thread GitBox
pkarashchenko commented on a change in pull request #5756: URL: https://github.com/apache/incubator-nuttx/pull/5756#discussion_r827811675 ## File path: boards/sim/sim/sim/scripts/Make.defs ## @@ -209,6 +209,7 @@ endif LDELFFLAGS = -r -e main --gc-sections LDELFFLAGS += -T $

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5756: sim: Enable garbage collection of unused input sections

2022-03-16 Thread GitBox
pkarashchenko commented on a change in pull request #5756: URL: https://github.com/apache/incubator-nuttx/pull/5756#discussion_r827838618 ## File path: boards/sim/sim/sim/scripts/Make.defs ## @@ -209,6 +209,11 @@ endif LDELFFLAGS = -r -e main --gc-sections LDELFFLAGS += -T

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1076: cmd_mkdir:support mkdir opthon -p

2022-03-16 Thread GitBox
xiaoxiang781216 commented on a change in pull request #1076: URL: https://github.com/apache/incubator-nuttx-apps/pull/1076#discussion_r827841633 ## File path: nshlib/nsh_fscmds.c ## @@ -1215,16 +1215,56 @@ int cmd_ls(FAR struct nsh_vtbl_s *vtbl, int argc, char **argv) #ifnde

[GitHub] [incubator-nuttx-apps] anjiahao1 opened a new pull request #1077: nshlib/nsh_fscmds:use strchr instead of strstr

2022-03-16 Thread GitBox
anjiahao1 opened a new pull request #1077: URL: https://github.com/apache/incubator-nuttx-apps/pull/1077 Signed-off-by: anjiahao ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #5752: arch: cxd56xx: Fix critical section in serial transmission

2022-03-16 Thread GitBox
Ouss4 commented on pull request #5752: URL: https://github.com/apache/incubator-nuttx/pull/5752#issuecomment-1068974936 We discussed this part of code before with @masayuki2009, I think that there is an `#else` missing in the logic. It should be: ```c #ifndef CONFIG_SUPPRESS_SERIAL_I

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5718: drivers/can: optimize can driver reader side

2022-03-16 Thread GitBox
pkarashchenko commented on pull request #5718: URL: https://github.com/apache/incubator-nuttx/pull/5718#issuecomment-1068977693 Changes have been verified -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5732: Zig build on NuttX

2022-03-16 Thread GitBox
pkarashchenko commented on pull request #5732: URL: https://github.com/apache/incubator-nuttx/pull/5732#issuecomment-1068979408 There are some troubles with `boards/sim/sim/sim/configs/zig/defconfig`. Please regenerate it. -- This is an automated message from the Apache Git Service. To r

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5736: driver/uinput: add cross core control function

2022-03-16 Thread GitBox
pkarashchenko commented on a change in pull request #5736: URL: https://github.com/apache/incubator-nuttx/pull/5736#discussion_r827865850 ## File path: drivers/input/keyboard_upper.c ## @@ -0,0 +1,443 @@ +/

[GitHub] [incubator-nuttx-apps] pkarashchenko opened a new pull request #1078: examples/timer: fix timer notification asignment

2022-03-16 Thread GitBox
pkarashchenko opened a new pull request #1078: URL: https://github.com/apache/incubator-nuttx-apps/pull/1078 ## Summary After https://github.com/apache/incubator-nuttx/pull/5747 the apps examples should be updated to fix `struct timer_notify_s` assignment. ## Impact Timer drive

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5752: arch: cxd56xx: Fix critical section in serial transmission

2022-03-16 Thread GitBox
masayuki2009 commented on pull request #5752: URL: https://github.com/apache/incubator-nuttx/pull/5752#issuecomment-1069008050 >We discussed this part of code before with @masayuki2009, I think that there is an #else missing in the logic. It should @Ouss4 I tried it before but a

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #5752: arch: cxd56xx: Fix critical section in serial transmission

2022-03-16 Thread GitBox
masayuki2009 commented on a change in pull request #5752: URL: https://github.com/apache/incubator-nuttx/pull/5752#discussion_r827890886 ## File path: arch/arm/src/cxd56xx/cxd56_serial.c ## @@ -1001,9 +1001,13 @@ static void up_txint(FAR struct uart_dev_s *dev, bool enable)

[GitHub] [incubator-nuttx-apps] pkarashchenko opened a new pull request #1079: definitions: unify MAX and MIN macro definitions

2022-03-16 Thread GitBox
pkarashchenko opened a new pull request #1079: URL: https://github.com/apache/incubator-nuttx-apps/pull/1079 ## Summary Unify MAX and MIN macro definitions ## Impact None ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #5752: arch: cxd56xx: Fix critical section in serial transmission

2022-03-16 Thread GitBox
Ouss4 commented on pull request #5752: URL: https://github.com/apache/incubator-nuttx/pull/5752#issuecomment-1069012395 Yes, I remember the deadlock, this is why we unlock the spinlock before calling `uart_xmitchars`: https://github.com/apache/incubator-nuttx/blob/bbf12f3b1b2a8ba272a21d

[GitHub] [incubator-nuttx] Ouss4 edited a comment on pull request #5752: arch: cxd56xx: Fix critical section in serial transmission

2022-03-16 Thread GitBox
Ouss4 edited a comment on pull request #5752: URL: https://github.com/apache/incubator-nuttx/pull/5752#issuecomment-1069012395 Yes, I remember the deadlock, this is why we unlock the spinlock before calling `uart_xmitchars`: https://github.com/apache/incubator-nuttx/blob/bbf12f3b1b2a8ba

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5752: arch: cxd56xx: Fix critical section in serial transmission

2022-03-16 Thread GitBox
pkarashchenko commented on a change in pull request #5752: URL: https://github.com/apache/incubator-nuttx/pull/5752#discussion_r827894155 ## File path: arch/arm/src/cxd56xx/cxd56_serial.c ## @@ -1001,9 +1001,13 @@ static void up_txint(FAR struct uart_dev_s *dev, bool enable)

[GitHub] [incubator-nuttx] masayuki2009 edited a comment on pull request #5752: arch: cxd56xx: Fix critical section in serial transmission

2022-03-16 Thread GitBox
masayuki2009 edited a comment on pull request #5752: URL: https://github.com/apache/incubator-nuttx/pull/5752#issuecomment-1069008050 >We discussed this part of code before with @masayuki2009, I think that there is an #else missing in the logic. It should @Ouss4 I tried it befor

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #5752: arch: cxd56xx: Fix critical section in serial transmission

2022-03-16 Thread GitBox
masayuki2009 commented on a change in pull request #5752: URL: https://github.com/apache/incubator-nuttx/pull/5752#discussion_r827895676 ## File path: arch/arm/src/cxd56xx/cxd56_serial.c ## @@ -1001,9 +1001,13 @@ static void up_txint(FAR struct uart_dev_s *dev, bool enable)

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #5752: arch: cxd56xx: Fix critical section in serial transmission

2022-03-16 Thread GitBox
masayuki2009 commented on a change in pull request #5752: URL: https://github.com/apache/incubator-nuttx/pull/5752#discussion_r827898406 ## File path: arch/arm/src/cxd56xx/cxd56_serial.c ## @@ -1001,9 +1001,13 @@ static void up_txint(FAR struct uart_dev_s *dev, bool enable)

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5752: arch: cxd56xx: Fix critical section in serial transmission

2022-03-16 Thread GitBox
masayuki2009 commented on pull request #5752: URL: https://github.com/apache/incubator-nuttx/pull/5752#issuecomment-1069019365 >If we find such corruption in SMP mode in the future, I would revert the changes. (i.e. use critical section API instead of spinlock API for cxd56_serial.c)

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #5752: arch: cxd56xx: Fix critical section in serial transmission

2022-03-16 Thread GitBox
masayuki2009 merged pull request #5752: URL: https://github.com/apache/incubator-nuttx/pull/5752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c

[incubator-nuttx] branch master updated (bbf12f3 -> c05ace5)

2022-03-16 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from bbf12f3 boards/sim/adb: Enable CONFIG_ADBD_SOCKET_SERVICE add c05ace5 arch: cxd56xx: Fix critical s

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5756: sim: Enable garbage collection of unused input sections

2022-03-16 Thread GitBox
anchao commented on a change in pull request #5756: URL: https://github.com/apache/incubator-nuttx/pull/5756#discussion_r827902685 ## File path: boards/sim/sim/sim/scripts/Make.defs ## @@ -209,6 +209,11 @@ endif LDELFFLAGS = -r -e main --gc-sections LDELFFLAGS += -T $(call

[GitHub] [incubator-nuttx] Gary-Hobson commented on a change in pull request #5736: driver/uinput: add cross core control function

2022-03-16 Thread GitBox
Gary-Hobson commented on a change in pull request #5736: URL: https://github.com/apache/incubator-nuttx/pull/5736#discussion_r827910097 ## File path: drivers/input/keyboard_upper.c ## @@ -0,0 +1,443 @@ +/**

[GitHub] [incubator-nuttx-apps] wenliangxue commented on a change in pull request #1066: Modifying the ping command

2022-03-16 Thread GitBox
wenliangxue commented on a change in pull request #1066: URL: https://github.com/apache/incubator-nuttx-apps/pull/1066#discussion_r827918790 ## File path: netutils/ping/icmpv6_ping.c ## @@ -58,11 +60,21 @@ */ static uint16_t g_ping6_id = 0; +static volatile bool exiting =

[GitHub] [incubator-nuttx-apps] wenliangxue commented on a change in pull request #1066: Modifying the ping command

2022-03-16 Thread GitBox
wenliangxue commented on a change in pull request #1066: URL: https://github.com/apache/incubator-nuttx-apps/pull/1066#discussion_r827919154 ## File path: netutils/ping/icmp_ping.c ## @@ -290,7 +310,7 @@ void icmp_ping(FAR const struct ping_info_s *info) goto do

[GitHub] [incubator-nuttx-apps] wenliangxue commented on a change in pull request #1066: Modifying the ping command

2022-03-16 Thread GitBox
wenliangxue commented on a change in pull request #1066: URL: https://github.com/apache/incubator-nuttx-apps/pull/1066#discussion_r827919869 ## File path: netutils/ping/icmpv6_ping.c ## @@ -58,11 +60,21 @@ */ static uint16_t g_ping6_id = 0; +static volatile bool exiting =

[GitHub] [incubator-nuttx-apps] wenliangxue commented on a change in pull request #1066: Modifying the ping command

2022-03-16 Thread GitBox
wenliangxue commented on a change in pull request #1066: URL: https://github.com/apache/incubator-nuttx-apps/pull/1066#discussion_r827920415 ## File path: netutils/ping/icmpv6_ping.c ## @@ -289,7 +309,7 @@ void icmp6_ping(FAR const struct ping6_info_s *info) got

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #1066: Modifying the ping command

2022-03-16 Thread GitBox
pkarashchenko commented on a change in pull request #1066: URL: https://github.com/apache/incubator-nuttx-apps/pull/1066#discussion_r827932933 ## File path: system/ping/ping.c ## @@ -217,8 +238,25 @@ static void ping_result(FAR const struct ping_result_s *result)

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1077: nshlib/nsh_fscmds:use strchr instead of strstr

2022-03-16 Thread GitBox
xiaoxiang781216 merged pull request #1077: URL: https://github.com/apache/incubator-nuttx-apps/pull/1077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[incubator-nuttx-apps] branch master updated: nshlib/nsh_fscmds:use strchr instead of strstr

2022-03-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 7d10751 nshlib/nsh_fscmds:use

[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request #5757: drivers/mtd/filemtd: fix compilation warnings

2022-03-16 Thread GitBox
pkarashchenko opened a new pull request #5757: URL: https://github.com/apache/incubator-nuttx/pull/5757 ## Summary Fix compilation warnings ## Impact None ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5754: arch/risc-v: Correct stack coloration in riscv_cpu_boot

2022-03-16 Thread GitBox
pkarashchenko merged pull request #5754: URL: https://github.com/apache/incubator-nuttx/pull/5754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-nuttx] branch master updated (c05ace5 -> 9cc0a60)

2022-03-16 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from c05ace5 arch: cxd56xx: Fix critical section in serial transmission add 9cc0a60 arch/risc-v: Co

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5753: Fix the initial idle tasks environment

2022-03-16 Thread GitBox
xiaoxiang781216 merged pull request #5753: URL: https://github.com/apache/incubator-nuttx/pull/5753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5736: driver/uinput: add cross core control function

2022-03-16 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5736: URL: https://github.com/apache/incubator-nuttx/pull/5736#discussion_r827948439 ## File path: drivers/input/Kconfig ## @@ -41,6 +41,14 @@ config INPUT_UINPUT ---help--- Enable support virtual in

[incubator-nuttx] branch master updated (9cc0a60 -> 50578dc)

2022-03-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 9cc0a60 arch/risc-v: Correct stack coloration in riscv_cpu_boot add 50578dc Fix the initial idle t

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5736: driver/uinput: add cross core control function

2022-03-16 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5736: URL: https://github.com/apache/incubator-nuttx/pull/5736#discussion_r827954509 ## File path: drivers/input/touchscreen_upper.c ## @@ -105,28 +101,25 @@ static const struct file_operations g_touch_fops = * Private Fu

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5736: driver/uinput: add cross core control function

2022-03-16 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5736: URL: https://github.com/apache/incubator-nuttx/pull/5736#discussion_r827957763 ## File path: drivers/input/touchscreen_upper.c ## @@ -366,34 +350,40 @@ static int touch_poll(FAR struct file *filep, void touch_event(F

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5736: driver/uinput: add cross core control function

2022-03-16 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5736: URL: https://github.com/apache/incubator-nuttx/pull/5736#discussion_r827969956 ## File path: drivers/input/keyboard_upper.c ## @@ -0,0 +1,444 @@ +/**

[GitHub] [incubator-nuttx] pussuw opened a new pull request #5758: Prepare CONFIG_BUILD_KERNEL part 1

2022-03-16 Thread GitBox
pussuw opened a new pull request #5758: URL: https://github.com/apache/incubator-nuttx/pull/5758 ## Summary This is preparation for enabling CONFIG_BUILD_KERNEL=y for RISC-V / MPFS target in supervisor mode and MMU enabled for user and kernel. ## Impact Adds a bit of abstractio

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5732: Zig build on NuttX

2022-03-16 Thread GitBox
xiaoxiang781216 commented on pull request #5732: URL: https://github.com/apache/incubator-nuttx/pull/5732#issuecomment-1069094542 > There are some troubles with `boards/sim/sim/sim/configs/zig/defconfig`. Please regenerate it. @kassane you can run "./tools/refresh.sh --silent sim:zig

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1067: Add dhcp6c module

2022-03-16 Thread GitBox
xiaoxiang781216 commented on a change in pull request #1067: URL: https://github.com/apache/incubator-nuttx-apps/pull/1067#discussion_r827976743 ## File path: netutils/dhcp6c/dhcp6c.c ## @@ -0,0 +1,1951 @@ +/*

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5736: driver/uinput: add cross core control function

2022-03-16 Thread GitBox
pkarashchenko commented on a change in pull request #5736: URL: https://github.com/apache/incubator-nuttx/pull/5736#discussion_r827980043 ## File path: drivers/input/touchscreen_upper.c ## @@ -105,28 +101,25 @@ static const struct file_operations g_touch_fops = * Private Func

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #1067: Add dhcp6c module

2022-03-16 Thread GitBox
pkarashchenko commented on a change in pull request #1067: URL: https://github.com/apache/incubator-nuttx-apps/pull/1067#discussion_r827981718 ## File path: netutils/dhcp6c/dhcp6c.c ## @@ -0,0 +1,1951 @@ +/***

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5736: driver/uinput: add cross core control function

2022-03-16 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5736: URL: https://github.com/apache/incubator-nuttx/pull/5736#discussion_r827990574 ## File path: drivers/input/touchscreen_upper.c ## @@ -105,28 +101,25 @@ static const struct file_operations g_touch_fops = * Private Fu

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1067: Add dhcp6c module

2022-03-16 Thread GitBox
xiaoxiang781216 commented on a change in pull request #1067: URL: https://github.com/apache/incubator-nuttx-apps/pull/1067#discussion_r827995497 ## File path: netutils/dhcp6c/dhcp6c.c ## @@ -0,0 +1,1951 @@ +/*

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5756: sim: Enable garbage collection of unused input sections

2022-03-16 Thread GitBox
pkarashchenko merged pull request #5756: URL: https://github.com/apache/incubator-nuttx/pull/5756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-nuttx] branch master updated (50578dc -> 7a27b58)

2022-03-16 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 50578dc Fix the initial idle tasks environment add 7a27b58 sim: Enable garbage collection of u

[GitHub] [incubator-nuttx-apps] davids5 commented on a change in pull request #1066: Modifying the ping command

2022-03-16 Thread GitBox
davids5 commented on a change in pull request #1066: URL: https://github.com/apache/incubator-nuttx-apps/pull/1066#discussion_r828033810 ## File path: system/ping/ping.c ## @@ -131,21 +139,21 @@ static void ping_result(FAR const struct ping_result_s *result) break;

[GitHub] [incubator-nuttx-apps] davids5 commented on a change in pull request #1066: Modifying the ping command

2022-03-16 Thread GitBox
davids5 commented on a change in pull request #1066: URL: https://github.com/apache/incubator-nuttx-apps/pull/1066#discussion_r828029803 ## File path: netutils/ping/icmpv6_ping.c ## @@ -57,12 +59,22 @@ * separate instance of g_ping6_id in every process space. */ -static

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5755: wireless/80211: update the 80211 header

2022-03-16 Thread GitBox
anchao commented on a change in pull request #5755: URL: https://github.com/apache/incubator-nuttx/pull/5755#discussion_r828038914 ## File path: include/nuttx/wireless/ieee80211/ieee80211.h ## @@ -42,849 +42,4026 @@ * Pre-processor Definitions **

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5755: wireless/80211: update the 80211 header

2022-03-16 Thread GitBox
anchao commented on a change in pull request #5755: URL: https://github.com/apache/incubator-nuttx/pull/5755#discussion_r828041957 ## File path: include/nuttx/wireless/ieee80211/ieee80211.h ## @@ -42,849 +42,4026 @@ * Pre-processor Definitions **

[GitHub] [incubator-nuttx] kassane commented on pull request #5732: Zig build on NuttX

2022-03-16 Thread GitBox
kassane commented on pull request #5732: URL: https://github.com/apache/incubator-nuttx/pull/5732#issuecomment-1069188579 cc: @pkarashchenko @xiaoxiang781216 I try: ```bash $> ./tools/refresh.sh --silent sim:zig && git status Normalize sim:zig On branch zig-build

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5732: Zig build on NuttX

2022-03-16 Thread GitBox
xiaoxiang781216 commented on pull request #5732: URL: https://github.com/apache/incubator-nuttx/pull/5732#issuecomment-1069195958 Look like the CI doesn't get the last change from apps git, let retrigger CI again. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx-apps] kassane opened a new pull request #1080: Zig: Application.mk fix

2022-03-16 Thread GitBox
kassane opened a new pull request #1080: URL: https://github.com/apache/incubator-nuttx-apps/pull/1080 ## Summary Ref.: #1059 ## Impact Fix ## Testing ArchLinux Simulation -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-nuttx] kassane commented on pull request #5732: Zig build on NuttX

2022-03-16 Thread GitBox
kassane commented on pull request #5732: URL: https://github.com/apache/incubator-nuttx/pull/5732#issuecomment-1069210050 I found some errors in app rules: - https://github.com/apache/incubator-nuttx-apps/pull/1080 -- This is an automated message from the Apache Git Service. To res

[incubator-nuttx] branch master updated (7a27b58 -> 18dd5f1)

2022-03-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 7a27b58 sim: Enable garbage collection of unused input sections add 18dd5f1 drivers/mtd/filemtd: f

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5757: drivers/mtd/filemtd: fix compilation warnings

2022-03-16 Thread GitBox
xiaoxiang781216 merged pull request #5757: URL: https://github.com/apache/incubator-nuttx/pull/5757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[incubator-nuttx-apps] branch master updated (b207387 -> 566be8c)

2022-03-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from b207387 examples/timer: fix timer notification asignment add 566be8c definitions: unify MAX a

[incubator-nuttx-apps] branch master updated (7d10751 -> b207387)

2022-03-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from 7d10751 nshlib/nsh_fscmds:use strchr instead of strstr add b207387 examples/timer: fix timer

[GitHub] [incubator-nuttx] jrosberg commented on a change in pull request #5740: Add ethernet support for risc-v/MPFS

2022-03-16 Thread GitBox
jrosberg commented on a change in pull request #5740: URL: https://github.com/apache/incubator-nuttx/pull/5740#discussion_r828121831 ## File path: arch/risc-v/src/mpfs/mpfs_ethernet.c ## @@ -0,0 +1,3860 @@ +/**

[GitHub] [incubator-nuttx] jrosberg commented on a change in pull request #5740: Add ethernet support for risc-v/MPFS

2022-03-16 Thread GitBox
jrosberg commented on a change in pull request #5740: URL: https://github.com/apache/incubator-nuttx/pull/5740#discussion_r828122019 ## File path: arch/risc-v/src/mpfs/mpfs_ethernet.c ## @@ -0,0 +1,3860 @@ +/**

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5758: RISC-V: Prepare CONFIG_BUILD_KERNEL part 1

2022-03-16 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5758: URL: https://github.com/apache/incubator-nuttx/pull/5758#discussion_r828129549 ## File path: arch/risc-v/src/common/riscv_schedulesigaction.c ## @@ -138,7 +138,7 @@ void up_schedule_sigaction(struct tcb_s *tcb, sig_de

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5758: RISC-V: Prepare CONFIG_BUILD_KERNEL part 1

2022-03-16 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5758: URL: https://github.com/apache/incubator-nuttx/pull/5758#discussion_r828131532 ## File path: arch/risc-v/src/mpfs/mpfs_irq.c ## @@ -107,7 +107,7 @@ void up_irqinitialize(void) irq_attach(RISCV_IRQ_ECALLM, riscv_s

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5758: RISC-V: Prepare CONFIG_BUILD_KERNEL part 1

2022-03-16 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5758: URL: https://github.com/apache/incubator-nuttx/pull/5758#discussion_r828127043 ## File path: arch/risc-v/src/common/riscv_internal.h ## @@ -253,6 +253,19 @@ void riscv_cpu_boot(int cpu); int riscv_pause_handler(int i

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5758: RISC-V: Prepare CONFIG_BUILD_KERNEL part 1

2022-03-16 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5758: URL: https://github.com/apache/incubator-nuttx/pull/5758#discussion_r828129621 ## File path: arch/risc-v/src/common/riscv_schedulesigaction.c ## @@ -303,7 +303,7 @@ void up_schedule_sigaction(struct tcb_s *tcb, sig_de

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5758: RISC-V: Prepare CONFIG_BUILD_KERNEL part 1

2022-03-16 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5758: URL: https://github.com/apache/incubator-nuttx/pull/5758#discussion_r828129096 ## File path: arch/risc-v/include/irq.h ## @@ -471,7 +471,7 @@ struct xcpt_syscall_s { uintptr_t sysreturn; /* The return PC */ -#i

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1078: examples/timer: fix timer notification asignment

2022-03-16 Thread GitBox
xiaoxiang781216 merged pull request #1078: URL: https://github.com/apache/incubator-nuttx-apps/pull/1078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1079: definitions: unify MAX and MIN macro definitions

2022-03-16 Thread GitBox
xiaoxiang781216 merged pull request #1079: URL: https://github.com/apache/incubator-nuttx-apps/pull/1079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5758: RISC-V: Prepare CONFIG_BUILD_KERNEL part 1

2022-03-16 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5758: URL: https://github.com/apache/incubator-nuttx/pull/5758#discussion_r828131060 ## File path: arch/risc-v/src/mpfs/mpfs_allocateheap.c ## @@ -75,7 +75,7 @@ * Kernel heap Size determined by CONFIG_MM_K

[GitHub] [incubator-nuttx] jrosberg commented on a change in pull request #5740: Add ethernet support for risc-v/MPFS

2022-03-16 Thread GitBox
jrosberg commented on a change in pull request #5740: URL: https://github.com/apache/incubator-nuttx/pull/5740#discussion_r828169342 ## File path: arch/risc-v/src/mpfs/hardware/mpfs_ethernet.h ## @@ -0,0 +1,701 @@ +/**

[GitHub] [incubator-nuttx] jrosberg commented on a change in pull request #5740: Add ethernet support for risc-v/MPFS

2022-03-16 Thread GitBox
jrosberg commented on a change in pull request #5740: URL: https://github.com/apache/incubator-nuttx/pull/5740#discussion_r828169553 ## File path: arch/risc-v/src/mpfs/hardware/mpfs_ethernet.h ## @@ -0,0 +1,701 @@ +/**

[incubator-nuttx-apps] branch master updated: Update Application.mk

2022-03-16 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 2796187 Update Application

[incubator-nuttx] branch master updated (18dd5f1 -> 6ad06b0)

2022-03-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 18dd5f1 drivers/mtd/filemtd: fix compilation warnings add 6ad06b0 [docs] eliminate potential misun

[incubator-nuttx] branch master updated (6ad06b0 -> 4880613)

2022-03-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 6ad06b0 [docs] eliminate potential misunderstandings add 4880613 zig-build added No new revisions

[GitHub] [incubator-nuttx] mysterywolf opened a new pull request #5759: [docs] eliminate potential misunderstandings

2022-03-16 Thread GitBox
mysterywolf opened a new pull request #5759: URL: https://github.com/apache/incubator-nuttx/pull/5759 ## Summary There are two folders called "nuttx", which makes people confusion a little bit. revise from `nuttx/nuttx` to `nuttxspace/nuttx` ## Impact ## Testing

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #1067: Add dhcp6c module

2022-03-16 Thread GitBox
pkarashchenko commented on a change in pull request #1067: URL: https://github.com/apache/incubator-nuttx-apps/pull/1067#discussion_r828292077 ## File path: netutils/dhcp6c/dhcp6c.c ## @@ -0,0 +1,1951 @@ +/***

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5732: Zig build on NuttX

2022-03-16 Thread GitBox
xiaoxiang781216 merged pull request #5732: URL: https://github.com/apache/incubator-nuttx/pull/5732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1080: Zig: Application.mk fix

2022-03-16 Thread GitBox
pkarashchenko merged pull request #1080: URL: https://github.com/apache/incubator-nuttx-apps/pull/1080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5759: [docs] eliminate potential misunderstandings

2022-03-16 Thread GitBox
xiaoxiang781216 commented on pull request #5759: URL: https://github.com/apache/incubator-nuttx/pull/5759#issuecomment-1069402721 @mysterywolf nice to see you start the contribution to NuttX:) -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-nuttx] gustavonihei opened a new pull request #5760: ESP32-S3: Fix UART IRQ setup hardcoded to CPU 0

2022-03-16 Thread GitBox
gustavonihei opened a new pull request #5760: URL: https://github.com/apache/incubator-nuttx/pull/5760 ## Summary This PR intends to fix a mistake in the setup process for the UART IRQ, which is hardcoded to CPU0. Also, some it applies other fixes and removes deactivated code due

[GitHub] [incubator-nuttx-apps] mogenson commented on a change in pull request #1075: add Lua interpreter

2022-03-16 Thread GitBox
mogenson commented on a change in pull request #1075: URL: https://github.com/apache/incubator-nuttx-apps/pull/1075#discussion_r828320722 ## File path: interpreters/lua/Makefile ## @@ -0,0 +1,133 @@ +

  1   2   >