Ouss4 commented on pull request #5752:
URL: https://github.com/apache/incubator-nuttx/pull/5752#issuecomment-1068974936
We discussed this part of code before with @masayuki2009, I think that there
is an `#else` missing in the logic. It should be:
```c
#ifndef CONFIG_SUPPRESS_SERIAL_INTS
priv->ier |= UART_INTR_TX;
up_serialout(priv, CXD56_UART_IMSC, priv->ier);
#else
/* Fake a TX interrupt here by just calling uart_xmitchars() with
* interrupts disabled (note this may recurse).
*/
spin_unlock_irqrestore(&priv->lock, flags);
uart_xmitchars(dev);
flags = spin_lock_irqsave(&priv->lock);
#endif
```
We fixed it in some chips (ESP32 and STM32), but for CXD56 I think he got
some issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
