coffee809721232 opened a new pull request #958:
URL: https://github.com/apache/incubator-nuttx-apps/pull/958
## Summary
netutils/dhcpc: Fix dhcpc lease bug
Signed-off-by: songlinzhang songlinzh...@xiaomi.com
## Impact
dhcpc lease management
## Testing
call dhcpc_request
xiaoxiang781216 commented on a change in pull request #4881:
URL: https://github.com/apache/incubator-nuttx/pull/4881#discussion_r778614713
##
File path: drivers/video/vnc/vnc_keymap.c
##
@@ -29,13 +29,8 @@
#include
#include
-
-#define XK_MISCELLANY 1 /* Select X11 charac
xiaoxiang781216 commented on a change in pull request #4881:
URL: https://github.com/apache/incubator-nuttx/pull/4881#discussion_r778614713
##
File path: drivers/video/vnc/vnc_keymap.c
##
@@ -29,13 +29,8 @@
#include
#include
-
-#define XK_MISCELLANY 1 /* Select X11 charac
xiaoxiang781216 commented on a change in pull request #958:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/958#discussion_r778620373
##
File path: netutils/dhcpc/dhcpc.c
##
@@ -458,6 +458,7 @@ static void *dhcpc_run(void *args)
struct dhcpc_state result;
int re
coffee809721232 commented on a change in pull request #958:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/958#discussion_r778622368
##
File path: netutils/dhcpc/dhcpc.c
##
@@ -458,6 +458,7 @@ static void *dhcpc_run(void *args)
struct dhcpc_state result;
int re
coffee809721232 commented on pull request #904:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/904#issuecomment-1005475381
> Was there a plan to update `netinit_net_bringup` to use
`dhcpc_request_async`? and/or add some built-in commands like `ntpc` has to
start/stop a dhcpc dae
coffee809721232 edited a comment on pull request #904:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/904#issuecomment-1005475381
> Was there a plan to update `netinit_net_bringup` to use
`dhcpc_request_async`? and/or add some built-in commands like `ntpc` has to
start/stop a dh
xiaoxiang781216 commented on a change in pull request #958:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/958#discussion_r778628718
##
File path: netutils/dhcpc/dhcpc.c
##
@@ -458,6 +458,7 @@ static void *dhcpc_run(void *args)
struct dhcpc_state result;
int re
anchao opened a new pull request #959:
URL: https://github.com/apache/incubator-nuttx-apps/pull/959
## Summary
wireless/gs2200m: replace the preamble scratch to union
## Impact
fix the preamble scratch buffer issue
## Testing
N/A, I do not have the wifi mo
xiaoxiang781216 commented on a change in pull request #958:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/958#discussion_r778629324
##
File path: netutils/dhcpc/dhcpc.c
##
@@ -458,6 +458,7 @@ static void *dhcpc_run(void *args)
struct dhcpc_state result;
int re
xiaoxiang781216 commented on pull request #959:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/959#issuecomment-1005480661
@masayuki2009 could you try the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
anchao commented on pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#issuecomment-1005480711
> @xiaoxiang781216 @anchao Yes, I use the latest apps but the renew command
still does not work with gs2200m daemon.
@masayuki2009 san, could you please to try thi
anchao edited a comment on pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#issuecomment-1005480711
> @xiaoxiang781216 @anchao Yes, I use the latest apps but the renew command
still does not work with gs2200m daemon.
@masayuki2009 san, could you please to
coffee809721232 commented on a change in pull request #958:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/958#discussion_r778636018
##
File path: netutils/dhcpc/dhcpc.c
##
@@ -458,6 +458,7 @@ static void *dhcpc_run(void *args)
struct dhcpc_state result;
int re
masayuki2009 commented on a change in pull request #959:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/959#discussion_r778640247
##
File path: wireless/gs2200m/gs2200m_main.c
##
@@ -389,17 +406,17 @@ static int usrsock_request(int fd, FAR struct gs2200m_s
*priv)
raiden00pl opened a new pull request #5166:
URL: https://github.com/apache/incubator-nuttx/pull/5166
## Summary
boards/nucleo-f446re: add procfs support
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
anchao commented on a change in pull request #959:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/959#discussion_r778644757
##
File path: wireless/gs2200m/gs2200m_main.c
##
@@ -389,17 +406,17 @@ static int usrsock_request(int fd, FAR struct gs2200m_s
*priv)
r
raiden00pl opened a new pull request #5167:
URL: https://github.com/apache/incubator-nuttx/pull/5167
## Summary
stm32: add CAN error support.
RX/TX buffer overflow errors not supported yet
## Impact
## Testing
nucleo-f302r8 and nucleo-f446re
--
This is an automa
xiaoxiang781216 commented on pull request #5163:
URL: https://github.com/apache/incubator-nuttx/pull/5163#issuecomment-1005506757
@Ouss4 do you think the rename is good to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
raiden00pl opened a new pull request #5168:
URL: https://github.com/apache/incubator-nuttx/pull/5168
## Summary
SocketCAN: add CAN error definitions
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
masayuki2009 commented on a change in pull request #959:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/959#discussion_r778658794
##
File path: wireless/gs2200m/gs2200m_main.c
##
@@ -389,17 +406,17 @@ static int usrsock_request(int fd, FAR struct gs2200m_s
*priv)
masayuki2009 commented on pull request #957:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/957#issuecomment-1005523807
@Donny9
The latest commit reduces the stack size.
Thanks for the fix.
```
1414 100 RR Task--- Waiting Signal 0
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git.
from b9a6dc2 netutils/netcat: implemented NETUTILS_NETCAT_SENDFILE option.
This option enables using sen
masayuki2009 merged pull request #957:
URL: https://github.com/apache/incubator-nuttx-apps/pull/957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
Ouss4 commented on a change in pull request #5164:
URL: https://github.com/apache/incubator-nuttx/pull/5164#discussion_r778687313
##
File path: tools/testbuild.sh
##
@@ -258,6 +258,10 @@ function build {
fail=1
fi
+ # Verify that the context rule does not need to be
Donny9 opened a new pull request #960:
URL: https://github.com/apache/incubator-nuttx-apps/pull/960
## Summary
ostest: fix assert when enable CONFIG_PRIORITY_INHERITANCE
[ 96.555456] [265] ap: up_assert: Assertion failed at
file:semaphore/sem_holder.c line: 112 task: pt-0x5b09
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git.
from 64ffdb4 ntpc: optimize stack used
add a1857b9 wireless/gs2200m: replace the preamble scratch t
masayuki2009 merged pull request #959:
URL: https://github.com/apache/incubator-nuttx-apps/pull/959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
xiaoxiang781216 commented on a change in pull request #5164:
URL: https://github.com/apache/incubator-nuttx/pull/5164#discussion_r778700904
##
File path: tools/testbuild.sh
##
@@ -258,6 +258,10 @@ function build {
fail=1
fi
+ # Verify that the context rule does not n
xiaoxiang781216 commented on pull request #5070:
URL: https://github.com/apache/incubator-nuttx/pull/5070#issuecomment-100900
Here is a case: https://github.com/apache/incubator-nuttx-apps/pull/960
--
This is an automated message from the Apache Git Service.
To respond to the message,
xiaoxiang781216 edited a comment on pull request #5070:
URL: https://github.com/apache/incubator-nuttx/pull/5070#issuecomment-100900
Here is a real case: https://github.com/apache/incubator-nuttx-apps/pull/960
--
This is an automated message from the Apache Git Service.
To respond to
xiaoxiang781216 merged pull request #958:
URL: https://github.com/apache/incubator-nuttx-apps/pull/958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git.
from a1857b9 wireless/gs2200m: replace the preamble scratch to union
add 04dd2d7 netutils/dhcpc: F
xiaoxiang781216 merged pull request #5166:
URL: https://github.com/apache/incubator-nuttx/pull/5166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 474205e boards/nucleo-f446re: add p
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit a8ca1ec026b4d61003f7d4ed3ea8d2f868f01b56
Author: raiden00pl
AuthorDate: Wed Jan 5 10:11:16 2022 +0100
S
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 474205e boards/nucleo-f446re: add procfs support
new 09ae157 include/nuttx/can/can.h: fix typo
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 09ae15755e3c34167ba4930861cae0568fec3d60
Author: raiden00pl
AuthorDate: Wed Jan 5 10:10:20 2022 +0100
i
xiaoxiang781216 merged pull request #5168:
URL: https://github.com/apache/incubator-nuttx/pull/5168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 5b9b381 stm32: add CAN error suppor
xiaoxiang781216 merged pull request #5163:
URL: https://github.com/apache/incubator-nuttx/pull/5163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new f4d74b5 Rename `tools/Makefile.*` t
raiden00pl opened a new pull request #5169:
URL: https://github.com/apache/incubator-nuttx/pull/5169
## Summary
- stm32: add SocketCAN support, based on stm32_can.c
- boards/stm32: register CAN character device if configured
## Impact
## Testing
nucleo-f302r8 and n
xiaoxiang781216 merged pull request #5167:
URL: https://github.com/apache/incubator-nuttx/pull/5167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
anjiahao1 opened a new pull request #5170:
URL: https://github.com/apache/incubator-nuttx/pull/5170
barrier is used protect resources. don't lock
Signed-off-by: anjiahao
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Se
Ouss4 commented on a change in pull request #5164:
URL: https://github.com/apache/incubator-nuttx/pull/5164#discussion_r778719017
##
File path: tools/testbuild.sh
##
@@ -258,6 +258,10 @@ function build {
fail=1
fi
+ # Verify that the context rule does not need to be
xiaoxiang781216 commented on pull request #5070:
URL: https://github.com/apache/incubator-nuttx/pull/5070#issuecomment-1005603855
Another real case: https://github.com/apache/incubator-nuttx/pull/5170, both
case will generate hard fault.
--
This is an automated message from the Apache Gi
xiaoxiang781216 commented on a change in pull request #5164:
URL: https://github.com/apache/incubator-nuttx/pull/5164#discussion_r778746479
##
File path: tools/testbuild.sh
##
@@ -258,6 +258,10 @@ function build {
fail=1
fi
+ # Verify that the context rule does not n
zhaoxiu-zeng opened a new pull request #5171:
URL: https://github.com/apache/incubator-nuttx/pull/5171
Add a list in TCB to track all semphores the task held, so we
can release all holders when exit, so nxsched_verify_tcb
is unnecessary.
Signed-off-by: Zeng Zhaoxiu
## Su
zhaoxiu-zeng commented on pull request #5070:
URL: https://github.com/apache/incubator-nuttx/pull/5070#issuecomment-1005610175
>
I have pushed the modificaiton, let's discuss in the PR.
https://github.com/apache/incubator-nuttx/pull/5171
--
This is an automated message fro
zhaoxiu-zeng removed a comment on pull request #5070:
URL: https://github.com/apache/incubator-nuttx/pull/5070#issuecomment-1005610175
>
I have pushed the modificaiton, let's discuss in the PR.
https://github.com/apache/incubator-nuttx/pull/5171
--
This is an automated mes
zhaoxiu-zeng commented on pull request #5070:
URL: https://github.com/apache/incubator-nuttx/pull/5070#issuecomment-1005614899
@pkarashchenko I have push the modification, let's discuss in the PR.
https://github.com/apache/incubator-nuttx/pull/5171
--
This is an automated message f
zhaoxiu-zeng commented on pull request #5070:
URL: https://github.com/apache/incubator-nuttx/pull/5070#issuecomment-1005623759
> Another real case: #5170, both case will generate hard fault.
I run ostest with https://github.com/apache/incubator-nuttx/pull/5171, no
such assertions wer
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git.
from 04dd2d7 netutils/dhcpc: Fix dhcpc lease bug
add 4a14126 ostest: fix assert when enable CONFIG
xiaoxiang781216 merged pull request #960:
URL: https://github.com/apache/incubator-nuttx-apps/pull/960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from f4d74b5 Rename `tools/Makefile.*` to have the `.mk` extension
add 9aa6916 libc/pthread:pthread_bar
xiaoxiang781216 merged pull request #5170:
URL: https://github.com/apache/incubator-nuttx/pull/5170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
xiaoxiang781216 commented on pull request #4530:
URL: https://github.com/apache/incubator-nuttx/pull/4530#issuecomment-1005643227
@Ouss4 and @gustavonihei could you help review this simple PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
masayuki2009 commented on pull request #955:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/955#issuecomment-1005647806
>@masayuki2009 cloud you try this patch with/without
apache/incubator-nuttx#5120?
I tried this PR with sabre-6quad:smp (QEMU) and confirmed that
apache/
masayuki2009 edited a comment on pull request #955:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/955#issuecomment-1005647806
>@masayuki2009 cloud you try this patch with/without
apache/incubator-nuttx#5120?
I tried this PR with sabre-6quad:smp (QEMU) and confirmed that
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 614b73d ostest: sighand.c: add
masayuki2009 merged pull request #955:
URL: https://github.com/apache/incubator-nuttx-apps/pull/955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
masayuki2009 merged pull request #5120:
URL: https://github.com/apache/incubator-nuttx/pull/5120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new fb43fd7 signal: signal handler may c
Donny9 opened a new pull request #5172:
URL: https://github.com/apache/incubator-nuttx/pull/5172
## Summary
fs/procfs: fix readdir loss last character
nsh> ls
/proc:
0/
1/
2/
3/
4/
5/
meminf
iobinf
f/
ne/
sel/
uptim
ver
gustavonihei opened a new pull request #5173:
URL: https://github.com/apache/incubator-nuttx/pull/5173
## Summary
This PR intends to fix two build system issues related to the recently added
feature of **Flash Encryption** on Espressif chips.
Commit 23dec090 prevents the build system
gustavonihei commented on a change in pull request #4530:
URL: https://github.com/apache/incubator-nuttx/pull/4530#discussion_r778802563
##
File path: include/nuttx/mmcsd.h
##
@@ -27,6 +27,47 @@
#include
+#include
+#include
+
+/**
gustavonihei commented on a change in pull request #4530:
URL: https://github.com/apache/incubator-nuttx/pull/4530#discussion_r778802563
##
File path: include/nuttx/mmcsd.h
##
@@ -27,6 +27,47 @@
#include
+#include
+#include
+
+/**
xiaoxiang781216 commented on a change in pull request #4530:
URL: https://github.com/apache/incubator-nuttx/pull/4530#discussion_r778835894
##
File path: include/nuttx/mmcsd.h
##
@@ -27,6 +27,47 @@
#include
+#include
+#include
+
+/***
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new f93c17b fs/procfs: fix readdir loss
xiaoxiang781216 merged pull request #5172:
URL: https://github.com/apache/incubator-nuttx/pull/5172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
anchao commented on pull request #4575:
URL: https://github.com/apache/incubator-nuttx/pull/4575#issuecomment-1005709861
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
This is an automated email from the ASF dual-hosted git repository.
archer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new e27962a net/devif: Fix the memory leak
anchao merged pull request #4575:
URL: https://github.com/apache/incubator-nuttx/pull/4575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits
davids5 merged pull request #5169:
URL: https://github.com/apache/incubator-nuttx/pull/5169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commit
This is an automated email from the ASF dual-hosted git repository.
davids5 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 6fe95d831499a6c907261394023c242651b65116
Author: raiden00pl
AuthorDate: Wed Jan 5 10:28:47 2022 +0100
stm
This is an automated email from the ASF dual-hosted git repository.
davids5 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit a983cd23777fb4596a140a15375012874e81c9a0
Author: raiden00pl
AuthorDate: Wed Jan 5 10:47:05 2022 +0100
boa
This is an automated email from the ASF dual-hosted git repository.
davids5 pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from e27962a net/devif: Fix the memory leak in case of netdev isn't alive
new 6fe95d8 stm32: add SocketCA
gustavonihei opened a new pull request #5174:
URL: https://github.com/apache/incubator-nuttx/pull/5174
## Summary
This PR intends to fix an issue with parallel build due to missing
dependency on the `include/arch/chip:` Make rule.
```bash
$ ./tools/configure.sh esp32-wrover-ki
gustavonihei commented on pull request #5174:
URL: https://github.com/apache/incubator-nuttx/pull/5174#issuecomment-1005724272
@AlanRosenthal PTAL, we've identified this issue in our internal CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
gustavonihei commented on a change in pull request #4530:
URL: https://github.com/apache/incubator-nuttx/pull/4530#discussion_r778855651
##
File path: include/nuttx/mmcsd.h
##
@@ -27,6 +27,47 @@
#include
+#include
+#include
+
+/**
This is an automated email from the ASF dual-hosted git repository.
gustavonihei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new fb92621 drivers/mmcsd: Add RPMB
gustavonihei merged pull request #4530:
URL: https://github.com/apache/incubator-nuttx/pull/4530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c
xiaoxiang781216 opened a new pull request #5175:
URL: https://github.com/apache/incubator-nuttx/pull/5175
## Summary
- input: Remove prompt string from INPUT_MOUSE
- usbhost: Fix typo error in Kconfig(MOUSE->INPUT_MOUSE)
## Impact
Minor
## Testing
Pass CI
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 6053de2 tools: Fix parallel build i
xiaoxiang781216 merged pull request #5174:
URL: https://github.com/apache/incubator-nuttx/pull/5174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
fjpanag opened a new pull request #961:
URL: https://github.com/apache/incubator-nuttx-apps/pull/961
## Summary
Several typo fixes, as indicated by
[typos](https://github.com/crate-ci/typos).
## Impact
There shouldn't be any functional change.
Mostly comments and d
davids5 commented on a change in pull request #961:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/961#discussion_r778926842
##
File path: fsutils/mkfatfs/Kconfig
##
@@ -11,7 +11,7 @@ config FSUTILS_MKFATFS
---help---
Enables support for the m
pkarashchenko commented on a change in pull request #5175:
URL: https://github.com/apache/incubator-nuttx/pull/5175#discussion_r778951401
##
File path: drivers/input/Kconfig
##
@@ -14,7 +14,7 @@ menuconfig INPUT
if INPUT
config INPUT_MOUSE
- bool "Enable mouse support
AlanRosenthal commented on pull request #5174:
URL: https://github.com/apache/incubator-nuttx/pull/5174#issuecomment-1005871823
> @AlanRosenthal PTAL, we've identified this issue in our internal CI.
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to th
fjpanag commented on a change in pull request #961:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/961#discussion_r778964201
##
File path: fsutils/mkfatfs/Kconfig
##
@@ -11,7 +11,7 @@ config FSUTILS_MKFATFS
---help---
Enables support for the m
pkarashchenko commented on a change in pull request #5171:
URL: https://github.com/apache/incubator-nuttx/pull/5171#discussion_r778982536
##
File path: sched/semaphore/sem_holder.c
##
@@ -187,35 +194,36 @@ nxsem_findorallocateholder(sem_t *sem, FAR struct tcb_s
*htcb)
static
pkarashchenko commented on a change in pull request #5171:
URL: https://github.com/apache/incubator-nuttx/pull/5171#discussion_r779009113
##
File path: sched/semaphore/sem_holder.c
##
@@ -1035,17 +1011,52 @@ void nxsem_release_holder(FAR sem_t *sem)
{
FAR struct tcb_s *rtcb
pkarashchenko commented on a change in pull request #5171:
URL: https://github.com/apache/incubator-nuttx/pull/5171#discussion_r779019294
##
File path: sched/semaphore/sem_holder.c
##
@@ -86,30 +87,36 @@ static inline FAR struct semholder_s
*nxsem_allocholder(sem_t *sem)
a-lunev commented on pull request #4575:
URL: https://github.com/apache/incubator-nuttx/pull/4575#issuecomment-1005946086
> @xiaoxiang781216 I tried to find if changing dev->d_flags is synchronized
to net_lock() anywhere. It looks like dev->d_flags can be modified (e.g. by
psock_ioctl()) a
gustavonihei commented on a change in pull request #5165:
URL: https://github.com/apache/incubator-nuttx/pull/5165#discussion_r779070441
##
File path: arch/ceva/Kconfig
##
@@ -0,0 +1,133 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfi
gustavonihei commented on a change in pull request #5165:
URL: https://github.com/apache/incubator-nuttx/pull/5165#discussion_r779070567
##
File path: arch/ceva/Kconfig
##
@@ -0,0 +1,133 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfi
gustavonihei commented on a change in pull request #5165:
URL: https://github.com/apache/incubator-nuttx/pull/5165#discussion_r779070913
##
File path: arch/ceva/Kconfig
##
@@ -0,0 +1,133 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfi
gustavonihei commented on a change in pull request #5165:
URL: https://github.com/apache/incubator-nuttx/pull/5165#discussion_r779071100
##
File path: arch/ceva/include/arch.h
##
@@ -0,0 +1,107 @@
+/
+
gustavonihei commented on a change in pull request #5165:
URL: https://github.com/apache/incubator-nuttx/pull/5165#discussion_r779071327
##
File path: arch/ceva/include/arch.h
##
@@ -0,0 +1,107 @@
+/
+
1 - 100 of 131 matches
Mail list logo
