anchao commented on a change in pull request #3926:
URL: https://github.com/apache/incubator-nuttx/pull/3926#discussion_r663685666
##
File path: net/tcp/tcp_ioctl.c
##
@@ -0,0 +1,74 @@
+/
+ * net/tcp/tc
anchao commented on a change in pull request #3926:
URL: https://github.com/apache/incubator-nuttx/pull/3926#discussion_r663685804
##
File path: net/tcp/tcp_ioctl.c
##
@@ -0,0 +1,74 @@
+/
+ * net/tcp/tc
xiaoxiang781216 opened a new pull request #4068:
URL: https://github.com/apache/incubator-nuttx/pull/4068
## Summary
since it's more simple to make mm_heap_s opaque outside of mm
## Impact
mm_heap_s become opaque struct
## Testing
ostest
--
This is an automated
yamt commented on a change in pull request #3926:
URL: https://github.com/apache/incubator-nuttx/pull/3926#discussion_r663694940
##
File path: net/tcp/tcp_ioctl.c
##
@@ -0,0 +1,74 @@
+/
+ * net/tcp/tcp_
yamt commented on a change in pull request #3926:
URL: https://github.com/apache/incubator-nuttx/pull/3926#discussion_r663700959
##
File path: net/tcp/tcp_ioctl.c
##
@@ -0,0 +1,74 @@
+/
+ * net/tcp/tcp_
xiaoxiang781216 commented on pull request #4055:
URL: https://github.com/apache/incubator-nuttx/pull/4055#issuecomment-873877943
> @xiaoxiang781216
>
> BTW, can you add sabre-6quad:knsh to test CONFIG_BUILD_KERNEL with QEMU?
But, sabre-6quad doesn't have any config enable CONFI
xiaoxiang781216 edited a comment on pull request #4055:
URL: https://github.com/apache/incubator-nuttx/pull/4055#issuecomment-873877943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
masayuki2009 commented on pull request #4055:
URL: https://github.com/apache/incubator-nuttx/pull/4055#issuecomment-873883916
> > @xiaoxiang781216
> > BTW, can you add sabre-6quad:knsh to test CONFIG_BUILD_KERNEL with QEMU?
>
> But, sabre-6quad doesn't have any config enable CONFIG
anchao opened a new pull request #4069:
URL: https://github.com/apache/incubator-nuttx/pull/4069
## Summary
net/socket: add SO_RCVBUF support
Reference here:
https://www.freebsd.org/cgi/man.cgi?query=setsockopt&sektion=2&format=html
## Impact
add SO_RCVBUF supp
anchao commented on a change in pull request #3926:
URL: https://github.com/apache/incubator-nuttx/pull/3926#discussion_r663736701
##
File path: net/tcp/tcp_ioctl.c
##
@@ -0,0 +1,74 @@
+/
+ * net/tcp/tc
anchao commented on pull request #3926:
URL: https://github.com/apache/incubator-nuttx/pull/3926#issuecomment-873929357
@yamt san, please review again,thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
anchao opened a new pull request #4070:
URL: https://github.com/apache/incubator-nuttx/pull/4070
## Summary
net/tcp: add window scale support
net/tcp: change the tcp optdata to dynamic arrays
net/tcp: remove the invalid break during tcp option loop
Reference here:
http
yamt commented on a change in pull request #4069:
URL: https://github.com/apache/incubator-nuttx/pull/4069#discussion_r663800441
##
File path: net/udp/udp_callback.c
##
@@ -83,6 +83,14 @@ static uint16_t udp_datahandler(FAR struct net_driver_s *dev,
FAR void *src_addr;
u
anchao commented on a change in pull request #4069:
URL: https://github.com/apache/incubator-nuttx/pull/4069#discussion_r663811404
##
File path: net/udp/udp_callback.c
##
@@ -83,6 +83,14 @@ static uint16_t udp_datahandler(FAR struct net_driver_s *dev,
FAR void *src_addr;
yamt commented on a change in pull request #4070:
URL: https://github.com/apache/incubator-nuttx/pull/4070#discussion_r663806067
##
File path: net/tcp/tcp_send.c
##
@@ -365,6 +365,13 @@ static void tcp_sendcommon(FAR struct net_driver_s *dev,
uint32_t rcvseq = tcp_getseq
yamt commented on a change in pull request #4069:
URL: https://github.com/apache/incubator-nuttx/pull/4069#discussion_r663821574
##
File path: net/udp/udp_callback.c
##
@@ -83,6 +83,14 @@ static uint16_t udp_datahandler(FAR struct net_driver_s *dev,
FAR void *src_addr;
u
anchao commented on a change in pull request #4069:
URL: https://github.com/apache/incubator-nuttx/pull/4069#discussion_r663831124
##
File path: net/udp/udp_callback.c
##
@@ -83,6 +83,14 @@ static uint16_t udp_datahandler(FAR struct net_driver_s *dev,
FAR void *src_addr;
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 75bfa45 mm: Add kmm_malloc_size and mm_malloc_size
add ebf89ff mm/iob: add iob_get_queue_size() he
xiaoxiang781216 merged pull request #3926:
URL: https://github.com/apache/incubator-nuttx/pull/3926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
xiaoxiang781216 commented on pull request #4055:
URL: https://github.com/apache/incubator-nuttx/pull/4055#issuecomment-874036195
No, we use dual Cortex-A7 in FLAT mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
acassis commented on a change in pull request #4066:
URL: https://github.com/apache/incubator-nuttx/pull/4066#discussion_r663908926
##
File path: arch/arm/src/rtl8720c/amebaZ.c
##
@@ -0,0 +1,62 @@
+/
+
gustavonihei commented on pull request #695:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/695#issuecomment-874099283
> @gustavonihei is the nullification thing the only thing you are unhappy
with this PR?
Yes.
Regarding the styling issues, I am fine with doing it in a
gustavonihei edited a comment on pull request #695:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/695#issuecomment-874099283
> @gustavonihei is the nullification thing the only thing you are unhappy
with this PR?
Yes.
Regarding the styling issues, I am fine with addres
acassis commented on pull request #4067:
URL: https://github.com/apache/incubator-nuttx/pull/4067#issuecomment-874100510
Hi @DS-LK it is a good idea to put a comment when open and close a PR, this
way we could understand what is going on. Thank you!
--
This is an automated message from t
yamt commented on a change in pull request #4069:
URL: https://github.com/apache/incubator-nuttx/pull/4069#discussion_r663959314
##
File path: net/udp/udp_callback.c
##
@@ -83,6 +83,14 @@ static uint16_t udp_datahandler(FAR struct net_driver_s *dev,
FAR void *src_addr;
u
yamt commented on a change in pull request #4070:
URL: https://github.com/apache/incubator-nuttx/pull/4070#discussion_r663960060
##
File path: net/tcp/Kconfig
##
@@ -106,6 +106,27 @@ config NET_TCP_FAST_RETRANSMIT_WATERMARK
missing segment, without waiti
xiaoxiang781216 commented on pull request #4067:
URL: https://github.com/apache/incubator-nuttx/pull/4067#issuecomment-874162931
The new PR will provide after finish the internal review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
anchao commented on a change in pull request #4070:
URL: https://github.com/apache/incubator-nuttx/pull/4070#discussion_r663992243
##
File path: net/tcp/Kconfig
##
@@ -106,6 +106,27 @@ config NET_TCP_FAST_RETRANSMIT_WATERMARK
missing segment, without wai
anchao opened a new pull request #4071:
URL: https://github.com/apache/incubator-nuttx/pull/4071
## Summary
net/local: add AF_[UNIX|LOCAL] socketpair support
## Impact
net/local: add AF_[UNIX|LOCAL] socketpair support
## Testing
socketpair wirth AF_UNIX and
fjpanag opened a new pull request #4072:
URL: https://github.com/apache/incubator-nuttx/pull/4072
## Summary
Added the Watchdog Timer (WDT) driver for the LPC17xx & LPC40xx families of
MCUs.
The new driver registers a new watchdog device, which can also use the
"auto-monitor"
xiaoxiang781216 merged pull request #4072:
URL: https://github.com/apache/incubator-nuttx/pull/4072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from eabe535 net/inet: add support of FIONREAD
add 2f0b4eb lpc17xx: Added WDT driver.
No new revisions
acassis commented on a change in pull request #4072:
URL: https://github.com/apache/incubator-nuttx/pull/4072#discussion_r664032202
##
File path: arch/arm/src/lpc17xx_40xx/hardware/lpc17_40_wdt.h
##
@@ -89,6 +89,8 @@
/* Watchdog feed sequence register */
+#define WDT_FEED
saramonteiro opened a new pull request #4073:
URL: https://github.com/apache/incubator-nuttx/pull/4073
## Summary
This MR removes the reset of TX FIFO, which was causing the UART 2 to print
garbage after the first print.
It also changes the default UART 2 pins from menuconfig to v
acassis commented on a change in pull request #4070:
URL: https://github.com/apache/incubator-nuttx/pull/4070#discussion_r664091493
##
File path: net/tcp/Kconfig
##
@@ -106,6 +106,27 @@ config NET_TCP_FAST_RETRANSMIT_WATERMARK
missing segment, without wa
anchao commented on a change in pull request #4070:
URL: https://github.com/apache/incubator-nuttx/pull/4070#discussion_r664114022
##
File path: net/tcp/Kconfig
##
@@ -106,6 +106,27 @@ config NET_TCP_FAST_RETRANSMIT_WATERMARK
missing segment, without wai
hartmannathan commented on pull request #4035:
URL: https://github.com/apache/incubator-nuttx/pull/4035#issuecomment-874330013
Hi @Donny9 do you intend to continue refining this PR?
Currently there are some compile errors:
```
wqueue/work_usrthread.c: In function 'work_proce
hartmannathan commented on pull request #4035:
URL: https://github.com/apache/incubator-nuttx/pull/4035#issuecomment-874330082
Also the file `arch/renesas/include/rx65n/inttypes.h` is being changed, but
I think it's a different subject and so should be in its own separate PR?
--
This
hartmannathan opened a new pull request #4074:
URL: https://github.com/apache/incubator-nuttx/pull/4074
## Summary
Documentation/reference/os/wqueue.rst:
- Fix spelling, grammar, and typos.
- Improve wording in a few areas.
- Re-wrap the paragraphs that were modified.
hartmannathan commented on pull request #4074:
URL: https://github.com/apache/incubator-nuttx/pull/4074#issuecomment-874334987
I have additional fixes for comments in the source files in [1], but I'm
waiting on PR #4035 since they could introduce unnecessary conflicts.
[1] https://gi
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 9a85507 Publishing web
YuuichiNakamura commented on pull request #3979:
URL: https://github.com/apache/incubator-nuttx/pull/3979#issuecomment-874390374
Thanks for the notification. I have confirmed that my instrumentation code
works well.
--
This is an automated message from the Apache Git Service.
To resp
DS-LK commented on pull request #4067:
URL: https://github.com/apache/incubator-nuttx/pull/4067#issuecomment-874397208
Sorry, I made a mistake in operation. This PR was submitted for review
before, and then closed. I wanted to withdraw that first, but I did not expect
to open it again. I w
jerry-tang-realsil commented on pull request #4066:
URL: https://github.com/apache/incubator-nuttx/pull/4066#issuecomment-874406368
Hello,
I’m sorry but I don’t understand what AFAIK GPL is incompatible with Apache
License means.
Could you please tell me what is incompatible about
jerry-tang-realsil commented on a change in pull request #4066:
URL: https://github.com/apache/incubator-nuttx/pull/4066#discussion_r664187880
##
File path: arch/arm/src/rtl8720c/Make.defs
##
@@ -0,0 +1,91 @@
+
donghengqaz opened a new pull request #4075:
URL: https://github.com/apache/incubator-nuttx/pull/4075
## Summary
Add ESP32-C3 board_ioctl and board_uniqueid.
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the me
masayuki2009 merged pull request #4064:
URL: https://github.com/apache/incubator-nuttx/pull/4064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 2b0b298ab654c17d8db4fc3324975a5af2ed59bd
Author: Xiang Xiao
AuthorDate: Mon Jul 5 12:24:14 2021 +0800
fs
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 2f0b4eb lpc17xx: Added WDT driver.
new 2b0b298 fs/mmap: Remove rammap_initialize declaration
n
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 8612af4ae59a94cc27d57680acfc55ed926f9067
Author: Xiang Xiao
AuthorDate: Sat Mar 20 05:06:08 2021 +0800
f
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 841a4922aacaee45ee0c456bfaf1c1355ccc9770
Author: Xiang Xiao
AuthorDate: Tue Feb 16 01:15:08 2021 +0800
b
jerry-tang-realsil commented on a change in pull request #4066:
URL: https://github.com/apache/incubator-nuttx/pull/4066#discussion_r664196627
##
File path: arch/arm/src/rtl8720c/Make.defs
##
@@ -0,0 +1,91 @@
+
jerry-tang-realsil commented on a change in pull request #4066:
URL: https://github.com/apache/incubator-nuttx/pull/4066#discussion_r664196627
##
File path: arch/arm/src/rtl8720c/Make.defs
##
@@ -0,0 +1,91 @@
+
jerry-tang-realsil commented on a change in pull request #4066:
URL: https://github.com/apache/incubator-nuttx/pull/4066#discussion_r664196627
##
File path: arch/arm/src/rtl8720c/Make.defs
##
@@ -0,0 +1,91 @@
+
jerry-tang-realsil commented on a change in pull request #4066:
URL: https://github.com/apache/incubator-nuttx/pull/4066#discussion_r664198252
##
File path: arch/arm/src/rtl8720c/Make.defs
##
@@ -0,0 +1,91 @@
+
jerry-tang-realsil closed pull request #4066:
URL: https://github.com/apache/incubator-nuttx/pull/4066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
jerry-tang-realsil commented on pull request #4066:
URL: https://github.com/apache/incubator-nuttx/pull/4066#issuecomment-874418390
License is not OK, modify and PR new
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jerry-tang-realsil opened a new pull request #4076:
URL: https://github.com/apache/incubator-nuttx/pull/4076
Add soc src code for rtl8720c
Signed-off-by: Jerry_tang
## Summary
add soc-rtl8720c src code
## Impact
no
## Testing
ok
--
This is an automated me
yamt commented on a change in pull request #4070:
URL: https://github.com/apache/incubator-nuttx/pull/4070#discussion_r664215474
##
File path: net/tcp/Kconfig
##
@@ -106,6 +106,27 @@ config NET_TCP_FAST_RETRANSMIT_WATERMARK
missing segment, without waiti
yamt commented on pull request #3900:
URL: https://github.com/apache/incubator-nuttx/pull/3900#issuecomment-874443249
> I am fine with either approach, but could you incorporate your LTO demo
into mainline? Otherwise, the same change may be created again for LTO.
maybe i will try.
xiaoxiang781216 merged pull request #4074:
URL: https://github.com/apache/incubator-nuttx/pull/4074
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 841a492 binfmt: Replace all nx_ API with file_ API
add 935c206 Documentation: Fix typos
No new re
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 935c206 Documentation: Fix typos
add 475beca risc-v/esp32c3: Add board_ioctl and board_uniqueid
N
xiaoxiang781216 merged pull request #4075:
URL: https://github.com/apache/incubator-nuttx/pull/4075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
anchao commented on pull request #4069:
URL: https://github.com/apache/incubator-nuttx/pull/4069#issuecomment-87998
> you should update tcp_maxrcvwin too.
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 475beca risc-v/esp32c3: Add board_ioctl and board_uniqueid
add d67852d xtensa/esp32: Change defaul
xiaoxiang781216 merged pull request #4073:
URL: https://github.com/apache/incubator-nuttx/pull/4073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
yamt commented on a change in pull request #4070:
URL: https://github.com/apache/incubator-nuttx/pull/4070#discussion_r664228213
##
File path: net/tcp/Kconfig
##
@@ -106,6 +106,27 @@ config NET_TCP_FAST_RETRANSMIT_WATERMARK
missing segment, without waiti
yamt commented on pull request #800:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/800#issuecomment-874454975
@GUIDINGLI @xiaoxiang781216
how do you think?
my colleagues are suffering from this Make.dep breakage.
and IMO the change itself seems rather controversial. it's
yamt commented on a change in pull request #4070:
URL: https://github.com/apache/incubator-nuttx/pull/4070#discussion_r664235030
##
File path: net/tcp/Kconfig
##
@@ -106,6 +106,27 @@ config NET_TCP_FAST_RETRANSMIT_WATERMARK
missing segment, without waiti
Virus-V commented on a change in pull request #4069:
URL: https://github.com/apache/incubator-nuttx/pull/4069#discussion_r664247917
##
File path: net/socket/setsockopt.c
##
@@ -131,9 +131,71 @@ static int psock_socketlevel_option(FAR struct socket
*psock, int option,
anchao commented on a change in pull request #4069:
URL: https://github.com/apache/incubator-nuttx/pull/4069#discussion_r664249503
##
File path: net/socket/setsockopt.c
##
@@ -131,9 +131,71 @@ static int psock_socketlevel_option(FAR struct socket
*psock, int option,
anchao commented on a change in pull request #4070:
URL: https://github.com/apache/incubator-nuttx/pull/4070#discussion_r664251381
##
File path: net/tcp/Kconfig
##
@@ -106,6 +106,27 @@ config NET_TCP_FAST_RETRANSMIT_WATERMARK
missing segment, without wai
xiaoxiang781216 commented on a change in pull request #4069:
URL: https://github.com/apache/incubator-nuttx/pull/4069#discussion_r664252652
##
File path: net/Kconfig
##
@@ -117,6 +117,12 @@ config NET_GUARDSIZE
packet size will be chopped down to the size indica
yamt commented on a change in pull request #4070:
URL: https://github.com/apache/incubator-nuttx/pull/4070#discussion_r664254702
##
File path: net/tcp/Kconfig
##
@@ -106,6 +106,27 @@ config NET_TCP_FAST_RETRANSMIT_WATERMARK
missing segment, without waiti
xiaoxiang781216 commented on a change in pull request #4071:
URL: https://github.com/apache/incubator-nuttx/pull/4071#discussion_r664276081
##
File path: net/local/local_sockif.c
##
@@ -728,6 +731,106 @@ static int local_ioctl(FAR struct socket *psock, int cmd,
return ret;
xiaoxiang781216 merged pull request #4069:
URL: https://github.com/apache/incubator-nuttx/pull/4069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from a5bf47b xtensa/esp32: Fixes issue with UART 2
add b901f22 net/socket: add SO_RCVBUF support
No ne
xiaoxiang781216 commented on pull request #3114:
URL: https://github.com/apache/incubator-nuttx/pull/3114#issuecomment-874510299
@masayuki2009 could you try the new change work with your hardware?
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
79 matches
Mail list logo