yamt commented on a change in pull request #3926: URL: https://github.com/apache/incubator-nuttx/pull/3926#discussion_r663700959
########## File path: net/tcp/tcp_ioctl.c ########## @@ -0,0 +1,74 @@ +/**************************************************************************** + * net/tcp/tcp_ioctl.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <stdint.h> +#include <stdbool.h> +#include <debug.h> +#include <errno.h> + +#include <net/if.h> + +#include <nuttx/fs/ioctl.h> +#include <nuttx/mm/iob.h> + +#include "tcp/tcp.h" + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: tcp_ioctl + * + * Description: + * This function performs tcp specific ioctl() operations. + * + * Parameters: + * conn The TCP connection of interest + * cmd The ioctl command + * arg The argument of the ioctl cmd + * arglen The length of 'arg' + * + ****************************************************************************/ + +int tcp_ioctl(FAR struct tcp_conn_s *conn, + int cmd, FAR void *arg, size_t arglen) +{ + int ret = OK; + + switch (cmd) + { + case FIONREAD: + *(FAR int *)((uintptr_t)arg) = + iob_get_queue_size(&conn->readahead); Review comment: > I'm a little worried here about the right edge is moved inside a package, will there be other problems? According to the previous strategy, the whole packet will be discarded if unable to allocate the new iob buffer. i don't expect major issues as it's what other tcp stacks sometimes do. but i can understand your concern. otoh, dropping more data would increase the chance of stalls when iobs are scarce. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
