[GitHub] [incubator-nuttx] michi-jung commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-16 Thread GitBox
michi-jung commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r594899319 ## File path: arch/arm/src/stm32l5/hardware/stm32l5_exti.h ## @@ -0,0 +1,119 @@ +/*

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #3003: ESP32: Re-organise the different heap regions

2021-03-16 Thread GitBox
Ouss4 commented on pull request #3003: URL: https://github.com/apache/incubator-nuttx/pull/3003#issuecomment-800017210 @yamt can you merge it please? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] yamt merged pull request #3003: ESP32: Re-organise the different heap regions

2021-03-16 Thread GitBox
yamt merged pull request #3003: URL: https://github.com/apache/incubator-nuttx/pull/3003 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[incubator-nuttx] branch master updated (ecb9e03 -> 2816082)

2021-03-16 Thread yamamoto
This is an automated email from the ASF dual-hosted git repository. yamamoto pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from ecb9e03 fs/mmap: Update mmap documentation of possible return values add a68a39c xtensa/esp32: Move

[GitHub] [incubator-nuttx] michi-jung commented on pull request #2974: STM32L5 Architecture Support

2021-03-16 Thread GitBox
michi-jung commented on pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#issuecomment-800021088 The 'Build / Fetch-Source (pull_request)' step now shows a lot of coding-style problems, which are not in the files I modified but in other files that have meanwhile

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2995: esp32: Add an option to use the whole region2 memory for imem heap

2021-03-16 Thread GitBox
Ouss4 commented on pull request #2995: URL: https://github.com/apache/incubator-nuttx/pull/2995#issuecomment-800027056 @yamt any plans for this one, or should we close it? This is an automated message from the Apache Git Serv

[GitHub] [incubator-nuttx] yamt commented on pull request #2995: esp32: Add an option to use the whole region2 memory for imem heap

2021-03-16 Thread GitBox
yamt commented on pull request #2995: URL: https://github.com/apache/incubator-nuttx/pull/2995#issuecomment-800028720 @Ouss4 actually i forgot this one. :-) thank you for reminding. This is an automated message from the Ap

[GitHub] [incubator-nuttx] yamt closed pull request #2995: esp32: Add an option to use the whole region2 memory for imem heap

2021-03-16 Thread GitBox
yamt closed pull request #2995: URL: https://github.com/apache/incubator-nuttx/pull/2995 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-nuttx] michi-jung edited a comment on pull request #2974: STM32L5 Architecture Support

2021-03-16 Thread GitBox
michi-jung edited a comment on pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#issuecomment-800021088 The 'Check / check (pull_request)' step now shows a lot of coding-style problems, which are not in the files I modified but in other files that have meanwhile

[GitHub] [incubator-nuttx] donghengqaz removed a comment on pull request #2939: xtensa/esp32: Refactor ESP32 WiFi driver to support station and softAP coexistence

2021-03-16 Thread GitBox
donghengqaz removed a comment on pull request #2939: URL: https://github.com/apache/incubator-nuttx/pull/2939#issuecomment-787778861 Draft: The code is mainly done, but some friends would not like to merge into `master` before Mar 15, so I set this PR to be Draft to avoid this PR being mer

[GitHub] [incubator-nuttx-apps] Donny9 opened a new pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS

2021-03-16 Thread GitBox
Donny9 opened a new pull request #612: URL: https://github.com/apache/incubator-nuttx-apps/pull/612 ## Summary using THTTPD_NFILE_DESCRIPTORS instead of NFILE_DESCRIPTORS. This patch associates with https://github.com/apache/incubator-nuttx/pull/3045. ## Impact ## Testing d

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2974: STM32L5 Architecture Support

2021-03-16 Thread GitBox
xiaoxiang781216 commented on pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#issuecomment-800061224 > The 'Check / check (pull_request)' step now shows a lot of coding-style problems, which are not in the files I modified but in other files that have meanwhile

[GitHub] [incubator-nuttx-apps] no1wudi opened a new pull request #613: Enhancement of QuickJS

2021-03-16 Thread GitBox
no1wudi opened a new pull request #613: URL: https://github.com/apache/incubator-nuttx-apps/pull/613 ## Summary 1. Bump to latest release 2020-11-08 2. A mini interpreter is implemented, only 50K RAM is required. The full version of the interpreter requires approximately 280K RAM,

[GitHub] [incubator-nuttx-apps] Donny9 commented on pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS

2021-03-16 Thread GitBox
Donny9 commented on pull request #612: URL: https://github.com/apache/incubator-nuttx-apps/pull/612#issuecomment-800080654 ../nuttx/tools/checkpatch.sh -g 5140962436f816cedfe6f9ff57c699e4d027af09..HEAD Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/tht

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3072: Fix typos in IOB Kconfig and comment

2021-03-16 Thread GitBox
xiaoxiang781216 merged pull request #3072: URL: https://github.com/apache/incubator-nuttx/pull/3072 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated (2816082 -> f8d56b9)

2021-03-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 2816082 arch/xtensa/esp32: ~6KB of memory at address 0x3ffae6f0 is not used by the ROM bootloader, add

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS

2021-03-16 Thread GitBox
xiaoxiang781216 commented on pull request #612: URL: https://github.com/apache/incubator-nuttx-apps/pull/612#issuecomment-800085746 Yes, let ignore it. This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx] hotislandn opened a new pull request #3073: arch:rv64:c906:demo protect build without the PMP.

2021-03-16 Thread GitBox
hotislandn opened a new pull request #3073: URL: https://github.com/apache/incubator-nuttx/pull/3073 Signed-off-by: hotislandn ## Summary This patch enables the protect build for C906 on QEMU without the RISC-V PMP. ## Impact TARGET: ARCH:RV64:C906. ## Testing

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #613: Enhancement of QuickJS

2021-03-16 Thread GitBox
xiaoxiang781216 commented on pull request #613: URL: https://github.com/apache/incubator-nuttx-apps/pull/613#issuecomment-800086696 Please fix this warning: ``` apps/interpreters/quickjs/qjsmini.c:2:1: error: Relative file path does not match actual file ```

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #613: Enhancement of QuickJS

2021-03-16 Thread GitBox
xiaoxiang781216 edited a comment on pull request #613: URL: https://github.com/apache/incubator-nuttx-apps/pull/613#issuecomment-800086696 Please fix this warning: ``` apps/interpreters/quickjs/qjsmini.c:2:1: error: Relative file path does not match actual file ``` Other mix ca

[incubator-nuttx-apps] 02/02: iperf: Plug a memory leak

2021-03-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit f8cb9db7295aef77d4db624f90dad93905625ece Author: YAMAMOTO Takashi AuthorDate: Tue Mar 16 15:19:55 2021

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #611: iperf: plug memory leaks

2021-03-16 Thread GitBox
xiaoxiang781216 merged pull request #611: URL: https://github.com/apache/incubator-nuttx-apps/pull/611 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[incubator-nuttx-apps] branch master updated (5140962 -> f8cb9db)

2021-03-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from 5140962 netutils/iperf/README.md: document what this is new 25d2948 iperf: plug a thread leak

[incubator-nuttx-apps] 01/02: iperf: plug a thread leak

2021-03-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 25d29482eaa8b0f4a9fcabcdb6ab636511c20755 Author: YAMAMOTO Takashi AuthorDate: Tue Mar 16 15:01:11 2021

[GitHub] [incubator-nuttx] michi-jung commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-16 Thread GitBox
michi-jung commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r594900877 ## File path: arch/arm/src/stm32l5/stm32l5_lse.c ## @@ -0,0 +1,166 @@ +/***

[GitHub] [incubator-nuttx] michi-jung commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-16 Thread GitBox
michi-jung commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r594899319 ## File path: arch/arm/src/stm32l5/hardware/stm32l5_exti.h ## @@ -0,0 +1,119 @@ +/*

[GitHub] [incubator-nuttx] michi-jung commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-16 Thread GitBox
michi-jung commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r594900312 ## File path: arch/arm/src/stm32l5/hardware/stm32l562xx_pinmap.h ## @@ -0,0 +1,745 @@ +/***

[GitHub] [incubator-nuttx] michi-jung commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-16 Thread GitBox
michi-jung commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r594902175 ## File path: arch/arm/src/stm32l5/hardware/stm32l562xx_pinmap.h ## @@ -0,0 +1,745 @@ +/***

[GitHub] [incubator-nuttx] michi-jung commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-16 Thread GitBox
michi-jung commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r594900312 ## File path: arch/arm/src/stm32l5/hardware/stm32l562xx_pinmap.h ## @@ -0,0 +1,745 @@ +/***

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3045: fs: Allocate file/socket dynamically

2021-03-16 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3045: URL: https://github.com/apache/incubator-nuttx/pull/3045#discussion_r594990051 ## File path: sched/Kconfig ## @@ -1058,12 +1058,12 @@ config SDCLONE_DISABLE descriptors by task_create() when a new task is star

[GitHub] [incubator-nuttx] michi-jung commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-16 Thread GitBox
michi-jung commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r594902175 ## File path: arch/arm/src/stm32l5/hardware/stm32l562xx_pinmap.h ## @@ -0,0 +1,745 @@ +/***

[GitHub] [incubator-nuttx] michi-jung commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-16 Thread GitBox
michi-jung commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r594900877 ## File path: arch/arm/src/stm32l5/stm32l5_lse.c ## @@ -0,0 +1,166 @@ +/***

[GitHub] [incubator-nuttx] michi-jung commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-16 Thread GitBox
michi-jung commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r594899319 ## File path: arch/arm/src/stm32l5/hardware/stm32l5_exti.h ## @@ -0,0 +1,119 @@ +/*

[GitHub] [incubator-nuttx] michi-jung commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-16 Thread GitBox
michi-jung commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r594901666 ## File path: arch/arm/src/stm32l5/hardware/stm32l562xx_rcc.h ## @@ -0,0 +1,867 @@ +/**

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #3067: boards/raspberrypi-pico: Pico Display Pack (ST7789 LCD) support

2021-03-16 Thread GitBox
acassis commented on a change in pull request #3067: URL: https://github.com/apache/incubator-nuttx/pull/3067#discussion_r594999374 ## File path: boards/arm/rp2040/common/src/rp2040_st7789.c ## @@ -0,0 +1,124 @@ +/

[incubator-nuttx] branch master updated (f8d56b9 -> 5699dd8)

2021-03-16 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from f8d56b9 iob_trimhead.c: Fix a comment typo new aa718dc lcd/st7789: X/Y offset and screen orientation

[incubator-nuttx] 01/02: lcd/st7789: X/Y offset and screen orientation support

2021-03-16 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit aa718dcbac641ced672407535dcf5a56ec6dd939 Author: Yuichi Nakamura AuthorDate: Tue Mar 16 00:32:54 2021 +0900

[GitHub] [incubator-nuttx] acassis merged pull request #3067: boards/raspberrypi-pico: Pico Display Pack (ST7789 LCD) support

2021-03-16 Thread GitBox
acassis merged pull request #3067: URL: https://github.com/apache/incubator-nuttx/pull/3067 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[incubator-nuttx] 02/02: boards/raspberrypi-pico: Pico Display Pack (ST7789 LCD) support

2021-03-16 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 5699dd86ebcbb764e2a0b6244fb236d1b3ab49d6 Author: Yuichi Nakamura AuthorDate: Tue Mar 16 00:32:54 2021 +0900

[GitHub] [incubator-nuttx-apps] acassis commented on pull request #591: lvgldemo: Add support for lcddev

2021-03-16 Thread GitBox
acassis commented on pull request #591: URL: https://github.com/apache/incubator-nuttx-apps/pull/591#issuecomment-80025 ping @btashton This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nuttx] acassis commented on pull request #3063: Integration between nuttx and pysimCoder

2021-03-16 Thread GitBox
acassis commented on pull request #3063: URL: https://github.com/apache/incubator-nuttx/pull/3063#issuecomment-800115314 Hi @robertobucher the CI reported some silly issues that need to be fixed. This issues were already there, but because this is the first time a PR includes these file we

[GitHub] [incubator-nuttx] acassis commented on pull request #3063: Integration between nuttx and pysimCoder

2021-03-16 Thread GitBox
acassis commented on pull request #3063: URL: https://github.com/apache/incubator-nuttx/pull/3063#issuecomment-800116014 You don't need to close this PR, just create a new commit and submit, it will appear here. This is an a

[GitHub] [incubator-nuttx] walbon commented on a change in pull request #3068: lpc17xx_40xx/mbed : refresh defconfig

2021-03-16 Thread GitBox
walbon commented on a change in pull request #3068: URL: https://github.com/apache/incubator-nuttx/pull/3068#discussion_r595017963 ## File path: boards/arm/lpc17xx_40xx/mbed/configs/nsh/defconfig ## @@ -20,7 +20,7 @@ CONFIG_ARCH_CHIP="lpc17xx_40xx" CONFIG_ARCH_CHIP_LPC1768=y

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #3003: ESP32: Re-organise the different heap regions

2021-03-16 Thread GitBox
masayuki2009 commented on pull request #3003: URL: https://github.com/apache/incubator-nuttx/pull/3003#issuecomment-800123362 @Ouss4 I noticed that ostest with esp32-devkitc:smp (QEMU) is unstable, although I added ```CONFIG_ESP32_QEMU_IMAGE=y```. ``` sender_thread: mq_sen

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3045: fs: Allocate file/socket dynamically

2021-03-16 Thread GitBox
xiaoxiang781216 commented on pull request #3045: URL: https://github.com/apache/incubator-nuttx/pull/3045#issuecomment-800131240 depends on https://github.com/apache/incubator-nuttx-apps/pull/612 This is an automated message

[GitHub] [incubator-nuttx-apps] Donny9 edited a comment on pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS

2021-03-16 Thread GitBox
Donny9 edited a comment on pull request #612: URL: https://github.com/apache/incubator-nuttx-apps/pull/612#issuecomment-800080654 ``` ../nuttx/tools/checkpatch.sh -g 5140962436f816cedfe6f9ff57c699e4d027af09..HEAD Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/app

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #3003: ESP32: Re-organise the different heap regions

2021-03-16 Thread GitBox
Ouss4 commented on pull request #3003: URL: https://github.com/apache/incubator-nuttx/pull/3003#issuecomment-800136105 @masayuki2009 I have seen some instability in QEMU before but I've fixed them, or at least so I thought. This can be another case of the differences in bootloader image

[GitHub] [incubator-nuttx-apps] no1wudi commented on pull request #613: Enhancement of QuickJS

2021-03-16 Thread GitBox
no1wudi commented on pull request #613: URL: https://github.com/apache/incubator-nuttx-apps/pull/613#issuecomment-800147017 > Please fix this warning: > > ``` > apps/interpreters/quickjs/qjsmini.c:2:1: error: Relative file path does not match actual file > ``` > > Other

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3045: fs: Allocate file/socket dynamically

2021-03-16 Thread GitBox
davids5 commented on a change in pull request #3045: URL: https://github.com/apache/incubator-nuttx/pull/3045#discussion_r595064716 ## File path: sched/Kconfig ## @@ -1058,12 +1058,12 @@ config SDCLONE_DISABLE descriptors by task_create() when a new task is started. If

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3070: fs/mmap: Return EACCES for incompatible file descriptors

2021-03-16 Thread GitBox
gustavonihei commented on a change in pull request #3070: URL: https://github.com/apache/incubator-nuttx/pull/3070#discussion_r595071043 ## File path: fs/mmap/fs_mmap.c ## @@ -142,6 +148,30 @@ FAR void *mmap(FAR void *start, size_t length, int prot, int flags, } #endif

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3070: fs/mmap: Return EACCES for incompatible file descriptors

2021-03-16 Thread GitBox
gustavonihei commented on a change in pull request #3070: URL: https://github.com/apache/incubator-nuttx/pull/3070#discussion_r595071043 ## File path: fs/mmap/fs_mmap.c ## @@ -142,6 +148,30 @@ FAR void *mmap(FAR void *start, size_t length, int prot, int flags, } #endif

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3070: fs/mmap: Return EACCES for incompatible file descriptors

2021-03-16 Thread GitBox
gustavonihei commented on a change in pull request #3070: URL: https://github.com/apache/incubator-nuttx/pull/3070#discussion_r595071043 ## File path: fs/mmap/fs_mmap.c ## @@ -142,6 +148,30 @@ FAR void *mmap(FAR void *start, size_t length, int prot, int flags, } #endif

[GitHub] [incubator-nuttx-apps] davids5 commented on pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS

2021-03-16 Thread GitBox
davids5 commented on pull request #612: URL: https://github.com/apache/incubator-nuttx-apps/pull/612#issuecomment-800172109 > Yes, let ignore it. https://github.com/apache/incubator-nuttx-apps/search?q=ClientData&type=code @xiaoxiang781216 Where is `ClientData` coming in from?

[GitHub] [incubator-nuttx] davids5 commented on pull request #2974: STM32L5 Architecture Support

2021-03-16 Thread GitBox
davids5 commented on pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#issuecomment-800176312 @michi-jung - the rest of the CI fails are in this PR. One more fixup and force push should do it, Th

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3070: fs/mmap: Return EACCES for incompatible file descriptors

2021-03-16 Thread GitBox
gustavonihei commented on a change in pull request #3070: URL: https://github.com/apache/incubator-nuttx/pull/3070#discussion_r595071043 ## File path: fs/mmap/fs_mmap.c ## @@ -142,6 +148,30 @@ FAR void *mmap(FAR void *start, size_t length, int prot, int flags, } #endif

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-16 Thread GitBox
davids5 commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r595080968 ## File path: arch/arm/src/stm32l5/hardware/stm32l562xx_pinmap.h ## @@ -0,0 +1,745 @@ +/**

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-16 Thread GitBox
davids5 commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r595083147 ## File path: arch/arm/src/stm32l5/stm32l5_lse.c ## @@ -0,0 +1,166 @@ +/**

[GitHub] [incubator-nuttx] michi-jung commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-16 Thread GitBox
michi-jung commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r595084262 ## File path: arch/arm/src/stm32l5/hardware/stm32l562xx_pinmap.h ## @@ -0,0 +1,745 @@ +/***

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS

2021-03-16 Thread GitBox
xiaoxiang781216 commented on pull request #612: URL: https://github.com/apache/incubator-nuttx-apps/pull/612#issuecomment-800189190 It exist for long time, do you want to rename it? This is an automated message from the Apac

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3070: fs/mmap: Return EACCES for incompatible file descriptors

2021-03-16 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3070: URL: https://github.com/apache/incubator-nuttx/pull/3070#discussion_r595095530 ## File path: fs/mmap/fs_mmap.c ## @@ -142,6 +148,30 @@ FAR void *mmap(FAR void *start, size_t length, int prot, int flags, } #endi

[GitHub] [incubator-nuttx-apps] davids5 commented on pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS

2021-03-16 Thread GitBox
davids5 commented on pull request #612: URL: https://github.com/apache/incubator-nuttx-apps/pull/612#issuecomment-800193265 @xiaoxiang781216 are you asking if you or @Donny9 should fix it? This is an automated message from

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3070: fs/mmap: Return EACCES for incompatible file descriptors

2021-03-16 Thread GitBox
gustavonihei commented on a change in pull request #3070: URL: https://github.com/apache/incubator-nuttx/pull/3070#discussion_r595102512 ## File path: fs/mmap/fs_mmap.c ## @@ -142,6 +148,30 @@ FAR void *mmap(FAR void *start, size_t length, int prot, int flags, } #endif

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS

2021-03-16 Thread GitBox
xiaoxiang781216 commented on pull request #612: URL: https://github.com/apache/incubator-nuttx-apps/pull/612#issuecomment-800202737 Yes, we can rename it if no objection. This is an automated message from the Apache Git Serv

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #2939: xtensa/esp32: Refactor ESP32 WiFi driver to support station and softAP coexistence

2021-03-16 Thread GitBox
saramonteiro commented on a change in pull request #2939: URL: https://github.com/apache/incubator-nuttx/pull/2939#discussion_r595107205 ## File path: arch/xtensa/src/esp32/esp32_wifi_adapter.c ## @@ -638,26 +755,20 @@ static int esp_event_lock(bool lock) static void esp_set_i

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #2939: xtensa/esp32: Refactor ESP32 WiFi driver to support station and softAP coexistence

2021-03-16 Thread GitBox
saramonteiro commented on a change in pull request #2939: URL: https://github.com/apache/incubator-nuttx/pull/2939#discussion_r595107751 ## File path: arch/xtensa/src/esp32/esp32_wifi_adapter.c ## @@ -638,26 +755,20 @@ static int esp_event_lock(bool lock) static void esp_set_i

[GitHub] [incubator-nuttx-apps] davids5 commented on pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS

2021-03-16 Thread GitBox
davids5 commented on pull request #612: URL: https://github.com/apache/incubator-nuttx-apps/pull/612#issuecomment-800210542 @xiaoxiang781216 Please do. This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3070: fs/mmap: Return EACCES for incompatible file descriptors

2021-03-16 Thread GitBox
gustavonihei commented on a change in pull request #3070: URL: https://github.com/apache/incubator-nuttx/pull/3070#discussion_r595114251 ## File path: fs/mmap/fs_mmap.c ## @@ -142,6 +148,30 @@ FAR void *mmap(FAR void *start, size_t length, int prot, int flags, } #endif

[GitHub] [incubator-nuttx-apps] saramonteiro opened a new pull request #614: apps/examples/watcher: Fixed an assert failure

2021-03-16 Thread GitBox
saramonteiro opened a new pull request #614: URL: https://github.com/apache/incubator-nuttx-apps/pull/614 ## Summary This PR: 1. Fixes an assert failure that was being caused because the print logs were being done from the ISR context. Now, the ISR only signals a signal handle

[GitHub] [incubator-nuttx] gustavonihei opened a new pull request #3074: boards/esp32c3-devkit: Use nx_mount to avoid overriding errno

2021-03-16 Thread GitBox
gustavonihei opened a new pull request #3074: URL: https://github.com/apache/incubator-nuttx/pull/3074 ## Summary Change `mount` call to `nx_mount` to not mess with the `errno` value in driver code. ## Impact No impact. ## Testing `esp32c3-devkit:nsh` with CONFIG_FS_T

[GitHub] [incubator-nuttx-apps] saramonteiro opened a new pull request #615: apps/examples: Adds termios example

2021-03-16 Thread GitBox
saramonteiro opened a new pull request #615: URL: https://github.com/apache/incubator-nuttx-apps/pull/615 ## Summary This example uses the termios interface to reconfigure serial parameters. ## Impact N/A ## Testing Tested in ESP32-C3 devkitc. ![image](http

[GitHub] [incubator-nuttx] Donny9 commented on a change in pull request #3045: fs: Allocate file/socket dynamically

2021-03-16 Thread GitBox
Donny9 commented on a change in pull request #3045: URL: https://github.com/apache/incubator-nuttx/pull/3045#discussion_r595138068 ## File path: sched/Kconfig ## @@ -1058,12 +1058,12 @@ config SDCLONE_DISABLE descriptors by task_create() when a new task is started. If

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3045: fs: Allocate file/socket dynamically

2021-03-16 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3045: URL: https://github.com/apache/incubator-nuttx/pull/3045#discussion_r595153023 ## File path: sched/Kconfig ## @@ -1058,12 +1058,12 @@ config SDCLONE_DISABLE descriptors by task_create() when a new task is star

[incubator-nuttx] branch master updated (5699dd8 -> b2f5031)

2021-03-16 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 5699dd8 boards/raspberrypi-pico: Pico Display Pack (ST7789 LCD) support add b2f5031 xtensa/esp32: R

[GitHub] [incubator-nuttx] acassis merged pull request #2939: xtensa/esp32: Refactor ESP32 WiFi driver to support station and softAP coexistence

2021-03-16 Thread GitBox
acassis merged pull request #2939: URL: https://github.com/apache/incubator-nuttx/pull/2939 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-nuttx] acassis merged pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-16 Thread GitBox
acassis merged pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[incubator-nuttx] branch master updated (b2f5031 -> 458caf2)

2021-03-16 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from b2f5031 xtensa/esp32: Refactor ESP32 WiFi driver to support station and softAP coexistence add 458ca

[GitHub] [incubator-nuttx-apps] Donny9 commented on pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS

2021-03-16 Thread GitBox
Donny9 commented on pull request #612: URL: https://github.com/apache/incubator-nuttx-apps/pull/612#issuecomment-800304493 > @xiaoxiang781216 Please do. There are so many such "Mixed case identifier found", Are you sure want to fix them? not just ClientData. Timer, TimerProc,

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #3075: arch/arm: Fix syscall number out of swi range in thumb mode

2021-03-16 Thread GitBox
xiaoxiang781216 opened a new pull request #3075: URL: https://github.com/apache/incubator-nuttx/pull/3075 ## Summary The immediate number is 8bits in thumb mode: ``` +-+---+ |15 14 13 12 11 10 9 8|7 6 5 4 3 2 1 0| +-+

[GitHub] [incubator-nuttx] acassis merged pull request #3073: arch:rv64:c906:demo protect build without the PMP.

2021-03-16 Thread GitBox
acassis merged pull request #3073: URL: https://github.com/apache/incubator-nuttx/pull/3073 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[incubator-nuttx] branch master updated (458caf2 -> fb7a5b8)

2021-03-16 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 458caf2 riscv/esp32c3: Add ESP32-C3 WLAN netcard driver add fb7a5b8 arch:rv64:c906:demo protect buil

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS

2021-03-16 Thread GitBox
xiaoxiang781216 commented on pull request #612: URL: https://github.com/apache/incubator-nuttx-apps/pull/612#issuecomment-800330888 @davids5 the violation is huge, let's merge this patch first and create a new PR late to fix the mix case issue since fs: Allocate file/socket dynamically ap

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS

2021-03-16 Thread GitBox
xiaoxiang781216 merged pull request #612: URL: https://github.com/apache/incubator-nuttx-apps/pull/612 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS

2021-03-16 Thread GitBox
xiaoxiang781216 edited a comment on pull request #612: URL: https://github.com/apache/incubator-nuttx-apps/pull/612#issuecomment-800330888 @davids5 the violation is huge, let's merge this patch first and create a new PR late to fix the mix case issue since apache/incubator-nuttx#3045 which

[incubator-nuttx-apps] branch master updated (f8cb9db -> ff4c3c3)

2021-03-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from f8cb9db iperf: Plug a memory leak add ff4c3c3 thttpd: add THTTPD_NFILE_DESCRIPTORS limits ins

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #3076: arch/stm32l4: Fix nxstyle errors

2021-03-16 Thread GitBox
hartmannathan opened a new pull request #3076: URL: https://github.com/apache/incubator-nuttx/pull/3076 ## Summary Fix nxstyle errors in: - arch/arm/include/stm32l4/chip.h - arch/arm/include/stm32l4/irq.h - arch/arm/include/stm32l4/stm32l4x5xx_irq.h - arch/arm/include/

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #3077: arch/stm32l4: Fix nxstyle errors

2021-03-16 Thread GitBox
hartmannathan opened a new pull request #3077: URL: https://github.com/apache/incubator-nuttx/pull/3077 ## Summary Fix (most) nxstyle errors in: - arch/arm/include/stm32l4/stm32l4x3xx_irq.h - arch/arm/include/stm32l4/stm32l4xrxx_irq.h Not fixed: nxstyle "Wrong column posi

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #3077: arch/stm32l4: Fix nxstyle errors

2021-03-16 Thread GitBox
hartmannathan commented on pull request #3077: URL: https://github.com/apache/incubator-nuttx/pull/3077#issuecomment-800340571 Any thoughts on how to handle the /* Reserved */ comments that are throwing the nxstyle "Wrong column position or missing blank line before comment" errors? -

[GitHub] [incubator-nuttx] hartmannathan edited a comment on pull request #3077: arch/stm32l4: Fix nxstyle errors

2021-03-16 Thread GitBox
hartmannathan edited a comment on pull request #3077: URL: https://github.com/apache/incubator-nuttx/pull/3077#issuecomment-800340571 Any thoughts on how to handle the `/* Reserved */` comments that are throwing the nxstyle "Wrong column position or missing blank line before comment" error

[GitHub] [incubator-nuttx] jerpelea commented on pull request #3077: arch/stm32l4: Fix nxstyle errors

2021-03-16 Thread GitBox
jerpelea commented on pull request #3077: URL: https://github.com/apache/incubator-nuttx/pull/3077#issuecomment-800373600 @hartmannathan usually blank line before that line This is an automated message from the Apache Git Se

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3077: arch/stm32l4: Fix nxstyle errors

2021-03-16 Thread GitBox
davids5 commented on a change in pull request #3077: URL: https://github.com/apache/incubator-nuttx/pull/3077#discussion_r595295026 ## File path: arch/arm/include/stm32l4/stm32l4x3xx_irq.h ## @@ -113,7 +117,7 @@ /* Reserved */ /* 50: T

[GitHub] [incubator-nuttx] jerpelea edited a comment on pull request #3077: arch/stm32l4: Fix nxstyle errors

2021-03-16 Thread GitBox
jerpelea edited a comment on pull request #3077: URL: https://github.com/apache/incubator-nuttx/pull/3077#issuecomment-800373600 @hartmannathan usually blank line before that line or you can move it after the comment This is

[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #3077: arch/stm32l4: Fix nxstyle errors

2021-03-16 Thread GitBox
jerpelea commented on a change in pull request #3077: URL: https://github.com/apache/incubator-nuttx/pull/3077#discussion_r595295977 ## File path: arch/arm/include/stm32l4/stm32l4x3xx_irq.h ## @@ -113,7 +117,7 @@ /* Reserved */ /* 50:

[GitHub] [incubator-nuttx] jerpelea opened a new pull request #3078: boards: Author Gregory Nutt: update licenses to Apache

2021-03-16 Thread GitBox
jerpelea opened a new pull request #3078: URL: https://github.com/apache/incubator-nuttx/pull/3078 ## Summary Gregory Nutt has submitted the SGA and we can migrate the licenses to Apache. ## Impact NONE ## Testing NONE

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3045: fs: Allocate file/socket dynamically

2021-03-16 Thread GitBox
davids5 commented on a change in pull request #3045: URL: https://github.com/apache/incubator-nuttx/pull/3045#discussion_r595303957 ## File path: sched/Kconfig ## @@ -1058,12 +1058,12 @@ config SDCLONE_DISABLE descriptors by task_create() when a new task is started. If

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3070: fs/mmap: Return EACCES for incompatible file descriptors

2021-03-16 Thread GitBox
xiaoxiang781216 merged pull request #3070: URL: https://github.com/apache/incubator-nuttx/pull/3070 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated (fb7a5b8 -> c80cdf0)

2021-03-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from fb7a5b8 arch:rv64:c906:demo protect build without PMP. add c80cdf0 fs/mmap: Return EACCES for inco

[incubator-nuttx] branch master updated (c80cdf0 -> c9db653)

2021-03-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from c80cdf0 fs/mmap: Return EACCES for incompatible file descriptors add c9db653 symtabs: improve hand

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3065: symtabs: remove leading underscores and simplify lookups

2021-03-16 Thread GitBox
xiaoxiang781216 merged pull request #3065: URL: https://github.com/apache/incubator-nuttx/pull/3065 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3070: fs/mmap: Return EACCES for incompatible file descriptors

2021-03-16 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3070: URL: https://github.com/apache/incubator-nuttx/pull/3070#discussion_r595384092 ## File path: fs/mmap/fs_mmap.c ## @@ -142,6 +148,30 @@ FAR void *mmap(FAR void *start, size_t length, int prot, int flags, } #endi

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3070: fs/mmap: Return EACCES for incompatible file descriptors

2021-03-16 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3070: URL: https://github.com/apache/incubator-nuttx/pull/3070#discussion_r595387476 ## File path: fs/mmap/fs_mmap.c ## @@ -142,6 +148,30 @@ FAR void *mmap(FAR void *start, size_t length, int prot, int flags, } #endi

  1   2   >