xiaoxiang781216 commented on a change in pull request #3070:
URL: https://github.com/apache/incubator-nuttx/pull/3070#discussion_r595095530
##########
File path: fs/mmap/fs_mmap.c
##########
@@ -142,6 +148,30 @@ FAR void *mmap(FAR void *start, size_t length, int prot,
int flags,
}
#endif
+ if (fs_getfilep(fd, &filep) < 0)
Review comment:
errno is very useful to identify the failure location without
enabling/adding debug log. It make the debug a bit harder if we eat the return
code and then return the new fixed error code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
