Ouss4 commented on a change in pull request #566:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/566#discussion_r559987690
##
File path: crypto/mbedtls/Makefile
##
@@ -0,0 +1,68 @@
+
+# apps/
anchao opened a new pull request #2718:
URL: https://github.com/apache/incubator-nuttx/pull/2718
## Summary
sim/hcitty: remove the poll lock to avoid invalid wait
it it unnecessary to protect pollnotify() since the wakeup
source comes from idle thread
Signed-o
anchao opened a new pull request #2719:
URL: https://github.com/apache/incubator-nuttx/pull/2719
## Summary
sched/task: setup the scheduling policy to task
## Impact
kthread_create / nxtask_create
## Testing
enable CONFIG_RR_INTERVAL
before:
acassis commented on a change in pull request #2714:
URL: https://github.com/apache/incubator-nuttx/pull/2714#discussion_r56004
##
File path: arch/xtensa/src/common/xtensa_lwl_console.c
##
@@ -0,0 +1,314 @@
+/*
xiaoxiang781216 merged pull request #2718:
URL: https://github.com/apache/incubator-nuttx/pull/2718
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new a32856f sim/hcitty: remove the poll
acassis commented on pull request #2714:
URL: https://github.com/apache/incubator-nuttx/pull/2714#issuecomment-762787755
I will close this PR and submit a new one!
This is an automated message from the Apache Git Service.
To
acassis closed pull request #2714:
URL: https://github.com/apache/incubator-nuttx/pull/2714
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
xiaoxiang781216 commented on a change in pull request #2714:
URL: https://github.com/apache/incubator-nuttx/pull/2714#discussion_r560116477
##
File path: arch/xtensa/src/common/xtensa_lwl_console.c
##
@@ -0,0 +1,314 @@
+/*
xiaoxiang781216 opened a new pull request #2720:
URL: https://github.com/apache/incubator-nuttx/pull/2720
## Summary
and remove bthcisocket driver since uart shim driver can provide the same
functionality but more flexible.
## Impact
The call sequence change from:
```
Nut
acassis merged pull request #2719:
URL: https://github.com/apache/incubator-nuttx/pull/2719
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from a32856f sim/hcitty: remove the poll lock to avoid invalid wait
add 23b2876 sched/task: setup the sch
v01d commented on pull request #2720:
URL: https://github.com/apache/incubator-nuttx/pull/2720#issuecomment-762814949
I'm not entirely convinced that the serial interface is better than the
socket interface. I also don't really see much benefit of replacing it with
something that involves
v01d commented on pull request #2717:
URL: https://github.com/apache/incubator-nuttx/pull/2717#issuecomment-762815986
> > No, no address lines are exposed. The point is that I2C/SDA are not
shared so I need five different pairs of SDA/SCL (or changing I2C/SDA pins of
peripheral on the fly,
v01d commented on a change in pull request #2717:
URL: https://github.com/apache/incubator-nuttx/pull/2717#discussion_r560148634
##
File path: drivers/i2c/i2c_bitbang.c
##
@@ -0,0 +1,340 @@
+/
+ * arch/
v01d commented on a change in pull request #2717:
URL: https://github.com/apache/incubator-nuttx/pull/2717#discussion_r560149030
##
File path: drivers/i2c/i2c_bitbang.c
##
@@ -0,0 +1,340 @@
+/
+ * arch/
v01d commented on a change in pull request #2717:
URL: https://github.com/apache/incubator-nuttx/pull/2717#discussion_r560149625
##
File path: drivers/i2c/i2c_bitbang.c
##
@@ -0,0 +1,340 @@
+/
+ * arch/
v01d commented on a change in pull request #2717:
URL: https://github.com/apache/incubator-nuttx/pull/2717#discussion_r560149924
##
File path: drivers/i2c/i2c_bitbang.c
##
@@ -0,0 +1,340 @@
+/
+ * arch/
v01d commented on a change in pull request #2717:
URL: https://github.com/apache/incubator-nuttx/pull/2717#discussion_r560151107
##
File path: arch/arm/src/nrf52/nrf52_i2c_bitbang.c
##
@@ -0,0 +1,147 @@
+/*
v01d commented on a change in pull request #2717:
URL: https://github.com/apache/incubator-nuttx/pull/2717#discussion_r560151421
##
File path: drivers/i2c/i2c_bitbang.c
##
@@ -0,0 +1,340 @@
+/
+ * arch/
v01d commented on a change in pull request #2717:
URL: https://github.com/apache/incubator-nuttx/pull/2717#discussion_r560152808
##
File path: drivers/i2c/i2c_bitbang.c
##
@@ -0,0 +1,340 @@
+/
+ * arch/
v01d commented on a change in pull request #2717:
URL: https://github.com/apache/incubator-nuttx/pull/2717#discussion_r560153134
##
File path: drivers/i2c/i2c_bitbang.c
##
@@ -0,0 +1,340 @@
+/
+ * arch/
v01d commented on pull request #2717:
URL: https://github.com/apache/incubator-nuttx/pull/2717#issuecomment-762821614
Thanks for the reviews so far. I will measure pin toggling timings with
logic analyzer and see how it is looking right now. I will place 1.5k resistors
on the line without
xiaoxiang781216 commented on pull request #2720:
URL: https://github.com/apache/incubator-nuttx/pull/2720#issuecomment-762835680
> I'm not entirely convinced that the serial interface is better than the
socket interface. I also don't really see much benefit of replacing it with
something t
xiaoxiang781216 edited a comment on pull request #2720:
URL: https://github.com/apache/incubator-nuttx/pull/2720#issuecomment-762835680
> I'm not entirely convinced that the serial interface is better than the
socket interface. I also don't really see much benefit of replacing it with
some
xiaoxiang781216 opened a new pull request #567:
URL: https://github.com/apache/incubator-nuttx-apps/pull/567
## Summary
since romfs can return the soft link with the kernel change:
commit 67ef70d460db4695b950208d861ff47d4a40bdb3
Author: Xiang Xiao
Date: Mon Jul 6 00:34:32
juniskane opened a new pull request #568:
URL: https://github.com/apache/incubator-nuttx-apps/pull/568
## Summary
Some typos in examples/README.md and netutils TFTP client code, nxtyle
changes
## Impact
No functional change
## Testing
--
davids5 commented on pull request #2717:
URL: https://github.com/apache/incubator-nuttx/pull/2717#issuecomment-762860109
> Thanks for the reviews so far. I will measure pin toggling timings with
logic analyzer and see how it is looking right now. I will place 1.5k resistors
on the line wit
v01d commented on pull request #2717:
URL: https://github.com/apache/incubator-nuttx/pull/2717#issuecomment-762862610
> > Thanks for the reviews so far. I will measure pin toggling timings with
logic analyzer and see how it is looking right now. I will place 1.5k resistors
on the line with
Ouss4 commented on pull request #2716:
URL: https://github.com/apache/incubator-nuttx/pull/2716#issuecomment-762906652
@donghengqaz the defconfig supplied needs to be refreshed:
`./tools/refresh.sh --silent esp32-devkitc/aes`
---
btashton commented on pull request #2720:
URL: https://github.com/apache/incubator-nuttx/pull/2720#issuecomment-762937459
I absolutely do not see how this is "more correct" . If you want to just do
your own BT thing in userspace than fine just expose the UART and do it in
userspace, but re
v01d commented on pull request #2720:
URL: https://github.com/apache/incubator-nuttx/pull/2720#issuecomment-762952933
I tend to agree, this seems more of a preference than a clear benefit. It is
good to add the option (is it was when the hcitty driver was added), but
replacing one for the
patacongo commented on pull request #2720:
URL: https://github.com/apache/incubator-nuttx/pull/2720#issuecomment-762968868
>
>
> I tend to agree, this seems more of a preference than a clear benefit. It
is good to add the option (is it was when the hcitty driver was added), but
rep
patacongo edited a comment on pull request #2720:
URL: https://github.com/apache/incubator-nuttx/pull/2720#issuecomment-762968868
>
>
> I tend to agree, this seems more of a preference than a clear benefit. It
is good to add the option (is it was when the hcitty driver was added), b
xiaoxiang781216 commented on pull request #2720:
URL: https://github.com/apache/incubator-nuttx/pull/2720#issuecomment-762978080
Ok, I change the patch to enable hcitty to integrate with NuttX BLE stack,
but keep the hcisock as before. Please take a look.
> > I tend to agree, thi
xiaoxiang781216 commented on pull request #2720:
URL: https://github.com/apache/incubator-nuttx/pull/2720#issuecomment-762978508
Ok, I change the patch to enable hcitty to integrate with NuttX BLE stack,
but keep the hcisock as before. Please take a look.
> > I tend to agree, thi
xiaoxiang781216 removed a comment on pull request #2720:
URL: https://github.com/apache/incubator-nuttx/pull/2720#issuecomment-762978080
Ok, I change the patch to enable hcitty to integrate with NuttX BLE stack,
but keep the hcisock as before. Please take a look.
> > I tend to ag
patacongo commented on pull request #2720:
URL: https://github.com/apache/incubator-nuttx/pull/2720#issuecomment-762989860
I think that a better, more roadmap friendly solution, would be a raw HCI
interface. Brennan and Matias discusses this some time back but I am not sure
what happened
patacongo edited a comment on pull request #2720:
URL: https://github.com/apache/incubator-nuttx/pull/2720#issuecomment-762989860
I think that a better, more roadmap friendly solution, would be a raw HCI
interface. Brennan and Matias discusses this some time back but I am not sure
what ha
patacongo edited a comment on pull request #2720:
URL: https://github.com/apache/incubator-nuttx/pull/2720#issuecomment-762989860
I think that a better, more roadmap friendly solution, would be a raw HCI
interface. Brennan and Matias discusses this some time back but I am not sure
what ha
btashton commented on pull request #2720:
URL: https://github.com/apache/incubator-nuttx/pull/2720#issuecomment-762995775
> I think that a better, more roadmap friendly solution, would be a raw HCI
interface. Brennan and Matias discusses this some time back but I am not sure
what happened
v01d commented on pull request #2720:
URL: https://github.com/apache/incubator-nuttx/pull/2720#issuecomment-762997126
> I think that a better, more roadmap friendly solution, would be a raw HCI
interface. Brennan and Matias discusses this some time back but I am not sure
what happened with
xiaoxiang781216 commented on pull request #2720:
URL: https://github.com/apache/incubator-nuttx/pull/2720#issuecomment-762999677
BTW, since BT stack is still supported by many chipset, it's important that
RAW/monitor socket support BT traffic too.
-
xiaoxiang781216 edited a comment on pull request #2720:
URL: https://github.com/apache/incubator-nuttx/pull/2720#issuecomment-762999677
BTW, since BT stack is still supported by many chipset, it's important that
RAW/monitor socket support BT traffic too before NuttX get native BT stack
sup
v01d commented on pull request #2720:
URL: https://github.com/apache/incubator-nuttx/pull/2720#issuecomment-763000952
Also, not to continue derailing the PR analysis, but an important discussion
is to decide what to do with NuttX's BLE host layer (I talked about this
before). At least, it
xiaoxiang781216 edited a comment on pull request #2720:
URL: https://github.com/apache/incubator-nuttx/pull/2720#issuecomment-762999677
BTW, since old BT protocol is still supported by many chipset, it's
important that RAW/monitor socket support BT traffic too before NuttX get
native BT st
Ouss4 merged pull request #568:
URL: https://github.com/apache/incubator-nuttx-apps/pull/568
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git.
from ee1f4fd webclient: Don't call the sink callback if no data is
available
add b66002c exampl
fjpanag commented on pull request #2717:
URL: https://github.com/apache/incubator-nuttx/pull/2717#issuecomment-763080354
> BTW, this is yet untested since I'm unsure about proper GPIO handling on
nRF52. I understand that the pin should be set to open-drain, but I think nRF52
does not reall
v01d commented on pull request #2717:
URL: https://github.com/apache/incubator-nuttx/pull/2717#issuecomment-763085650
Yes, I will start with the S0D1 mode (standard drive 0, disconnect 1). That
should be safe.
You're right about the pullup, I think 4k7 is the typical value. I think I
co
acassis opened a new pull request #2721:
URL: https://github.com/apache/incubator-nuttx/pull/2721
## Summary
Replace the old ESP32 efuse driver to use generic driver
## Impact
User will get better driver to use
## Testing
ESP32
---
yamt opened a new pull request #569:
URL: https://github.com/apache/incubator-nuttx-apps/pull/569
## Summary
Detected by clang static analyzer.
## Impact
## Testing
This is an automated message from the Apach
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 74bf699 Publishing web
xiaoxiang781216 merged pull request #569:
URL: https://github.com/apache/incubator-nuttx-apps/pull/569
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 412cf2b webclient: Fix a use o
SChina-CSC-SDD-Dev commented on a change in pull request #2625:
URL: https://github.com/apache/incubator-nuttx/pull/2625#discussion_r560689178
##
File path: sched/wdog/wd_getidletime.c
##
@@ -0,0 +1,64 @@
+/***
SChina-CSC-SDD-Dev commented on a change in pull request #2625:
URL: https://github.com/apache/incubator-nuttx/pull/2625#discussion_r560690115
##
File path: sched/wdog/wd_setsleepticks.c
##
@@ -0,0 +1,65 @@
+/*
SChina-CSC-SDD-Dev commented on pull request #2625:
URL: https://github.com/apache/incubator-nuttx/pull/2625#issuecomment-763350514
I agree this simple API will have minimal impact.
This is an automated message from the Apach
xiaoxiang781216 commented on a change in pull request #2625:
URL: https://github.com/apache/incubator-nuttx/pull/2625#discussion_r560693468
##
File path: sched/wdog/wd_getidletime.c
##
@@ -0,0 +1,64 @@
+/**
xiaoxiang781216 commented on a change in pull request #2625:
URL: https://github.com/apache/incubator-nuttx/pull/2625#discussion_r560694031
##
File path: sched/wdog/wd_getidletime.c
##
@@ -0,0 +1,64 @@
+/**
xiaoxiang781216 commented on a change in pull request #2625:
URL: https://github.com/apache/incubator-nuttx/pull/2625#discussion_r560694031
##
File path: sched/wdog/wd_getidletime.c
##
@@ -0,0 +1,64 @@
+/**
xiaoxiang781216 commented on a change in pull request #2625:
URL: https://github.com/apache/incubator-nuttx/pull/2625#discussion_r560694031
##
File path: sched/wdog/wd_getidletime.c
##
@@ -0,0 +1,64 @@
+/**
62 matches
Mail list logo
