Ouss4 commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653746422
> The missing init.d I suspect is caused because inside that folder is a rcS
file.
Isn't because it's being confused with make dependency files? In any case,
this is a
Ouss4 commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653752098
I think short term solution is to remove the `exclude-vcs-ignores` option.
One should make sure that the repo is clean, zipme does a `distclean`. Also
any file that was adde
yamt commented on a change in pull request #1355:
URL: https://github.com/apache/incubator-nuttx/pull/1355#discussion_r449765278
##
File path: include/sys/statvfs.h
##
@@ -49,7 +49,14 @@
* Pre-processor Definitions
***
patacongo commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653757037
> However, I don't understand why the "*.asm" files are ignored in the first
place. Those are our files, they should be kept under version control.
My recollection i
patacongo commented on pull request #1194:
URL: https://github.com/apache/incubator-nuttx/pull/1194#issuecomment-653757807
Humm.. It was probably a mistake to merge this one. _exit is the standard
name for this function. See https://linux.die.net/man/2/_exit
--
patacongo edited a comment on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653757037
> However, I don't understand why the "*.asm" files are ignored in the first
place. Those are our files, they should be kept under version control.
My recolle
patacongo commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653758312
> I think short term solution is to remove the `exclude-vcs-ignores` option.
One should make sure that the repo is clean, zipme does a `distclean`. Also any
file that was
Ouss4 commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653759383
Yes some tools generate `.asm` files. BTW, is it possible to use the .S
extension for Z80 assembly files?
> But if my hunch is correct, this would leave the .gitignore
xiaoxiang781216 commented on pull request #1194:
URL: https://github.com/apache/incubator-nuttx/pull/1194#issuecomment-653760117
> Humm.. It was probably a mistake to merge this one. _exit is the standard
name for this function. See https://linux.die.net/man/2/_exit
_exit still exist
xiaoxiang781216 commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653760770
> > However, I don't understand why the "*.asm" files are ignored in the
first place. Those are our files, they should be kept under version control.
>
> My re
xiaoxiang781216 opened a new pull request #1364:
URL: https://github.com/apache/incubator-nuttx/pull/1364
## Summary
since zipme.sh(with --exclude-vcs-ignores) fail to copy z80's assembler
files(.asm).
## Impact
## Testing
-
xiaoxiang781216 edited a comment on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653760770
> > However, I don't understand why the "*.asm" files are ignored in the
first place. Those are our files, they should be kept under version control.
>
xiaoxiang781216 commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653761360
Here is the patch: https://github.com/apache/incubator-nuttx/pull/1364
let's see the result.
This
xiaoxiang781216 opened a new pull request #1365:
URL: https://github.com/apache/incubator-nuttx/pull/1365
and change the 1st argument from "const uint8_t *" to "const char *"
## Summary
Ensure all arch function is declared inside nuttx/arch.h
## Impact
No functionality ch
patacongo commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653765144
> BTW, is it possible to use the .S extension for Z80 assembly files?
No, unfortunately not. I do use .S file now and then and autogenerate the
.asm files using the
xiaoxiang781216 opened a new pull request #1366:
URL: https://github.com/apache/incubator-nuttx/pull/1366
and change the type of divb7 from float32_t to float.
## Summary
Suggested by @yamt here:
https://github.com/apache/incubator-nuttx/pull/1340
## Impact
No function
xiaoxiang781216 commented on a change in pull request #1340:
URL: https://github.com/apache/incubator-nuttx/pull/1340#discussion_r449772507
##
File path: arch/arm/src/tms570/tms570_lowputc.c
##
@@ -272,19 +273,20 @@ void tms570_lowsetup(void)
#endif
}
-/
xiaoxiang781216 commented on a change in pull request #1340:
URL: https://github.com/apache/incubator-nuttx/pull/1340#discussion_r449772533
##
File path: arch/arm/src/tms570/tms570_lowputc.c
##
@@ -272,19 +273,20 @@ void tms570_lowsetup(void)
#endif
}
-/
Ouss4 commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653765410
GIT is still tracking the Z80 .asm files since they were there before the
gitignore change. Any new file with the .asm extension will be ignored though.
Here is a quick way
xiaoxiang781216 commented on issue #1356:
URL:
https://github.com/apache/incubator-nuttx/issues/1356#issuecomment-653769946
@dieselburner it's unfortunate that SPI and QSPI don't share the same common
driver interface as much as possible. Most external perpherals support both SPI
and QSPI
patacongo commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653770349
> GIT is still tracking the Z80 .asm files since they were there before the
gitignore change. Any new file with the .asm extension will be ignored though.
Yes, but t
xiaoxiang781216 commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653770679
@patacongo @btashton @Ouss4 #1364 pass the build which mean we can remove
*.asm from .gitignore without problem.
---
Ouss4 commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653771281
> Yes, but there is still a bug. If you modify one of the .asm files, your
modifications will not be included in the commit. That is very bad.
It is a bug but if you mod
patacongo commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653772126
I believe that the issue is the the ZDS-II toolchain assembly files have the
extension .asm but when you compile a .c file it generates a temporary .asm
file that is then
xiaoxiang781216 commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653772045
> We can merge then, this solves the Z80 .asm part. But please don't close
this issue, we still have init.d to worry about.
Ok, I remove #1364 from the link.
patacongo commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653772547
Is there any .gitignore syntax to undo a higher level .gitignore file? We
really only need to NOT ignore .asm files in those few low level directories
where there the .as
patacongo edited a comment on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653772126
I believe that the issue is the the ZDS-II toolchain assembly files have the
extension .asm but when you compile a .c file it generates a temporary .asm
file that i
Ouss4 commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653773157
> Is there any .gitignore syntax to undo a higher level .gitignore file?
This should do:
```diff
diff --git a/arch/z80/src/.gitignore b/arch/z80/src/.gitignore
i
patacongo commented on pull request #1364:
URL: https://github.com/apache/incubator-nuttx/pull/1364#issuecomment-653773280
This is not a good change and should not be merged. All ZDS-II toolchain
assembly files have the extension .asm but when you compile a .c file it
generates a temporar
patacongo commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653773944
#1364 should not be merged. It is incorrect.
My recommendation is to revert #1106. A modified version can be re-applied
after the release.
--
patacongo edited a comment on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653773944
#1364 should not be merged. It is incorrect. See the comments above and in
#1364
My recommendation is to revert #1106. A modified version can be re-applied
xiaoxiang781216 commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653774683
> I believe that the issue is the the ZDS-II toolchain assembly files have
the extension .asm but when you compile a .c file it generates a temporary .asm
file that
patacongo commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653775527
> Your description isn't self-consistent:
> 1.If git ignore *.asm, git can't track the manual written assembler files.
> 2.If git don't ignore *.asm, the generated ass
patacongo commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653775748
> Is there any .gitignore syntax to undo a higher level .gitignore file? We
really only need to NOT ignore .asm files in those few low level directories
where there the .a
patacongo opened a new pull request #1367:
URL: https://github.com/apache/incubator-nuttx/pull/1367
## Summary
Do not ignore .asm files that are tracked.
The ZDS-II toolchain assembly files have the extension .asm but when you
compile a .c file it generates a temporary .asm fi
patacongo commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653776709
I believe that PR #1367 will fix the issue with the .asm files. Can you
please verify that?
This is an a
patacongo commented on pull request #1364:
URL: https://github.com/apache/incubator-nuttx/pull/1364#issuecomment-653776820
Replaced with PR #1367
This is an automated message from the Apache Git Service.
To respond to the mes
patacongo edited a comment on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653776709
I believe that PR #1367 will fix the issue with the .asm files. Can you
please verify that? This replaces PR #1364 (which I closed).
patacongo closed pull request #1364:
URL: https://github.com/apache/incubator-nuttx/pull/1364
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Ouss4 commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653777038
Do you need to ignore them in every sub-directory? Doesn't the z80/src
suffice?
I suggested this before
```diff
diff --git a/arch/z80/src/.gitignore b/arch/z80/src/.g
Ouss4 edited a comment on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653777038
Do you need to ignore them in every sub-directory? Doesn't the z80/src
suffice?
I suggested this above:
```diff
diff --git a/arch/z80/src/.gitignore b/arch/z80
patacongo commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653777423
> Do you need to ignore them in every sub-directory? Doesn't the z80/src
suffice?
No, that will not work. All of the generated, temporary .asm files will
exist in
patacongo edited a comment on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653777423
> Do you need to ignore them in every sub-directory? Doesn't the z80/src
suffice?
No, that will not work. All of the generated, temporary .asm files will
ex
davids5 merged pull request #1366:
URL: https://github.com/apache/incubator-nuttx/pull/1366
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
davids5 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 95aa3a1 arch/tms570: Remove the unuse
davids5 commented on pull request #1365:
URL: https://github.com/apache/incubator-nuttx/pull/1365#issuecomment-653779983
@xiaoxiang781216 Is there more in the PR that you have suggested? i.e. The
removal of CONFIG_HAVE_FILENAME
-
Ouss4 commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653780125
> This used to work fine before because arch/z80/src/.gitignore contained
/*.asm which ignored the .asm files ONLY in that directory and not the lower
level directories. We ne
patacongo commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653781947
> We can chain patterns like the following:
Sure ... go ahead. This would be a new PR.
This is an
patacongo edited a comment on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653781947
> We can chain patterns like the following:
Except we still need to ignore the .asm files in the (copied) board
sub-directory.
-
patacongo edited a comment on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653781947
> We can chain patterns like the following:
Except we still need to ignore the .asm files in the (copied) board
sub-directory. Since there are no symbolic li
patacongo edited a comment on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653781947
> We can chain patterns like the following:
Except we still need to ignore the .asm files in the (copied) board
sub-directory. Since there are no symbolic li
patacongo edited a comment on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653781947
> We can chain patterns like the following:
Except we still need to ignore the .asm files in the (copied) board
sub-directory. Since there are no symbolic li
xiaoxiang781216 commented on pull request #1365:
URL: https://github.com/apache/incubator-nuttx/pull/1365#issuecomment-653786228
> @xiaoxiang781216 Is there more in the PR that you have suggested? i.e. The
removal of CONFIG_HAVE_FILENAME
Yes, here https://github.com/apache/incubator-
xiaoxiang781216 commented on pull request #1365:
URL: https://github.com/apache/incubator-nuttx/pull/1365#issuecomment-653786663
@patacongo this patch remove exit call from up_assert which is part of
https://github.com/apache/incubator-nuttx/issues/1263.
--
patacongo commented on pull request #1367:
URL: https://github.com/apache/incubator-nuttx/pull/1367#issuecomment-653786940
See discussion of this change in Issue #1363
This is an automated message from the Apache Git Service
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 2481b1b Do not ignore .asm files
Ouss4 merged pull request #1367:
URL: https://github.com/apache/incubator-nuttx/pull/1367
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Ouss4 commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653788378
I was trying to replicate the old behavior, but apparently there is more to
it.
I merged #1367. @xiaoxiang781216 This means that we don't need to remove
*.asm from the top
patacongo opened a new issue #1368:
URL: https://github.com/apache/incubator-nuttx/issues/1368
When the VNC server was created initially, it worked well. However, in 2019
as part of the Twm4Nx development, I tried to use it and it did not work.
These are problems that I noted:
* M
patacongo commented on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653790376
> Except we still need to ignore the .asm files in the (copied) board
sub-directory. Since there are no symbolic links in this particular Windows
configuration, the board
patacongo edited a comment on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653790376
> Except we still need to ignore the .asm files in the (copied) board
sub-directory. Since there are no symbolic links in this particular Windows
configuration, the
patacongo edited a comment on issue #1363:
URL:
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653790376
> Except we still need to ignore the .asm files in the (copied) board
sub-directory. Since there are no symbolic links in this particular Windows
configuration, the
xiaoxiang781216 opened a new pull request #326:
URL: https://github.com/apache/incubator-nuttx-apps/pull/326
and move NUTTXLIB defintion to the common place
## Summary
So the common variables(e.g. NUTTXLIB) which is shared in apps can be put
into a common place(apps/Make.defs).
adamfeuer commented on pull request #1349:
URL: https://github.com/apache/incubator-nuttx/pull/1349#issuecomment-653816418
@Ouss4 I changed license header to APL 2.0. Is it ready to merge now?
This is an automated message fro
64 matches
Mail list logo
