xiaoxiang781216 edited a comment on issue #1363:
URL: 
https://github.com/apache/incubator-nuttx/issues/1363#issuecomment-653760770


   > > However, I don't understand why the "*.asm" files are ignored in the 
first place. Those are our files, they should be kept under version control.
   > 
   > My recollection is that there was recently a change by Xiao Xiang that 
reorganized and combined, gitignore files. It removed many .gitignore files and 
combined them at a higher level. I suspect that this introduced the error for 
.asm files. I think that for some tools, .asm is the proper name for assembly 
files. I think that for others, .asm are generated files.
   > 
   > If my suspicion is true, then the correct fix is to revert parts of that 
PR, Maybe #1106 ? I can't look now, I am using my phone.
   
   Yes, I move .asm to the top level of .gitigonre since *.asm appear in many 
sub .gitigonre. The build system can catch the orphan files error, so we can 
simplify remove *.asm from the top level .gitigonre and see which folder really 
need this and add it back one by one.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to