yamt commented on pull request #1172:
URL: https://github.com/apache/incubator-nuttx/pull/1172#issuecomment-637335420
@jerpelea where can i find the rule?
i scanned "Code Contribution Workflow". but i failed to find it.
Th
jerpelea commented on pull request #1172:
URL: https://github.com/apache/incubator-nuttx/pull/1172#issuecomment-637336329
@yamt
https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53
This is an automated me
jerpelea edited a comment on pull request #1172:
URL: https://github.com/apache/incubator-nuttx/pull/1172#issuecomment-637336329
@yamt
https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53
It is a good advice for all commits not a rule for NuttX
-
yamt commented on pull request #1172:
URL: https://github.com/apache/incubator-nuttx/pull/1172#issuecomment-637344215
@jerpelea
ok, i added some text.
honestly speaking, i feel the original commit messages were good enough for
this kind of obvious things though.
---
xiaoxiang781216 opened a new pull request #283:
URL: https://github.com/apache/incubator-nuttx-apps/pull/283
Signed-off-by: Xiang Xiao
Change-Id: Iabedaa5da6439f4bfc34fb861382276446b4224f
## Summary
## Impact
## Testing
-
xiaoxiang781216 commented on issue #1158:
URL:
https://github.com/apache/incubator-nuttx/issues/1158#issuecomment-637347205
@papatience @Ouss4 it seems that the dependence in Makefile is wrong, please
review the fix at:
https://github.com/apache/incubator-nuttx-apps/pull/283
-
jerpelea commented on pull request #1172:
URL: https://github.com/apache/incubator-nuttx/pull/1172#issuecomment-637348741
@yamt thanks.
Sometimes is hard to state the obvious but it may be usefull for others to
understand the reason
-
This is an automated email from the ASF dual-hosted git repository.
jerpelea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 4f0957a threads.h: Support mtx_timed
jerpelea merged pull request #1174:
URL: https://github.com/apache/incubator-nuttx/pull/1174
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
yamt commented on a change in pull request #1173:
URL: https://github.com/apache/incubator-nuttx/pull/1173#discussion_r433683505
##
File path: include/limits.h
##
@@ -68,6 +70,13 @@
# endif
#endif
+/* Maximum length of any multibyte character in any locale.
+ * We define t
xiaoxiang781216 commented on a change in pull request #1173:
URL: https://github.com/apache/incubator-nuttx/pull/1173#discussion_r433687628
##
File path: include/limits.h
##
@@ -68,6 +70,13 @@
# endif
#endif
+/* Maximum length of any multibyte character in any locale.
+ *
This is an automated email from the ASF dual-hosted git repository.
jerpelea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit d884dd301fee130698e4a2e2f47f4463d188edeb
Author: YAMAMOTO Takashi
AuthorDate: Tue Jun 2 13:55:55 2020 +0900
jerpelea merged pull request #1172:
URL: https://github.com/apache/incubator-nuttx/pull/1172
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
jerpelea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 86b7c20b7d090c5720e297829757323253b2ba0c
Author: YAMAMOTO Takashi
AuthorDate: Tue Jun 2 13:51:12 2020 +0900
This is an automated email from the ASF dual-hosted git repository.
jerpelea pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 4f0957a threads.h: Support mtx_timedlock and recursive mutex
new d884dd3 Fix nxstyle complaints
jerpelea commented on pull request #380:
URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-637410662
@yamt please comment
This is an automated message from the Apache Git Service.
To respond to the message,
jerpelea commented on a change in pull request #1173:
URL: https://github.com/apache/incubator-nuttx/pull/1173#discussion_r433742318
##
File path: include/limits.h
##
@@ -68,6 +70,13 @@
# endif
#endif
+/* Maximum length of any multibyte character in any locale.
+ * We defi
xiaoxiang781216 opened a new pull request #1175:
URL: https://github.com/apache/incubator-nuttx/pull/1175
let toolchain decide the correct value base on the command line
Signed-off-by: Xiang Xiao
Change-Id: I342db6a88e4a161a322a8fea48a59e6ca7617ae6
## Summary
## Impa
xiaoxiang781216 commented on a change in pull request #1173:
URL: https://github.com/apache/incubator-nuttx/pull/1173#discussion_r433765238
##
File path: include/limits.h
##
@@ -68,6 +70,13 @@
# endif
#endif
+/* Maximum length of any multibyte character in any locale.
+ *
yamt commented on pull request #380:
URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-637448228
i guess the problem still exists. but i'm not looking at KERNEL build these
days. it's great if someone more familiar with KERNEL build can take this over.
-
jerpelea merged pull request #283:
URL: https://github.com/apache/incubator-nuttx-apps/pull/283
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
This is an automated email from the ASF dual-hosted git repository.
jerpelea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 8f18b23 examples: Fix the wrong
davids5 commented on a change in pull request #1165:
URL: https://github.com/apache/incubator-nuttx/pull/1165#discussion_r433795441
##
File path: arch/arm/src/stm32h7/stm32_spi.c
##
@@ -2114,6 +2109,11 @@ static void spi_exchange(FAR struct spi_dev_s *dev, FAR
const void *txbu
davids5 commented on a change in pull request #1165:
URL: https://github.com/apache/incubator-nuttx/pull/1165#discussion_r433809648
##
File path: arch/arm/src/stm32h7/stm32_spi.c
##
@@ -2114,6 +2109,11 @@ static void spi_exchange(FAR struct spi_dev_s *dev, FAR
const void *txbu
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 4fe35cc boards: Remove OUTPUT_FORMAT an
patacongo merged pull request #1175:
URL: https://github.com/apache/incubator-nuttx/pull/1175
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 4fe35cc boards: Remove OUTPUT_FORMAT and OUTPUT_ARCH from ld script
new 57caa4e libc: Move MB_LEN_MAX
patacongo merged pull request #1173:
URL: https://github.com/apache/incubator-nuttx/pull/1173
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 7cbcbcde51052fc854c6feac0a96558cb70613fa
Author: Xiang Xiao
AuthorDate: Tue Jun 2 12:22:26 2020 +0800
libc:
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit de509004fddbff4a2aa2349589752677244a8967
Author: Xiang Xiao
AuthorDate: Tue Jun 2 13:54:30 2020 +0800
libc:
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 57caa4e12121fa4af736f172c03dd09c6223c671
Author: Xiang Xiao
AuthorDate: Tue Jun 2 12:03:59 2020 +0800
libc:
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit f1433ee8d20d3da01ab3ec0384896e44fc0b9f2c
Author: Xiang Xiao
AuthorDate: Tue Jun 2 13:46:55 2020 +0800
libc:
xiaoxiang781216 opened a new pull request #284:
URL: https://github.com/apache/incubator-nuttx-apps/pull/284
Signed-off-by: Xiang Xiao
Change-Id: If6b324c20fcb245633f3bdc9000bc48f581c7dc6
## Summary
## Impact
## Testing
-
xiaoxiang781216 opened a new pull request #1176:
URL: https://github.com/apache/incubator-nuttx/pull/1176
Signed-off-by: Xiang Xiao
Change-Id: I44a26550ff856af07d2d96a6f0a6066f988d6da3
## Summary
## Impact
## Testing
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 5f0179e5b60ca09b2aa928867e96ee7648773d76
Author: Peter van der Perk
AuthorDate: Wed Mar 18 12:27:39 2020 +010
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 8a737215fa454c176b8967e85393eb85bbd30e56
Author: Jari van Ewijk
AuthorDate: Fri Mar 13 17:27:21 2020 +0100
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 437ca3a3a52abd32e4b23a8293871ac7f73ae54b
Author: Peter van der Perk
AuthorDate: Tue Feb 25 08:28:20 2020 +010
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 53fe91ca5840e03955f9a31dd40696d05ffd358e
Author: Gregory Nutt
AuthorDate: Thu Feb 13 09:57:38 2020 -0600
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 1f32cf314ade6950b8066b58375f9648ed302d0e
Author: Peter van der Perk
AuthorDate: Mon Mar 9 12:47:26 2020 +0100
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 80582342e991014f5026ba6638f8fde617f2cce0
Author: Jari van Ewijk
AuthorDate: Fri Mar 13 13:48:10 2020 +0100
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit ec7b886e97b893353263f1f43beeb4247bfcdcb1
Author: Peter van der Perk
AuthorDate: Wed Mar 18 12:18:30 2020 +010
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit a84840881a26d431d43b004765649c948b8adfc0
Author: Gregory Nutt
AuthorDate: Fri Feb 21 11:17:10 2020 -0600
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit c9844c2d3f641910880ad2d9e90734c26133d3ec
Author: Jari van Ewijk
AuthorDate: Mon Mar 16 09:03:03 2020 +0100
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 059d44838793ebb2520c35430619fbdf7612ce72
Author: Peter van der Perk
AuthorDate: Wed Mar 18 09:13:34 2020 +010
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 95d8441a09607d66c480e54126f30a8947dcea4b
Author: Jari van Ewijk
AuthorDate: Fri Mar 13 14:30:32 2020 +0100
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 785ef9d12fe47c82965d2a6023d1dd5627e343a4
Author: Peter van der Perk
AuthorDate: Mon Mar 9 13:51:28 2020 +0100
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit e01749593b5292368c6cb5be9a2bb1dbe3798199
Author: Peter van der Perk
AuthorDate: Wed Mar 11 16:13:18 2020 +010
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit d6502bcba39aa85c9614e8bf49bf24d72157a4e9
Author: Peter van der Perk
AuthorDate: Mon Mar 9 13:49:11 2020 +0100
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 754b9ae6e755720ac1caeab75d550e8ba5af8614
Author: Peter van der Perk
AuthorDate: Wed Mar 11 14:32:52 2020 +010
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 46c67a47a0d24cb9ea8939d1c2ce8ff9b1474f47
Author: Gregory Nutt
AuthorDate: Thu Feb 13 09:59:00 2020 -0600
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 6d8e06bcf0bfb69f46197a0bd2daeee0668bb79d
Author: Peter van der Perk
AuthorDate: Tue Feb 25 16:56:26 2020 +010
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 72d10458eca8b6a3fcea4c7d3ba45883b367653d
Author: Peter van der Perk
AuthorDate: Thu Feb 20 16:06:15 2020 +010
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 0fe722cc64f6d9065aecacc924d69efd3ca16998
Author: Peter van der Perk
AuthorDate: Wed Mar 18 11:33:53 2020 +010
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 9ec0f58018abc18c2a00cec2a68ce7945e824dbe
Author: Gregory Nutt
AuthorDate: Thu Feb 13 09:58:12 2020 -0600
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit d600a3dca452519c129d04f03244dff048970428
Author: Peter van der Perk
AuthorDate: Wed Feb 19 11:24:31 2020 +010
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit e67d2cbee8c485344b487aab3700fc4690aa4984
Author: Peter van der Perk
AuthorDate: Thu Mar 5 09:49:41 2020 +0100
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 8d24e580c2120e61248384ba3a25f26edb832c07
Author: Peter van der Perk
AuthorDate: Fri Mar 6 15:20:15 2020 +0100
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 5f13717f56e276ef5d7a79aca50d8fea5759ccfd
Author: Jari van Ewijk
AuthorDate: Fri Mar 13 12:29:56 2020 +0100
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit cd52a3f042dfdec9eaa2646da4bfad850ad277c8
Author: Peter van der Perk
AuthorDate: Thu Mar 12 13:59:33 2020 +010
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit b76d6099a570a5ff08893155e79d61c3ffb66d7c
Author: Peter van der Perk
AuthorDate: Fri Feb 21 16:24:54 2020 +010
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit f08151cc60ddc05b952de091aba53c68ef18c89c
Author: Peter van der Perk
AuthorDate: Tue Mar 17 13:57:22 2020 +010
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 8bc2922f22d77ad565aafdcdde956c3a39718cab
Author: Peter van der Perk
AuthorDate: Thu Mar 5 16:36:56 2020 +0100
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit b37b61614d4a843568bbac4dc4a0f92f5738224b
Author: Peter van der Perk
AuthorDate: Fri Mar 13 18:12:29 2020 +010
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 1fa53edb62ae731af44ef7677f7b422fad547d95
Author: Peter van der Perk
AuthorDate: Wed Feb 26 13:36:24 2020 +010
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch SocketCAN
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 5076da1aabb04f3ff7ee8c9cb176b33700aa03ce
Author: Peter van der Perk
AuthorDate: Wed Feb 19 17:46:37 2020 +010
jlaitine commented on pull request #1165:
URL: https://github.com/apache/incubator-nuttx/pull/1165#issuecomment-637583827
I sure can, but why squash? Isn't it nicer to have separate changes as
separate commits?
This is an au
jlaitine removed a comment on pull request #1165:
URL: https://github.com/apache/incubator-nuttx/pull/1165#issuecomment-637583827
I sure can, but why squash? Isn't it nicer to have separate changes as
separate commits?
This
jlaitine commented on a change in pull request #1165:
URL: https://github.com/apache/incubator-nuttx/pull/1165#discussion_r433931473
##
File path: arch/arm/src/stm32h7/stm32_spi.c
##
@@ -2114,6 +2109,11 @@ static void spi_exchange(FAR struct spi_dev_s *dev, FAR
const void *txb
davids5 commented on a change in pull request #1165:
URL: https://github.com/apache/incubator-nuttx/pull/1165#discussion_r433945279
##
File path: arch/arm/src/stm32h7/stm32_spi.c
##
@@ -2114,6 +2109,11 @@ static void spi_exchange(FAR struct spi_dev_s *dev, FAR
const void *txbu
patacongo opened a new pull request #1177:
URL: https://github.com/apache/incubator-nuttx/pull/1177
## Summary
arch/z80/src/Makefile: Correct inclusion of non-existent file. This was
not a problem before because there was '-' before the include. Problem
revealed with '-' removed.
patacongo commented on pull request #1176:
URL: https://github.com/apache/incubator-nuttx/pull/1176#issuecomment-637624439
>
>
> @xiaoxiang781216 - please check the history on the addition of
`defined(__cplusplus)` I seam to recall @patacongo added this for a reason
(that I do not
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit a7174cee30c85696debacbeef0a7e5a2b111f620
Author: Xiang Xiao
AuthorDate: Tue Jun 2 21:41:13 2020 +0800
libc:
patacongo merged pull request #1176:
URL: https://github.com/apache/incubator-nuttx/pull/1176
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 9ff32427bf02b646e86f23d48265e80f8853ef6b
Author: Xiang Xiao
AuthorDate: Tue Jun 2 22:53:45 2020 +0800
libc:
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from de50900 libc: Implement mblen, mbstowcs and wcstombs
new a7174ce libc: Unify the selection of inline o
xiaoxiang781216 opened a new pull request #1178:
URL: https://github.com/apache/incubator-nuttx/pull/1178
Signed-off-by: Xiang Xiao
Change-Id: Ic6db2c76844a5a9d503fc46bb4b930870afbd9ed
## Summary
Typo error by: https://github.com/apache/incubator-nuttx/pull/1176
## Impac
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 6b3ac93 libc: Fix a typo error in tmpfi
patacongo merged pull request #1178:
URL: https://github.com/apache/incubator-nuttx/pull/1178
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
acassis merged pull request #1177:
URL: https://github.com/apache/incubator-nuttx/pull/1177
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 0da3400 ez80: Fix ez80 build problem
jlaitine commented on a change in pull request #1165:
URL: https://github.com/apache/incubator-nuttx/pull/1165#discussion_r434016051
##
File path: arch/arm/src/stm32h7/stm32_spi.c
##
@@ -2114,6 +2109,11 @@ static void spi_exchange(FAR struct spi_dev_s *dev, FAR
const void *txb
jlaitine commented on a change in pull request #1165:
URL: https://github.com/apache/incubator-nuttx/pull/1165#discussion_r434016051
##
File path: arch/arm/src/stm32h7/stm32_spi.c
##
@@ -2114,6 +2109,11 @@ static void spi_exchange(FAR struct spi_dev_s *dev, FAR
const void *txb
xiaoxiang781216 opened a new pull request #1179:
URL: https://github.com/apache/incubator-nuttx/pull/1179
Signed-off-by: Xiang Xiao
Change-Id: I2421e57b2c848c43afb749b8ebfa79ec457cde26
## Summary
## Impact
## Testing
xiaoxiang781216 opened a new pull request #1180:
URL: https://github.com/apache/incubator-nuttx/pull/1180
since the fgets isn't decorated by IPTR
Signed-off-by: Xiang Xiao
Change-Id: I2a83afb4d934a44ad1b56ec6dd72e654f4e112a3
## Summary
## Impact
## Testing
patacongo commented on a change in pull request #1179:
URL: https://github.com/apache/incubator-nuttx/pull/1179#discussion_r434112939
##
File path: libs/libc/stdio/lib_vprintf.c
##
@@ -49,7 +52,13 @@
int vprintf(FAR const IPTR char *fmt, va_list ap)
{
+#if CONFIG_NFILE_STRE
patacongo commented on a change in pull request #1179:
URL: https://github.com/apache/incubator-nuttx/pull/1179#discussion_r434114709
##
File path: libs/libc/stdio/lib_vprintf.c
##
@@ -49,7 +52,13 @@
int vprintf(FAR const IPTR char *fmt, va_list ap)
{
+#if CONFIG_NFILE_STRE
patacongo commented on a change in pull request #1179:
URL: https://github.com/apache/incubator-nuttx/pull/1179#discussion_r434113844
##
File path: libs/libc/stdio/lib_vprintf.c
##
@@ -49,7 +52,13 @@
int vprintf(FAR const IPTR char *fmt, va_list ap)
{
+#if CONFIG_NFILE_STRE
patacongo commented on pull request #1180:
URL: https://github.com/apache/incubator-nuttx/pull/1180#issuecomment-637763581
This function did not need to be decorated with IPTR since it explicitly
copied the bytes from ROM. IPTR is a special storage class for Harvard
architecture maches th
patacongo commented on a change in pull request #1180:
URL: https://github.com/apache/incubator-nuttx/pull/1180#discussion_r434131699
##
File path: libs/libc/stdio/lib_fputs.c
##
@@ -59,51 +59,6 @@
*
**
patacongo commented on a change in pull request #1180:
URL: https://github.com/apache/incubator-nuttx/pull/1180#discussion_r434131699
##
File path: libs/libc/stdio/lib_fputs.c
##
@@ -59,51 +59,6 @@
*
**
patacongo commented on a change in pull request #1180:
URL: https://github.com/apache/incubator-nuttx/pull/1180#discussion_r434131699
##
File path: libs/libc/stdio/lib_fputs.c
##
@@ -59,51 +59,6 @@
*
**
patacongo edited a comment on pull request #1180:
URL: https://github.com/apache/incubator-nuttx/pull/1180#issuecomment-637763581
This function did not need to be decorated with IPTR since it explicitly
copied the bytes from ROM. IPTR is a special storage class for Harvard
architecture ma
patacongo edited a comment on pull request #1180:
URL: https://github.com/apache/incubator-nuttx/pull/1180#issuecomment-637763581
This function did not need to be decorated with IPTR since it explicitly
copied the bytes from ROM. IPTR is a special storage class for Harvard
architecture ma
patacongo commented on a change in pull request #1179:
URL: https://github.com/apache/incubator-nuttx/pull/1179#discussion_r434186409
##
File path: libs/libc/stdio/lib_vprintf.c
##
@@ -49,7 +52,13 @@
int vprintf(FAR const IPTR char *fmt, va_list ap)
{
+#if CONFIG_NFILE_STRE
davids5 opened a new pull request #1181:
URL: https://github.com/apache/incubator-nuttx/pull/1181
## Summary
## Impact
## Testing
This is an automated message from the Apache Git Service.
To respond to t
davids5 commented on pull request #1181:
URL: https://github.com/apache/incubator-nuttx/pull/1181#issuecomment-637838861
@btashton what is the incantation to fix the mac CI?
This is an automated message from the Apache Git Se
btashton commented on pull request #1181:
URL: https://github.com/apache/incubator-nuttx/pull/1181#issuecomment-637843372
@davids5 kicked the build, there is a rerun all. But I don't know if it will
fix this issue looked like a bintray issue.
```
https://akamai.bintray.com/a1/a1
patacongo merged pull request #1181:
URL: https://github.com/apache/incubator-nuttx/pull/1181
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 698ac72 stm32h7:stm32_sdmmc fix compile
patacongo commented on a change in pull request #1179:
URL: https://github.com/apache/incubator-nuttx/pull/1179#discussion_r434238346
##
File path: libs/libc/stdio/lib_vprintf.c
##
@@ -49,7 +52,13 @@
int vprintf(FAR const IPTR char *fmt, va_list ap)
{
+#if CONFIG_NFILE_STRE
1 - 100 of 112 matches
Mail list logo