Re: [PR] xtensa/esp32: Add support for hardware accelerated SHA [nuttx]

2025-03-19 Thread via GitHub
PruteanuVlad commented on PR #16016: URL: https://github.com/apache/nuttx/pull/16016#issuecomment-2735617460 @lupyuen Thank you for the quick review. I applied your suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] xtensa/esp32: Add support for hardware accelerated SHA [nuttx]

2025-03-18 Thread via GitHub
lupyuen commented on code in PR #16016: URL: https://github.com/apache/nuttx/pull/16016#discussion_r2002240228 ## arch/xtensa/src/esp32/hardware/esp32_sha.h: ## @@ -0,0 +1,136 @@ +/ + * arch/xtensa/src/e

Re: [PR] xtensa/esp32: Add support for hardware accelerated SHA [nuttx]

2025-03-18 Thread via GitHub
lupyuen commented on code in PR #16016: URL: https://github.com/apache/nuttx/pull/16016#discussion_r2002239506 ## arch/xtensa/src/esp32/esp32_sha.h: ## @@ -0,0 +1,219 @@ +/ + * arch/xtensa/src/esp32/esp3

Re: [PR] xtensa/esp32: Add support for hardware accelerated SHA [nuttx]

2025-03-18 Thread via GitHub
lupyuen commented on code in PR #16016: URL: https://github.com/apache/nuttx/pull/16016#discussion_r2002239344 ## arch/xtensa/src/esp32/esp32_sha.h: ## @@ -0,0 +1,219 @@ +/ + * arch/xtensa/src/esp32/esp3

Re: [PR] xtensa/esp32: Add support for hardware accelerated SHA [nuttx]

2025-03-18 Thread via GitHub
nuttxpr commented on PR #16016: URL: https://github.com/apache/nuttx/pull/16016#issuecomment-2734908725 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al