Re: [PR] sensors/sht4x: Converted SHT4X driver to UORB framework. [nuttx]

2025-01-16 Thread via GitHub
xiaoxiang781216 merged PR #15573: URL: https://github.com/apache/nuttx/pull/15573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] sensors/sht4x: Converted SHT4X driver to UORB framework. [nuttx]

2025-01-16 Thread via GitHub
linguini1 commented on code in PR #15573: URL: https://github.com/apache/nuttx/pull/15573#discussion_r1918735012 ## drivers/sensors/sht4x_uorb.c: ## @@ -153,68 +162,58 @@ static const uint8_t g_crc_lookup[] = static const uint16_t g_measurement_times[] = { -[SHT4X_PREC_L

Re: [PR] sensors/sht4x: Converted SHT4X driver to UORB framework. [nuttx]

2025-01-16 Thread via GitHub
raiden00pl commented on code in PR #15573: URL: https://github.com/apache/nuttx/pull/15573#discussion_r1918759637 ## drivers/sensors/sht4x_uorb.c: ## @@ -153,68 +162,58 @@ static const uint8_t g_crc_lookup[] = static const uint16_t g_measurement_times[] = { -[SHT4X_PREC_

Re: [PR] sensors/sht4x: Converted SHT4X driver to UORB framework. [nuttx]

2025-01-16 Thread via GitHub
linguini1 commented on code in PR #15573: URL: https://github.com/apache/nuttx/pull/15573#discussion_r1918735012 ## drivers/sensors/sht4x_uorb.c: ## @@ -153,68 +162,58 @@ static const uint8_t g_crc_lookup[] = static const uint16_t g_measurement_times[] = { -[SHT4X_PREC_L

Re: [PR] sensors/sht4x: Converted SHT4X driver to UORB framework. [nuttx]

2025-01-16 Thread via GitHub
raiden00pl commented on code in PR #15573: URL: https://github.com/apache/nuttx/pull/15573#discussion_r1918086477 ## drivers/sensors/sht4x_uorb.c: ## @@ -451,337 +444,328 @@ static int16_t sht4x_calc_hum(uint16_t humidity) } #endif - return hum; + return (float)(hum /

Re: [PR] sensors/sht4x: Converted SHT4X driver to UORB framework. [nuttx]

2025-01-16 Thread via GitHub
raiden00pl commented on code in PR #15573: URL: https://github.com/apache/nuttx/pull/15573#discussion_r1918084794 ## drivers/sensors/sht4x_uorb.c: ## @@ -411,19 +410,13 @@ static int sht4x_reset(FAR struct sht4x_dev_s *priv) * Name: sht4x_calc_temp * * Description: - * C

Re: [PR] sensors/sht4x: Converted SHT4X driver to UORB framework. [nuttx]

2025-01-16 Thread via GitHub
raiden00pl commented on code in PR #15573: URL: https://github.com/apache/nuttx/pull/15573#discussion_r1918081645 ## drivers/sensors/sht4x_uorb.c: ## @@ -153,68 +162,58 @@ static const uint8_t g_crc_lookup[] = static const uint16_t g_measurement_times[] = { -[SHT4X_PREC_

Re: [PR] sensors/sht4x: Converted SHT4X driver to UORB framework. [nuttx]

2025-01-16 Thread via GitHub
raiden00pl commented on code in PR #15573: URL: https://github.com/apache/nuttx/pull/15573#discussion_r1918062568 ## Documentation/components/drivers/special/sensors/sht4x.rst: ## @@ -7,101 +7,74 @@ The SHT4x is a family of temperature and humidity sensors created by Sensirion

Re: [PR] sensors/sht4x: Converted SHT4X driver to UORB framework. [nuttx]

2025-01-15 Thread via GitHub
linguini1 commented on PR #15573: URL: https://github.com/apache/nuttx/pull/15573#issuecomment-2594299960 @raiden00pl @Donny9 This is my attempt at dipping my toes in UORB with a sensor driver I've already written and which fits into the existing UORB framework before I try to add thermocou