Re: [PR] replace spin_lock_irqrestore with raw_spin_lock_irqrestore [nuttx]

2025-02-05 Thread via GitHub
hujun260 closed pull request #15695: replace spin_lock_irqrestore with raw_spin_lock_irqrestore URL: https://github.com/apache/nuttx/pull/15695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] replace spin_lock_irqrestore with raw_spin_lock_irqrestore [nuttx]

2025-02-04 Thread via GitHub
linguini1 commented on PR #15695: URL: https://github.com/apache/nuttx/pull/15695#issuecomment-2634465114 Could you update the impact and testing sections? What is the purpose of the change? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] replace spin_lock_irqrestore with raw_spin_lock_irqrestore [nuttx]

2025-01-25 Thread via GitHub
anchao commented on PR #15695: URL: https://github.com/apache/nuttx/pull/15695#issuecomment-2614199181 Please do not make such changes. The meaning of raw_ in linux is to disable the preemption. We need to discuss API naming further. https://github.com/apache/nuttx/pull/15684#issuecom

Re: [PR] replace spin_lock_irqrestore with raw_spin_lock_irqrestore [nuttx]

2025-01-25 Thread via GitHub
nuttxpr commented on PR #15695: URL: https://github.com/apache/nuttx/pull/15695#issuecomment-2614193925 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements