lupyuen commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2683544053
Thanks @keever50! Could you make 2 tiny fixes:
- Please fill in the Commit Description:
https://github.com/apache/nuttx/pull/15795/commits/8adb928da77c81ad05274999b0699c567860412e
-
keever50 commented on code in PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#discussion_r1970236415
##
Documentation/components/drivers/wireless/lpwan/sx126x.rst:
##
@@ -0,0 +1,65 @@
+==
+SX126x LoRa driver
+==
+**Currently experimenta
acassis commented on code in PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#discussion_r1969991230
##
Documentation/components/drivers/wireless/lpwan/sx126x.rst:
##
@@ -0,0 +1,65 @@
+==
+SX126x LoRa driver
+==
+**Currently experimental
keever50 commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2681819745
adding it as seperate commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
keever50 commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2681803421
oh ok i misunderstood the request then. Ill remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
keever50 commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2679284009
Documentation added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
acassis commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2678592279
> @acassis I can do that. Is it a good idea if i create a directory called
/wireless/lpwan under /documentation/components/drivers/character/ ? I am not
very familiar with this documentat
keever50 commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2678566430
@acassis I can do that.
Is it a good idea if i create a directory called /wireless/lpwan under
/documentation/components/drivers/character/ ?
I am not very familiar with this docume
acassis commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2678432589
@keever50 please create also the Documentation/ and include the screenshots
about the SDR and NSH to let people get more information before using it.
--
This is an automated message fro
keever50 commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2678338495
The common API is discussed here https://github.com/apache/nuttx/issues/15856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
keever50 commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2678335275
@xiaoxiang781216 Yes thats the idea, however it could help to have this one
pushed as experimental driver. So i can push a board and app which can be used
for testing.
Currently my bo
xiaoxiang781216 commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2678321236
> #15828 here is another PR with LORA chip support. Shared ioctl will be
beneficial for this driver as well
I suggest to follow the suggestion from @raiden00pl before mergin
keever50 commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2677939104
Signed and changed message. Also includes [experimental] as tag.
It is review ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
keever50 commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2677078462
Added a comment to both headers about this driver being currently
experimental and breaking changes might happen in the near future.
--
This is an automated message from the Apache Git
keever50 commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2676192088
Actually, @acassis if approved. Can this be pushed? This would significantly
help testing it as boards and apps dont have to be removed from the PR every
time. The rest of the less signi
keever50 commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2676180231
And obviously, it also works from across the room. Message "Hello" is sent
using the app from
keever50 commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2676179004
Fixed some issues after testing the driver using RAK11310 and a demo code.
- An echo back and forth test on low spreading factor:
,
most likely it will be some nam
keever50 commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2665040167
There are quite some things in common between these devices. For pretty much
all LoRa devices(SF, BW). Maybe it would be nice to have ioctls for common lora
devices. Let me know what you
keever50 commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2665032215
@raiden00pl yes! i was thinking about trying to do this... are we sure we
want to break the API? Maybe we can add wrapper macros that point to SX12XX
ioctls. That way old apps dont need
raiden00pl commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2665013877
hi, can we make this driver interface compatible with sx127x ? It would be
ideally if this driver can work with `sx127x_demo` example. this will probably
require breaking changes in th
keever50 commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2661530061
@acassis Is it okay if i create a completely new fresh PR somewhere this
week with the clean up and board removed? This makes things a bit easier to
manage. Later afterwards i can do a P
acassis commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2661505799
> Let me know if these integrations and ioctl look OK. I would appreciate
that. If anything has to be changed lmk
@keever50 I suggest just separating the board support from the driv
keever50 commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2661488890
Let me know if these integrations and ioctl look OK. I would appreciate
that. If anything has to be changed lmk
--
This is an automated message from the Apache Git Service.
To respond
acassis commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2661455683
ping @keever50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
keever50 commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2661458455
I can drop the updates here for review if you like but it is not fully
cleaned up yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
keever50 commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2661458142
pong @acassis
Update:
Still working on it on a different branch to not spam this PR.
Things are fully integrated, added a board for testing and made an app for
testing.
N
keever50 commented on code in PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#discussion_r1951536782
##
drivers/wireless/lpwan/sx126x/sx126x.c:
##
@@ -0,0 +1,1008 @@
+/
+ * drivers/wireless/lp
keever50 commented on code in PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#discussion_r1951536782
##
drivers/wireless/lpwan/sx126x/sx126x.c:
##
@@ -0,0 +1,1008 @@
+/
+ * drivers/wireless/lp
acassis commented on code in PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#discussion_r1951504067
##
drivers/wireless/lpwan/sx126x/sx126x.c:
##
@@ -0,0 +1,1008 @@
+/
+ * drivers/wireless/lpw
keever50 commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2651625180
I am not sure if i should keep squashing it with force pushing on every
change. Tell me if i am doing something wrong. Learning new things
--
This is an automated message from the Apac
keever50 commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2651584456
hm, i dont think that squashed, or did it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
keever50 commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2646315639
I am not entirely sure why all the indents are triple space now. Maybe
something happened after copying the file over and it somehow magically auto
formatted it to tripple space from dou
keever50 commented on code in PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#discussion_r1948112187
##
drivers/wireless/lpwan/sx126x/sx126x.c:
##
@@ -0,0 +1,867 @@
+/
+ * boards/arm/rp2040/ra
acassis commented on code in PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#discussion_r1948110305
##
drivers/wireless/lpwan/sx126x/sx126x.c:
##
@@ -0,0 +1,867 @@
+/
+ * boards/arm/rp2040/rak
nuttxpr commented on PR #15795:
URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2646282153
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
__Fill In The Commit Message:__ This PR contains a Commit with
40 matches
Mail list logo
