Re: [PR] Getline support backspace [nuttx]

2025-01-22 Thread via GitHub
anchao commented on PR #14037: URL: https://github.com/apache/nuttx/pull/14037#issuecomment-2607435480 @xiaoxiang781216 @zhangwenjian111 regression on cu command, here is fix: https://github.com/apache/nuttx-apps/pull/2968 -- This is an automated message from the Apache Git Service. To

Re: [PR] Getline support backspace [nuttx]

2024-10-15 Thread via GitHub
xiaoxiang781216 commented on PR #14037: URL: https://github.com/apache/nuttx/pull/14037#issuecomment-2414123885 update, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Getline support backspace [nuttx]

2024-10-15 Thread via GitHub
TimJTi commented on PR #14037: URL: https://github.com/apache/nuttx/pull/14037#issuecomment-2413736552 > do you update nsh too? [apache/nuttx-apps#2664](https://github.com/apache/nuttx-apps/pull/2664) I thought I had - but it seems not. I've had this before so I may need to reclone/refor

Re: [PR] Getline support backspace [nuttx]

2024-10-14 Thread via GitHub
xiaoxiang781216 commented on PR #14037: URL: https://github.com/apache/nuttx/pull/14037#issuecomment-2412013171 > @xiaoxiang781216 @zhangwenjian111 Assuming my git bisect attempt was correct, this PR has broken the backspace on my setup (custom board, UART console, MiniCom terminal on via W

Re: [PR] Getline support backspace [nuttx]

2024-10-14 Thread via GitHub
TimJTi commented on PR #14037: URL: https://github.com/apache/nuttx/pull/14037#issuecomment-2411949924 @xiaoxiang781216 @zhangwenjian111 Assuming my git bisect attempt was correct, this PR has broken the backspace on my setup (custom board, UART console, MiniCom terminal on via WSL on Windo

Re: [PR] Getline support backspace [nuttx]

2024-10-10 Thread via GitHub
xiaoxiang781216 merged PR #14037: URL: https://github.com/apache/nuttx/pull/14037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] Getline support backspace [nuttx]

2024-10-10 Thread via GitHub
nuttxpr commented on PR #14037: URL: https://github.com/apache/nuttx/pull/14037#issuecomment-2404562442 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does **not** meet the NuttX requirements.

Re: [PR] Getline support backspace [nuttx]

2024-10-10 Thread via GitHub
zhangwenjian111 closed pull request #13998: Getline support backspace URL: https://github.com/apache/nuttx/pull/13998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] Getline support backspace [nuttx]

2024-10-09 Thread via GitHub
xiaoxiang781216 commented on PR #13998: URL: https://github.com/apache/nuttx/pull/13998#issuecomment-2402409394 > Nice feature @zhangwenjian111, it should be nice to have support to left/right arrows to edit text in the nsh> prompt. this patch make the standard c API(e.g. getline) cou

Re: [PR] Getline support backspace [nuttx]

2024-10-09 Thread via GitHub
acassis commented on PR #13998: URL: https://github.com/apache/nuttx/pull/13998#issuecomment-2402275374 Nice feature @zhangwenjian111, it should be nice to have support to left/right arrows to edit text in the nsh> prompt. -- This is an automated message from the Apache Git Service. To re

Re: [PR] Getline support backspace [nuttx]

2024-10-09 Thread via GitHub
nuttxpr commented on PR #13998: URL: https://github.com/apache/nuttx/pull/13998#issuecomment-2402182046 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR appears to be **missing some required informati