nuttxpr commented on PR #13998: URL: https://github.com/apache/nuttx/pull/13998#issuecomment-2402182046
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR appears to be **missing some required information**. **Here's what needs improvement:** * **Summary:** * **Why is this change necessary?** Is there a bug report or feature request this addresses? Simply stating "getline function support backspace" isn't descriptive enough. * **What functional part of the code is changed?** Be specific. Mention the file(s) or modules impacted. * **How does the change work?** Explain the technical implementation details briefly. * **Impact:** * While you state "None", it's unlikely a code change has zero impact. * **Think carefully:** Does this affect any specific boards, architectures, or configurations? Are there any potential compatibility concerns, even minor ones? * **Documentation:** Does this change require any updates to the NuttX documentation? * **Testing:** * **Insufficient detail:** "sim,qemu,arm64" is too vague. * **Provide specifics:** * Which simulator(s)? * Which QEMU targets (board/configuration)? * Which ARM64 board(s) and configurations? * **Testing logs:** You need to include actual logs demonstrating the issue before the change and the improvement after the change. **Recommendations:** 1. **Expand the Summary:** Provide a clear explanation of the problem, the solution, and the code affected. 2. **Review Impact Carefully:** Think through potential consequences, even if they seem minor. 3. **Detailed Testing Information:** Be specific about your test environments and provide relevant logs. By addressing these points, you'll make your PR much stronger and easier for reviewers to understand and approve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
