Re: [PR] xtensa: inline up_cpu_index [nuttx]

2025-01-22 Thread via GitHub
xiaoxiang781216 merged PR #15636: URL: https://github.com/apache/nuttx/pull/15636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] xtensa: inline up_cpu_index [nuttx]

2025-01-22 Thread via GitHub
chirping78 commented on code in PR #15636: URL: https://github.com/apache/nuttx/pull/15636#discussion_r1926247271 ## arch/xtensa/include/esp32/irq.h: ## @@ -495,6 +495,23 @@ static inline_function int esp32_irq_gpio(int cpu) #endif #endif +#ifdef CONFIG_ARCH_HAVE_MULTICPU R

Re: [PR] xtensa: inline up_cpu_index [nuttx]

2025-01-21 Thread via GitHub
xiaoxiang781216 commented on code in PR #15636: URL: https://github.com/apache/nuttx/pull/15636#discussion_r1924809988 ## arch/xtensa/include/esp32/irq.h: ## @@ -495,6 +495,23 @@ static inline_function int esp32_irq_gpio(int cpu) #endif #endif +#ifdef CONFIG_ARCH_HAVE_MULTIC

Re: [PR] xtensa: inline up_cpu_index [nuttx]

2025-01-21 Thread via GitHub
nuttxpr commented on PR #15636: URL: https://github.com/apache/nuttx/pull/15636#issuecomment-2606232851 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

[PR] xtensa: inline up_cpu_index [nuttx]

2025-01-21 Thread via GitHub
chirping78 opened a new pull request, #15636: URL: https://github.com/apache/nuttx/pull/15636 ## Summary Currently `up_cpu_index` of xtensa arch is a non-inline function, which means it will be called by `callX` instruction, and it will cause stack push/pop operations. And fro