Re: [PR] video.c: modify set_buf call seqence in start_capture function. [nuttx]

2023-11-29 Thread via GitHub
xiaoxiang781216 merged PR #11249: URL: https://github.com/apache/nuttx/pull/11249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] video.c: modify set_buf call seqence in start_capture function. [nuttx]

2023-11-28 Thread via GitHub
Joneyao commented on PR #11249: URL: https://github.com/apache/nuttx/pull/11249#issuecomment-1829581286 > spresense hardware needs the format information in IMGDATA_SET_BUF. So, would you add the arguments to IMGDATA_SET_BUF(set_buf() interface of struct imgdata_ops_s) as my patch at the sa

Re: [PR] video.c: modify set_buf call seqence in start_capture function. [nuttx]

2023-11-28 Thread via GitHub
Joneyao closed pull request #11249: video.c: modify set_buf call seqence in start_capture function. URL: https://github.com/apache/nuttx/pull/11249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] video.c: modify set_buf call seqence in start_capture function. [nuttx]

2023-11-27 Thread via GitHub
Joneyao commented on PR #11249: URL: https://github.com/apache/nuttx/pull/11249#issuecomment-1829229753 > spresense hardware needs the format information in IMGDATA_SET_BUF. So, would you add the arguments to IMGDATA_SET_BUF(set_buf() interface of struct imgdata_ops_s) as my patch at the sa

Re: [PR] video.c: modify set_buf call seqence in start_capture function. [nuttx]

2023-11-27 Thread via GitHub
SPRESENSE commented on PR #11249: URL: https://github.com/apache/nuttx/pull/11249#issuecomment-1828861951 spresense hardware needs the format information in IMGDATA_SET_BUF. So, would you add the arguments to IMGDATA_SET_BUF(set_buf() interface of struct imgdata_ops_s) as my patch at the

Re: [PR] video.c: modify set_buf call seqence in start_capture function. [nuttx]

2023-11-24 Thread via GitHub
xiaoxiang781216 commented on PR #11249: URL: https://github.com/apache/nuttx/pull/11249#issuecomment-1825621822 > @SPRESENSE please check Have you finished the test, @SPRESENSE ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] video.c: modify set_buf call seqence in start_capture function. [nuttx]

2023-11-22 Thread via GitHub
jerpelea commented on PR #11249: URL: https://github.com/apache/nuttx/pull/11249#issuecomment-1822316356 @SPRESENSE please check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] video.c: modify set_buf call seqence in start_capture function. [nuttx]

2023-11-22 Thread via GitHub
Joneyao commented on PR #11249: URL: https://github.com/apache/nuttx/pull/11249#issuecomment-1822309680 @jerpelea hi, this patch will have an impact on capturing sensor image, but i don't have sony hardware, can you help me verify it when you have time? thank you very much. -- This is

[PR] video.c: modify set_buf call seqence in start_capture function. [nuttx]

2023-11-22 Thread via GitHub
Joneyao opened a new pull request, #11249: URL: https://github.com/apache/nuttx/pull/11249 To avoid losing the first frame, the set_buf needs to excute first. At the same time, imgdata->start_capture should excuted before the imgsensor->start_capture. ## Summary ## Impact V