Re: [PR] syslog: Don't allow blocking when in signal handler [nuttx]

2024-10-23 Thread via GitHub
xiaoxiang781216 merged PR #14456: URL: https://github.com/apache/nuttx/pull/14456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] syslog: Don't allow blocking when in signal handler [nuttx]

2024-10-22 Thread via GitHub
acassis commented on code in PR #14456: URL: https://github.com/apache/nuttx/pull/14456#discussion_r1811156390 ## drivers/syslog/syslog_write.c: ## @@ -37,6 +37,39 @@ * Private Functions / +/**

Re: [PR] syslog: Don't allow blocking when in signal handler [nuttx]

2024-10-22 Thread via GitHub
acassis commented on code in PR #14456: URL: https://github.com/apache/nuttx/pull/14456#discussion_r1811154657 ## drivers/syslog/syslog_write.c: ## @@ -37,6 +37,39 @@ * Private Functions / +/**

Re: [PR] syslog: Don't allow blocking when in signal handler [nuttx]

2024-10-22 Thread via GitHub
acassis commented on code in PR #14456: URL: https://github.com/apache/nuttx/pull/14456#discussion_r1811154657 ## drivers/syslog/syslog_write.c: ## @@ -37,6 +37,39 @@ * Private Functions / +/**

Re: [PR] syslog: Don't allow blocking when in signal handler [nuttx]

2024-10-22 Thread via GitHub
nuttxpr commented on PR #14456: URL: https://github.com/apache/nuttx/pull/14456#issuecomment-2429311386 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR summary is missing some key information:

[PR] syslog: Don't allow blocking when in signal handler [nuttx]

2024-10-22 Thread via GitHub
pussuw opened a new pull request, #14456: URL: https://github.com/apache/nuttx/pull/14456 ## Summary Blocking while running a signal handler is not advisable, instead write the log string character by character. There is also a potential for a deadlock, as discussed in #6618